docker: add debug logs around Start and Attach

.github/workflows/build-test.yml

@@ -56,21 +56,16 @@ jobs:
           CGO_ENABLED: 0
           SRC_PATH: github.com/pterodactyl/wings
         run: |
-          go build -v -trimpath -ldflags="-s -w -X ${SRC_PATH}/system.Version=dev-${GIT_COMMIT:0:7}" -o build/wings_${GOOS}_${GOARCH} wings.go
-          go build -v -trimpath -ldflags="-X ${SRC_PATH}/system.Version=dev-${GIT_COMMIT:0:7}" -o build/wings_${GOOS}_${GOARCH}_debug wings.go
-          upx build/wings_${GOOS}_${{ matrix.goarch }}
-          chmod +x build/*
+          go build -v -trimpath -ldflags="-s -w -X ${SRC_PATH}/system.Version=dev-${GIT_COMMIT:0:7}" -o build/wings_${{ matrix.goos }}_${{ matrix.goarch }} wings.go
+          upx build/wings_${{ matrix.goos }}_${{ matrix.goarch }}
+          chmod +x build/wings_${{ matrix.goos }}_${{ matrix.goarch }}
       - name: Tests
+        run: go test ./...
+      - name: Tests (Race)
         run: go test -race ./...
-      - name: Upload Release Artifact
+      - name: Upload Artifact
         uses: actions/upload-artifact@v2
         if: ${{ github.ref == 'refs/heads/develop' || github.event_name == 'pull_request' }}
         with:
-          name: wings_linux_${{ matrix.goarch }}
-          path: build/wings_linux_${{ matrix.goarch }}
-      - name: Upload Debug Artifact
-        uses: actions/upload-artifact@v2
-        if: ${{ github.ref == 'refs/heads/develop' || github.event_name == 'pull_request' }}
-        with:
-          name: wings_linux_${{ matrix.goarch }}_debug
-          path: build/wings_linux_${{ matrix.goarch }}_debug
+          name: wings_${{ matrix.goos }}_${{ matrix.goarch }}
+          path: build/wings_${{ matrix.goos }}_${{ matrix.goarch }}

.gitignore

@@ -49,4 +49,3 @@ debug
 .DS_Store
 *.pprof
 *.pdf
-pprof.*

CHANGELOG.md

@@ -1,15 +1,5 @@
 # Changelog
 
-## v1.6.0
-### Fixed
-* Internal logic for processing a server start event has been adjusted to attach to the Docker container before attempting to start the container. This should fix issues where a server would get stuck after pulling the container image.
-* Fixes a bug in the console output that was dropping console lines when a large number of lines were sent at once.
-
-### Changed
-* Removed the console throttle logic that would terminate a server instance that was sending too much data. This logic has been replaced with simpler logic that only throttles the console, it does not try to terminate the server. In addition, this change has reduced the number of go-routines needed by the application and dramatically simplified internal logic.
-* Removed the `--profiler` flag and replaced it with `--pprof` which will start an internal server listening on `localhost:6060` allowing you to use Go's standard `pprof` tooling.
-* Replaced the `json` log driver for Docker containers with `local` to reduce the amount of overhead when it comes to streaming logs from instances.
-
 ## v1.5.6
 ### Fixed
 * Rewrote handler logic for the power actions lock to hopefully address issues people have been having when a server crashes and they're unable to start it again until restarting Wings.

Makefile

@@ -5,8 +5,8 @@ build:
 	GOOS=linux GOARCH=arm64 go build -ldflags="-s -w" -gcflags "all=-trimpath=$(pwd)" -o build/wings_linux_arm64 -v wings.go
 
 debug:
-	go build -ldflags="-X github.com/pterodactyl/wings/system.Version=$(GIT_HEAD)"
-	sudo ./wings --debug --ignore-certificate-errors --config config.yml --pprof
+	go build -ldflags="-X github.com/pterodactyl/wings/system.Version=$(GIT_HEAD)" -race
+	sudo ./wings --debug --ignore-certificate-errors --config config.yml
 
 # Runs a remotly debuggable session for Wings allowing an IDE to connect and target
 # different breakpoints.

cmd/root.go

@@ -7,7 +7,6 @@ import (
 	"fmt"
 	log2 "log"
 	"net/http"
-	_ "net/http/pprof"
 	"os"
 	"path"
 	"path/filepath"
@@ -21,6 +20,7 @@ import (
 	"github.com/docker/docker/client"
 	"github.com/gammazero/workerpool"
 	"github.com/mitchellh/colorstring"
+	"github.com/pkg/profile"
 	"github.com/spf13/cobra"
 	"golang.org/x/crypto/acme"
 	"golang.org/x/crypto/acme/autocert"
@@ -75,8 +75,7 @@ func init() {
 	rootCommand.PersistentFlags().BoolVar(&debug, "debug", false, "pass in order to run wings in debug mode")
 
 	// Flags specifically used when running the API.
-	rootCommand.Flags().Bool("pprof", false, "if the pprof profiler should be enabled. The profiler will bind to localhost:6060 by default")
-	rootCommand.Flags().Int("pprof-port", 6060, "If provided with --pprof, the port it will run on")
+	rootCommand.Flags().String("profiler", "", "the profiler to run for this instance")
 	rootCommand.Flags().Bool("auto-tls", false, "pass in order to have wings generate and manage it's own SSL certificates using Let's Encrypt")
 	rootCommand.Flags().String("tls-hostname", "", "required with --auto-tls, the FQDN for the generated SSL certificate")
 	rootCommand.Flags().Bool("ignore-certificate-errors", false, "ignore certificate verification errors when executing API calls")
@@ -87,6 +86,25 @@ func init() {
 }
 
 func rootCmdRun(cmd *cobra.Command, _ []string) {
+	switch cmd.Flag("profiler").Value.String() {
+	case "cpu":
+		defer profile.Start(profile.CPUProfile).Stop()
+	case "mem":
+		defer profile.Start(profile.MemProfile).Stop()
+	case "alloc":
+		defer profile.Start(profile.MemProfile, profile.MemProfileAllocs).Stop()
+	case "heap":
+		defer profile.Start(profile.MemProfile, profile.MemProfileHeap).Stop()
+	case "routines":
+		defer profile.Start(profile.GoroutineProfile).Stop()
+	case "mutex":
+		defer profile.Start(profile.MutexProfile).Stop()
+	case "threads":
+		defer profile.Start(profile.ThreadcreationProfile).Stop()
+	case "block":
+		defer profile.Start(profile.BlockProfile).Stop()
+	}
+
 	printLogo()
 	log.Debug("running in debug mode")
 	log.WithField("config_file", configPath).Info("loading configuration from file")
@@ -307,14 +325,6 @@ func rootCmdRun(cmd *cobra.Command, _ []string) {
 		TLSConfig: config.DefaultTLSConfig,
 	}
 
-	profile, _ := cmd.Flags().GetBool("pprof")
-	if profile {
-		profilePort, _ := cmd.Flags().GetInt("pprof-port")
-		go func() {
-			http.ListenAndServe(fmt.Sprintf("localhost:%d", profilePort), nil)
-		}()
-	}
-
 	// Check if the server should run with TLS but using autocert.
 	if autotls {
 		m := autocert.Manager{

config/config.go

@@ -222,14 +222,26 @@ type ConsoleThrottles struct {
 	// Whether or not the throttler is enabled for this instance.
 	Enabled bool `json:"enabled" yaml:"enabled" default:"true"`
 
-	// The total number of lines that can be output in a given Period period before
+	// The total number of lines that can be output in a given LineResetInterval period before
 	// a warning is triggered and counted against the server.
 	Lines uint64 `json:"lines" yaml:"lines" default:"2000"`
 
+	// The total number of throttle activations that can accumulate before a server is considered
+	// to be breaching and will be stopped. This value is decremented by one every DecayInterval.
+	MaximumTriggerCount uint64 `json:"maximum_trigger_count" yaml:"maximum_trigger_count" default:"5"`
+
 	// The amount of time after which the number of lines processed is reset to 0. This runs in
 	// a constant loop and is not affected by the current console output volumes. By default, this
 	// will reset the processed line count back to 0 every 100ms.
-	Period uint64 `json:"line_reset_interval" yaml:"line_reset_interval" default:"100"`
+	LineResetInterval uint64 `json:"line_reset_interval" yaml:"line_reset_interval" default:"100"`
+
+	// The amount of time in milliseconds that must pass without an output warning being triggered
+	// before a throttle activation is decremented.
+	DecayInterval uint64 `json:"decay_interval" yaml:"decay_interval" default:"10000"`
+
+	// The amount of time that a server is allowed to be stopping for before it is terminated
+	// forcefully if it triggers output throttles.
+	StopGracePeriod uint `json:"stop_grace_period" yaml:"stop_grace_period" default:"15"`
 }
 
 type Configuration struct {

environment/docker/container.go

@@ -16,7 +16,7 @@ import (
 	"github.com/docker/docker/api/types/container"
 	"github.com/docker/docker/api/types/mount"
 	"github.com/docker/docker/client"
-	"github.com/docker/docker/daemon/logger/local"
+	"github.com/docker/docker/daemon/logger/jsonfilelog"
 
 	"github.com/pterodactyl/wings/config"
 	"github.com/pterodactyl/wings/environment"
@@ -38,21 +38,23 @@ func (nw noopWriter) Write(b []byte) (int, error) {
 }
 
 // Attach attaches to the docker container itself and ensures that we can pipe
-// data in and out of the process stream. This should always be called before
-// you have started the container, but after you've ensured it exists.
+// data in and out of the process stream. This should not be used for reading
+// console data as you *will* miss important output at the beginning because of
+// the time delay with attaching to the output.
 //
 // Calling this function will poll resources for the container in the background
-// until the container is stopped. The context provided to this function is used
-// for the purposes of attaching to the container, a seecond context is created
-// within the function for managing polling.
+// until the provided context is canceled by the caller. Failure to cancel said
+// context will cause background memory leaks as the goroutine will not exit.
 func (e *Environment) Attach(ctx context.Context) error {
 	if e.IsAttached() {
 		return nil
 	}
+	e.log().Debug("not attached to container, continuing with attach...")
 
 	if err := e.followOutput(); err != nil {
 		return err
 	}
+	e.log().Debug("following container output")
 
 	opts := types.ContainerAttachOptions{
 		Stdin:  true,
@@ -62,11 +64,13 @@ func (e *Environment) Attach(ctx context.Context) error {
 	}
 
 	// Set the stream again with the container.
+	e.log().Debug("attempting to attach...")
 	if st, err := e.client.ContainerAttach(ctx, e.Id, opts); err != nil {
 		return err
 	} else {
 		e.SetStream(&st)
 	}
+	e.log().Debug("attached!")
 
 	go func() {
 		// Don't use the context provided to the function, that'll cause the polling to
@@ -216,12 +220,11 @@ func (e *Environment) Create() error {
 		// since we only need it for the last few hundred lines of output and don't care
 		// about anything else in it.
 		LogConfig: container.LogConfig{
-			Type: local.Name,
+			Type: jsonfilelog.Name,
 			Config: map[string]string{
 				"max-size": "5m",
 				"max-file": "1",
 				"compress": "false",
-				"mode":     "non-blocking",
 			},
 		},
 

environment/docker/environment.go

@@ -27,6 +27,7 @@ var _ environment.ProcessEnvironment = (*Environment)(nil)
 
 type Environment struct {
 	mu      sync.RWMutex
+	eventMu sync.Once
 
 	// The public identifier for this environment. In this case it is the Docker container
 	// name that will be used for all instances created under it.
@@ -72,7 +73,6 @@ func New(id string, m *Metadata, c *environment.Configuration) (*Environment, er
 		meta:          m,
 		client:        cli,
 		st:            system.NewAtomicString(environment.ProcessOfflineState),
-		emitter:       events.NewBus(),
 	}
 
 	return e, nil
@@ -86,33 +86,34 @@ func (e *Environment) Type() string {
 	return "docker"
 }
 
-// SetStream sets the current stream value from the Docker client. If a nil
-// value is provided we assume that the stream is no longer operational and the
-// instance is effectively offline.
+// Set if this process is currently attached to the process.
 func (e *Environment) SetStream(s *types.HijackedResponse) {
 	e.mu.Lock()
+	defer e.mu.Unlock()
+
 	e.stream = s
-	e.mu.Unlock()
 }
 
-// IsAttached determine if the this process is currently attached to the
-// container instance by checking if the stream is nil or not.
+// Determine if the this process is currently attached to the container.
 func (e *Environment) IsAttached() bool {
 	e.mu.RLock()
 	defer e.mu.RUnlock()
+
 	return e.stream != nil
 }
 
-// Events returns an event bus for the environment.
 func (e *Environment) Events() *events.Bus {
+	e.eventMu.Do(func() {
+		e.emitter = events.NewBus()
+	})
+
 	return e.emitter
 }
 
-// Exists determines if the container exists in this environment. The ID passed
-// through should be the server UUID since containers are created utilizing the
-// server UUID as the name and docker will work fine when using the container
-// name as the lookup parameter in addition to the longer ID auto-assigned when
-// the container is created.
+// Determines if the container exists in this environment. The ID passed through should be the
+// server UUID since containers are created utilizing the server UUID as the name and docker
+// will work fine when using the container name as the lookup parameter in addition to the longer
+// ID auto-assigned when the container is created.
 func (e *Environment) Exists() (bool, error) {
 	_, err := e.ContainerInspect(context.Background())
 	if err != nil {
@@ -121,8 +122,10 @@ func (e *Environment) Exists() (bool, error) {
 		if client.IsErrNotFound(err) {
 			return false, nil
 		}
+
 		return false, err
 	}
+
 	return true, nil
 }
 
@@ -143,7 +146,7 @@ func (e *Environment) IsRunning(ctx context.Context) (bool, error) {
 	return c.State.Running, nil
 }
 
-// ExitState returns the container exit state, the exit code and whether or not
+// Determine the container exit state and return the exit code and whether or not
 // the container was killed by the OOM killer.
 func (e *Environment) ExitState() (uint32, bool, error) {
 	c, err := e.ContainerInspect(context.Background())
@@ -160,13 +163,15 @@ func (e *Environment) ExitState() (uint32, bool, error) {
 		if client.IsErrNotFound(err) {
 			return 1, false, nil
 		}
+
 		return 0, false, err
 	}
+
 	return uint32(c.State.ExitCode), c.State.OOMKilled, nil
 }
 
-// Config returns the environment configuration allowing a process to make
-// modifications of the environment on the fly.
+// Returns the environment configuration allowing a process to make modifications of the
+// environment on the fly.
 func (e *Environment) Config() *environment.Configuration {
 	e.mu.RLock()
 	defer e.mu.RUnlock()
@@ -174,11 +179,12 @@ func (e *Environment) Config() *environment.Configuration {
 	return e.Configuration
 }
 
-// SetStopConfiguration sets the stop configuration for the environment.
+// Sets the stop configuration for the environment.
 func (e *Environment) SetStopConfiguration(c remote.ProcessStopConfiguration) {
 	e.mu.Lock()
+	defer e.mu.Unlock()
+
 	e.meta.Stop = c
-	e.mu.Unlock()
 }
 
 func (e *Environment) SetImage(i string) {

environment/docker/power.go

@@ -111,20 +111,15 @@ func (e *Environment) Start(ctx context.Context) error {
 	actx, cancel := context.WithTimeout(ctx, time.Second*30)
 	defer cancel()
 
-	// You must attach to the instance _before_ you start the container. If you do this
-	// in the opposite order you'll enter a deadlock condition where we're attached to
-	// the instance successfully, but the container has already stopped and you'll get
-	// the entire program into a very confusing state.
-	//
-	// By explicitly attaching to the instance before we start it, we can immediately
-	// react to errors/output stopping/etc. when starting.
 	if err := e.Attach(actx); err != nil {
 		return err
 	}
 
+	e.log().Debug("attempting to start container...")
 	if err := e.client.ContainerStart(actx, e.Id, types.ContainerStartOptions{}); err != nil {
 		return errors.WrapIf(err, "environment/docker: failed to start container")
 	}
+	e.log().Debug("started container!")
 
 	// No errors, good to continue through.
 	sawError = false

remote/types.go

@@ -1,7 +1,6 @@
 package remote
 
 import (
-	"bytes"
 	"regexp"
 	"strings"
 
@@ -86,38 +85,37 @@ type SftpAuthResponse struct {
 type OutputLineMatcher struct {
 	// The raw string to match against. This may or may not be prefixed with
 	// regex: which indicates we want to match against the regex expression.
-	raw []byte
+	raw string
 	reg *regexp.Regexp
 }
 
-// Matches determines if the provided byte string matches the given regex or
-// raw string provided to the matcher.
-func (olm *OutputLineMatcher) Matches(s []byte) bool {
+// Matches determines if a given string "s" matches the given line.
+func (olm *OutputLineMatcher) Matches(s string) bool {
 	if olm.reg == nil {
-		return bytes.Contains(s, olm.raw)
+		return strings.Contains(s, olm.raw)
 	}
-	return olm.reg.Match(s)
+
+	return olm.reg.MatchString(s)
 }
 
 // String returns the matcher's raw comparison string.
 func (olm *OutputLineMatcher) String() string {
-	return string(olm.raw)
+	return olm.raw
 }
 
 // UnmarshalJSON unmarshals the startup lines into individual structs for easier
 // matching abilities.
 func (olm *OutputLineMatcher) UnmarshalJSON(data []byte) error {
-	var r string
-	if err := json.Unmarshal(data, &r); err != nil {
+	if err := json.Unmarshal(data, &olm.raw); err != nil {
 		return err
 	}
 
-	olm.raw = []byte(r)
-	if bytes.HasPrefix(olm.raw, []byte("regex:")) && len(olm.raw) > 6 {
-		r, err := regexp.Compile(strings.TrimPrefix(string(olm.raw), "regex:"))
+	if strings.HasPrefix(olm.raw, "regex:") && len(olm.raw) > 6 {
+		r, err := regexp.Compile(strings.TrimPrefix(olm.raw, "regex:"))
 		if err != nil {
-			log.WithField("error", err).WithField("raw", string(olm.raw)).Warn("failed to compile output line marked as being regex")
+			log.WithField("error", err).WithField("raw", olm.raw).Warn("failed to compile output line marked as being regex")
 		}
+
 		olm.reg = r
 	}
 

router/websocket/listeners.go

@@ -89,8 +89,8 @@ func (h *Handler) listenForServerEvents(ctx context.Context) error {
 	defer cancel()
 
 	eventChan := make(chan events.Event)
-	logOutput := make(chan []byte, 8)
-	installOutput := make(chan []byte, 4)
+	logOutput := make(chan []byte)
+	installOutput := make(chan []byte)
 	h.server.Events().On(eventChan, e...)
 	h.server.Sink(server.LogSink).On(logOutput)
 	h.server.Sink(server.InstallSink).On(installOutput)

server/console.go

@@ -1,11 +1,15 @@
 package server
 
 import (
+	"context"
 	"fmt"
 	"sync"
+	"sync/atomic"
 	"time"
 
+	"emperror.dev/errors"
 	"github.com/mitchellh/colorstring"
+
 	"github.com/pterodactyl/wings/config"
 	"github.com/pterodactyl/wings/system"
 )
@@ -14,8 +18,118 @@ import (
 // the configuration every time we need to send output along to the websocket for
 // a server.
 var appName string
+
 var appNameSync sync.Once
 
+var ErrTooMuchConsoleData = errors.New("console is outputting too much data")
+
+type ConsoleThrottler struct {
+	mu sync.Mutex
+	config.ConsoleThrottles
+
+	// The total number of activations that have occurred thus far.
+	activations uint64
+
+	// The total number of lines that have been sent since the last reset timer period.
+	count uint64
+
+	// Wether or not the console output is being throttled. It is up to calling code to
+	// determine what to do if it is.
+	isThrottled *system.AtomicBool
+
+	// The total number of lines processed so far during the given time period.
+	timerCancel *context.CancelFunc
+}
+
+// Resets the state of the throttler.
+func (ct *ConsoleThrottler) Reset() {
+	atomic.StoreUint64(&ct.count, 0)
+	atomic.StoreUint64(&ct.activations, 0)
+	ct.isThrottled.Store(false)
+}
+
+// Triggers an activation for a server. You can also decrement the number of activations
+// by passing a negative number.
+func (ct *ConsoleThrottler) markActivation(increment bool) uint64 {
+	if !increment {
+		if atomic.LoadUint64(&ct.activations) == 0 {
+			return 0
+		}
+
+		// This weird dohicky subtracts 1 from the activation count.
+		return atomic.AddUint64(&ct.activations, ^uint64(0))
+	}
+
+	return atomic.AddUint64(&ct.activations, 1)
+}
+
+// Determines if the console is currently being throttled. Calls to this function can be used to
+// determine if output should be funneled along to the websocket processes.
+func (ct *ConsoleThrottler) Throttled() bool {
+	return ct.isThrottled.Load()
+}
+
+// Starts a timer that runs in a seperate thread and will continually decrement the lines processed
+// and number of activations, regardless of the current console message volume. All of the timers
+// are canceled if the context passed through is canceled.
+func (ct *ConsoleThrottler) StartTimer(ctx context.Context) {
+	system.Every(ctx, time.Duration(int64(ct.LineResetInterval))*time.Millisecond, func(_ time.Time) {
+		ct.isThrottled.Store(false)
+		atomic.StoreUint64(&ct.count, 0)
+	})
+
+	system.Every(ctx, time.Duration(int64(ct.DecayInterval))*time.Millisecond, func(_ time.Time) {
+		ct.markActivation(false)
+	})
+}
+
+// Handles output from a server's console. This code ensures that a server is not outputting
+// an excessive amount of data to the console that could indicate a malicious or run-away process
+// and lead to performance issues for other users.
+//
+// This was much more of a problem for the NodeJS version of the daemon which struggled to handle
+// large volumes of output. However, this code is much more performant so I generally feel a lot
+// better about it's abilities.
+//
+// However, extreme output is still somewhat of a DoS attack vector against this software since we
+// are still logging it to the disk temporarily and will want to avoid dumping a huge amount of
+// data all at once. These values are all configurable via the wings configuration file, however the
+// defaults have been in the wild for almost two years at the time of this writing, so I feel quite
+// confident in them.
+//
+// This function returns an error if the server should be stopped due to violating throttle constraints
+// and a boolean value indicating if a throttle is being violated when it is checked.
+func (ct *ConsoleThrottler) Increment(onTrigger func()) error {
+	if !ct.Enabled {
+		return nil
+	}
+
+	// Increment the line count and if we have now output more lines than are allowed, trigger a throttle
+	// activation. Once the throttle is triggered and has passed the kill at value we will trigger a server
+	// stop automatically.
+	if atomic.AddUint64(&ct.count, 1) >= ct.Lines && !ct.Throttled() {
+		ct.isThrottled.Store(true)
+		if ct.markActivation(true) >= ct.MaximumTriggerCount {
+			return ErrTooMuchConsoleData
+		}
+
+		onTrigger()
+	}
+
+	return nil
+}
+
+// Returns the throttler instance for the server or creates a new one.
+func (s *Server) Throttler() *ConsoleThrottler {
+	s.throttleOnce.Do(func() {
+		s.throttler = &ConsoleThrottler{
+			isThrottled:      system.NewAtomicBool(false),
+			ConsoleThrottles: config.Get().Throttles,
+		}
+	})
+	return s.throttler
+}
+
 // PublishConsoleOutputFromDaemon sends output to the server console formatted
 // to appear correctly as being sent from Wings.
 func (s *Server) PublishConsoleOutputFromDaemon(data string) {
@@ -27,55 +141,3 @@ func (s *Server) PublishConsoleOutputFromDaemon(data string) {
 		colorstring.Color(fmt.Sprintf("[yellow][bold][%s Daemon]:[default] %s", appName, data)),
 	)
 }
-
-// Throttler returns the throttler instance for the server or creates a new one.
-func (s *Server) Throttler() *ConsoleThrottle {
-	s.throttleOnce.Do(func() {
-		throttles := config.Get().Throttles
-		period := time.Duration(throttles.Period) * time.Millisecond
-
-		s.throttler = newConsoleThrottle(throttles.Lines, period)
-		s.throttler.strike = func() {
-			s.PublishConsoleOutputFromDaemon(fmt.Sprintf("Server is outputting console data too quickly -- throttling..."))
-		}
-	})
-	return s.throttler
-}
-
-type ConsoleThrottle struct {
-	limit  *system.Rate
-	lock   *system.Locker
-	strike func()
-}
-
-func newConsoleThrottle(lines uint64, period time.Duration) *ConsoleThrottle {
-	return &ConsoleThrottle{
-		limit: system.NewRate(lines, period),
-		lock:  system.NewLocker(),
-	}
-}
-
-// Allow checks if the console is allowed to process more output data, or if too
-// much has already been sent over the line. If there is too much output the
-// strike callback function is triggered, but only if it has not already been
-// triggered at this point in the process.
-//
-// If output is allowed, the lock on the throttler is released and the next time
-// it is triggered the strike function will be re-executed.
-func (ct *ConsoleThrottle) Allow() bool {
-	if !ct.limit.Try() {
-		if err := ct.lock.Acquire(); err == nil {
-			if ct.strike != nil {
-				ct.strike()
-			}
-		}
-		return false
-	}
-	ct.lock.Release()
-	return true
-}
-
-// Reset resets the console throttler internal rate limiter and overage counter.
-func (ct *ConsoleThrottle) Reset() {
-	ct.limit.Reset()
-}

server/console_test.go

@@ -1,62 +0,0 @@
-package server
-
-import (
-	"testing"
-	"time"
-
-	"github.com/franela/goblin"
-)
-
-func TestName(t *testing.T) {
-	g := goblin.Goblin(t)
-
-	g.Describe("ConsoleThrottler", func() {
-		g.It("keeps count of the number of overages in a time period", func() {
-			t := newConsoleThrottle(1, time.Second)
-			g.Assert(t.Allow()).IsTrue()
-			g.Assert(t.Allow()).IsFalse()
-			g.Assert(t.Allow()).IsFalse()
-		})
-
-		g.It("calls strike once per time period", func() {
-			t := newConsoleThrottle(1, time.Millisecond * 20)
-
-			var times int
-			t.strike = func() {
-				times = times + 1
-			}
-
-			t.Allow()
-			t.Allow()
-			t.Allow()
-			time.Sleep(time.Millisecond * 100)
-			t.Allow()
-			t.Reset()
-			t.Allow()
-			t.Allow()
-			t.Allow()
-
-			g.Assert(times).Equal(2)
-		})
-
-		g.It("is properly reset", func() {
-			t := newConsoleThrottle(10, time.Second)
-
-			for i := 0; i < 10; i++ {
-				g.Assert(t.Allow()).IsTrue()
-			}
-			g.Assert(t.Allow()).IsFalse()
-			t.Reset()
-			g.Assert(t.Allow()).IsTrue()
-		})
-	})
-}
-
-func BenchmarkConsoleThrottle(b *testing.B) {
-	t := newConsoleThrottle(10, time.Millisecond * 10)
-
-	b.ReportAllocs()
-    for i := 0; i < b.N; i++ {
-        t.Allow()
-    }
-}

server/listeners.go

@@ -1,13 +1,13 @@
 package server
 
 import (
-	"bytes"
 	"regexp"
 	"strconv"
 	"sync"
 
 	"github.com/apex/log"
 
+	"github.com/pterodactyl/wings/config"
 	"github.com/pterodactyl/wings/environment"
 	"github.com/pterodactyl/wings/events"
 	"github.com/pterodactyl/wings/remote"
@@ -50,34 +50,48 @@ func (dsl *diskSpaceLimiter) Trigger() {
 	})
 }
 
-// processConsoleOutputEvent handles output from a server's Docker container
-// and runs through different limiting logic to ensure that spam console output
-// does not cause negative effects to the system. This will also monitor the
-// output lines to determine if the server is started yet, and if the output is
-// not being throttled, will send the data over to the websocket.
 func (s *Server) processConsoleOutputEvent(v []byte) {
-	// Always process the console output, but do this in a seperate thread since we
-	// don't really care about side-effects from this call, and don't want it to block
-	// the console sending logic.
-	go s.onConsoleOutput(v)
+	t := s.Throttler()
+	err := t.Increment(func() {
+		s.PublishConsoleOutputFromDaemon("Your server is outputting too much data and is being throttled.")
+	})
+	// An error is only returned if the server has breached the thresholds set.
+	if err != nil {
+		// If the process is already stopping, just let it continue with that action rather than attempting
+		// to terminate again.
+		if s.Environment.State() != environment.ProcessStoppingState {
+			s.Environment.SetState(environment.ProcessStoppingState)
 
-	// If the console is being throttled, do nothing else with it, we don't want
-	// to waste time. This code previously terminated server instances after violating
-	// different throttle limits. That code was clunky and difficult to reason about,
-	// in addition to being a consistent pain point for users.
-	//
-	// In the interest of building highly efficient software, that code has been removed
-	// here, and we'll rely on the host to detect bad actors through their own means.
-	if !s.Throttler().Allow() {
-		return
+			go func() {
+				s.Log().Warn("stopping server instance, violating throttle limits")
+				s.PublishConsoleOutputFromDaemon("Your server is being stopped for outputting too much data in a short period of time.")
+
+				// Completely skip over server power actions and terminate the running instance. This gives the
+				// server 15 seconds to finish stopping gracefully before it is forcefully terminated.
+				if err := s.Environment.WaitForStop(config.Get().Throttles.StopGracePeriod, true); err != nil {
+					// If there is an error set the process back to running so that this throttler is called
+					// again and hopefully kills the server.
+					if s.Environment.State() != environment.ProcessOfflineState {
+						s.Environment.SetState(environment.ProcessRunningState)
 					}
 
+					s.Log().WithField("error", err).Error("failed to terminate environment after triggering throttle")
+				}
+			}()
+		}
+	}
+
+	// If we are not throttled, go ahead and output the data.
+	if !t.Throttled() {
 		s.Sink(LogSink).Push(v)
+	}
+
+	// Also pass the data along to the console output channel.
+	s.onConsoleOutput(string(v))
 }
 
-// StartEventListeners adds all the internal event listeners we want to use for
-// a server. These listeners can only be removed by deleting the server as they
-// should last for the duration of the process' lifetime.
+// StartEventListeners adds all the internal event listeners we want to use for a server. These listeners can only be
+// removed by deleting the server as they should last for the duration of the process' lifetime.
 func (s *Server) StartEventListeners() {
 	state := make(chan events.Event)
 	stats := make(chan events.Event)
@@ -100,10 +114,13 @@ func (s *Server) StartEventListeners() {
 				}()
 			case e := <-stats:
 				go func() {
-					s.resources.UpdateStats(e.Data.(environment.Stats))
+					// Update the server resource tracking object with the resources we got here.
+					s.resources.mu.Lock()
+					s.resources.Stats = e.Data.(environment.Stats)
+					s.resources.mu.Unlock()
 
-					// If there is no disk space available at this point, trigger the server
-					// disk limiter logic which will start to stop the running instance.
+					// If there is no disk space available at this point, trigger the server disk limiter logic
+					// which will start to stop the running instance.
 					if !s.Filesystem().HasSpaceAvailable(true) {
 						l.Trigger()
 					}
@@ -117,10 +134,8 @@ func (s *Server) StartEventListeners() {
 						s.Events().Publish(InstallOutputEvent, e.Data)
 					case environment.DockerImagePullStarted:
 						s.PublishConsoleOutputFromDaemon("Pulling Docker container image, this could take a few minutes to complete...")
-					case environment.DockerImagePullCompleted:
-						s.PublishConsoleOutputFromDaemon("Finished pulling Docker container image")
 					default:
-						s.Log().WithField("topic", e.Topic).Error("unhandled docker event topic")
+						s.PublishConsoleOutputFromDaemon("Finished pulling Docker container image")
 					}
 				}()
 			}
@@ -138,34 +153,27 @@ var stripAnsiRegex = regexp.MustCompile("[\u001B\u009B][[\\]()#;?]*(?:(?:(?:[a-z
 
 // Custom listener for console output events that will check if the given line
 // of output matches one that should mark the server as started or not.
-func (s *Server) onConsoleOutput(data []byte) {
-	if s.Environment.State() != environment.ProcessStartingState && !s.IsRunning() {
-		return
-	}
-
+func (s *Server) onConsoleOutput(data string) {
+	// Get the server's process configuration.
 	processConfiguration := s.ProcessConfiguration()
 
-	// Make a copy of the data provided since it is by reference, otherwise you'll
-	// potentially introduce a race condition by modifying the value.
-	v := make([]byte, len(data))
-	copy(v, data)
-
 	// Check if the server is currently starting.
 	if s.Environment.State() == environment.ProcessStartingState {
 		// Check if we should strip ansi color codes.
 		if processConfiguration.Startup.StripAnsi {
-			v = stripAnsiRegex.ReplaceAll(v, []byte(""))
+			// Strip ansi color codes from the data string.
+			data = stripAnsiRegex.ReplaceAllString(data, "")
 		}
 
 		// Iterate over all the done lines.
 		for _, l := range processConfiguration.Startup.Done {
-			if !l.Matches(v) {
+			if !l.Matches(data) {
 				continue
 			}
 
 			s.Log().WithFields(log.Fields{
 				"match":   l.String(),
-				"against": strconv.QuoteToASCII(string(v)),
+				"against": strconv.QuoteToASCII(data),
 			}).Debug("detected server in running state based on console line output")
 
 			// If the specific line of output is one that would mark the server as started,
@@ -182,7 +190,7 @@ func (s *Server) onConsoleOutput(data []byte) {
 	if s.IsRunning() {
 		stop := processConfiguration.Stop
 
-		if stop.Type == remote.ProcessStopCommand && bytes.Equal(v, []byte(stop.Value)) {
+		if stop.Type == remote.ProcessStopCommand && data == stop.Value {
 			s.Environment.SetState(environment.ProcessOfflineState)
 		}
 	}

server/manager.go

@@ -199,6 +199,7 @@ func (m *Manager) InitServer(data remote.ServerConfigurationResponse) (*Server,
 	} else {
 		s.Environment = env
 		s.StartEventListeners()
+		s.Throttler().StartTimer(s.Context())
 	}
 
 	// If the server's data directory exists, force disk usage calculation.

server/power.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"fmt"
 	"os"
+	"sync"
 	"time"
 
 	"emperror.dev/errors"
@@ -40,6 +41,81 @@ func (pa PowerAction) IsStart() bool {
 	return pa == PowerActionStart || pa == PowerActionRestart
 }
 
+type powerLocker struct {
+	mu sync.RWMutex
+	ch chan bool
+}
+
+func newPowerLocker() *powerLocker {
+	return &powerLocker{
+		ch: make(chan bool, 1),
+	}
+}
+
+type errPowerLockerLocked struct{}
+
+func (e errPowerLockerLocked) Error() string {
+	return "cannot acquire a lock on the power state: already locked"
+}
+
+var ErrPowerLockerLocked error = errPowerLockerLocked{}
+
+// IsLocked returns the current state of the locker channel. If there is
+// currently a value in the channel, it is assumed to be locked.
+func (pl *powerLocker) IsLocked() bool {
+	pl.mu.RLock()
+	defer pl.mu.RUnlock()
+	return len(pl.ch) == 1
+}
+
+// Acquire will acquire the power lock if it is not currently locked. If it is
+// already locked, acquire will fail to acquire the lock, and will return false.
+func (pl *powerLocker) Acquire() error {
+	pl.mu.Lock()
+	defer pl.mu.Unlock()
+	if len(pl.ch) == 1 {
+		return errors.WithStack(ErrPowerLockerLocked)
+	}
+	pl.ch <- true
+	return nil
+}
+
+// TryAcquire will attempt to acquire a power-lock until the context provided
+// is canceled.
+func (pl *powerLocker) TryAcquire(ctx context.Context) error {
+	select {
+	case pl.ch <- true:
+		return nil
+	case <-ctx.Done():
+		if err := ctx.Err(); err != nil {
+			return errors.WithStack(err)
+		}
+		return nil
+	}
+}
+
+// Release will drain the locker channel so that we can properly re-acquire it
+// at a later time.
+func (pl *powerLocker) Release() {
+	pl.mu.Lock()
+	if len(pl.ch) == 1 {
+		<-pl.ch
+	}
+	pl.mu.Unlock()
+}
+
+// Destroy cleans up the power locker by closing the channel.
+func (pl *powerLocker) Destroy() {
+	pl.mu.Lock()
+	if pl.ch != nil {
+		if len(pl.ch) == 1 {
+			<-pl.ch
+		}
+		close(pl.ch)
+	}
+	pl.mu.Unlock()
+}
+
 // ExecutingPowerAction checks if there is currently a power action being
 // processed for the server.
 func (s *Server) ExecutingPowerAction() bool {

server/power_test.go

@@ -1,18 +1,154 @@
 package server
 
 import (
+	"context"
 	"testing"
+	"time"
 
+	"emperror.dev/errors"
 	. "github.com/franela/goblin"
-	"github.com/pterodactyl/wings/system"
 )
 
 func TestPower(t *testing.T) {
 	g := Goblin(t)
 
+	g.Describe("PowerLocker", func() {
+		var pl *powerLocker
+		g.BeforeEach(func() {
+			pl = newPowerLocker()
+		})
+
+		g.Describe("PowerLocker#IsLocked", func() {
+			g.It("should return false when the channel is empty", func() {
+				g.Assert(cap(pl.ch)).Equal(1)
+				g.Assert(pl.IsLocked()).IsFalse()
+			})
+
+			g.It("should return true when the channel is at capacity", func() {
+				pl.ch <- true
+
+				g.Assert(pl.IsLocked()).IsTrue()
+				<-pl.ch
+				g.Assert(pl.IsLocked()).IsFalse()
+
+				// We don't care what the channel value is, just that there is
+				// something in it.
+				pl.ch <- false
+				g.Assert(pl.IsLocked()).IsTrue()
+				g.Assert(cap(pl.ch)).Equal(1)
+			})
+		})
+
+		g.Describe("PowerLocker#Acquire", func() {
+			g.It("should acquire a lock when channel is empty", func() {
+				err := pl.Acquire()
+
+				g.Assert(err).IsNil()
+				g.Assert(cap(pl.ch)).Equal(1)
+				g.Assert(len(pl.ch)).Equal(1)
+			})
+
+			g.It("should return an error when the channel is full", func() {
+				pl.ch <- true
+
+				err := pl.Acquire()
+
+				g.Assert(err).IsNotNil()
+				g.Assert(errors.Is(err, ErrPowerLockerLocked)).IsTrue()
+				g.Assert(cap(pl.ch)).Equal(1)
+				g.Assert(len(pl.ch)).Equal(1)
+			})
+		})
+
+		g.Describe("PowerLocker#TryAcquire", func() {
+			g.It("should acquire a lock when channel is empty", func() {
+				g.Timeout(time.Second)
+
+				err := pl.TryAcquire(context.Background())
+
+				g.Assert(err).IsNil()
+				g.Assert(cap(pl.ch)).Equal(1)
+				g.Assert(len(pl.ch)).Equal(1)
+				g.Assert(pl.IsLocked()).IsTrue()
+			})
+
+			g.It("should block until context is canceled if channel is full", func() {
+				g.Timeout(time.Second)
+				ctx, cancel := context.WithTimeout(context.Background(), time.Millisecond*500)
+				defer cancel()
+
+				pl.ch <- true
+				err := pl.TryAcquire(ctx)
+
+				g.Assert(err).IsNotNil()
+				g.Assert(errors.Is(err, context.DeadlineExceeded)).IsTrue()
+				g.Assert(cap(pl.ch)).Equal(1)
+				g.Assert(len(pl.ch)).Equal(1)
+				g.Assert(pl.IsLocked()).IsTrue()
+			})
+
+			g.It("should block until lock can be acquired", func() {
+				g.Timeout(time.Second)
+
+				ctx, cancel := context.WithTimeout(context.Background(), time.Millisecond*200)
+				defer cancel()
+
+				pl.Acquire()
+				go func() {
+					time.AfterFunc(time.Millisecond * 50, func() {
+						pl.Release()
+					})
+				}()
+
+				err := pl.TryAcquire(ctx)
+				g.Assert(err).IsNil()
+				g.Assert(cap(pl.ch)).Equal(1)
+				g.Assert(len(pl.ch)).Equal(1)
+				g.Assert(pl.IsLocked()).IsTrue()
+			})
+		})
+
+		g.Describe("PowerLocker#Release", func() {
+			g.It("should release when channel is full", func() {
+				pl.Acquire()
+				g.Assert(pl.IsLocked()).IsTrue()
+				pl.Release()
+				g.Assert(cap(pl.ch)).Equal(1)
+				g.Assert(len(pl.ch)).Equal(0)
+				g.Assert(pl.IsLocked()).IsFalse()
+			})
+
+			g.It("should release when channel is empty", func() {
+				g.Assert(pl.IsLocked()).IsFalse()
+				pl.Release()
+				g.Assert(cap(pl.ch)).Equal(1)
+				g.Assert(len(pl.ch)).Equal(0)
+				g.Assert(pl.IsLocked()).IsFalse()
+			})
+		})
+
+		g.Describe("PowerLocker#Destroy", func() {
+			g.It("should unlock and close the channel", func() {
+				pl.Acquire()
+				g.Assert(pl.IsLocked()).IsTrue()
+				pl.Destroy()
+				g.Assert(pl.IsLocked()).IsFalse()
+
+				defer func() {
+					r := recover()
+
+					g.Assert(r).IsNotNil()
+					g.Assert(r.(error).Error()).Equal("send on closed channel")
+				}()
+
+				pl.Acquire()
+			})
+		})
+	})
+
 	g.Describe("Server#ExecutingPowerAction", func() {
 		g.It("should return based on locker status", func() {
-			s := &Server{powerLock: system.NewLocker()}
+			s := &Server{powerLock: newPowerLocker()}
 
 			g.Assert(s.ExecutingPowerAction()).IsFalse()
 			s.powerLock.Acquire()

server/resources.go

@@ -38,13 +38,6 @@ func (s *Server) Proc() ResourceUsage {
 	return s.resources
 }
 
-// UpdateStats updates the current stats for the server's resource usage.
-func (ru *ResourceUsage) UpdateStats(stats environment.Stats) {
-	ru.mu.Lock()
-	ru.Stats = stats
-	ru.mu.Unlock()
-}
-
 // Reset resets the usages values to zero, used when a server is stopped to ensure we don't hold
 // onto any values incorrectly.
 func (ru *ResourceUsage) Reset() {

server/server.go

@@ -31,7 +31,8 @@ type Server struct {
 	ctxCancel *context.CancelFunc
 
 	emitterLock  sync.Mutex
-	powerLock   *system.Locker
+	powerLock    *powerLocker
+	throttleOnce sync.Once
 
 	// Maintains the configuration for the server. This is the data that gets returned by the Panel
 	// such as build settings and container images.
@@ -63,8 +64,7 @@ type Server struct {
 	restoring    *system.AtomicBool
 
 	// The console throttler instance used to control outputs.
-	throttler    *ConsoleThrottle
-	throttleOnce sync.Once
+	throttler *ConsoleThrottler
 
 	// Tracks open websocket connections for the server.
 	wsBag       *WebsocketBag
@@ -87,7 +87,7 @@ func New(client remote.Client) (*Server, error) {
 		installing:   system.NewAtomicBool(false),
 		transferring: system.NewAtomicBool(false),
 		restoring:    system.NewAtomicBool(false),
-		powerLock:    system.NewLocker(),
+		powerLock:    newPowerLocker(),
 		sinks: map[SinkName]*sinkPool{
 			LogSink:     newSinkPool(),
 			InstallSink: newSinkPool(),
@@ -239,6 +239,14 @@ func (s *Server) ReadLogfile(len int) ([]string, error) {
 	return s.Environment.Readlog(len)
 }
 
+// Determine if the server is bootable in it's current state or not. This will not
+// indicate why a server is not bootable, only if it is.
+func (s *Server) IsBootable() bool {
+	exists, _ := s.Environment.Exists()
+
+	return exists
+}
+
 // Initializes a server instance. This will run through and ensure that the environment
 // for the server is setup, and that all of the necessary files are created.
 func (s *Server) CreateEnvironment() error {

server/sink.go

@@ -2,7 +2,6 @@ package server
 
 import (
 	"sync"
-	"time"
 )
 
 // SinkName represents one of the registered sinks for a server.
@@ -80,44 +79,20 @@ func (p *sinkPool) Destroy() {
 }
 
 // Push sends a given message to each of the channels registered in the pool.
-// This will use a Ring Buffer channel in order to avoid blocking the channel
-// sends, and attempt to push though the most recent messages in the queue in
-// favor of the oldest messages.
-//
-// If the channel becomes full and isn't being drained fast enough, this
-// function will remove the oldest message in the channel, and then push the
-// message that it got onto the end, effectively making the channel a rolling
-// buffer.
-//
-// There is a potential for data to be lost when passing it through this
-// function, but only in instances where the channel buffer is full and the
-// channel is not drained fast enough, in which case dropping messages is most
-// likely the best option anyways. This uses waitgroups to allow every channel
-// to attempt its send concurrently thus making the total blocking time of this
-// function "O(1)" instead of "O(n)".
 func (p *sinkPool) Push(data []byte) {
 	p.mu.RLock()
-	defer p.mu.RUnlock()
-	var wg sync.WaitGroup
-	wg.Add(len(p.sinks))
+	// Attempt to send the data over to the channels. If the channel buffer is full,
+	// or otherwise blocked for some reason (such as being a nil channel), just discard
+	// the event data and move on to the next channel in the slice. If you don't
+	// implement the "default" on the select you'll block execution until the channel
+	// becomes unblocked, which is not what we want to do here.
 	for _, c := range p.sinks {
-		go func(c chan []byte) {
-			defer wg.Done()
 		select {
 		case c <- data:
-			case <-time.After(time.Millisecond * 10):
-				// If there is nothing in the channel to read, but we also cannot write
-				// to the channel, just skip over sending data. If we don't do this you'll
-				// end up blocking the application on the channel read below.
-				if len(c) == 0 {
-					break
+		default:
 		}
-				<-c
-				c <- data
 	}
-		}(c)
-	}
-	wg.Wait()
+	p.mu.RUnlock()
 }
 
 // Sink returns the instantiated and named sink for a server. If the sink has

server/sink_test.go

@@ -1,11 +1,9 @@
 package server
 
 import (
-	"fmt"
 	"reflect"
 	"sync"
 	"testing"
-	"time"
 
 	. "github.com/franela/goblin"
 )
@@ -83,7 +81,7 @@ func TestSink(t *testing.T) {
 		g.It("does not panic if a nil channel is provided", func() {
 			ch := make([]chan []byte, 1)
 
-			defer func() {
+			defer func () {
 				if r := recover(); r != nil {
                     g.Fail("removing a nil channel should not cause a panic")
                 }
@@ -125,67 +123,22 @@ func TestSink(t *testing.T) {
 			g.Assert(len(pool.sinks)).Equal(2)
 		})
 
-		g.It("uses a ring-buffer to avoid blocking when the channel is full", func() {
-			ch1 := make(chan []byte, 1)
-			ch2 := make(chan []byte, 2)
-			ch3 := make(chan []byte)
+		g.It("does not block if a channel is nil or otherwise full", func() {
+			ch := make([]chan []byte, 2)
+			ch[1] = make(chan []byte, 1)
+			ch[1] <- []byte("test")
 
-			// ch1 and ch2 are now full, and would block if the code doesn't account
-			// for a full buffer.
-			ch1 <- []byte("pre-test")
-			ch2 <- []byte("pre-test")
-			ch2 <- []byte("pre-test 2")
-
-			pool.On(ch1)
-			pool.On(ch2)
-			pool.On(ch3)
+			pool.On(ch[0])
+			pool.On(ch[1])
 
 			pool.Push([]byte("testing"))
-			time.Sleep(time.Millisecond * 20)
 
 			g.Assert(MutexLocked(&pool.mu)).IsFalse()
-			// We expect that value previously in the channel to have been dumped
-			// and therefore only the value we pushed will be present. For ch2 we
-			// expect only the first message was dropped, and the second one is now
-			// the first in the out queue.
-			g.Assert(<-ch1).Equal([]byte("testing"))
-			g.Assert(<-ch2).Equal([]byte("pre-test 2"))
-			g.Assert(<-ch2).Equal([]byte("testing"))
-
-			// Because nothing in this test was listening for ch3, it would have
-			// blocked for the 10ms duration, and then been skipped over entirely
-			// because it had no length to try and push onto.
-			g.Assert(len(ch3)).Equal(0)
-
-			// Now, push again and expect similar results.
-			pool.Push([]byte("testing 2"))
-			time.Sleep(time.Millisecond * 20)
+			g.Assert(<-ch[1]).Equal([]byte("test"))
 
+			pool.Push([]byte("test2"))
+			g.Assert(<-ch[1]).Equal([]byte("test2"))
 			g.Assert(MutexLocked(&pool.mu)).IsFalse()
-			g.Assert(<-ch1).Equal([]byte("testing 2"))
-			g.Assert(<-ch2).Equal([]byte("testing 2"))
-		})
-
-		g.It("can handle concurrent pushes FIFO", func() {
-			ch := make(chan []byte, 4)
-
-			pool.On(ch)
-			pool.On(make(chan []byte))
-
-			for i := 0; i < 100; i++ {
-				pool.Push([]byte(fmt.Sprintf("iteration %d", i)))
-			}
-
-			time.Sleep(time.Millisecond * 20)
-			g.Assert(MutexLocked(&pool.mu)).IsFalse()
-			g.Assert(len(ch)).Equal(4)
-
-			g.Timeout(time.Millisecond * 500)
-			g.Assert(<-ch).Equal([]byte("iteration 96"))
-			g.Assert(<-ch).Equal([]byte("iteration 97"))
-			g.Assert(<-ch).Equal([]byte("iteration 98"))
-			g.Assert(<-ch).Equal([]byte("iteration 99"))
-			g.Assert(len(ch)).Equal(0)
 		})
 	})
 

system/locker.go

@@ -1,83 +0,0 @@
-package system
-
-import (
-	"context"
-	"sync"
-
-	"emperror.dev/errors"
-)
-
-var ErrLockerLocked = errors.Sentinel("locker: cannot acquire lock, already locked")
-
-type Locker struct {
-	mu sync.RWMutex
-	ch chan bool
-}
-
-// NewLocker returns a new Locker instance.
-func NewLocker() *Locker {
-	return &Locker{
-		ch: make(chan bool, 1),
-	}
-}
-
-// IsLocked returns the current state of the locker channel. If there is
-// currently a value in the channel, it is assumed to be locked.
-func (l *Locker) IsLocked() bool {
-	l.mu.RLock()
-	defer l.mu.RUnlock()
-	return len(l.ch) == 1
-}
-
-// Acquire will acquire the power lock if it is not currently locked. If it is
-// already locked, acquire will fail to acquire the lock, and will return false.
-func (l *Locker) Acquire() error {
-	l.mu.Lock()
-	defer l.mu.Unlock()
-	select {
-	case l.ch <- true:
-	default:
-		return ErrLockerLocked
-	}
-	return nil
-}
-
-
-// TryAcquire will attempt to acquire a power-lock until the context provided
-// is canceled.
-func (l *Locker) TryAcquire(ctx context.Context) error {
-	select {
-	case l.ch <- true:
-		return nil
-	case <-ctx.Done():
-		if err := ctx.Err(); err != nil {
-			return err
-		}
-		return nil
-	}
-}
-
-// Release will drain the locker channel so that we can properly re-acquire it
-// at a later time. If the channel is not currently locked this function is a
-// no-op and will immediately return.
-func (l *Locker) Release() {
-	l.mu.Lock()
-	select {
-	case <-l.ch:
-	default:
-	}
-	l.mu.Unlock()
-}
-
-// Destroy cleans up the power locker by closing the channel.
-func (l *Locker) Destroy() {
-	l.mu.Lock()
-	if l.ch != nil {
-		select {
-		case <-l.ch:
-		default:
-		}
-		close(l.ch)
-	}
-	l.mu.Unlock()
-}

system/locker_test.go

@@ -1,148 +0,0 @@
-package system
-
-import (
-	"context"
-	"testing"
-	"time"
-
-	"emperror.dev/errors"
-	. "github.com/franela/goblin"
-)
-
-func TestPower(t *testing.T) {
-	g := Goblin(t)
-
-	g.Describe("Locker", func() {
-		var l *Locker
-		g.BeforeEach(func() {
-			l = NewLocker()
-		})
-
-		g.Describe("PowerLocker#IsLocked", func() {
-			g.It("should return false when the channel is empty", func() {
-				g.Assert(cap(l.ch)).Equal(1)
-				g.Assert(l.IsLocked()).IsFalse()
-			})
-
-			g.It("should return true when the channel is at capacity", func() {
-				l.ch <- true
-
-				g.Assert(l.IsLocked()).IsTrue()
-				<-l.ch
-				g.Assert(l.IsLocked()).IsFalse()
-
-				// We don't care what the channel value is, just that there is
-				// something in it.
-				l.ch <- false
-				g.Assert(l.IsLocked()).IsTrue()
-				g.Assert(cap(l.ch)).Equal(1)
-			})
-		})
-
-		g.Describe("PowerLocker#Acquire", func() {
-			g.It("should acquire a lock when channel is empty", func() {
-				err := l.Acquire()
-
-				g.Assert(err).IsNil()
-				g.Assert(cap(l.ch)).Equal(1)
-				g.Assert(len(l.ch)).Equal(1)
-			})
-
-			g.It("should return an error when the channel is full", func() {
-				l.ch <- true
-
-				err := l.Acquire()
-
-				g.Assert(err).IsNotNil()
-				g.Assert(errors.Is(err, ErrLockerLocked)).IsTrue()
-				g.Assert(cap(l.ch)).Equal(1)
-				g.Assert(len(l.ch)).Equal(1)
-			})
-		})
-
-		g.Describe("PowerLocker#TryAcquire", func() {
-			g.It("should acquire a lock when channel is empty", func() {
-				g.Timeout(time.Second)
-
-				err := l.TryAcquire(context.Background())
-
-				g.Assert(err).IsNil()
-				g.Assert(cap(l.ch)).Equal(1)
-				g.Assert(len(l.ch)).Equal(1)
-				g.Assert(l.IsLocked()).IsTrue()
-			})
-
-			g.It("should block until context is canceled if channel is full", func() {
-				g.Timeout(time.Second)
-				ctx, cancel := context.WithTimeout(context.Background(), time.Millisecond*500)
-				defer cancel()
-
-				l.ch <- true
-				err := l.TryAcquire(ctx)
-
-				g.Assert(err).IsNotNil()
-				g.Assert(errors.Is(err, context.DeadlineExceeded)).IsTrue()
-				g.Assert(cap(l.ch)).Equal(1)
-				g.Assert(len(l.ch)).Equal(1)
-				g.Assert(l.IsLocked()).IsTrue()
-			})
-
-			g.It("should block until lock can be acquired", func() {
-				g.Timeout(time.Second)
-
-				ctx, cancel := context.WithTimeout(context.Background(), time.Millisecond*200)
-				defer cancel()
-
-				l.Acquire()
-				go func() {
-					time.AfterFunc(time.Millisecond * 50, func() {
-						l.Release()
-					})
-				}()
-
-				err := l.TryAcquire(ctx)
-				g.Assert(err).IsNil()
-				g.Assert(cap(l.ch)).Equal(1)
-				g.Assert(len(l.ch)).Equal(1)
-				g.Assert(l.IsLocked()).IsTrue()
-			})
-		})
-
-		g.Describe("PowerLocker#Release", func() {
-			g.It("should release when channel is full", func() {
-				l.Acquire()
-				g.Assert(l.IsLocked()).IsTrue()
-				l.Release()
-				g.Assert(cap(l.ch)).Equal(1)
-				g.Assert(len(l.ch)).Equal(0)
-				g.Assert(l.IsLocked()).IsFalse()
-			})
-
-			g.It("should release when channel is empty", func() {
-				g.Assert(l.IsLocked()).IsFalse()
-				l.Release()
-				g.Assert(cap(l.ch)).Equal(1)
-				g.Assert(len(l.ch)).Equal(0)
-				g.Assert(l.IsLocked()).IsFalse()
-			})
-		})
-
-		g.Describe("PowerLocker#Destroy", func() {
-			g.It("should unlock and close the channel", func() {
-				l.Acquire()
-				g.Assert(l.IsLocked()).IsTrue()
-				l.Destroy()
-				g.Assert(l.IsLocked()).IsFalse()
-
-				defer func() {
-					r := recover()
-
-					g.Assert(r).IsNotNil()
-					g.Assert(r.(error).Error()).Equal("send on closed channel")
-				}()
-
-				l.Acquire()
-			})
-		})
-	})
-}

system/rate.go

@@ -1,50 +0,0 @@
-package system
-
-import (
-	"sync"
-	"time"
-)
-
-// Rate defines a rate limiter of n items (limit) per duration of time.
-type Rate struct {
-	mu       sync.Mutex
-	limit    uint64
-	duration time.Duration
-	count    uint64
-	last     time.Time
-}
-
-func NewRate(limit uint64, duration time.Duration) *Rate {
-	return &Rate{
-		limit:    limit,
-		duration: duration,
-		last:     time.Now(),
-	}
-}
-
-// Try returns true if under the rate limit defined, or false if the rate limit
-// has been exceeded for the current duration.
-func (r *Rate) Try() bool {
-	r.mu.Lock()
-	defer r.mu.Unlock()
-	now := time.Now()
-	// If it has been more than the duration, reset the timer and count.
-	if now.Sub(r.last) > r.duration {
-		r.count = 0
-		r.last = now
-	}
-	if (r.count + 1) > r.limit {
-		return false
-	}
-	// Hit this once, and return.
-	r.count = r.count + 1
-	return true
-}
-
-// Reset resets the internal state of the rate limiter back to zero.
-func (r *Rate) Reset() {
-	r.mu.Lock()
-    r.count = 0
-    r.last = time.Now()
-	r.mu.Unlock()
-}

system/rate_test.go

@@ -1,67 +0,0 @@
-package system
-
-import (
-	"testing"
-	"time"
-
-	. "github.com/franela/goblin"
-)
-
-func TestRate(t *testing.T) {
-	g := Goblin(t)
-
-	g.Describe("Rate", func() {
-		g.It("properly rate limits a bucket", func() {
-			r := NewRate(10, time.Millisecond*100)
-
-			for i := 0; i < 100; i++ {
-				ok := r.Try()
-				if i < 10 && !ok {
-					g.Failf("should not have allowed take on try %d", i)
-				} else if i >= 10 && ok {
-					g.Failf("should have blocked take on try %d", i)
-				}
-			}
-		})
-
-		g.It("handles rate limiting in chunks", func() {
-			var out []int
-			r := NewRate(12, time.Millisecond*10)
-
-			for i := 0; i < 100; i++ {
-				if i%20 == 0 {
-					// Give it time to recover.
-					time.Sleep(time.Millisecond * 10)
-				}
-				if r.Try() {
-					out = append(out, i)
-				}
-			}
-
-			g.Assert(len(out)).Equal(60)
-			g.Assert(out[0]).Equal(0)
-			g.Assert(out[12]).Equal(20)
-			g.Assert(out[len(out)-1]).Equal(91)
-		})
-
-		g.It("resets back to zero when called", func() {
-			r := NewRate(10, time.Second)
-			for i := 0; i < 100; i++ {
-				if i % 10 == 0 {
-					r.Reset()
-				}
-				g.Assert(r.Try()).IsTrue()
-			}
-			g.Assert(r.Try()).IsFalse("final attempt should not allow taking")
-		})
-	})
-}
-
-func BenchmarkRate_Try(b *testing.B) {
-	r := NewRate(10, time.Millisecond*100)
-
-	b.ReportAllocs()
-	for i := 0; i < b.N; i++ {
-		r.Try()
-	}
-}

system/utils.go

@@ -165,9 +165,9 @@ func (ab *AtomicBool) Store(v bool) {
 	ab.mu.Unlock()
 }
 
-// SwapIf stores the value "v" if the current value stored in the AtomicBool is
-// the opposite boolean value. If successfully swapped, the response is "true",
-// otherwise "false" is returned.
+// Stores the value "v" if the current value stored in the AtomicBool is the opposite
+// boolean value. If successfully swapped, the response is "true", otherwise "false"
+// is returned.
 func (ab *AtomicBool) SwapIf(v bool) bool {
 	ab.mu.Lock()
 	defer ab.mu.Unlock()

system/utils_test.go

@@ -3,12 +3,10 @@ package system
 import (
 	"math/rand"
 	"strings"
-	"sync"
 	"testing"
 	"time"
 
 	. "github.com/franela/goblin"
-	"github.com/goccy/go-json"
 )
 
 func Test_Utils(t *testing.T) {
@@ -42,80 +40,6 @@ func Test_Utils(t *testing.T) {
 			g.Assert(lines).Equal([]string{"test\rstrin", "another\rli", "hodor\r\r\rhe", "material g"})
 		})
 	})
-
-	g.Describe("AtomicBool", func() {
-		var b *AtomicBool
-		g.BeforeEach(func() {
-			b = NewAtomicBool(false)
-		})
-
-		g.It("initalizes with the provided start value", func() {
-			b = NewAtomicBool(true)
-			g.Assert(b.Load()).IsTrue()
-
-			b = NewAtomicBool(false)
-			g.Assert(b.Load()).IsFalse()
-		})
-
-		g.Describe("AtomicBool#Store", func() {
-			g.It("stores the provided value", func() {
-				g.Assert(b.Load()).IsFalse()
-				b.Store(true)
-				g.Assert(b.Load()).IsTrue()
-			})
-
-			// This test makes no assertions, it just expects to not hit a race condition
-			// by having multiple things writing at the same time.
-			g.It("handles contention from multiple routines", func() {
-				var wg sync.WaitGroup
-
-				wg.Add(100)
-				for i := 0; i < 100; i++ {
-					go func(i int) {
-						b.Store(i%2 == 0)
-						wg.Done()
-					}(i)
-				}
-				wg.Wait()
-			})
-		})
-
-		g.Describe("AtomicBool#SwapIf", func() {
-			g.It("swaps the value out if different than what is stored", func() {
-				o := b.SwapIf(false)
-				g.Assert(o).IsFalse()
-				g.Assert(b.Load()).IsFalse()
-
-				o = b.SwapIf(true)
-				g.Assert(o).IsTrue()
-				g.Assert(b.Load()).IsTrue()
-
-				o = b.SwapIf(true)
-				g.Assert(o).IsFalse()
-				g.Assert(b.Load()).IsTrue()
-
-				o = b.SwapIf(false)
-				g.Assert(o).IsTrue()
-				g.Assert(b.Load()).IsFalse()
-			})
-		})
-
-		g.Describe("can be marshaled with JSON", func() {
-			type testStruct struct {
-				Value AtomicBool `json:"value"`
-			}
-
-			var o testStruct
-			err := json.Unmarshal([]byte(`{"value":true}`), &o)
-
-			g.Assert(err).IsNil()
-			g.Assert(o.Value.Load()).IsTrue()
-
-			b, err2 := json.Marshal(&o)
-			g.Assert(err2).IsNil()
-			g.Assert(b).Equal([]byte(`{"value":true}`))
-		})
-	})
 }
 
 func Benchmark_ScanReader(b *testing.B) {