bump version for release

.envrc

@@ -1 +0,0 @@
-use flake

.github/workflows/codeql.yaml

@@ -13,7 +13,7 @@ on:
 jobs:
   analyze:
     name: Analyze
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-20.04
 
     permissions:
       actions: read
@@ -28,7 +28,7 @@ jobs:
 
     steps:
       - name: Code Checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@v3
 
       - name: Initialize CodeQL
         uses: github/codeql-action/init@v2

.github/workflows/docker.yaml

@@ -4,40 +4,34 @@ on:
   push:
     branches:
       - develop
-  release:
+    tags:
-    types:
+      - "v*"
-      - published
 
 jobs:
   build-and-push:
     name: Build and Push
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-20.04
     # Always run against a tag, even if the commit into the tag has [docker skip] within the commit message.
     if: "!contains(github.ref, 'develop') || (!contains(github.event.head_commit.message, 'skip docker') && !contains(github.event.head_commit.message, 'docker skip'))"
-    steps:
-      - name: Code checkout
-        uses: actions/checkout@v4
 
-      - name: Docker metadata
+    steps:
+      - name: Code Checkout
+        uses: actions/checkout@v3
+
+      - name: Docker Meta
         id: docker_meta
-        uses: docker/metadata-action@v5
+        uses: crazy-max/ghaction-docker-meta@v1
         with:
           images: ghcr.io/pterodactyl/wings
-          flavor: |
-            latest=false
-          tags: |
-            type=raw,value=latest,enable=${{ github.event_name == 'release' && github.event.action == 'published' && github.event.release.prerelease == false }}
-            type=ref,event=tag
-            type=ref,event=branch
 
-      - name: Setup QEMU
+      - name: Set up QEMU
-        uses: docker/setup-qemu-action@v3
+        uses: docker/setup-qemu-action@v2
 
-      - name: Setup Docker buildx
+      - name: Install buildx
-        uses: docker/setup-buildx-action@v3
+        uses: docker/setup-buildx-action@v2
 
       - name: Login to GitHub Container Registry
-        uses: docker/login-action@v3
+        uses: docker/login-action@v2
         with:
           registry: ghcr.io
           username: ${{ github.repository_owner }}
@@ -46,12 +40,12 @@ jobs:
       - name: Get Build Information
         id: build_info
         run: |
-          echo "version_tag=${GITHUB_REF/refs\/tags\/v/}" >> $GITHUB_OUTPUT
+          echo "::set-output name=version_tag::${GITHUB_REF/refs\/tags\/v/}"
-          echo "short_sha=$(git rev-parse --short HEAD)" >> $GITHUB_OUTPUT
+          echo "::set-output name=short_sha::$(git rev-parse --short HEAD)"
 
-      - name: Build and Push (tag)
+      - name: Build and push (latest)
-        uses: docker/build-push-action@v5
+        uses: docker/build-push-action@v2
-        if: "github.event_name == 'release' && github.event.action == 'published'"
+        if: "!contains(github.ref, 'develop')"
         with:
           context: .
           file: ./Dockerfile
@@ -62,9 +56,9 @@ jobs:
           labels: ${{ steps.docker_meta.outputs.labels }}
           tags: ${{ steps.docker_meta.outputs.tags }}
 
-      - name: Build and Push (develop)
+      - name: Build and push (develop)
-        uses: docker/build-push-action@v5
+        uses: docker/build-push-action@v2
-        if: "github.event_name == 'push' && contains(github.ref, 'develop')"
+        if: "contains(github.ref, 'develop')"
         with:
           context: .
           file: ./Dockerfile

.github/workflows/push.yaml

@@ -15,19 +15,44 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        os: [ubuntu-22.04]
+        os: [ubuntu-20.04]
-        go: ["1.22.5"]
+        go: ["1.18.8", "1.19.3"]
         goos: [linux]
         goarch: [amd64, arm64]
 
     steps:
       - name: Setup Go
-        uses: actions/setup-go@v5
+        uses: actions/setup-go@v3
         with:
           go-version: ${{ matrix.go }}
 
-      - name: Code checkout
+      - name: Code Checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@v3
+
+      - name: Gather environment variables
+        id: env
+        run: |
+          printf "Go Executable Path: $(which go)\n"
+          printf "Go Version: $(go version)\n"
+          printf "\n\nGo Environment:\n\n"
+          go env
+          printf "\n\nSystem Environment:\n\n"
+          env
+          printf "Git Version: $(git version)\n\n"
+          echo "version_tag=${GITHUB_REF/refs\/tags\//}" >> $GITHUB_OUTPUT
+          echo "short_sha=$(git rev-parse --short HEAD)" >> $GITHUB_OUTPUT
+          echo "go_cache=$(go env GOCACHE)" >> $GITHUB_OUTPUT
+          echo "go_mod_cache=$(go env GOMODCACHE)" >> $GITHUB_OUTPUT
+
+      - name: Build Cache
+        uses: actions/cache@v3
+        with:
+          key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
+          restore-keys: |
+            ${{ runner.os }}-go-
+          path: |
+            ${{ steps.env.outputs.go_cache }}
+            ${{ steps.env.outputs.go_mod_cache }}
 
       - name: go mod download
         env:
@@ -61,15 +86,15 @@ jobs:
           go test -race $(go list ./...)
 
       - name: Upload Release Artifact
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v2
-        if: ${{ (github.ref == 'refs/heads/develop' || github.event_name == 'pull_request') && matrix.go == '1.22.5' }}
+        if: ${{ github.ref == 'refs/heads/develop' || github.event_name == 'pull_request' }}
         with:
           name: wings_linux_${{ matrix.goarch }}
           path: dist/wings
 
       - name: Upload Debug Artifact
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v2
-        if: ${{ (github.ref == 'refs/heads/develop' || github.event_name == 'pull_request') && matrix.go == '1.22.5' }}
+        if: ${{ github.ref == 'refs/heads/develop' || github.event_name == 'pull_request' }}
         with:
           name: wings_linux_${{ matrix.goarch }}_debug
           path: dist/wings_debug

.github/workflows/release.yaml

@@ -8,16 +8,16 @@ on:
 jobs:
   release:
     name: Release
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-20.04
 
     steps:
       - name: Code Checkout
-        uses: actions/checkout@v4
+        uses: actions/checkout@v3
 
       - name: Setup Go
-        uses: actions/setup-go@v5
+        uses: actions/setup-go@v3
         with:
-          go-version: "1.22.5"
+          go-version: "1.18.8"
 
       - name: Build release binaries
         env:
@@ -34,6 +34,7 @@ jobs:
           REF: ${{ github.ref }}
         run: |
           sed -n "/^## ${REF:10}/,/^## /{/^## /b;p}" CHANGELOG.md > ./RELEASE_CHANGELOG
+          echo "version_name=`sed -nr "s/^## (${REF:10} .*)$/\1/p" CHANGELOG.md`" > $GITHUB_OUTPUT
 
       - name: Create checksum and add to changelog
         run: |
@@ -58,13 +59,15 @@ jobs:
 
       - name: Create release
         id: create_release
-        uses: softprops/action-gh-release@v1
+        uses: actions/create-release@v1
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
-          draft: true
+          tag_name: ${{ github.ref }}
-          prerelease: ${{ contains(github.ref, 'rc') || contains(github.ref, 'beta') || contains(github.ref, 'alpha') }}
+          release_name: ${{ steps.extract_changelog.outputs.version_name }}
           body_path: ./RELEASE_CHANGELOG
+          draft: true
+          prerelease: ${{ contains(github.ref, 'beta') || contains(github.ref, 'alpha') }}
 
       - name: Upload amd64 binary
         uses: actions/upload-release-asset@v1

CHANGELOG.md

@@ -1,128 +1,5 @@
 # Changelog
 
-## v1.11.14
-
-### Added
-
-* Support relative file paths for the Wings config ([#180](https://github.com/pterodactyl/wings/pull/180))
-
-### Fixed
-
-* Folders not being sorted before files properly ([#5078](https://github.com/pterodactyl/panel/issues/5078)
-
-## v1.11.13
-
-### Fixed
-
-* Auto-configure not working ([#5087](https://github.com/pterodactyl/panel/issues/5087))
-* Individual files unable to be decompressed ([#5034](https://github.com/pterodactyl/panel/issues/5034))
-
-## v1.11.12
-
-### Fixed
-* Arbitrary File Write/Read ([GHSA-gqmf-jqgv-v8fw](https://github.com/pterodactyl/wings/security/advisories/GHSA-gqmf-jqgv-v8fw))
-* Server-side Request Forgery (SSRF) during remote file pull ([GHSA-qq22-jj8x-4wwv](https://github.com/pterodactyl/wings/security/advisories/GHSA-qq22-jj8x-4wwv))
-* Invalid `Content-Type` being used with the `wings diagnostics` command ([#186](https://github.com/pterodactyl/wings/pull/186))
-
-## v1.11.11
-### Fixed
-* Backups missing content when a `.pteroignore` file is used
-* Archives originating from a subdirectory not containing any files ([#5030](https://github.com/pterodactyl/panel/issues/5030))
-
-## v1.11.10
-### Fixed
-* Archives randomly ignoring files and directories ([#5027](https://github.com/pterodactyl/panel/issues/5027))
-* Crash when deleting or transferring a server ([#5028](https://github.com/pterodactyl/panel/issues/5028))
-
-## v1.11.9
-### Changed
-* Release binaries are now built with Go 1.21.8
-* Updated Go dependencies
-
-### Fixed
-* [CVE-2024-27102](https://www.cve.org/CVERecord?id=CVE-2024-27102)
-
-## v1.11.8
-### Changed
-* Release binaries are now built with Go 1.20.10 (resolves [CVE-2023-44487](https://www.cve.org/CVERecord?id=CVE-2023-44487))
-* Updated Go dependencies
-
-## v1.11.7
-### Changed
-* Updated Go dependencies (this resolves an issue related to `http: invalid Host header` with Docker)
-* Wings is now built with go1.19.11
-
-## v1.11.6
-### Fixed
-* CVE-2023-32080
-
-## v1.11.5
-### Added
-* Added a config option to disable Wings config.yml updates from the Panel (https://github.com/pterodactyl/wings/commit/ec6d6d83ea3eb14995c24f001233e85b37ffb87b)
-
-### Changed
-* Wings is now built with Go 1.19.7
-
-### Fixed
-* Fixed archives containing partially matched file names (https://github.com/pterodactyl/wings/commit/43b3496f0001cec231c80af1f9a9b3417d04e8d4)
-
-## v1.11.4
-### Fixed
-* CVE-2023-25168
-
-## v1.11.3
-### Fixed
-* CVE-2023-25152
-
-## v1.11.2
-### Fixed
-* Backups being restored from remote storage (s3) erroring out due to a closed stream.
-* Fix IP validation logic for activity logs filtering out valid IPs instead of invalid IPs
-
-## v1.11.1
-### Changed
-* Release binaries are now built with Go 1.18.10
-* Timeout when stopping a server before a transfer begins has been reduced to 15 seconds from 1 minute
-* Removed insecure SSH protocols for use with the SFTP server
-
-### Fixed
-* Unnecessary Docker client connections being left open, causing a slow leak of file descriptors
-* Files being left open in parts of the server's filesystem, causing a leak of file descriptors
-* IPv6 addresses being corrupted by flawed port stripping logic for activity logs, old entries with malformed IPs will be deleted from the local SQLite database automatically
-* A server that times out while being stopped at the beginning of a transfer no longer causes the server to become stuck in a transferring state
-
-## v1.11.0
-### Added (since 1.7.2)
-* More detailed information returned by the `/api/system` endpoint when using the `?v=2` query parameter.
-
-### Changed (since 1.7.2)
-* Send re-installation status separately from installation status.
-* Wings release versions will now follow the major and minor version of the Panel.
-* Transfers no longer buffer to disk, instead they are fully streamed with only a small amount of memory used for buffering.
-* Release binaries are no longer compressed with UPX.
-* Use `POST` instead of `GET` for sending the status of a transfer to the Panel.
-
-### Fixed (since 1.7.2)
-* Fixed servers outgoing IP not being updated whenever a server's primary allocation is changed when using the Force Outgoing IP option.
-* Fixed servers being terminated rather than gracefully stopped when a signal is used to stop the container rather than a command.
-* Fixed file not found errors being treated as an internal error, they are now treated as a 404.
-* Wings can be run with Podman instead of Docker, this is still experimental and not recommended for production use.
-* Archive progress is now reported correctly.
-* Labels for containers can now be set by the Panel.
-* Fixed servers becoming deadlocked when the target node of a transfer goes offline.
-
-## v1.11.0-rc.2
-### Added
-* More detailed information returned by the `/api/system` endpoint when using the `?v=2` query parameter.
-
-### Changed
-* Send reinstallation status separately from installation status.
-
-### Fixed
-* Fixed servers outgoing IP not being updated whenever a server's primary allocation is changed when using the Force Outgoing IP option.
-* Fixed servers being terminated rather than gracefully stopped when a signal is used to stop the container rather than a command.
-* Fixed file not found errors being treated as an internal error, they are now treated as a 404.
-
 ## v1.11.0-rc.1
 ### Changed
 * Wings release versions will now follow the major and minor version of the panel.
@@ -134,18 +11,6 @@
 * Archive progress is now reported correctly.
 * Labels for containers can now be set by the Panel.
 
-## v1.7.5
-### Fixed
-* CVE-2023-32080
-
-## v1.7.4
-### Fixed
-* CVE-2023-25168
-
-## v1.7.3
-### Fixed
-* CVE-2023-25152
-
 ## v1.7.2
 ### Fixed
 * The S3 backup driver now supports Cloudflare R2

Dockerfile

@@ -1,5 +1,5 @@
 # Stage 1 (Build)
-FROM golang:1.22.5-alpine AS builder
+FROM golang:1.18-alpine AS builder
 
 ARG VERSION
 RUN apk add --update --no-cache git make

README.md

@@ -5,7 +5,6 @@
 [![Go Report Card](https://goreportcard.com/badge/github.com/pterodactyl/wings)](https://goreportcard.com/report/github.com/pterodactyl/wings)
 
 # Pterodactyl Wings
-
 Wings is Pterodactyl's server control plane, built for the rapidly changing gaming industry and designed to be
 highly performant and secure. Wings provides an HTTP API allowing you to interface directly with running server
 instances, fetch server logs, generate backups, and control all aspects of the server lifecycle.
@@ -14,29 +13,31 @@ In addition, Wings ships with a built-in SFTP server allowing your system to rem
 dependencies, and allowing users to authenticate with the same credentials they would normally use to access the Panel.
 
 ## Sponsors
-
+I would like to extend my sincere thanks to the following sponsors for helping find Pterodactyl's developement.
-I would like to extend my sincere thanks to the following sponsors for helping fund Pterodactyl's development.
 [Interested in becoming a sponsor?](https://github.com/sponsors/matthewpi)
 
-| Company                                                      | About                                                                                                                                                                                                                                           |
+| Company | About |
-|--------------------------------------------------------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
+| ------- | ----- |
-| [**Aussie Server Hosts**](https://aussieserverhosts.com/)    | No frills Australian Owned and operated High Performance Server hosting for some of the most demanding games serving Australia and New Zealand.                                                                                                                       |
+| [**WISP**](https://wisp.gg) | Extra features. |
-| [**CodeNode LLC**](https://codenode.gg/)                     | Looking for simplicity? Well, look no further! CodeNode has got you covered with everything you need at the rock-bottom price of $1.75 per GB, including dedicated IPs in Dallas, Texas, and Amsterdam, Netherlands. We're not just good, we're the best in the game! |
+| [**BisectHosting**](https://www.bisecthosting.com/) | BisectHosting provides Minecraft, Valheim and other server hosting services with the highest reliability and lightning fast support since 2012. |
-| [**BisectHosting**](https://www.bisecthosting.com/)          | BisectHosting provides Minecraft, Valheim and other server hosting services with the highest reliability and lightning fast support since 2012.                                                                                                                       |
+| [**Fragnet**](https://fragnet.net) | Providing low latency, high-end game hosting solutions to gamers, game studios and eSports platforms. |
-| [**MineStrator**](https://minestrator.com/)                  | Looking for the most highend French hosting company for your minecraft server? More than 24,000 members on our discord trust us. Give us a try!                                                                                                                       |
+| [**Tempest**](https://tempest.net/) | Tempest Hosting is a subsidiary of Path Network, Inc. offering unmetered DDoS protected 10Gbps dedicated servers, starting at just $80/month. Full anycast, tons of filters. |
-| [**HostEZ**](https://hostez.io)                              | US & EU Rust & Minecraft Hosting. DDoS Protected bare metal, VPS and colocation with low latency, high uptime and maximum availability. EZ!                                                                                                                           |
+| [**Bloom.host**](https://bloom.host) | Bloom.host offers dedicated core VPS and Minecraft hosting with Ryzen 9 processors. With owned-hardware, we offer truly unbeatable prices on high-performance hosting. |
-| [**Blueprint**](https://blueprint.zip/?pterodactyl=true)     | Create and install Pterodactyl addons and themes with the growing Blueprint framework - the package-manager for Pterodactyl. Use multiple modifications at once without worrying about conflicts and make use of the large extension ecosystem.                       |
+| [**MineStrator**](https://minestrator.com/) | Looking for the most highend French hosting company for your minecraft server? More than 24,000 members on our discord trust us. Give us a try! |
-| [**indifferent broccoli**](https://indifferentbroccoli.com/) | indifferent broccoli is a game server hosting and rental company. With us, you get top-notch computer power for your gaming sessions. We destroy lag, latency, and complexity--letting you focus on the fun stuff.                                                    |
+| [**Skynode**](https://www.skynode.pro/) | Skynode provides blazing fast game servers along with a top-notch user experience. Whatever our clients are looking for, we're able to provide it! |
+| [**DeinServerHost**](https://deinserverhost.de/) | DeinServerHost offers Dedicated, vps and Gameservers for many popular Games like Minecraft and Rust in Germany since 2013. |
+| [**Aussie Server Hosts**](https://aussieserverhosts.com/) | No frills Australian Owned and operated High Performance Server hosting for some of the most demanding games serving Australia and New Zealand. |
+| [**HostEZ**](https://hostez.io) | Providing North America Valheim, Minecraft and other popular games with low latency, high uptime and maximum availability. EZ! |
+| [**VibeGAMES**](https://vibegames.net/) | VibeGAMES is a game server provider that specializes in DDOS protection for the games we offer. We have multiple locations in the US, Brazil, France, Germany, Singapore, Australia and South Africa.|
+| [**Gamenodes**](https://gamenodes.nl) | Gamenodes love quality. For Minecraft, Discord Bots and other services, among others. With our own programmers, we provide just that little bit of extra service! |
 
 ## Documentation
-
 * [Panel Documentation](https://pterodactyl.io/panel/1.0/getting_started.html)
 * [Wings Documentation](https://pterodactyl.io/wings/1.0/installing.html)
 * [Community Guides](https://pterodactyl.io/community/about.html)
 * Or, get additional help [via Discord](https://discord.gg/pterodactyl)
 
 ## Reporting Issues
-
 Please use the [pterodactyl/panel](https://github.com/pterodactyl/panel) repository to report any issues or make
 feature requests for Wings. In addition, the [security policy](https://github.com/pterodactyl/panel/security/policy) listed
 within that repository also applies to Wings.

cmd/configure.go

@@ -155,9 +155,6 @@ func configureCmdRun(cmd *cobra.Command, args []string) {
 		panic(err)
 	}
 
-	// Manually specify the Panel URL as it won't be decoded from JSON.
-	cfg.PanelLocation = configureArgs.PanelURL
-
 	if err = config.WriteToDisk(cfg); err != nil {
 		panic(err)
 	}

cmd/diagnostics.go

@@ -229,8 +229,8 @@ func uploadToHastebin(hbUrl, content string) (string, error) {
 		return "", err
 	}
 	u.Path = path.Join(u.Path, "documents")
-	res, err := http.Post(u.String(), "text/plain", r)
+	res, err := http.Post(u.String(), "plain/text", r)
-	if err != nil || res.StatusCode < 200 || res.StatusCode >= 300 {
+	if err != nil || res.StatusCode != 200 {
 		fmt.Println("Failed to upload report to ", u.String(), err)
 		return "", err
 	}

cmd/root.go

@@ -13,6 +13,7 @@ import (
 	"path/filepath"
 	"runtime"
 	"strconv"
+	"strings"
 	"time"
 
 	"github.com/NYTimes/logrotate"
@@ -112,9 +113,6 @@ func rootCmdRun(cmd *cobra.Command, _ []string) {
 	if err := config.EnsurePterodactylUser(); err != nil {
 		log.WithField("error", err).Fatal("failed to create pterodactyl system user")
 	}
-	if err := config.ConfigurePasswd(); err != nil {
-		log.WithField("error", err).Fatal("failed to configure container passwd file")
-	}
 	log.WithFields(log.Fields{
 		"username": config.Get().System.Username,
 		"uid":      config.Get().System.User.Uid,
@@ -381,14 +379,13 @@ func rootCmdRun(cmd *cobra.Command, _ []string) {
 // Reads the configuration from the disk and then sets up the global singleton
 // with all the configuration values.
 func initConfig() {
-	if !filepath.IsAbs(configPath) {
+	if !strings.HasPrefix(configPath, "/") {
-		d, err := filepath.Abs(configPath)
+		d, err := os.Getwd()
 		if err != nil {
-			log2.Fatalf("cmd/root: failed to get path to config file: %s", err)
+			log2.Fatalf("cmd/root: could not determine directory: %s", err)
 		}
-		configPath = d
+		configPath = path.Clean(path.Join(d, configPath))
 	}
-
 	err := config.FromFile(configPath)
 	if err != nil {
 		if errors.Is(err, os.ErrNotExist) {
@@ -443,18 +440,18 @@ in all copies or substantial portions of the Software.%s`), system.Version, time
 }
 
 func exitWithConfigurationNotice() {
-	fmt.Printf(colorstring.Color(`
+	fmt.Print(colorstring.Color(`
 [_red_][white][bold]Error: Configuration File Not Found[reset]
 
 Wings was not able to locate your configuration file, and therefore is not
 able to complete its boot process. Please ensure you have copied your instance
 configuration file into the default location below.
 
-Default Location: %s
+Default Location: /etc/pterodactyl/config.yml
 
 [yellow]This is not a bug with this software. Please do not make a bug report
 for this issue, it will be closed.[reset]
 
-`), config.DefaultLocation)
+`))
 	os.Exit(1)
 }

config/config.go

@@ -12,7 +12,6 @@ import (
 	"regexp"
 	"strings"
 	"sync"
-	"sync/atomic"
 	"text/template"
 	"time"
 
@@ -21,7 +20,6 @@ import (
 	"github.com/apex/log"
 	"github.com/creasty/defaults"
 	"github.com/gbrlsnchs/jwt/v3"
-	"golang.org/x/sys/unix"
 	"gopkg.in/yaml.v2"
 
 	"github.com/pterodactyl/wings/system"
@@ -89,7 +87,7 @@ type ApiConfiguration struct {
 	// Determines if functionality for allowing remote download of files into server directories
 	// is enabled on this instance. If set to "true" remote downloads will not be possible for
 	// servers.
-	DisableRemoteDownload bool `json:"-" yaml:"disable_remote_download"`
+	DisableRemoteDownload bool `json:"disable_remote_download" yaml:"disable_remote_download"`
 
 	// The maximum size for files uploaded through the Panel in MB.
 	UploadLimit int64 `default:"100" json:"upload_limit" yaml:"upload_limit"`
@@ -123,23 +121,23 @@ type RemoteQueryConfiguration struct {
 // SystemConfiguration defines basic system configuration settings.
 type SystemConfiguration struct {
 	// The root directory where all of the pterodactyl data is stored at.
-	RootDirectory string `default:"/var/lib/pterodactyl" json:"-" yaml:"root_directory"`
+	RootDirectory string `default:"/var/lib/pterodactyl" yaml:"root_directory"`
 
 	// Directory where logs for server installations and other wings events are logged.
-	LogDirectory string `default:"/var/log/pterodactyl" json:"-" yaml:"log_directory"`
+	LogDirectory string `default:"/var/log/pterodactyl" yaml:"log_directory"`
 
 	// Directory where the server data is stored at.
-	Data string `default:"/var/lib/pterodactyl/volumes" json:"-" yaml:"data"`
+	Data string `default:"/var/lib/pterodactyl/volumes" yaml:"data"`
 
 	// Directory where server archives for transferring will be stored.
-	ArchiveDirectory string `default:"/var/lib/pterodactyl/archives" json:"-" yaml:"archive_directory"`
+	ArchiveDirectory string `default:"/var/lib/pterodactyl/archives" yaml:"archive_directory"`
 
 	// Directory where local backups will be stored on the machine.
-	BackupDirectory string `default:"/var/lib/pterodactyl/backups" json:"-" yaml:"backup_directory"`
+	BackupDirectory string `default:"/var/lib/pterodactyl/backups" yaml:"backup_directory"`
 
 	// TmpDirectory specifies where temporary files for Pterodactyl installation processes
 	// should be created. This supports environments running docker-in-docker.
-	TmpDirectory string `default:"/tmp/pterodactyl" json:"-" yaml:"tmp_directory"`
+	TmpDirectory string `default:"/tmp/pterodactyl" yaml:"tmp_directory"`
 
 	// The user that should own all of the server files, and be used for containers.
 	Username string `default:"pterodactyl" yaml:"username"`
@@ -172,25 +170,6 @@ type SystemConfiguration struct {
 		Gid int `yaml:"gid"`
 	} `yaml:"user"`
 
-	// Passwd controls the mounting of a generated passwd files into containers started by Wings.
-	Passwd struct {
-		// Enable controls whether generated passwd files should be mounted into containers.
-		//
-		// By default this option is disabled and Wings will not mount any additional passwd
-		// files into containers.
-		Enable bool `yaml:"enabled" default:"false"`
-
-		// Directory is the directory on disk where the generated files will be stored.
-		// This directory may be temporary as it will be re-created whenever Wings is started.
-		//
-		// This path **WILL** be both written to by Wings and mounted into containers created by
-		// Wings. If you are running Wings itself in a container, this path will need to be mounted
-		// into the Wings container as the exact path on the host, which should match the value
-		// specified here. If you are using SELinux, you will need to make sure this file has the
-		// correct SELinux context in order for containers to use it.
-		Directory string `yaml:"directory" default:"/run/wings/etc"`
-	} `yaml:"passwd"`
-
 	// The amount of time in seconds that can elapse before a server's disk space calculation is
 	// considered stale and a re-check should occur. DANGER: setting this value too low can seriously
 	// impact system performance and cause massive I/O bottlenecks and high CPU usage for the Wings
@@ -230,8 +209,6 @@ type SystemConfiguration struct {
 	Backups Backups `yaml:"backups"`
 
 	Transfers Transfers `yaml:"transfers"`
-
-	OpenatMode string `default:"auto" yaml:"openat_mode"`
 }
 
 type CrashDetection struct {
@@ -325,7 +302,7 @@ type Configuration struct {
 
 	// The location where the panel is running that this daemon should connect to
 	// to collect data and send events.
-	PanelLocation string                   `json:"-" yaml:"remote"`
+	PanelLocation string                   `json:"remote" yaml:"remote"`
 	RemoteQuery   RemoteQueryConfiguration `json:"remote_query" yaml:"remote_query"`
 
 	// AllowedMounts is a list of allowed host-system mount points.
@@ -342,9 +319,6 @@ type Configuration struct {
 	// is only required by users running Wings without SSL certificates and using internal IP
 	// addresses in order to connect. Most users should NOT enable this setting.
 	AllowCORSPrivateNetwork bool `json:"allow_cors_private_network" yaml:"allow_cors_private_network"`
-
-	// IgnorePanelConfigUpdates causes confiuration updates that are sent by the panel to be ignored.
-	IgnorePanelConfigUpdates bool `json:"ignore_panel_config_updates" yaml:"ignore_panel_config_updates"`
 }
 
 // NewAtPath creates a new struct and set the path where it should be stored.
@@ -516,37 +490,6 @@ func EnsurePterodactylUser() error {
 	return nil
 }
 
-// ConfigurePasswd generates required passwd files for use with containers started by Wings.
-func ConfigurePasswd() error {
-	passwd := _config.System.Passwd
-	if !passwd.Enable {
-		return nil
-	}
-
-	v := []byte(fmt.Sprintf(
-		`root:x:0:
-container:x:%d:
-nogroup:x:65534:`,
-		_config.System.User.Gid,
-	))
-	if err := os.WriteFile(filepath.Join(passwd.Directory, "group"), v, 0o644); err != nil {
-		return fmt.Errorf("failed to write file to %s/group: %v", passwd.Directory, err)
-	}
-
-	v = []byte(fmt.Sprintf(
-		`root:x:0:0::/root:/bin/sh
-container:x:%d:%d::/home/container:/bin/sh
-nobody:x:65534:65534::/var/empty:/bin/sh
-`,
-		_config.System.User.Uid,
-		_config.System.User.Gid,
-	))
-	if err := os.WriteFile(filepath.Join(passwd.Directory, "passwd"), v, 0o644); err != nil {
-		return fmt.Errorf("failed to write file to %s/passwd: %v", passwd.Directory, err)
-	}
-	return nil
-}
-
 // FromFile reads the configuration from the provided file and stores it in the
 // global singleton for this instance.
 func FromFile(path string) error {
@@ -611,13 +554,6 @@ func ConfigureDirectories() error {
 		return err
 	}
 
-	if _config.System.Passwd.Enable {
-		log.WithField("path", _config.System.Passwd.Directory).Debug("ensuring passwd directory exists")
-		if err := os.MkdirAll(_config.System.Passwd.Directory, 0o755); err != nil {
-			return err
-		}
-	}
-
 	return nil
 }
 
@@ -732,36 +668,3 @@ func getSystemName() (string, error) {
 	}
 	return release["ID"], nil
 }
-
-var (
-	openat2    atomic.Bool
-	openat2Set atomic.Bool
-)
-
-func UseOpenat2() bool {
-	if openat2Set.Load() {
-		return openat2.Load()
-	}
-	defer openat2Set.Store(true)
-
-	c := Get()
-	openatMode := c.System.OpenatMode
-	switch openatMode {
-	case "openat2":
-		openat2.Store(true)
-		return true
-	case "openat":
-		openat2.Store(false)
-		return false
-	default:
-		fd, err := unix.Openat2(unix.AT_FDCWD, "/", &unix.OpenHow{})
-		if err != nil {
-			log.WithError(err).Warn("error occurred while checking for openat2 support, falling back to openat")
-			openat2.Store(false)
-			return false
-		}
-		_ = unix.Close(fd)
-		openat2.Store(true)
-		return true
-	}
-}

config/config_docker.go

@@ -4,8 +4,8 @@ import (
 	"encoding/base64"
 	"sort"
 
+	"github.com/docker/docker/api/types"
 	"github.com/docker/docker/api/types/container"
-	"github.com/docker/docker/api/types/registry"
 	"github.com/goccy/go-json"
 )
 
@@ -115,7 +115,7 @@ type RegistryConfiguration struct {
 // Base64 returns the authentication for a given registry as a base64 encoded
 // string value.
 func (c RegistryConfiguration) Base64() (string, error) {
-	b, err := json.Marshal(registry.AuthConfig{
+	b, err := json.Marshal(types.AuthConfig{
 		Username: c.Username,
 		Password: c.Password,
 	})

environment/docker/container.go

@@ -58,7 +58,7 @@ func (e *Environment) Attach(ctx context.Context) error {
 
 	// Set the stream again with the container.
 	if st, err := e.client.ContainerAttach(ctx, e.Id, opts); err != nil {
-		return errors.WrapIf(err, "environment/docker: error while attaching to container")
+		return err
 	} else {
 		e.SetStream(&st)
 	}
@@ -143,7 +143,7 @@ func (e *Environment) Create() error {
 	if _, err := e.ContainerInspect(ctx); err == nil {
 		return nil
 	} else if !client.IsErrNotFound(err) {
-		return errors.WrapIf(err, "environment/docker: failed to inspect container")
+		return errors.Wrap(err, "environment/docker: failed to inspect container")
 	}
 
 	// Try to pull the requested image before creating the container.
@@ -196,7 +196,7 @@ func (e *Environment) Create() error {
 	networkMode := container.NetworkMode(cfg.Docker.Network.Mode)
 	if a.ForceOutgoingIP {
 		e.log().Debug("environment/docker: forcing outgoing IP address")
-		networkName := "ip-" + strings.ReplaceAll(strings.ReplaceAll(a.DefaultMapping.Ip, ".", "-"), ":", "-")
+		networkName := strings.ReplaceAll(e.Id, "-", "")
 		networkMode = container.NetworkMode(networkName)
 
 		if _, err := e.client.NetworkInspect(ctx, networkName, types.NetworkInspectOptions{}); err != nil {

environment/docker/environment.go

@@ -161,7 +161,7 @@ func (e *Environment) ExitState() (uint32, bool, error) {
 		if client.IsErrNotFound(err) {
 			return 1, false, nil
 		}
-		return 0, false, errors.WrapIf(err, "environment/docker: failed to inspect container")
+		return 0, false, err
 	}
 	return uint32(c.State.ExitCode), c.State.OOMKilled, nil
 }

environment/docker/power.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"os"
 	"strings"
+	"syscall"
 	"time"
 
 	"emperror.dev/errors"
@@ -102,7 +103,7 @@ func (e *Environment) Start(ctx context.Context) error {
 	// exists on the system, and rebuild the container if that is required for server booting to
 	// occur.
 	if err := e.OnBeforeStart(ctx); err != nil {
-		return errors.WrapIf(err, "environment/docker: failed to run pre-boot process")
+		return errors.WithStackIf(err)
 	}
 
 	// If we cannot start & attach to the container in 30 seconds something has gone
@@ -118,7 +119,7 @@ func (e *Environment) Start(ctx context.Context) error {
 	// By explicitly attaching to the instance before we start it, we can immediately
 	// react to errors/output stopping/etc. when starting.
 	if err := e.Attach(actx); err != nil {
-		return errors.WrapIf(err, "environment/docker: failed to attach to container")
+		return err
 	}
 
 	if err := e.client.ContainerStart(actx, e.Id, types.ContainerStartOptions{}); err != nil {
@@ -142,55 +143,44 @@ func (e *Environment) Stop(ctx context.Context) error {
 	s := e.meta.Stop
 	e.mu.RUnlock()
 
+	// A native "stop" as the Type field value will just skip over all of this
+	// logic and end up only executing the container stop command (which may or
+	// may not work as expected).
+	if s.Type == "" || s.Type == remote.ProcessStopSignal {
+		if s.Type == "" {
+			log.WithField("container_id", e.Id).Warn("no stop configuration detected for environment, using termination procedure")
+		}
+
+		signal := os.Kill
+		// Handle a few common cases, otherwise just fall through and just pass along
+		// the os.Kill signal to the process.
+		switch strings.ToUpper(s.Value) {
+		case "SIGABRT":
+			signal = syscall.SIGABRT
+		case "SIGINT":
+			signal = syscall.SIGINT
+		case "SIGTERM":
+			signal = syscall.SIGTERM
+		}
+		return e.Terminate(ctx, signal)
+	}
+
 	// If the process is already offline don't switch it back to stopping. Just leave it how
 	// it is and continue through to the stop handling for the process.
 	if e.st.Load() != environment.ProcessOfflineState {
 		e.SetState(environment.ProcessStoppingState)
 	}
 
-	// Handle signal based actions
-	if s.Type == remote.ProcessStopSignal {
-		log.WithField("signal_value", s.Value).Debug("stopping server using signal")
-
-		// Handle some common signals - Default to SIGKILL
-		signal := "SIGKILL"
-		switch strings.ToUpper(s.Value) {
-		case "SIGABRT":
-			signal = "SIGABRT"
-		case "SIGINT", "C":
-			signal = "SIGINT"
-		case "SIGTERM":
-			signal = "SIGTERM"
-		case "SIGKILL":
-			signal = "SIGKILL"
-		default:
-			log.Info("Unrecognised signal requested, defaulting to SIGKILL")
-		}
-
-		return e.SignalContainer(ctx, signal)
-
-	}
-
-	// Handle command based stops
 	// Only attempt to send the stop command to the instance if we are actually attached to
 	// the instance. If we are not for some reason, just send the container stop event.
 	if e.IsAttached() && s.Type == remote.ProcessStopCommand {
 		return e.SendCommand(s.Value)
 	}
 
-	if s.Type == "" {
+	// Allow the stop action to run for however long it takes, similar to executing a command
-		log.WithField("container_id", e.Id).Warn("no stop configuration detected for environment, using native docker stop")
+	// and using a different logic pathway to wait for the container to stop successfully.
-	}
+	t := time.Duration(-1)
-
+	if err := e.client.ContainerStop(ctx, e.Id, &t); err != nil {
-	// Fallback to a native docker stop. As we aren't passing a signal to ContainerStop docker will
-	// attempt to stop the container using the default stop signal, SIGTERM, unless
-	// another signal was specified in the Dockerfile
-	//
-	// Using a negative timeout here will allow the container to stop gracefully,
-	// rather than forcefully terminating it.  Value is in seconds, but -1 is
-	// treated as indefinitely.
-	timeout := -1
-	if err := e.client.ContainerStop(ctx, e.Id, container.StopOptions{Timeout: &timeout}); err != nil {
 		// If the container does not exist just mark the process as stopped and return without
 		// an error.
 		if client.IsErrNotFound(err) {
@@ -230,7 +220,7 @@ func (e *Environment) WaitForStop(ctx context.Context, duration time.Duration, t
 
 	doTermination := func(s string) error {
 		e.log().WithField("step", s).WithField("duration", duration).Warn("container stop did not complete in time, terminating process...")
-		return e.Terminate(ctx, "SIGKILL")
+		return e.Terminate(ctx, os.Kill)
 	}
 
 	// We pass through the timed context for this stop action so that if one of the
@@ -274,8 +264,8 @@ func (e *Environment) WaitForStop(ctx context.Context, duration time.Duration, t
 	return nil
 }
 
-// Sends the specified signal to the container in an attempt to stop it.
+// Terminate forcefully terminates the container using the signal provided.
-func (e *Environment) SignalContainer(ctx context.Context, signal string) error {
+func (e *Environment) Terminate(ctx context.Context, signal os.Signal) error {
 	c, err := e.ContainerInspect(ctx)
 	if err != nil {
 		// Treat missing containers as an okay error state, means it is obviously
@@ -300,27 +290,11 @@ func (e *Environment) SignalContainer(ctx context.Context, signal string) error
 
 	// We set it to stopping than offline to prevent crash detection from being triggered.
 	e.SetState(environment.ProcessStoppingState)
-	if err := e.client.ContainerKill(ctx, e.Id, signal); err != nil && !client.IsErrNotFound(err) {
+	sig := strings.TrimSuffix(strings.TrimPrefix(signal.String(), "signal "), "ed")
+	if err := e.client.ContainerKill(ctx, e.Id, sig); err != nil && !client.IsErrNotFound(err) {
 		return errors.WithStack(err)
 	}
-
-	return nil
-
-}
-
-// Terminate forcefully terminates the container using the signal provided.
-// then sets its state to stopped.
-func (e *Environment) Terminate(ctx context.Context, signal string) error {
-
-	// Send the signal to the container to kill it
-	if err := e.SignalContainer(ctx, signal); err != nil {
-		return errors.WithStack(err)
-	}
-
-	// We expect Terminate to instantly kill the container
-	// so go ahead and mark it as dead and clean up
 	e.SetState(environment.ProcessOfflineState)
 
 	return nil
-
 }

environment/environment.go

@@ -2,6 +2,7 @@ package environment
 
 import (
 	"context"
+	"os"
 	"time"
 
 	"github.com/pterodactyl/wings/events"
@@ -71,7 +72,7 @@ type ProcessEnvironment interface {
 
 	// Terminate stops a running server instance using the provided signal. This function
 	// is a no-op if the server is already stopped.
-	Terminate(ctx context.Context, signal string) error
+	Terminate(ctx context.Context, signal os.Signal) error
 
 	// Destroys the environment removing any containers that were created (in Docker
 	// environments at least).

environment/settings.go

@@ -34,7 +34,7 @@ type Mount struct {
 // Limits is the build settings for a given server that impact docker container
 // creation and resource limits for a server instance.
 type Limits struct {
-	// The total amount of memory in mebibytes that this server is allowed to
+	// The total amount of memory in megabytes that this server is allowed to
 	// use on the host system.
 	MemoryLimit int64 `json:"memory_limit"`
 
@@ -79,7 +79,7 @@ func (l Limits) MemoryOverheadMultiplier() float64 {
 }
 
 func (l Limits) BoundedMemoryLimit() int64 {
-	return int64(math.Round(float64(l.MemoryLimit) * l.MemoryOverheadMultiplier() * 1024 * 1024))
+	return int64(math.Round(float64(l.MemoryLimit) * l.MemoryOverheadMultiplier() * 1_000_000))
 }
 
 // ConvertedSwap returns the amount of swap available as a total in bytes. This
@@ -90,7 +90,7 @@ func (l Limits) ConvertedSwap() int64 {
 		return -1
 	}
 
-	return (l.Swap * 1024 * 1024) + l.BoundedMemoryLimit()
+	return (l.Swap * 1_000_000) + l.BoundedMemoryLimit()
 }
 
 // ProcessLimit returns the process limit for a container. This is currently
@@ -105,7 +105,7 @@ func (l Limits) AsContainerResources() container.Resources {
 	pids := l.ProcessLimit()
 	resources := container.Resources{
 		Memory:            l.BoundedMemoryLimit(),
-		MemoryReservation: l.MemoryLimit * 1024 * 1024,
+		MemoryReservation: l.MemoryLimit * 1_000_000,
 		MemorySwap:        l.ConvertedSwap(),
 		BlkioWeight:       l.IoWeight,
 		OomKillDisable:    &l.OOMDisabled,

flake.lock

@@ -1,79 +0,0 @@
-{
-  "nodes": {
-    "flake-parts": {
-      "inputs": {
-        "nixpkgs-lib": "nixpkgs-lib"
-      },
-      "locked": {
-        "lastModified": 1719994518,
-        "narHash": "sha256-pQMhCCHyQGRzdfAkdJ4cIWiw+JNuWsTX7f0ZYSyz0VY=",
-        "owner": "hercules-ci",
-        "repo": "flake-parts",
-        "rev": "9227223f6d922fee3c7b190b2cc238a99527bbb7",
-        "type": "github"
-      },
-      "original": {
-        "owner": "hercules-ci",
-        "repo": "flake-parts",
-        "type": "github"
-      }
-    },
-    "nixpkgs": {
-      "locked": {
-        "lastModified": 1721562059,
-        "narHash": "sha256-Tybxt65eyOARf285hMHIJ2uul8SULjFZbT9ZaEeUnP8=",
-        "owner": "NixOS",
-        "repo": "nixpkgs",
-        "rev": "68c9ed8bbed9dfce253cc91560bf9043297ef2fe",
-        "type": "github"
-      },
-      "original": {
-        "owner": "NixOS",
-        "ref": "nixos-unstable",
-        "repo": "nixpkgs",
-        "type": "github"
-      }
-    },
-    "nixpkgs-lib": {
-      "locked": {
-        "lastModified": 1719876945,
-        "narHash": "sha256-Fm2rDDs86sHy0/1jxTOKB1118Q0O3Uc7EC0iXvXKpbI=",
-        "type": "tarball",
-        "url": "https://github.com/NixOS/nixpkgs/archive/5daf0514482af3f97abaefc78a6606365c9108e2.tar.gz"
-      },
-      "original": {
-        "type": "tarball",
-        "url": "https://github.com/NixOS/nixpkgs/archive/5daf0514482af3f97abaefc78a6606365c9108e2.tar.gz"
-      }
-    },
-    "root": {
-      "inputs": {
-        "flake-parts": "flake-parts",
-        "nixpkgs": "nixpkgs",
-        "treefmt-nix": "treefmt-nix"
-      }
-    },
-    "treefmt-nix": {
-      "inputs": {
-        "nixpkgs": [
-          "nixpkgs"
-        ]
-      },
-      "locked": {
-        "lastModified": 1721769617,
-        "narHash": "sha256-6Pqa0bi5nV74IZcENKYRToRNM5obo1EQ+3ihtunJ014=",
-        "owner": "numtide",
-        "repo": "treefmt-nix",
-        "rev": "8db8970be1fb8be9c845af7ebec53b699fe7e009",
-        "type": "github"
-      },
-      "original": {
-        "owner": "numtide",
-        "repo": "treefmt-nix",
-        "type": "github"
-      }
-    }
-  },
-  "root": "root",
-  "version": 7
-}

flake.nix

@@ -1,54 +0,0 @@
-{
-  description = "Wings";
-
-  inputs = {
-    flake-parts.url = "github:hercules-ci/flake-parts";
-    nixpkgs.url = "github:NixOS/nixpkgs/nixos-unstable";
-
-    treefmt-nix = {
-      url = "github:numtide/treefmt-nix";
-      inputs.nixpkgs.follows = "nixpkgs";
-    };
-  };
-
-  outputs = {...} @ inputs:
-    inputs.flake-parts.lib.mkFlake {inherit inputs;} {
-      systems = ["aarch64-darwin" "aarch64-linux" "x86_64-darwin" "x86_64-linux"];
-
-      imports = [
-        inputs.treefmt-nix.flakeModule
-      ];
-
-      perSystem = {system, ...}: let
-        pkgs = import inputs.nixpkgs {inherit system;};
-      in {
-         devShells.default = pkgs.mkShell {
-          buildInputs = with pkgs; [
-            go_1_22
-            gofumpt
-            golangci-lint
-            gotools 
-          ];
-        };
-
-        treefmt = {
-          projectRootFile = "flake.nix";
-
-          programs = {
-            alejandra.enable = true;
-            deadnix.enable = true;
-            gofumpt = {
-              enable = true;
-              extra = true;
-            };
-            shellcheck.enable = true;
-            shfmt = {
-              enable = true;
-              indent_size = 0; # 0 causes shfmt to use tabs
-            };
-            yamlfmt.enable = true;
-          };
-        };
-      };
-    };
-}

go.mod

@@ -1,137 +1,124 @@
 module github.com/pterodactyl/wings
 
-go 1.21
+go 1.18
 
 require (
 	emperror.dev/errors v0.8.1
-	github.com/AlecAivazis/survey/v2 v2.3.7
+	github.com/AlecAivazis/survey/v2 v2.3.6
-	github.com/Jeffail/gabs/v2 v2.7.0
+	github.com/Jeffail/gabs/v2 v2.6.1
 	github.com/NYTimes/logrotate v1.0.0
 	github.com/acobaugh/osrelease v0.1.0
 	github.com/apex/log v1.9.0
-	github.com/asaskevich/govalidator v0.0.0-20230301143203-a9d515a09cc2
+	github.com/asaskevich/govalidator v0.0.0-20210307081110-f21760c49a8d
-	github.com/beevik/etree v1.3.0
+	github.com/beevik/etree v1.1.0
 	github.com/buger/jsonparser v1.1.1
-	github.com/cenkalti/backoff/v4 v4.3.0
+	github.com/cenkalti/backoff/v4 v4.1.3
-	github.com/creasty/defaults v1.7.0
+	github.com/creasty/defaults v1.6.0
-	github.com/docker/docker v25.0.4+incompatible
+	github.com/docker/docker v20.10.18+incompatible
-	github.com/docker/go-connections v0.5.0
+	github.com/docker/go-connections v0.4.0
-	github.com/fatih/color v1.16.0
+	github.com/fatih/color v1.13.0
-	github.com/franela/goblin v0.0.0-20211003143422-0a4f594942bf
+	github.com/franela/goblin v0.0.0-20200825194134-80c0062ed6cd
-	github.com/gabriel-vasile/mimetype v1.4.3
+	github.com/gabriel-vasile/mimetype v1.4.1
 	github.com/gammazero/workerpool v1.1.3
 	github.com/gbrlsnchs/jwt/v3 v3.0.1
-	github.com/gin-gonic/gin v1.9.1
+	github.com/gin-gonic/gin v1.8.1
-	github.com/glebarez/sqlite v1.11.0
+	github.com/glebarez/sqlite v1.4.8
-	github.com/go-co-op/gocron v1.37.0
+	github.com/go-co-op/gocron v1.17.0
-	github.com/goccy/go-json v0.10.2
+	github.com/goccy/go-json v0.9.11
-	github.com/google/uuid v1.6.0
+	github.com/google/uuid v1.3.0
-	github.com/gorilla/websocket v1.5.1
+	github.com/gorilla/websocket v1.5.0
-	github.com/iancoleman/strcase v0.3.0
+	github.com/iancoleman/strcase v0.2.0
-	github.com/icza/dyno v0.0.0-20230330125955-09f820a8d9c0
+	github.com/icza/dyno v0.0.0-20220812133438-f0b6f8a18845
 	github.com/juju/ratelimit v1.0.2
-	github.com/klauspost/compress v1.17.8
+	github.com/karrick/godirwalk v1.17.0
-	github.com/klauspost/pgzip v1.2.6
+	github.com/klauspost/compress v1.15.11
-	github.com/magiconair/properties v1.8.7
+	github.com/klauspost/pgzip v1.2.5
+	github.com/magiconair/properties v1.8.6
 	github.com/mattn/go-colorable v0.1.13
-	github.com/mholt/archiver/v4 v4.0.0-alpha.8
+	github.com/mholt/archiver/v4 v4.0.0-alpha.7
 	github.com/mitchellh/colorstring v0.0.0-20190213212951-d06e56a500db
 	github.com/patrickmn/go-cache v2.1.0+incompatible
-	github.com/pkg/sftp v1.13.6
+	github.com/pkg/sftp v1.13.5
 	github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06
-	github.com/spf13/cobra v1.8.0
+	github.com/spf13/cobra v1.5.0
-	github.com/stretchr/testify v1.9.0
+	github.com/stretchr/testify v1.8.0
-	golang.org/x/crypto v0.22.0
+	golang.org/x/crypto v0.0.0-20220926161630-eccd6366d1be
-	golang.org/x/sync v0.7.0
+	golang.org/x/sync v0.0.0-20220929204114-8fcdb60fdcc0
-	golang.org/x/sys v0.19.0
 	gopkg.in/ini.v1 v1.67.0
 	gopkg.in/yaml.v2 v2.4.0
 	gopkg.in/yaml.v3 v3.0.1
-	gorm.io/gorm v1.25.9
+	gorm.io/gorm v1.23.10
 )
 
 require (
-	github.com/Microsoft/go-winio v0.6.1 // indirect
+	github.com/Azure/go-ansiterm v0.0.0-20210617225240-d185dfc1b5a1 // indirect
-	github.com/Microsoft/hcsshim v0.12.2 // indirect
+	github.com/Microsoft/go-winio v0.6.0 // indirect
-	github.com/andybalholm/brotli v1.1.0 // indirect
+	github.com/Microsoft/hcsshim v0.9.4 // indirect
-	github.com/bodgit/plumbing v1.3.0 // indirect
+	github.com/andybalholm/brotli v1.0.4 // indirect
-	github.com/bodgit/sevenzip v1.5.1 // indirect
+	github.com/beorn7/perks v1.0.1 // indirect
-	github.com/bodgit/windows v1.0.1 // indirect
+	github.com/cespare/xxhash/v2 v2.1.2 // indirect
-	github.com/bytedance/sonic v1.11.3 // indirect
+	github.com/containerd/fifo v1.0.0 // indirect
-	github.com/chenzhuoyu/base64x v0.0.0-20230717121745-296ad89f973d // indirect
-	github.com/chenzhuoyu/iasm v0.9.1 // indirect
-	github.com/containerd/log v0.1.0 // indirect
 	github.com/davecgh/go-spew v1.1.1 // indirect
-	github.com/distribution/reference v0.6.0 // indirect
+	github.com/docker/distribution v2.8.1+incompatible // indirect
+	github.com/docker/go-metrics v0.0.1 // indirect
 	github.com/docker/go-units v0.5.0 // indirect
 	github.com/dsnet/compress v0.0.2-0.20210315054119-f66993602bf5 // indirect
-	github.com/dustin/go-humanize v1.0.1 // indirect
+	github.com/fsnotify/fsnotify v1.5.4 // indirect
-	github.com/felixge/httpsnoop v1.0.4 // indirect
+	github.com/gammazero/deque v0.2.0 // indirect
-	github.com/gammazero/deque v0.2.1 // indirect
 	github.com/gin-contrib/sse v0.1.0 // indirect
-	github.com/glebarez/go-sqlite v1.22.0 // indirect
+	github.com/glebarez/go-sqlite v1.19.1 // indirect
-	github.com/go-logr/logr v1.4.1 // indirect
+	github.com/go-playground/locales v0.14.0 // indirect
-	github.com/go-logr/stdr v1.2.2 // indirect
+	github.com/go-playground/universal-translator v0.18.0 // indirect
-	github.com/go-playground/locales v0.14.1 // indirect
+	github.com/go-playground/validator/v10 v10.11.1 // indirect
-	github.com/go-playground/universal-translator v0.18.1 // indirect
-	github.com/go-playground/validator/v10 v10.19.0 // indirect
 	github.com/gogo/protobuf v1.3.2 // indirect
+	github.com/golang/protobuf v1.5.2 // indirect
 	github.com/golang/snappy v0.0.4 // indirect
-	github.com/hashicorp/errwrap v1.1.0 // indirect
+	github.com/inconshreveable/mousetrap v1.0.1 // indirect
-	github.com/hashicorp/go-multierror v1.1.1 // indirect
-	github.com/hashicorp/golang-lru/v2 v2.0.7 // indirect
-	github.com/inconshreveable/mousetrap v1.1.0 // indirect
 	github.com/jinzhu/inflection v1.0.0 // indirect
 	github.com/jinzhu/now v1.1.5 // indirect
 	github.com/json-iterator/go v1.1.12 // indirect
 	github.com/kballard/go-shellquote v0.0.0-20180428030007-95032a82bc51 // indirect
-	github.com/klauspost/cpuid/v2 v2.2.7 // indirect
 	github.com/kr/fs v0.1.0 // indirect
-	github.com/leodido/go-urn v1.4.0 // indirect
+	github.com/leodido/go-urn v1.2.1 // indirect
-	github.com/magefile/mage v1.15.0 // indirect
+	github.com/magefile/mage v1.14.0 // indirect
-	github.com/mattn/go-isatty v0.0.20 // indirect
+	github.com/mattn/go-isatty v0.0.16 // indirect
+	github.com/matttproud/golang_protobuf_extensions v1.0.2 // indirect
 	github.com/mgutz/ansi v0.0.0-20200706080929-d51e80ef957d // indirect
 	github.com/moby/term v0.0.0-20220808134915-39b0c02b01ae // indirect
 	github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
 	github.com/modern-go/reflect2 v1.0.2 // indirect
 	github.com/morikuni/aec v1.0.0 // indirect
-	github.com/ncruces/go-strftime v0.1.9 // indirect
 	github.com/nwaples/rardecode/v2 v2.0.0-beta.2 // indirect
 	github.com/opencontainers/go-digest v1.0.0 // indirect
-	github.com/opencontainers/image-spec v1.1.0 // indirect
+	github.com/opencontainers/image-spec v1.1.0-rc2 // indirect
-	github.com/pelletier/go-toml/v2 v2.2.0 // indirect
+	github.com/pelletier/go-toml/v2 v2.0.5 // indirect
-	github.com/pierrec/lz4/v4 v4.1.21 // indirect
+	github.com/pierrec/lz4/v4 v4.1.17 // indirect
 	github.com/pkg/errors v0.9.1 // indirect
 	github.com/pmezard/go-difflib v1.0.0 // indirect
-	github.com/remyoudompheng/bigfft v0.0.0-20230129092748-24d4a6f8daec // indirect
+	github.com/prometheus/client_golang v1.13.0 // indirect
+	github.com/prometheus/client_model v0.2.0 // indirect
+	github.com/prometheus/common v0.37.0 // indirect
+	github.com/prometheus/procfs v0.8.0 // indirect
+	github.com/remyoudompheng/bigfft v0.0.0-20220927061507-ef77025ab5aa // indirect
 	github.com/robfig/cron/v3 v3.0.1 // indirect
-	github.com/sirupsen/logrus v1.9.3 // indirect
+	github.com/sirupsen/logrus v1.9.0 // indirect
 	github.com/spf13/pflag v1.0.5 // indirect
 	github.com/therootcompany/xz v1.0.1 // indirect
-	github.com/twitchyliquid64/golang-asm v0.15.1 // indirect
+	github.com/ugorji/go/codec v1.2.7 // indirect
-	github.com/ugorji/go/codec v1.2.12 // indirect
+	github.com/ulikunitz/xz v0.5.10 // indirect
-	github.com/ulikunitz/xz v0.5.12 // indirect
+	go.uber.org/atomic v1.10.0 // indirect
-	go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.50.0 // indirect
+	go.uber.org/multierr v1.8.0 // indirect
-	go.opentelemetry.io/otel v1.25.0 // indirect
+	golang.org/x/mod v0.6.0-dev.0.20220419223038-86c51ed26bb4 // indirect
-	go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp v1.24.0 // indirect
+	golang.org/x/net v0.0.0-20221004154528-8021a29435af // indirect
-	go.opentelemetry.io/otel/metric v1.25.0 // indirect
+	golang.org/x/sys v0.0.0-20220928140112-f11e5e49a4ec // indirect
-	go.opentelemetry.io/otel/sdk v1.24.0 // indirect
+	golang.org/x/term v0.0.0-20220919170432-7a66f970e087 // indirect
-	go.opentelemetry.io/otel/trace v1.25.0 // indirect
+	golang.org/x/text v0.3.7 // indirect
-	go.uber.org/atomic v1.11.0 // indirect
-	go.uber.org/multierr v1.11.0 // indirect
-	go4.org v0.0.0-20230225012048-214862532bf5 // indirect
-	golang.org/x/arch v0.7.0 // indirect
-	golang.org/x/mod v0.17.0 // indirect
-	golang.org/x/net v0.24.0 // indirect
-	golang.org/x/term v0.19.0 // indirect
-	golang.org/x/text v0.14.0 // indirect
 	golang.org/x/time v0.0.0-20220922220347-f3bd1da661af // indirect
-	golang.org/x/tools v0.20.0 // indirect
+	golang.org/x/tools v0.1.12 // indirect
-	golang.org/x/xerrors v0.0.0-20231012003039-104605ab7028 // indirect
+	golang.org/x/xerrors v0.0.0-20220907171357-04be3eba64a2 // indirect
-	google.golang.org/protobuf v1.33.0 // indirect
+	google.golang.org/protobuf v1.28.1 // indirect
-	gotest.tools/v3 v3.0.2 // indirect
+	modernc.org/libc v1.20.0 // indirect
-	modernc.org/libc v1.49.3 // indirect
+	modernc.org/mathutil v1.5.0 // indirect
-	modernc.org/mathutil v1.6.0 // indirect
+	modernc.org/memory v1.4.0 // indirect
-	modernc.org/memory v1.8.0 // indirect
+	modernc.org/sqlite v1.19.1 // indirect
-	modernc.org/sqlite v1.29.6 // indirect
 )

internal/cron/activity_cron.go

@@ -2,7 +2,6 @@ package cron
 
 import (
 	"context"
-	"net"
 
 	"emperror.dev/errors"
 
@@ -18,9 +17,9 @@ type activityCron struct {
 	max     int
 }
 
-// Run executes the cronjob and ensures we fetch and send all the stored activity to the
+// Run executes the cronjob and ensures we fetch and send all of the stored activity to the
 // Panel instance. Once activity is sent it is deleted from the local database instance. Any
-// SFTP specific events are not handled in this cron, they're handled separately to account
+// SFTP specific events are not handled in this cron, they're handled seperately to account
 // for de-duplication and event merging.
 func (ac *activityCron) Run(ctx context.Context) error {
 	// Don't execute this cron if there is currently one running. Once this task is completed
@@ -35,6 +34,7 @@ func (ac *activityCron) Run(ctx context.Context) error {
 		Where("event NOT LIKE ?", "server:sftp.%").
 		Limit(ac.max).
 		Find(&activity)
+
 	if tx.Error != nil {
 		return errors.WithStack(tx.Error)
 	}
@@ -42,42 +42,15 @@ func (ac *activityCron) Run(ctx context.Context) error {
 		return nil
 	}
 
-	// ids to delete from the database.
+	if err := ac.manager.Client().SendActivityLogs(ctx, activity); err != nil {
-	ids := make([]int, 0, len(activity))
-	// activities to send to the panel.
-	activities := make([]models.Activity, 0, len(activity))
-	for _, v := range activity {
-		// Delete any activity that has an invalid IP address. This is a fix for
-		// a bug that truncated the last octet of an IPv6 address in the database.
-		if ip := net.ParseIP(v.IP); ip == nil {
-			ids = append(ids, v.ID)
-			continue
-		}
-		activities = append(activities, v)
-	}
-
-	if len(ids) > 0 {
-		tx = database.Instance().WithContext(ctx).Where("id IN ?", ids).Delete(&models.Activity{})
-		if tx.Error != nil {
-			return errors.WithStack(tx.Error)
-		}
-	}
-
-	if len(activities) == 0 {
-		return nil
-	}
-
-	if err := ac.manager.Client().SendActivityLogs(ctx, activities); err != nil {
 		return errors.WrapIf(err, "cron: failed to send activity events to Panel")
 	}
 
-	// Add all the successful activities to the list of IDs to delete.
+	var ids []int
-	ids = make([]int, len(activities))
+	for _, v := range activity {
-	for i, v := range activities {
+		ids = append(ids, v.ID)
-		ids[i] = v.ID
 	}
 
-	// Delete all the activities that were sent to the Panel (or that were invalid).
 	tx = database.Instance().WithContext(ctx).Where("id IN ?", ids).Delete(&models.Activity{})
 	if tx.Error != nil {
 		return errors.WithStack(tx.Error)

internal/models/activity.go

@@ -1,11 +1,11 @@
 package models
 
 import (
-	"net"
-	"strings"
 	"time"
 
 	"gorm.io/gorm"
+
+	"github.com/pterodactyl/wings/system"
 )
 
 type Event string
@@ -57,9 +57,7 @@ func (a Activity) SetUser(u string) *Activity {
 // is trimmed down to remove any extraneous data, and the timestamp is set to the current
 // system time and then stored as UTC.
 func (a *Activity) BeforeCreate(_ *gorm.DB) error {
-	if ip, _, err := net.SplitHostPort(strings.TrimSpace(a.IP)); err == nil {
+	a.IP = system.TrimIPSuffix(a.IP)
-		a.IP = ip
-	}
 	if a.Timestamp.IsZero() {
 		a.Timestamp = time.Now()
 	}

internal/ufs/LICENSE

@@ -1,21 +0,0 @@
-MIT License
-
-Copyright (c) 2024 Matthew Penner
-
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all
-copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.

internal/ufs/README.md

@@ -1,17 +0,0 @@
-# Filesystem
-
-## Licensing
-
-Most code in this package is licensed under `MIT` with some exceptions.
-
-The following files are licensed under `BSD-3-Clause` due to them being copied
-verbatim or derived from [Go](https://go.dev)'s source code.
-
-- [`file_posix.go`](./file_posix.go)
-- [`mkdir_unix.go`](./mkdir_unix.go)
-- [`path_unix.go`](./path_unix.go)
-- [`removeall_unix.go`](./removeall_unix.go)
-- [`stat_unix.go`](./stat_unix.go) 
-- [`walk.go`](./walk.go)
-
-These changes are not associated with nor endorsed by The Go Authors.

internal/ufs/doc.go

@@ -1,12 +0,0 @@
-// SPDX-License-Identifier: MIT
-// SPDX-FileCopyrightText: Copyright (c) 2024 Matthew Penner
-
-// Package ufs provides an abstraction layer for performing I/O on filesystems.
-// This package is designed to be used in-place of standard `os` package I/O
-// calls, and is not designed to be used as a generic filesystem abstraction
-// like the `io/fs` package.
-//
-// The primary use-case of this package was to provide a "chroot-like" `os`
-// wrapper, so we can safely sandbox I/O operations within a directory and
-// use untrusted arbitrary paths.
-package ufs

internal/ufs/error.go

@@ -1,120 +0,0 @@
-// SPDX-License-Identifier: MIT
-// SPDX-FileCopyrightText: Copyright (c) 2024 Matthew Penner
-
-package ufs
-
-import (
-	"errors"
-	iofs "io/fs"
-	"os"
-
-	"golang.org/x/sys/unix"
-)
-
-var (
-	// ErrIsDirectory is an error for when an operation that operates only on
-	// files is given a path to a directory.
-	ErrIsDirectory = errors.New("is a directory")
-	// ErrNotDirectory is an error for when an operation that operates only on
-	// directories is given a path to a file.
-	ErrNotDirectory = errors.New("not a directory")
-	// ErrBadPathResolution is an error for when a sand-boxed filesystem
-	// resolves a given path to a forbidden location.
-	ErrBadPathResolution = errors.New("bad path resolution")
-	// ErrNotRegular is an error for when an operation that operates only on
-	// regular files is passed something other than a regular file.
-	ErrNotRegular = errors.New("not a regular file")
-
-	// ErrClosed is an error for when an entry was accessed after being closed.
-	ErrClosed = iofs.ErrClosed
-	// ErrInvalid is an error for when an invalid argument was used.
-	ErrInvalid = iofs.ErrInvalid
-	// ErrExist is an error for when an entry already exists.
-	ErrExist = iofs.ErrExist
-	// ErrNotExist is an error for when an entry does not exist.
-	ErrNotExist = iofs.ErrNotExist
-	// ErrPermission is an error for when the required permissions to perform an
-	// operation are missing.
-	ErrPermission = iofs.ErrPermission
-)
-
-// LinkError records an error during a link or symlink or rename
-// system call and the paths that caused it.
-type LinkError = os.LinkError
-
-// PathError records an error and the operation and file path that caused it.
-type PathError = iofs.PathError
-
-// SyscallError records an error from a specific system call.
-type SyscallError = os.SyscallError
-
-// NewSyscallError returns, as an error, a new SyscallError
-// with the given system call name and error details.
-// As a convenience, if err is nil, NewSyscallError returns nil.
-func NewSyscallError(syscall string, err error) error {
-	return os.NewSyscallError(syscall, err)
-}
-
-// convertErrorType converts errors into our custom errors to ensure consistent
-// error values.
-func convertErrorType(err error) error {
-	if err == nil {
-		return nil
-	}
-	var pErr *PathError
-	switch {
-	case errors.As(err, &pErr):
-		switch {
-		// File exists
-		case errors.Is(pErr.Err, unix.EEXIST):
-			return &PathError{
-				Op:   pErr.Op,
-				Path: pErr.Path,
-				Err:  ErrExist,
-			}
-		// Is a directory
-		case errors.Is(pErr.Err, unix.EISDIR):
-			return &PathError{
-				Op:   pErr.Op,
-				Path: pErr.Path,
-				Err:  ErrIsDirectory,
-			}
-		// Not a directory
-		case errors.Is(pErr.Err, unix.ENOTDIR):
-			return &PathError{
-				Op:   pErr.Op,
-				Path: pErr.Path,
-				Err:  ErrNotDirectory,
-			}
-		// No such file or directory
-		case errors.Is(pErr.Err, unix.ENOENT):
-			return &PathError{
-				Op:   pErr.Op,
-				Path: pErr.Path,
-				Err:  ErrNotExist,
-			}
-		// Operation not permitted
-		case errors.Is(pErr.Err, unix.EPERM):
-			return &PathError{
-				Op:   pErr.Op,
-				Path: pErr.Path,
-				Err:  ErrPermission,
-			}
-		// Invalid cross-device link
-		case errors.Is(pErr.Err, unix.EXDEV):
-			return &PathError{
-				Op:   pErr.Op,
-				Path: pErr.Path,
-				Err:  ErrBadPathResolution,
-			}
-		// Too many levels of symbolic links
-		case errors.Is(pErr.Err, unix.ELOOP):
-			return &PathError{
-				Op:   pErr.Op,
-				Path: pErr.Path,
-				Err:  ErrBadPathResolution,
-			}
-		}
-	}
-	return err
-}

internal/ufs/file.go

@@ -1,179 +0,0 @@
-// SPDX-License-Identifier: MIT
-// SPDX-FileCopyrightText: Copyright (c) 2024 Matthew Penner
-
-package ufs
-
-import (
-	"io"
-	iofs "io/fs"
-
-	"golang.org/x/sys/unix"
-)
-
-// DirEntry is an entry read from a directory.
-type DirEntry = iofs.DirEntry
-
-// File describes readable and/or writable file from a Filesystem.
-type File interface {
-	// Name returns the base name of the file.
-	Name() string
-
-	// Stat returns the FileInfo structure describing the file.
-	// If there is an error, it will be of type *PathError.
-	Stat() (FileInfo, error)
-
-	// ReadDir reads the contents of the directory associated with the file f
-	// and returns a slice of DirEntry values in directory order.
-	// Subsequent calls on the same file will yield later DirEntry records in the directory.
-	//
-	// If n > 0, ReadDir returns at most n DirEntry records.
-	// In this case, if ReadDir returns an empty slice, it will return an error explaining why.
-	// At the end of a directory, the error is io.EOF.
-	//
-	// If n <= 0, ReadDir returns all the DirEntry records remaining in the directory.
-	// When it succeeds, it returns a nil error (not io.EOF).
-	ReadDir(n int) ([]DirEntry, error)
-
-	// Readdirnames reads the contents of the directory associated with file
-	// and returns a slice of up to n names of files in the directory,
-	// in directory order. Subsequent calls on the same file will yield
-	// further names.
-	//
-	// If n > 0, Readdirnames returns at most n names. In this case, if
-	// Readdirnames returns an empty slice, it will return a non-nil error
-	// explaining why. At the end of a directory, the error is io.EOF.
-	//
-	// If n <= 0, Readdirnames returns all the names from the directory in
-	// a single slice. In this case, if Readdirnames succeeds (reads all
-	// the way to the end of the directory), it returns the slice and a
-	// nil error. If it encounters an error before the end of the
-	// directory, Readdirnames returns the names read until that point and
-	// a non-nil error.
-	Readdirnames(n int) (names []string, err error)
-
-	// Fd returns the integer Unix file descriptor referencing the open file.
-	// If f is closed, the file descriptor becomes invalid.
-	// If f is garbage collected, a finalizer may close the file descriptor,
-	// making it invalid; see runtime.SetFinalizer for more information on when
-	// a finalizer might be run. On Unix systems this will cause the SetDeadline
-	// methods to stop working.
-	// Because file descriptors can be reused, the returned file descriptor may
-	// only be closed through the Close method of f, or by its finalizer during
-	// garbage collection. Otherwise, during garbage collection the finalizer
-	// may close an unrelated file descriptor with the same (reused) number.
-	//
-	// As an alternative, see the f.SyscallConn method.
-	Fd() uintptr
-
-	// Truncate changes the size of the file.
-	// It does not change the I/O offset.
-	// If there is an error, it will be of type *PathError.
-	Truncate(size int64) error
-
-	io.Closer
-
-	io.Reader
-	io.ReaderAt
-	io.ReaderFrom
-
-	io.Writer
-	io.WriterAt
-
-	io.Seeker
-}
-
-// FileInfo describes a file and is returned by Stat and Lstat.
-type FileInfo = iofs.FileInfo
-
-// FileMode represents a file's mode and permission bits.
-// The bits have the same definition on all systems, so that
-// information about files can be moved from one system
-// to another portably. Not all bits apply to all systems.
-// The only required bit is ModeDir for directories.
-type FileMode = iofs.FileMode
-
-// The defined file mode bits are the most significant bits of the FileMode.
-// The nine least-significant bits are the standard Unix rwxrwxrwx permissions.
-// The values of these bits should be considered part of the public API and
-// may be used in wire protocols or disk representations: they must not be
-// changed, although new bits might be added.
-const (
-	// ModeDir represents a directory.
-	// d: is a directory
-	ModeDir = iofs.ModeDir
-	// ModeAppend represents an append-only file.
-	// a: append-only
-	ModeAppend = iofs.ModeAppend
-	// ModeExclusive represents an exclusive file.
-	// l: exclusive use
-	ModeExclusive = iofs.ModeExclusive
-	// ModeTemporary .
-	// T: temporary file; Plan 9 only.
-	ModeTemporary = iofs.ModeTemporary
-	// ModeSymlink .
-	// L: symbolic link.
-	ModeSymlink = iofs.ModeSymlink
-	// ModeDevice .
-	// D: device file.
-	ModeDevice = iofs.ModeDevice
-	// ModeNamedPipe .
-	// p: named pipe (FIFO)
-	ModeNamedPipe = iofs.ModeNamedPipe
-	// ModeSocket .
-	// S: Unix domain socket.
-	ModeSocket = iofs.ModeSocket
-	// ModeSetuid .
-	// u: setuid
-	ModeSetuid = iofs.ModeSetuid
-	// ModeSetgid .
-	// g: setgid
-	ModeSetgid = iofs.ModeSetgid
-	// ModeCharDevice .
-	// c: Unix character device, when ModeDevice is set
-	ModeCharDevice = iofs.ModeCharDevice
-	// ModeSticky .
-	// t: sticky
-	ModeSticky = iofs.ModeSticky
-	// ModeIrregular .
-	// ?: non-regular file; nothing else is known about this file.
-	ModeIrregular = iofs.ModeIrregular
-
-	// ModeType .
-	ModeType = iofs.ModeType
-
-	// ModePerm .
-	// Unix permission bits, 0o777.
-	ModePerm = iofs.ModePerm
-)
-
-const (
-	// O_RDONLY opens the file read-only.
-	O_RDONLY = unix.O_RDONLY
-	// O_WRONLY opens the file write-only.
-	O_WRONLY = unix.O_WRONLY
-	// O_RDWR opens the file read-write.
-	O_RDWR = unix.O_RDWR
-	// O_APPEND appends data to the file when writing.
-	O_APPEND = unix.O_APPEND
-	// O_CREATE creates a new file if it doesn't exist.
-	O_CREATE = unix.O_CREAT
-	// O_EXCL is used with O_CREATE, file must not exist.
-	O_EXCL = unix.O_EXCL
-	// O_SYNC open for synchronous I/O.
-	O_SYNC = unix.O_SYNC
-	// O_TRUNC truncates regular writable file when opened.
-	O_TRUNC = unix.O_TRUNC
-	// O_DIRECTORY opens a directory only. If the entry is not a directory an
-	// error will be returned.
-	O_DIRECTORY = unix.O_DIRECTORY
-	// O_NOFOLLOW opens the exact path given without following symlinks.
-	O_NOFOLLOW  = unix.O_NOFOLLOW
-	O_CLOEXEC   = unix.O_CLOEXEC
-	O_LARGEFILE = unix.O_LARGEFILE
-)
-
-const (
-	AT_SYMLINK_NOFOLLOW = unix.AT_SYMLINK_NOFOLLOW
-	AT_REMOVEDIR        = unix.AT_REMOVEDIR
-	AT_EMPTY_PATH       = unix.AT_EMPTY_PATH
-)

internal/ufs/file_posix.go

@@ -1,49 +0,0 @@
-// SPDX-License-Identifier: BSD-3-Clause
-
-// Code in this file was copied from `go/src/os/file_posix.go`.
-
-// Copyright 2009 The Go Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style
-// license that can be found in the `go.LICENSE` file.
-
-//go:build unix || (js && wasm) || wasip1 || windows
-
-package ufs
-
-import (
-	"golang.org/x/sys/unix"
-)
-
-// ignoringEINTR makes a function call and repeats it if it returns an
-// EINTR error. This appears to be required even though we install all
-// signal handlers with SA_RESTART: see https://go.dev/issue/22838,
-// https://go.dev/issue/38033, https://go.dev/issue/38836,
-// https://go.dev/issue/40846. Also, https://go.dev/issue/20400 and
-// https://go.dev/issue/36644 are issues in which a signal handler is
-// installed without setting SA_RESTART. None of these are the common case,
-// but there are enough of them that it seems that we can't avoid
-// an EINTR loop.
-func ignoringEINTR(fn func() error) error {
-	for {
-		err := fn()
-		if err != unix.EINTR {
-			return err
-		}
-	}
-}
-
-// syscallMode returns the syscall-specific mode bits from Go's portable mode bits.
-func syscallMode(i FileMode) (o FileMode) {
-	o |= i.Perm()
-	if i&ModeSetuid != 0 {
-		o |= unix.S_ISUID
-	}
-	if i&ModeSetgid != 0 {
-		o |= unix.S_ISGID
-	}
-	if i&ModeSticky != 0 {
-		o |= unix.S_ISVTX
-	}
-	// No mapping for Go's ModeTemporary (plan9 only).
-	return
-}

internal/ufs/filesystem.go

@@ -1,168 +0,0 @@
-// SPDX-License-Identifier: MIT
-// SPDX-FileCopyrightText: Copyright (c) 2024 Matthew Penner
-
-package ufs
-
-import (
-	"time"
-)
-
-// Filesystem represents a filesystem capable of performing I/O operations.
-type Filesystem interface {
-	// Chmod changes the mode of the named file to mode.
-	//
-	// If the file is a symbolic link, it changes the mode of the link's target.
-	// If there is an error, it will be of type *PathError.
-	//
-	// A different subset of the mode bits are used, depending on the
-	// operating system.
-	//
-	// On Unix, the mode's permission bits, ModeSetuid, ModeSetgid, and
-	// ModeSticky are used.
-	//
-	// On Windows, only the 0200 bit (owner writable) of mode is used; it
-	// controls whether the file's read-only attribute is set or cleared.
-	// The other bits are currently unused. For compatibility with Go 1.12
-	// and earlier, use a non-zero mode. Use mode 0400 for a read-only
-	// file and 0600 for a readable+writable file.
-	//
-	// On Plan 9, the mode's permission bits, ModeAppend, ModeExclusive,
-	// and ModeTemporary are used.
-	Chmod(name string, mode FileMode) error
-
-	// Chown changes the numeric uid and gid of the named file.
-	//
-	// If the file is a symbolic link, it changes the uid and gid of the link's target.
-	// A uid or gid of -1 means to not change that value.
-	// If there is an error, it will be of type *PathError.
-	//
-	// On Windows or Plan 9, Chown always returns the syscall.EWINDOWS or
-	// EPLAN9 error, wrapped in *PathError.
-	Chown(name string, uid, gid int) error
-
-	// Lchown changes the numeric uid and gid of the named file.
-	//
-	// If the file is a symbolic link, it changes the uid and gid of the link itself.
-	// If there is an error, it will be of type *PathError.
-	//
-	// On Windows, it always returns the syscall.EWINDOWS error, wrapped
-	// in *PathError.
-	Lchown(name string, uid, gid int) error
-
-	// Chtimes changes the access and modification times of the named
-	// file, similar to the Unix utime() or utimes() functions.
-	//
-	// The underlying filesystem may truncate or round the values to a
-	// less precise time unit.
-	//
-	// If there is an error, it will be of type *PathError.
-	Chtimes(name string, atime, mtime time.Time) error
-
-	// Create creates or truncates the named file. If the file already exists,
-	// it is truncated.
-	//
-	// If the file does not exist, it is created with mode 0666
-	// (before umask). If successful, methods on the returned File can
-	// be used for I/O; the associated file descriptor has mode O_RDWR.
-	// If there is an error, it will be of type *PathError.
-	Create(name string) (File, error)
-
-	// Mkdir creates a new directory with the specified name and permission
-	// bits (before umask).
-	//
-	// If there is an error, it will be of type *PathError.
-	Mkdir(name string, perm FileMode) error
-
-	// MkdirAll creates a directory named path, along with any necessary
-	// parents, and returns nil, or else returns an error.
-	//
-	// The permission bits perm (before umask) are used for all
-	// directories that MkdirAll creates.
-	// If path is already a directory, MkdirAll does nothing
-	// and returns nil.
-	MkdirAll(path string, perm FileMode) error
-
-	// Open opens the named file for reading.
-	//
-	// If successful, methods on the returned file can be used for reading; the
-	// associated file descriptor has mode O_RDONLY.
-	//
-	// If there is an error, it will be of type *PathError.
-	Open(name string) (File, error)
-
-	// OpenFile is the generalized open call; most users will use Open
-	// or Create instead. It opens the named file with specified flag
-	// (O_RDONLY etc.).
-	//
-	// If the file does not exist, and the O_CREATE flag
-	// is passed, it is created with mode perm (before umask). If successful,
-	// methods on the returned File can be used for I/O.
-	//
-	// If there is an error, it will be of type *PathError.
-	OpenFile(name string, flag int, perm FileMode) (File, error)
-
-	// ReadDir reads the named directory,
-	//
-	// returning all its directory entries sorted by filename.
-	// If an error occurs reading the directory, ReadDir returns the entries it
-	// was able to read before the error, along with the error.
-	ReadDir(name string) ([]DirEntry, error)
-
-	// Remove removes the named file or (empty) directory.
-	//
-	// If there is an error, it will be of type *PathError.
-	Remove(name string) error
-
-	// RemoveAll removes path and any children it contains.
-	//
-	// It removes everything it can but returns the first error
-	// it encounters. If the path does not exist, RemoveAll
-	// returns nil (no error).
-	//
-	// If there is an error, it will be of type *PathError.
-	RemoveAll(path string) error
-
-	// Rename renames (moves) oldpath to newpath.
-	//
-	// If newpath already exists and is not a directory, Rename replaces it.
-	// OS-specific restrictions may apply when oldpath and newpath are in different directories.
-	// Even within the same directory, on non-Unix platforms Rename is not an atomic operation.
-	//
-	// If there is an error, it will be of type *LinkError.
-	Rename(oldname, newname string) error
-
-	// Stat returns a FileInfo describing the named file.
-	//
-	// If there is an error, it will be of type *PathError.
-	Stat(name string) (FileInfo, error)
-
-	// Lstat returns a FileInfo describing the named file.
-	//
-	// If the file is a symbolic link, the returned FileInfo
-	// describes the symbolic link. Lstat makes no attempt to follow the link.
-	//
-	// If there is an error, it will be of type *PathError.
-	Lstat(name string) (FileInfo, error)
-
-	// Symlink creates newname as a symbolic link to oldname.
-	//
-	// On Windows, a symlink to a non-existent oldname creates a file symlink;
-	// if oldname is later created as a directory the symlink will not work.
-	//
-	// If there is an error, it will be of type *LinkError.
-	Symlink(oldname, newname string) error
-
-	// WalkDir walks the file tree rooted at root, calling fn for each file or
-	// directory in the tree, including root.
-	//
-	// All errors that arise visiting files and directories are filtered by fn:
-	// see the [WalkDirFunc] documentation for details.
-	//
-	// The files are walked in lexical order, which makes the output deterministic
-	// but requires WalkDir to read an entire directory into memory before proceeding
-	// to walk that directory.
-	//
-	// WalkDir does not follow symbolic links found in directories,
-	// but if root itself is a symbolic link, its target will be walked.
-	WalkDir(root string, fn WalkDirFunc) error
-}

internal/ufs/fs_quota.go

@@ -1,159 +0,0 @@
-// SPDX-License-Identifier: MIT
-// SPDX-FileCopyrightText: Copyright (c) 2024 Matthew Penner
-
-package ufs
-
-import (
-	"sync/atomic"
-)
-
-type Quota struct {
-	// fs is the underlying filesystem that runs the actual I/O operations.
-	*UnixFS
-
-	// limit is the size limit of the filesystem.
-	//
-	// limit is atomic to allow the limit to be safely changed after the
-	// filesystem was created.
-	//
-	// A limit of `-1` disables any write operation from being performed.
-	// A limit of `0` disables any limit checking.
-	limit atomic.Int64
-
-	// usage is the current usage of the filesystem.
-	//
-	// If usage is set to `-1`, it hasn't been calculated yet.
-	usage atomic.Int64
-}
-
-func NewQuota(fs *UnixFS, limit int64) *Quota {
-	qfs := Quota{UnixFS: fs}
-	qfs.limit.Store(limit)
-	return &qfs
-}
-
-// Close closes the filesystem.
-func (fs *Quota) Close() (err error) {
-	err = fs.UnixFS.Close()
-	return
-}
-
-// Limit returns the limit of the filesystem.
-func (fs *Quota) Limit() int64 {
-	return fs.limit.Load()
-}
-
-// SetLimit returns the limit of the filesystem.
-func (fs *Quota) SetLimit(newLimit int64) int64 {
-	return fs.limit.Swap(newLimit)
-}
-
-// Usage returns the current usage of the filesystem.
-func (fs *Quota) Usage() int64 {
-	return fs.usage.Load()
-}
-
-// SetUsage updates the total usage of the filesystem.
-func (fs *Quota) SetUsage(newUsage int64) int64 {
-	return fs.usage.Swap(newUsage)
-}
-
-// Add adds `i` to the tracked usage total.
-func (fs *Quota) Add(i int64) int64 {
-	usage := fs.Usage()
-
-	// If adding `i` to the usage will put us below 0, cap it. (`i` can be negative)
-	if usage+i < 0 {
-		fs.usage.Store(0)
-		return 0
-	}
-	return fs.usage.Add(i)
-}
-
-// CanFit checks if the given size can fit in the filesystem without exceeding
-// the limit of the filesystem.
-func (fs *Quota) CanFit(size int64) bool {
-	// Get the size limit of the filesystem.
-	limit := fs.Limit()
-	switch limit {
-	case -1:
-		// A limit of -1 means no write operations are allowed.
-		return false
-	case 0:
-		// A limit of 0 means unlimited.
-		return true
-	}
-
-	// Any other limit is a value we need to check.
-	usage := fs.Usage()
-	if usage == -1 {
-		// We don't know what the current usage is yet.
-		return true
-	}
-
-	// If the current usage + the requested size are under the limit of the
-	// filesystem, allow it.
-	if usage+size <= limit {
-		return true
-	}
-
-	// Welp, the size would exceed the limit of the filesystem, deny it.
-	return false
-}
-
-func (fs *Quota) Remove(name string) error {
-	// For information on why this interface is used here, check its
-	// documentation.
-	s, err := fs.RemoveStat(name)
-	if err != nil {
-		return err
-	}
-
-	// Don't reduce the quota's usage as `name` is not a regular file.
-	if !s.Mode().IsRegular() {
-		return nil
-	}
-
-	// Remove the size of the deleted file from the quota usage.
-	fs.Add(-s.Size())
-	return nil
-}
-
-// RemoveAll removes path and any children it contains.
-//
-// It removes everything it can but returns the first error
-// it encounters. If the path does not exist, RemoveAll
-// returns nil (no error).
-//
-// If there is an error, it will be of type *PathError.
-func (fs *Quota) RemoveAll(name string) error {
-	name, err := fs.unsafePath(name)
-	if err != nil {
-		return err
-	}
-	// While removeAll internally checks this, I want to make sure we check it
-	// and return the proper error so our tests can ensure that this will never
-	// be a possibility.
-	if name == "." {
-		return &PathError{
-			Op:   "removeall",
-			Path: name,
-			Err:  ErrBadPathResolution,
-		}
-	}
-	return fs.removeAll(name)
-}
-
-func (fs *Quota) removeAll(path string) error {
-	return removeAll(fs, path)
-}
-
-func (fs *Quota) unlinkat(dirfd int, name string, flags int) error {
-	if flags == 0 {
-		s, err := fs.Lstatat(dirfd, name)
-		if err == nil && s.Mode().IsRegular() {
-			fs.Add(-s.Size())
-		}
-	}
-	return fs.UnixFS.unlinkat(dirfd, name, flags)
-}

internal/ufs/fs_unix.go

@@ -1,825 +0,0 @@
-// SPDX-License-Identifier: MIT
-// SPDX-FileCopyrightText: Copyright (c) 2024 Matthew Penner
-
-//go:build unix
-
-package ufs
-
-import (
-	"errors"
-	"fmt"
-	"os"
-	"path/filepath"
-	"strconv"
-	"strings"
-	"sync/atomic"
-	"time"
-
-	"golang.org/x/sys/unix"
-)
-
-// UnixFS is a filesystem that uses the unix package to make io calls.
-//
-// This is used for proper sand-boxing and full control over the exact syscalls
-// being performed.
-type UnixFS struct {
-	// basePath is the base path for file operations to take place in.
-	basePath string
-
-	// dirfd holds the file descriptor of BasePath and is used to ensure
-	// operations are restricted into descendants of BasePath.
-	dirfd atomic.Int64
-
-	// useOpenat2 controls whether the `openat2` syscall is used instead of the
-	// older `openat` syscall.
-	useOpenat2 bool
-}
-
-// NewUnixFS creates a new sandboxed unix filesystem. BasePath is used as the
-// sandbox path, operations on BasePath itself are not allowed, but any
-// operations on its descendants are. Symlinks pointing outside BasePath are
-// checked and prevented from enabling an escape in a non-raceable manor.
-func NewUnixFS(basePath string, useOpenat2 bool) (*UnixFS, error) {
-	basePath = strings.TrimSuffix(basePath, "/")
-	// We don't need Openat2, if we are given a basePath that is already unsafe
-	// I give up on trying to sandbox it.
-	dirfd, err := unix.Openat(AT_EMPTY_PATH, basePath, O_DIRECTORY|O_RDONLY, 0)
-	if err != nil {
-		return nil, convertErrorType(err)
-	}
-
-	fs := &UnixFS{
-		basePath:   basePath,
-		useOpenat2: useOpenat2,
-	}
-	fs.dirfd.Store(int64(dirfd))
-	return fs, nil
-}
-
-// BasePath returns the base path of the UnixFS sandbox, file operations
-// pointing outside this path are prohibited and will be blocked by all
-// operations implemented by UnixFS.
-func (fs *UnixFS) BasePath() string {
-	return fs.basePath
-}
-
-// Close releases the file descriptor used to sandbox operations within the
-// base path of the filesystem.
-func (fs *UnixFS) Close() error {
-	// Once closed, change dirfd to something invalid to detect when it has been
-	// closed.
-	defer func() {
-		fs.dirfd.Store(-1)
-	}()
-	return unix.Close(int(fs.dirfd.Load()))
-}
-
-// Chmod changes the mode of the named file to mode.
-//
-// If the file is a symbolic link, it changes the mode of the link's target.
-// If there is an error, it will be of type *PathError.
-//
-// A different subset of the mode bits are used, depending on the
-// operating system.
-//
-// On Unix, the mode's permission bits, ModeSetuid, ModeSetgid, and
-// ModeSticky are used.
-//
-// On Windows, only the 0200 bit (owner writable) of mode is used; it
-// controls whether the file's read-only attribute is set or cleared.
-// The other bits are currently unused. For compatibility with Go 1.12
-// and earlier, use a non-zero mode. Use mode 0400 for a read-only
-// file and 0600 for a readable+writable file.
-//
-// On Plan 9, the mode's permission bits, ModeAppend, ModeExclusive,
-// and ModeTemporary are used.
-func (fs *UnixFS) Chmod(name string, mode FileMode) error {
-	dirfd, name, closeFd, err := fs.safePath(name)
-	defer closeFd()
-	if err != nil {
-		return err
-	}
-	return convertErrorType(unix.Fchmodat(dirfd, name, uint32(mode), 0))
-}
-
-// Chown changes the numeric uid and gid of the named file.
-//
-// If the file is a symbolic link, it changes the uid and gid of the link's target.
-// A uid or gid of -1 means to not change that value.
-// If there is an error, it will be of type *PathError.
-//
-// On Windows or Plan 9, Chown always returns the syscall.EWINDOWS or
-// EPLAN9 error, wrapped in *PathError.
-func (fs *UnixFS) Chown(name string, uid, gid int) error {
-	return fs.fchown(name, uid, gid, 0)
-}
-
-// Lchown changes the numeric uid and gid of the named file.
-//
-// If the file is a symbolic link, it changes the uid and gid of the link itself.
-// If there is an error, it will be of type *PathError.
-//
-// On Windows, it always returns the syscall.EWINDOWS error, wrapped
-// in *PathError.
-func (fs *UnixFS) Lchown(name string, uid, gid int) error {
-	// With AT_SYMLINK_NOFOLLOW, Fchownat acts like Lchown but allows us to
-	// pass a dirfd.
-	return fs.fchown(name, uid, gid, AT_SYMLINK_NOFOLLOW)
-}
-
-// fchown is a re-usable Fchownat syscall used by Chown and Lchown.
-func (fs *UnixFS) fchown(name string, uid, gid, flags int) error {
-	dirfd, name, closeFd, err := fs.safePath(name)
-	defer closeFd()
-	if err != nil {
-		return err
-	}
-	return convertErrorType(unix.Fchownat(dirfd, name, uid, gid, flags))
-}
-
-// Chownat is like Chown but allows passing an existing directory file
-// descriptor rather than needing to resolve one.
-func (fs *UnixFS) Chownat(dirfd int, name string, uid, gid int) error {
-	return convertErrorType(unix.Fchownat(dirfd, name, uid, gid, 0))
-}
-
-// Lchownat is like Lchown but allows passing an existing directory file
-// descriptor rather than needing to resolve one.
-func (fs *UnixFS) Lchownat(dirfd int, name string, uid, gid int) error {
-	return convertErrorType(unix.Fchownat(dirfd, name, uid, gid, AT_SYMLINK_NOFOLLOW))
-}
-
-// Chtimes changes the access and modification times of the named
-// file, similar to the Unix utime() or utimes() functions.
-//
-// The underlying filesystem may truncate or round the values to a
-// less precise time unit.
-//
-// If there is an error, it will be of type *PathError.
-func (fs *UnixFS) Chtimes(name string, atime, mtime time.Time) error {
-	dirfd, name, closeFd, err := fs.safePath(name)
-	defer closeFd()
-	if err != nil {
-		return err
-	}
-	return fs.Chtimesat(dirfd, name, atime, mtime)
-}
-
-// Chtimesat is like Chtimes but allows passing an existing directory file
-// descriptor rather than needing to resolve one.
-func (fs *UnixFS) Chtimesat(dirfd int, name string, atime, mtime time.Time) error {
-	var utimes [2]unix.Timespec
-	set := func(i int, t time.Time) {
-		if t.IsZero() {
-			utimes[i] = unix.Timespec{Sec: unix.UTIME_OMIT, Nsec: unix.UTIME_OMIT}
-		} else {
-			utimes[i] = unix.NsecToTimespec(t.UnixNano())
-		}
-	}
-	set(0, atime)
-	set(1, mtime)
-	// This does support `AT_SYMLINK_NOFOLLOW` as well if needed.
-	if err := unix.UtimesNanoAt(dirfd, name, utimes[0:], 0); err != nil {
-		return convertErrorType(&PathError{Op: "chtimes", Path: name, Err: err})
-	}
-	return nil
-}
-
-// Create creates or truncates the named file. If the file already exists,
-// it is truncated.
-//
-// If the file does not exist, it is created with mode 0666
-// (before umask). If successful, methods on the returned File can
-// be used for I/O; the associated file descriptor has mode O_RDWR.
-// If there is an error, it will be of type *PathError.
-func (fs *UnixFS) Create(name string) (File, error) {
-	return fs.OpenFile(name, O_CREATE|O_WRONLY|O_TRUNC, 0o644)
-}
-
-// Mkdir creates a new directory with the specified name and permission
-// bits (before umask).
-//
-// If there is an error, it will be of type *PathError.
-func (fs *UnixFS) Mkdir(name string, mode FileMode) error {
-	dirfd, name, closeFd, err := fs.safePath(name)
-	defer closeFd()
-	if err != nil {
-		return err
-	}
-	return fs.Mkdirat(dirfd, name, mode)
-}
-
-func (fs *UnixFS) Mkdirat(dirfd int, name string, mode FileMode) error {
-	return convertErrorType(unix.Mkdirat(dirfd, name, uint32(mode)))
-}
-
-// MkdirAll creates a directory named path, along with any necessary
-// parents, and returns nil, or else returns an error.
-//
-// The permission bits perm (before umask) are used for all
-// directories that MkdirAll creates.
-// If path is already a directory, MkdirAll does nothing
-// and returns nil.
-func (fs *UnixFS) MkdirAll(name string, mode FileMode) error {
-	// Ensure name is somewhat clean before continuing.
-	name, err := fs.unsafePath(name)
-	if err != nil {
-		return err
-	}
-	return fs.mkdirAll(name, mode)
-}
-
-// Open opens the named file for reading.
-//
-// If successful, methods on the returned file can be used for reading; the
-// associated file descriptor has mode O_RDONLY.
-//
-// If there is an error, it will be of type *PathError.
-func (fs *UnixFS) Open(name string) (File, error) {
-	return fs.OpenFile(name, O_RDONLY, 0)
-}
-
-// OpenFile is the generalized open call; most users will use Open
-// or Create instead. It opens the named file with specified flag
-// (O_RDONLY etc.).
-//
-// If the file does not exist, and the O_CREATE flag
-// is passed, it is created with mode perm (before umask). If successful,
-// methods on the returned File can be used for I/O.
-//
-// If there is an error, it will be of type *PathError.
-func (fs *UnixFS) OpenFile(name string, flag int, mode FileMode) (File, error) {
-	fd, err := fs.openFile(name, flag, mode)
-	if err != nil {
-		return nil, err
-	}
-	// Do not close `fd` here, it is passed to a file that needs the fd, the
-	// caller of this function is responsible for calling Close() on the File
-	// to release the file descriptor.
-	return os.NewFile(uintptr(fd), name), nil
-}
-
-func (fs *UnixFS) openFile(name string, flag int, mode FileMode) (int, error) {
-	dirfd, name, closeFd, err := fs.safePath(name)
-	defer closeFd()
-	if err != nil {
-		return 0, err
-	}
-	return fs.openat(dirfd, name, flag, mode)
-}
-
-func (fs *UnixFS) OpenFileat(dirfd int, name string, flag int, mode FileMode) (File, error) {
-	fd, err := fs.openat(dirfd, name, flag, mode)
-	if err != nil {
-		return nil, err
-	}
-	// Do not close `fd` here, it is passed to a file that needs the fd, the
-	// caller of this function is responsible for calling Close() on the File
-	// to release the file descriptor.
-	return os.NewFile(uintptr(fd), name), nil
-}
-
-// ReadDir reads the named directory,
-//
-// returning all its directory entries sorted by filename.
-// If an error occurs reading the directory, ReadDir returns the entries it
-// was able to read before the error, along with the error.
-func (fs *UnixFS) ReadDir(path string) ([]DirEntry, error) {
-	dirfd, name, closeFd, err := fs.safePath(path)
-	defer closeFd()
-	if err != nil {
-		return nil, err
-	}
-	fd, err := fs.openat(dirfd, name, O_DIRECTORY|O_RDONLY, 0)
-	if err != nil {
-		return nil, err
-	}
-	defer unix.Close(fd)
-	return fs.readDir(fd, name, nil)
-}
-
-// RemoveStat is a combination of Stat and Remove, it is used to more
-// efficiently remove a file when the caller needs to stat it before
-// removing it.
-//
-// This optimized function exists for our QuotaFS abstraction, which needs
-// to track writes to a filesystem. When removing a file, the QuotaFS needs
-// to know if the entry is a file and if so, how large it is. Because we
-// need to Stat a file in order to get its mode and size, we will already
-// know if the entry needs to be removed by using Unlink or Rmdir. The
-// standard `Remove` method just tries both Unlink and Rmdir (in that order)
-// as it ends up usually being faster and more efficient than calling Stat +
-// the proper operation in the first place.
-func (fs *UnixFS) RemoveStat(name string) (FileInfo, error) {
-	dirfd, name, closeFd, err := fs.safePath(name)
-	defer closeFd()
-	if err != nil {
-		return nil, err
-	}
-
-	// Lstat name, we use Lstat as Unlink doesn't care about symlinks.
-	s, err := fs.Lstatat(dirfd, name)
-	if err != nil {
-		return nil, err
-	}
-
-	if s.IsDir() {
-		err = fs.unlinkat(dirfd, name, AT_REMOVEDIR) // Rmdir
-	} else {
-		err = fs.unlinkat(dirfd, name, 0)
-	}
-	if err != nil {
-		return s, convertErrorType(&PathError{Op: "remove", Path: name, Err: err})
-	}
-	return s, nil
-}
-
-// Remove removes the named file or (empty) directory.
-//
-// If there is an error, it will be of type *PathError.
-func (fs *UnixFS) Remove(name string) error {
-	dirfd, name, closeFd, err := fs.safePath(name)
-	defer closeFd()
-	if err != nil {
-		return err
-	}
-
-	// Prevent trying to Remove the base directory.
-	if name == "." {
-		return &PathError{
-			Op:   "remove",
-			Path: name,
-			Err:  ErrBadPathResolution,
-		}
-	}
-
-	// System call interface forces us to know
-	// whether name is a file or directory.
-	// Try both: it is cheaper on average than
-	// doing a Stat plus the right one.
-	err = fs.unlinkat(dirfd, name, 0)
-	if err == nil {
-		return nil
-	}
-	err1 := fs.unlinkat(dirfd, name, AT_REMOVEDIR) // Rmdir
-	if err1 == nil {
-		return nil
-	}
-
-	// Both failed: figure out which error to return.
-	// OS X and Linux differ on whether unlink(dir)
-	// returns EISDIR, so can't use that. However,
-	// both agree that rmdir(file) returns ENOTDIR,
-	// so we can use that to decide which error is real.
-	// Rmdir might also return ENOTDIR if given a bad
-	// file path, like /etc/passwd/foo, but in that case,
-	// both errors will be ENOTDIR, so it's okay to
-	// use the error from unlink.
-	if err1 != unix.ENOTDIR {
-		err = err1
-	}
-	return convertErrorType(&PathError{Op: "remove", Path: name, Err: err})
-}
-
-// RemoveAll removes path and any children it contains.
-//
-// It removes everything it can but returns the first error
-// it encounters. If the path does not exist, RemoveAll
-// returns nil (no error).
-//
-// If there is an error, it will be of type *PathError.
-func (fs *UnixFS) RemoveAll(name string) error {
-	name, err := fs.unsafePath(name)
-	if err != nil {
-		return err
-	}
-	// While removeAll internally checks this, I want to make sure we check it
-	// and return the proper error so our tests can ensure that this will never
-	// be a possibility.
-	if name == "." {
-		return &PathError{
-			Op:   "removeall",
-			Path: name,
-			Err:  ErrBadPathResolution,
-		}
-	}
-	return fs.removeAll(name)
-}
-
-func (fs *UnixFS) unlinkat(dirfd int, name string, flags int) error {
-	return ignoringEINTR(func() error {
-		return unix.Unlinkat(dirfd, name, flags)
-	})
-}
-
-// Rename renames (moves) oldpath to newpath.
-//
-// If newpath already exists and is not a directory, Rename replaces it.
-// OS-specific restrictions may apply when oldpath and newpath are in different directories.
-// Even within the same directory, on non-Unix platforms Rename is not an atomic operation.
-//
-// If there is an error, it will be of type *LinkError.
-func (fs *UnixFS) Rename(oldpath, newpath string) error {
-	// Simple case: both paths are the same.
-	if oldpath == newpath {
-		return nil
-	}
-
-	olddirfd, oldname, closeFd, err := fs.safePath(oldpath)
-	defer closeFd()
-	if err != nil {
-		return err
-	}
-	// Ensure that we are not trying to rename the base directory itself.
-	// While unix.Renameat ends up throwing a "device or resource busy" error,
-	// that doesn't mean we are protecting the system properly.
-	if oldname == "." {
-		return convertErrorType(&PathError{
-			Op:   "rename",
-			Path: oldname,
-			Err:  ErrBadPathResolution,
-		})
-	}
-	// Stat the old target to return proper errors.
-	if _, err := fs.Lstatat(olddirfd, oldname); err != nil {
-		return err
-	}
-
-	newdirfd, newname, closeFd2, err := fs.safePath(newpath)
-	if err != nil {
-		closeFd2()
-		if !errors.Is(err, ErrNotExist) {
-			return convertErrorType(err)
-		}
-		var pathErr *PathError
-		if !errors.As(err, &pathErr) {
-			return convertErrorType(err)
-		}
-		if err := fs.MkdirAll(pathErr.Path, 0o755); err != nil {
-			return err
-		}
-		newdirfd, newname, closeFd2, err = fs.safePath(newpath)
-		defer closeFd2()
-		if err != nil {
-			return err
-		}
-	} else {
-		defer closeFd2()
-	}
-
-	// Ensure that we are not trying to rename the base directory itself.
-	// While unix.Renameat ends up throwing a "device or resource busy" error,
-	// that doesn't mean we are protecting the system properly.
-	if newname == "." {
-		return convertErrorType(&PathError{
-			Op:   "rename",
-			Path: newname,
-			Err:  ErrBadPathResolution,
-		})
-	}
-	// Stat the new target to return proper errors.
-	_, err = fs.Lstatat(newdirfd, newname)
-	switch {
-	case err == nil:
-		return convertErrorType(&PathError{
-			Op:   "rename",
-			Path: newname,
-			Err:  ErrExist,
-		})
-	case !errors.Is(err, ErrNotExist):
-		return err
-	}
-	return unix.Renameat(olddirfd, oldname, newdirfd, newname)
-}
-
-// Stat returns a FileInfo describing the named file.
-//
-// If there is an error, it will be of type *PathError.
-func (fs *UnixFS) Stat(name string) (FileInfo, error) {
-	return fs.fstat(name, 0)
-}
-
-// Statat is like Stat but allows passing an existing directory file
-// descriptor rather than needing to resolve one.
-func (fs *UnixFS) Statat(dirfd int, name string) (FileInfo, error) {
-	return fs.fstatat(dirfd, name, 0)
-}
-
-// Lstat returns a FileInfo describing the named file.
-//
-// If the file is a symbolic link, the returned FileInfo
-// describes the symbolic link. Lstat makes no attempt to follow the link.
-//
-// If there is an error, it will be of type *PathError.
-func (fs *UnixFS) Lstat(name string) (FileInfo, error) {
-	return fs.fstat(name, AT_SYMLINK_NOFOLLOW)
-}
-
-// Lstatat is like Lstat but allows passing an existing directory file
-// descriptor rather than needing to resolve one.
-func (fs *UnixFS) Lstatat(dirfd int, name string) (FileInfo, error) {
-	return fs.fstatat(dirfd, name, AT_SYMLINK_NOFOLLOW)
-}
-
-func (fs *UnixFS) fstat(name string, flags int) (FileInfo, error) {
-	dirfd, name, closeFd, err := fs.safePath(name)
-	defer closeFd()
-	if err != nil {
-		return nil, err
-	}
-	return fs.fstatat(dirfd, name, flags)
-}
-
-func (fs *UnixFS) fstatat(dirfd int, name string, flags int) (FileInfo, error) {
-	var s fileStat
-	if err := ignoringEINTR(func() error {
-		return unix.Fstatat(dirfd, name, &s.sys, flags)
-	}); err != nil {
-		return nil, &PathError{Op: "stat", Path: name, Err: err}
-	}
-	fillFileStatFromSys(&s, name)
-	return &s, nil
-}
-
-// Symlink creates newname as a symbolic link to oldname.
-//
-// On Windows, a symlink to a non-existent oldname creates a file symlink;
-// if oldname is later created as a directory the symlink will not work.
-//
-// If there is an error, it will be of type *LinkError.
-func (fs *UnixFS) Symlink(oldpath, newpath string) error {
-	dirfd, newpath, closeFd, err := fs.safePath(newpath)
-	defer closeFd()
-	if err != nil {
-		return err
-	}
-	if err := ignoringEINTR(func() error {
-		// We aren't concerned with oldpath here as a symlink can point anywhere
-		// it wants.
-		return unix.Symlinkat(oldpath, dirfd, newpath)
-	}); err != nil {
-		return &LinkError{Op: "symlink", Old: oldpath, New: newpath, Err: err}
-	}
-	return nil
-}
-
-// Touch will attempt to open a file for reading and/or writing. If the file
-// does not exist it will be created, and any missing parent directories will
-// also be created. The opened file may be truncated, only if `flag` has
-// O_TRUNC set.
-func (fs *UnixFS) Touch(path string, flag int, mode FileMode) (File, error) {
-	if flag&O_CREATE == 0 {
-		flag |= O_CREATE
-	}
-	dirfd, name, closeFd, err := fs.safePath(path)
-	defer closeFd()
-	if err == nil {
-		return fs.OpenFileat(dirfd, name, flag, mode)
-	}
-	if !errors.Is(err, ErrNotExist) {
-		return nil, err
-	}
-	var pathErr *PathError
-	if !errors.As(err, &pathErr) {
-		return nil, err
-	}
-	if err := fs.MkdirAll(pathErr.Path, 0o755); err != nil {
-		return nil, err
-	}
-	// Try to open the file one more time after creating its parent directories.
-	return fs.OpenFile(path, flag, mode)
-}
-
-// WalkDir walks the file tree rooted at root, calling fn for each file or
-// directory in the tree, including root.
-//
-// All errors that arise visiting files and directories are filtered by fn:
-// see the [WalkDirFunc] documentation for details.
-//
-// The files are walked in lexical order, which makes the output deterministic
-// but requires WalkDir to read an entire directory into memory before proceeding
-// to walk that directory.
-//
-// WalkDir does not follow symbolic links found in directories,
-// but if root itself is a symbolic link, its target will be walked.
-func (fs *UnixFS) WalkDir(root string, fn WalkDirFunc) error {
-	return WalkDir(fs, root, fn)
-}
-
-// openat is a wrapper around both unix.Openat and unix.Openat2. If the UnixFS
-// was configured to enable openat2 support, unix.Openat2 will be used instead
-// of unix.Openat due to having better security properties for our use-case.
-func (fs *UnixFS) openat(dirfd int, name string, flag int, mode FileMode) (int, error) {
-	if flag&O_NOFOLLOW == 0 {
-		flag |= O_NOFOLLOW
-	}
-
-	var fd int
-	for {
-		var err error
-		if fs.useOpenat2 {
-			fd, err = fs._openat2(dirfd, name, uint64(flag), uint64(syscallMode(mode)))
-		} else {
-			fd, err = fs._openat(dirfd, name, flag, uint32(syscallMode(mode)))
-		}
-		if err == nil {
-			break
-		}
-		// We have to check EINTR here, per issues https://go.dev/issue/11180 and https://go.dev/issue/39237.
-		if err == unix.EINTR {
-			continue
-		}
-		return 0, convertErrorType(err)
-	}
-
-	// If we are not using openat2, do additional path checking. This assumes
-	// that openat2 is using `RESOLVE_BENEATH` to avoid the same security
-	// issue.
-	if !fs.useOpenat2 {
-		var finalPath string
-		finalPath, err := filepath.EvalSymlinks(filepath.Join("/proc/self/fd/", strconv.Itoa(dirfd)))
-		if err != nil {
-			return fd, convertErrorType(err)
-		}
-		if err != nil {
-			if !errors.Is(err, ErrNotExist) {
-				return fd, fmt.Errorf("failed to evaluate symlink: %w", convertErrorType(err))
-			}
-
-			// The target of one of the symlinks (EvalSymlinks is recursive)
-			// does not exist. So get the path that does not exist and use
-			// that for further validation instead.
-			var pErr *PathError
-			if ok := errors.As(err, &pErr); !ok {
-				return fd, fmt.Errorf("failed to evaluate symlink: %w", convertErrorType(err))
-			}
-			finalPath = pErr.Path
-		}
-
-		// Check if the path is within our root.
-		if !fs.unsafeIsPathInsideOfBase(finalPath) {
-			return fd, convertErrorType(&PathError{
-				Op:   "openat",
-				Path: name,
-				Err:  ErrBadPathResolution,
-			})
-		}
-	}
-	return fd, nil
-}
-
-// _openat is a wrapper around unix.Openat. This method should never be directly
-// called, use `openat` instead.
-func (fs *UnixFS) _openat(dirfd int, name string, flag int, mode uint32) (int, error) {
-	// Ensure the O_CLOEXEC flag is set.
-	// Go sets this in the os package, but since we are directly using unix
-	// we need to set it ourselves.
-	if flag&O_CLOEXEC == 0 {
-		flag |= O_CLOEXEC
-	}
-	// O_LARGEFILE is set by Openat for us automatically.
-	fd, err := unix.Openat(dirfd, name, flag, mode)
-	switch {
-	case err == nil:
-		return fd, nil
-	case err == unix.EINTR:
-		return 0, err
-	case err == unix.EAGAIN:
-		return 0, err
-	default:
-		return 0, &PathError{Op: "openat", Path: name, Err: err}
-	}
-}
-
-// _openat2 is a wonderful syscall that supersedes the `openat` syscall. It has
-// improved validation and security characteristics that weren't available or
-// considered when `openat` was originally implemented. As such, it is only
-// present in Kernel 5.6 and above.
-//
-// This method should never be directly called, use `openat` instead.
-func (fs *UnixFS) _openat2(dirfd int, name string, flag uint64, mode uint64) (int, error) {
-	// Ensure the O_CLOEXEC flag is set.
-	// Go sets this when using the os package, but since we are directly using
-	// the unix package we need to set it ourselves.
-	if flag&O_CLOEXEC == 0 {
-		flag |= O_CLOEXEC
-	}
-	// Ensure the O_LARGEFILE flag is set.
-	// Go sets this for unix.Open, unix.Openat, but not unix.Openat2.
-	if flag&O_LARGEFILE == 0 {
-		flag |= O_LARGEFILE
-	}
-	fd, err := unix.Openat2(dirfd, name, &unix.OpenHow{
-		Flags: flag,
-		Mode:  mode,
-		// This is the bread and butter of preventing a symlink escape, without
-		// this option, we have to handle path validation fully on our own.
-		//
-		// This is why using Openat2 over Openat is preferred if available.
-		Resolve: unix.RESOLVE_BENEATH,
-	})
-	switch {
-	case err == nil:
-		return fd, nil
-	case err == unix.EINTR:
-		return 0, err
-	case err == unix.EAGAIN:
-		return 0, err
-	default:
-		return 0, &PathError{Op: "openat2", Path: name, Err: err}
-	}
-}
-
-func (fs *UnixFS) SafePath(path string) (int, string, func(), error) {
-	return fs.safePath(path)
-}
-
-func (fs *UnixFS) safePath(path string) (dirfd int, file string, closeFd func(), err error) {
-	// Default closeFd to a NO-OP.
-	closeFd = func() {}
-
-	// Use unsafePath to clean the path and strip BasePath if path is absolute.
-	var name string
-	name, err = fs.unsafePath(path)
-	if err != nil {
-		return
-	}
-
-	// Check if dirfd was closed, this will happen if (*UnixFS).Close()
-	// was called.
-	fsDirfd := int(fs.dirfd.Load())
-	if fsDirfd == -1 {
-		err = ErrClosed
-		return
-	}
-
-	// Split the parent from the last element in the path, this gives us the
-	// "file name" and the full path to its parent.
-	var dir string
-	dir, file = filepath.Split(name)
-	// If dir is empty then name is not nested.
-	if dir == "" {
-		// We don't need to set closeFd here as it will default to a NO-OP and
-		// `fs.dirfd` is re-used until the filesystem is no-longer needed.
-		dirfd = fsDirfd
-
-		// Return dirfd, name, an empty closeFd func, and no error
-		return
-	}
-
-	// Dir will usually contain a trailing slash as filepath.Split doesn't
-	// trim slashes.
-	dir = strings.TrimSuffix(dir, "/")
-	dirfd, err = fs.openat(fsDirfd, dir, O_DIRECTORY|O_RDONLY, 0)
-	if dirfd != 0 {
-		// Set closeFd to close the newly opened directory file descriptor.
-		closeFd = func() { _ = unix.Close(dirfd) }
-	}
-
-	// Return dirfd, name, the closeFd func, and err
-	return
-}
-
-// unsafePath prefixes the given path and prefixes it with the filesystem's
-// base path, cleaning the result. The path returned by this function may not
-// be inside the filesystem's base path, additional checks are required to
-// safely use paths returned by this function.
-func (fs *UnixFS) unsafePath(path string) (string, error) {
-	// Calling filepath.Clean on the joined directory will resolve it to the
-	// absolute path, removing any ../ type of resolution arguments, and leaving
-	// us with a direct path link.
-	//
-	// This will also trim the existing root path off the beginning of the path
-	// passed to the function since that can get a bit messy.
-	r := filepath.Clean(filepath.Join(fs.basePath, strings.TrimPrefix(path, fs.basePath)))
-
-	if fs.unsafeIsPathInsideOfBase(r) {
-		// This is kinda ironic isn't it.
-		// We do this as we are operating with dirfds and `*at` syscalls which
-		// behave differently if given an absolute path.
-		//
-		// First trim the BasePath, then trim any leading slashes.
-		r = strings.TrimPrefix(strings.TrimPrefix(r, fs.basePath), "/")
-		// If the path is empty then return "." as the path is pointing to the
-		// root.
-		if r == "" {
-			return ".", nil
-		}
-		return r, nil
-	}
-
-	return "", &PathError{
-		Op:   "safePath",
-		Path: path,
-		Err:  ErrBadPathResolution,
-	}
-}
-
-// unsafeIsPathInsideOfBase checks if the given path is inside the filesystem's
-// base path.
-func (fs *UnixFS) unsafeIsPathInsideOfBase(path string) bool {
-	return strings.HasPrefix(
-		strings.TrimSuffix(path, "/")+"/",
-		fs.basePath+"/",
-	)
-}

internal/ufs/fs_unix_test.go

@@ -1,255 +0,0 @@
-// SPDX-License-Identifier: MIT
-// SPDX-FileCopyrightText: Copyright (c) 2024 Matthew Penner
-
-//go:build unix
-
-package ufs_test
-
-import (
-	"errors"
-	"os"
-	"path/filepath"
-	"testing"
-
-	"github.com/pterodactyl/wings/internal/ufs"
-)
-
-type testUnixFS struct {
-	*ufs.UnixFS
-
-	TmpDir string
-	Root   string
-}
-
-func (fs *testUnixFS) Cleanup() {
-	_ = fs.Close()
-	_ = os.RemoveAll(fs.TmpDir)
-}
-
-func newTestUnixFS() (*testUnixFS, error) {
-	tmpDir, err := os.MkdirTemp(os.TempDir(), "ufs")
-	if err != nil {
-		return nil, err
-	}
-	root := filepath.Join(tmpDir, "root")
-	if err := os.Mkdir(root, 0o755); err != nil {
-		return nil, err
-	}
-	// TODO: test both disabled and enabled.
-	fs, err := ufs.NewUnixFS(root, false)
-	if err != nil {
-		return nil, err
-	}
-	tfs := &testUnixFS{
-		UnixFS: fs,
-		TmpDir: tmpDir,
-		Root:   root,
-	}
-	return tfs, nil
-}
-
-func TestUnixFS_Remove(t *testing.T) {
-	t.Parallel()
-	fs, err := newTestUnixFS()
-	if err != nil {
-		t.Fatal(err)
-		return
-	}
-	defer fs.Cleanup()
-
-	t.Run("base directory", func(t *testing.T) {
-		// Try to remove the base directory.
-		if err := fs.Remove(""); !errors.Is(err, ufs.ErrBadPathResolution) {
-			t.Errorf("expected an a bad path resolution error, but got: %v", err)
-			return
-		}
-	})
-
-	t.Run("path traversal", func(t *testing.T) {
-		// Try to remove the base directory.
-		if err := fs.RemoveAll("../root"); !errors.Is(err, ufs.ErrBadPathResolution) {
-			t.Errorf("expected an a bad path resolution error, but got: %v", err)
-			return
-		}
-	})
-}
-
-func TestUnixFS_RemoveAll(t *testing.T) {
-	t.Parallel()
-	fs, err := newTestUnixFS()
-	if err != nil {
-		t.Fatal(err)
-		return
-	}
-	defer fs.Cleanup()
-
-	t.Run("base directory", func(t *testing.T) {
-		// Try to remove the base directory.
-		if err := fs.RemoveAll(""); !errors.Is(err, ufs.ErrBadPathResolution) {
-			t.Errorf("expected an a bad path resolution error, but got: %v", err)
-			return
-		}
-	})
-
-	t.Run("path traversal", func(t *testing.T) {
-		// Try to remove the base directory.
-		if err := fs.RemoveAll("../root"); !errors.Is(err, ufs.ErrBadPathResolution) {
-			t.Errorf("expected an a bad path resolution error, but got: %v", err)
-			return
-		}
-	})
-}
-
-func TestUnixFS_Rename(t *testing.T) {
-	t.Parallel()
-	fs, err := newTestUnixFS()
-	if err != nil {
-		t.Fatal(err)
-		return
-	}
-	defer fs.Cleanup()
-
-	t.Run("rename base directory", func(t *testing.T) {
-		// Try to rename the base directory.
-		if err := fs.Rename("", "yeet"); !errors.Is(err, ufs.ErrBadPathResolution) {
-			t.Errorf("expected an a bad path resolution error, but got: %v", err)
-			return
-		}
-	})
-
-	t.Run("rename over base directory", func(t *testing.T) {
-		// Create a directory that we are going to try and move over top of the
-		// existing base directory.
-		if err := fs.Mkdir("overwrite_dir", 0o755); err != nil {
-			t.Error(err)
-			return
-		}
-
-		// Try to rename over the base directory.
-		if err := fs.Rename("overwrite_dir", ""); !errors.Is(err, ufs.ErrBadPathResolution) {
-			t.Errorf("expected an a bad path resolution error, but got: %v", err)
-			return
-		}
-	})
-
-	t.Run("directory rename", func(t *testing.T) {
-		// Create a directory to rename to something else.
-		if err := fs.Mkdir("test_directory", 0o755); err != nil {
-			t.Error(err)
-			return
-		}
-
-		// Try to rename "test_directory" to "directory".
-		if err := fs.Rename("test_directory", "directory"); err != nil {
-			t.Errorf("expected no error, but got: %v", err)
-			return
-		}
-
-		// Sanity check
-		if _, err := os.Lstat(filepath.Join(fs.Root, "directory")); err != nil {
-			t.Errorf("Lstat errored when performing sanity check: %v", err)
-			return
-		}
-	})
-
-	t.Run("file rename", func(t *testing.T) {
-		// Create a directory to rename to something else.
-		if f, err := fs.Create("test_file"); err != nil {
-			t.Error(err)
-			return
-		} else {
-			_ = f.Close()
-		}
-
-		// Try to rename "test_file" to "file".
-		if err := fs.Rename("test_file", "file"); err != nil {
-			t.Errorf("expected no error, but got: %v", err)
-			return
-		}
-
-		// Sanity check
-		if _, err := os.Lstat(filepath.Join(fs.Root, "file")); err != nil {
-			t.Errorf("Lstat errored when performing sanity check: %v", err)
-			return
-		}
-	})
-}
-
-func TestUnixFS_Touch(t *testing.T) {
-	t.Parallel()
-	fs, err := newTestUnixFS()
-	if err != nil {
-		t.Fatal(err)
-		return
-	}
-	defer fs.Cleanup()
-
-	t.Run("base directory", func(t *testing.T) {
-		path := "i_touched_a_file"
-		f, err := fs.Touch(path, ufs.O_RDWR, 0o644)
-		if err != nil {
-			t.Error(err)
-			return
-		}
-		_ = f.Close()
-
-		// Sanity check
-		if _, err := os.Lstat(filepath.Join(fs.Root, path)); err != nil {
-			t.Errorf("Lstat errored when performing sanity check: %v", err)
-			return
-		}
-	})
-
-	t.Run("existing parent directory", func(t *testing.T) {
-		dir := "some_parent_directory"
-		if err := fs.Mkdir(dir, 0o755); err != nil {
-			t.Errorf("error creating parent directory: %v", err)
-			return
-		}
-		path := filepath.Join(dir, "i_touched_a_file")
-		f, err := fs.Touch(path, ufs.O_RDWR, 0o644)
-		if err != nil {
-			t.Errorf("error touching file: %v", err)
-			return
-		}
-		_ = f.Close()
-
-		// Sanity check
-		if _, err := os.Lstat(filepath.Join(fs.Root, path)); err != nil {
-			t.Errorf("Lstat errored when performing sanity check: %v", err)
-			return
-		}
-	})
-
-	t.Run("non-existent parent directory", func(t *testing.T) {
-		path := "some_other_directory/i_touched_a_file"
-		f, err := fs.Touch(path, ufs.O_RDWR, 0o644)
-		if err != nil {
-			t.Errorf("error touching file: %v", err)
-			return
-		}
-		_ = f.Close()
-
-		// Sanity check
-		if _, err := os.Lstat(filepath.Join(fs.Root, path)); err != nil {
-			t.Errorf("Lstat errored when performing sanity check: %v", err)
-			return
-		}
-	})
-
-	t.Run("non-existent parent directories", func(t *testing.T) {
-		path := "some_other_directory/some_directory/i_touched_a_file"
-		f, err := fs.Touch(path, ufs.O_RDWR, 0o644)
-		if err != nil {
-			t.Errorf("error touching file: %v", err)
-			return
-		}
-		_ = f.Close()
-
-		// Sanity check
-		if _, err := os.Lstat(filepath.Join(fs.Root, path)); err != nil {
-			t.Errorf("Lstat errored when performing sanity check: %v", err)
-			return
-		}
-	})
-}

internal/ufs/go.LICENSE

@@ -1,27 +0,0 @@
-Copyright (c) 2009 The Go Authors. All rights reserved.
-
-Redistribution and use in source and binary forms, with or without
-modification, are permitted provided that the following conditions are
-met:
-
-   * Redistributions of source code must retain the above copyright
-notice, this list of conditions and the following disclaimer.
-   * Redistributions in binary form must reproduce the above
-copyright notice, this list of conditions and the following disclaimer
-in the documentation and/or other materials provided with the
-distribution.
-   * Neither the name of Google Inc. nor the names of its
-contributors may be used to endorse or promote products derived from
-this software without specific prior written permission.
-
-THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
-LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
-THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

internal/ufs/mkdir_unix.go

@@ -1,67 +0,0 @@
-// SPDX-License-Identifier: BSD-3-Clause
-
-// Code in this file was derived from `go/src/os/path.go`.
-
-// Copyright 2009 The Go Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style
-// license that can be found in the `go.LICENSE` file.
-
-//go:build unix
-
-package ufs
-
-import (
-	"golang.org/x/sys/unix"
-)
-
-// mkdirAll is a recursive Mkdir implementation that properly handles symlinks.
-func (fs *UnixFS) mkdirAll(name string, mode FileMode) error {
-	// Fast path: if we can tell whether path is a directory or file, stop with success or error.
-	dir, err := fs.Lstat(name)
-	if err == nil {
-		if dir.Mode()&ModeSymlink != 0 {
-			// If the final path is a symlink, resolve its target and use that
-			// to check instead.
-			dir, err = fs.Stat(name)
-			if err != nil {
-				return err
-			}
-		}
-		if dir.IsDir() {
-			return nil
-		}
-		return convertErrorType(&PathError{Op: "mkdir", Path: name, Err: unix.ENOTDIR})
-	}
-
-	// Slow path: make sure parent exists and then call Mkdir for path.
-	i := len(name)
-	for i > 0 && name[i-1] == '/' { // Skip trailing path separator.
-		i--
-	}
-
-	j := i
-	for j > 0 && name[j-1] != '/' { // Scan backward over element.
-		j--
-	}
-
-	if j > 1 {
-		// Create parent.
-		err = fs.mkdirAll(name[:j-1], mode)
-		if err != nil {
-			return err
-		}
-	}
-
-	// Parent now exists; invoke Mkdir and use its result.
-	err = fs.Mkdir(name, mode)
-	if err != nil {
-		// Handle arguments like "foo/." by
-		// double-checking that directory doesn't exist.
-		dir, err1 := fs.Lstat(name)
-		if err1 == nil && dir.IsDir() {
-			return nil
-		}
-		return err
-	}
-	return nil
-}

internal/ufs/path_unix.go

@@ -1,80 +0,0 @@
-// SPDX-License-Identifier: BSD-3-Clause
-
-// Code in this file was copied from `go/src/os/path.go`
-// and `go/src/os/path_unix.go`.
-
-// Copyright 2009 The Go Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style
-// license that can be found in the `go.LICENSE` file.
-
-//go:build unix
-
-package ufs
-
-import (
-	"os"
-)
-
-// basename removes trailing slashes and the leading directory name from path name.
-func basename(name string) string {
-	i := len(name) - 1
-	// Remove trailing slashes
-	for ; i > 0 && name[i] == '/'; i-- {
-		name = name[:i]
-	}
-	// Remove leading directory name
-	for i--; i >= 0; i-- {
-		if name[i] == '/' {
-			name = name[i+1:]
-			break
-		}
-	}
-	return name
-}
-
-// endsWithDot reports whether the final component of path is ".".
-func endsWithDot(path string) bool {
-	if path == "." {
-		return true
-	}
-	if len(path) >= 2 && path[len(path)-1] == '.' && os.IsPathSeparator(path[len(path)-2]) {
-		return true
-	}
-	return false
-}
-
-// splitPath returns the base name and parent directory.
-func splitPath(path string) (string, string) {
-	// if no better parent is found, the path is relative from "here"
-	dirname := "."
-
-	// Remove all but one leading slash.
-	for len(path) > 1 && path[0] == '/' && path[1] == '/' {
-		path = path[1:]
-	}
-
-	i := len(path) - 1
-
-	// Remove trailing slashes.
-	for ; i > 0 && path[i] == '/'; i-- {
-		path = path[:i]
-	}
-
-	// if no slashes in path, base is path
-	basename := path
-
-	// Remove leading directory path
-	for i--; i >= 0; i-- {
-		if path[i] == '/' {
-			if i == 0 {
-				dirname = path[:1]
-			} else {
-				dirname = path[:i]
-			}
-			basename = path[i+1:]
-			break
-		}
-	}
-
-	return dirname, basename
-}

internal/ufs/quota_writer.go

@@ -1,117 +0,0 @@
-// SPDX-License-Identifier: MIT
-// SPDX-FileCopyrightText: Copyright (c) 2024 Matthew Penner
-
-package ufs
-
-import (
-	"errors"
-	"io"
-	"sync/atomic"
-)
-
-// CountedWriter is a writer that counts the amount of data written to the
-// underlying writer.
-type CountedWriter struct {
-	File
-
-	counter atomic.Int64
-	err     error
-}
-
-// NewCountedWriter returns a new countedWriter that counts the amount of bytes
-// written to the underlying writer.
-func NewCountedWriter(f File) *CountedWriter {
-	return &CountedWriter{File: f}
-}
-
-// BytesWritten returns the amount of bytes that have been written to the
-// underlying writer.
-func (w *CountedWriter) BytesWritten() int64 {
-	return w.counter.Load()
-}
-
-// Error returns the error from the writer if any. If the error is an EOF, nil
-// will be returned.
-func (w *CountedWriter) Error() error {
-	if errors.Is(w.err, io.EOF) {
-		return nil
-	}
-	return w.err
-}
-
-// Write writes bytes to the underlying writer while tracking the total amount
-// of bytes written.
-func (w *CountedWriter) Write(p []byte) (int, error) {
-	if w.err != nil {
-		return 0, io.EOF
-	}
-
-	// Write is a very simple operation for us to handle.
-	n, err := w.File.Write(p)
-	w.counter.Add(int64(n))
-	w.err = err
-
-	// TODO: is this how we actually want to handle errors with this?
-	if err == io.EOF {
-		return n, io.EOF
-	} else {
-		return n, nil
-	}
-}
-
-func (w *CountedWriter) ReadFrom(r io.Reader) (n int64, err error) {
-	cr := NewCountedReader(r)
-	n, err = w.File.ReadFrom(cr)
-	w.counter.Add(n)
-	return
-}
-
-// CountedReader is a reader that counts the amount of data read from the
-// underlying reader.
-type CountedReader struct {
-	reader io.Reader
-
-	counter atomic.Int64
-	err     error
-}
-
-var _ io.Reader = (*CountedReader)(nil)
-
-// NewCountedReader returns a new countedReader that counts the amount of bytes
-// read from the underlying reader.
-func NewCountedReader(r io.Reader) *CountedReader {
-	return &CountedReader{reader: r}
-}
-
-// BytesRead returns the amount of bytes that have been read from the underlying
-// reader.
-func (r *CountedReader) BytesRead() int64 {
-	return r.counter.Load()
-}
-
-// Error returns the error from the reader if any. If the error is an EOF, nil
-// will be returned.
-func (r *CountedReader) Error() error {
-	if errors.Is(r.err, io.EOF) {
-		return nil
-	}
-	return r.err
-}
-
-// Read reads bytes from the underlying reader while tracking the total amount
-// of bytes read.
-func (r *CountedReader) Read(p []byte) (int, error) {
-	if r.err != nil {
-		return 0, io.EOF
-	}
-
-	n, err := r.reader.Read(p)
-	r.counter.Add(int64(n))
-	r.err = err
-
-	if err == io.EOF {
-		return n, io.EOF
-	} else {
-		return n, nil
-	}
-}

internal/ufs/removeall_unix.go

@@ -1,207 +0,0 @@
-// SPDX-License-Identifier: BSD-3-Clause
-
-// Code in this file was derived from `go/src/os/removeall_at.go`.
-
-// Copyright 2009 The Go Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style
-// license that can be found in the `go.LICENSE` file.
-
-//go:build unix
-
-package ufs
-
-import (
-	"errors"
-	"io"
-	"os"
-
-	"golang.org/x/sys/unix"
-)
-
-type unixFS interface {
-	Open(name string) (File, error)
-	Remove(name string) error
-	unlinkat(dirfd int, path string, flags int) error
-}
-
-func (fs *UnixFS) removeAll(path string) error {
-	return removeAll(fs, path)
-}
-
-func removeAll(fs unixFS, path string) error {
-	if path == "" {
-		// fail silently to retain compatibility with previous behavior
-		// of RemoveAll. See issue https://go.dev/issue/28830.
-		return nil
-	}
-
-	// The rmdir system call does not permit removing ".",
-	// so we don't permit it either.
-	if endsWithDot(path) {
-		return &PathError{Op: "removeall", Path: path, Err: unix.EINVAL}
-	}
-
-	// Simple case: if Remove works, we're done.
-	err := fs.Remove(path)
-	if err == nil || errors.Is(err, ErrNotExist) {
-		return nil
-	}
-
-	// RemoveAll recurses by deleting the path base from
-	// its parent directory
-	parentDir, base := splitPath(path)
-
-	parent, err := fs.Open(parentDir)
-	if errors.Is(err, ErrNotExist) {
-		// If parent does not exist, base cannot exist. Fail silently
-		return nil
-	}
-	if err != nil {
-		return err
-	}
-	defer parent.Close()
-
-	if err := removeAllFrom(fs, parent, base); err != nil {
-		if pathErr, ok := err.(*PathError); ok {
-			pathErr.Path = parentDir + string(os.PathSeparator) + pathErr.Path
-			err = pathErr
-		}
-		return convertErrorType(err)
-	}
-	return nil
-}
-
-func removeAllFrom(fs unixFS, parent File, base string) error {
-	parentFd := int(parent.Fd())
-	// Simple case: if Unlink (aka remove) works, we're done.
-	err := fs.unlinkat(parentFd, base, 0)
-	if err == nil || errors.Is(err, ErrNotExist) {
-		return nil
-	}
-
-	// EISDIR means that we have a directory, and we need to
-	// remove its contents.
-	// EPERM or EACCES means that we don't have write permission on
-	// the parent directory, but this entry might still be a directory
-	// whose contents need to be removed.
-	// Otherwise, just return the error.
-	if err != unix.EISDIR && err != unix.EPERM && err != unix.EACCES {
-		return &PathError{Op: "unlinkat", Path: base, Err: err}
-	}
-
-	// Is this a directory we need to recurse into?
-	var statInfo unix.Stat_t
-	statErr := ignoringEINTR(func() error {
-		return unix.Fstatat(parentFd, base, &statInfo, AT_SYMLINK_NOFOLLOW)
-	})
-	if statErr != nil {
-		if errors.Is(statErr, ErrNotExist) {
-			return nil
-		}
-		return &PathError{Op: "fstatat", Path: base, Err: statErr}
-	}
-	if statInfo.Mode&unix.S_IFMT != unix.S_IFDIR {
-		// Not a directory; return the error from the unix.Unlinkat.
-		return &PathError{Op: "unlinkat", Path: base, Err: err}
-	}
-
-	// Remove the directory's entries.
-	var recurseErr error
-	for {
-		const reqSize = 1024
-		var respSize int
-
-		// Open the directory to recurse into
-		file, err := openFdAt(parentFd, base)
-		if err != nil {
-			if errors.Is(err, ErrNotExist) {
-				return nil
-			}
-			recurseErr = &PathError{Op: "openfdat", Path: base, Err: err}
-			break
-		}
-
-		for {
-			numErr := 0
-
-			names, readErr := file.Readdirnames(reqSize)
-			// Errors other than EOF should stop us from continuing.
-			if readErr != nil && readErr != io.EOF {
-				_ = file.Close()
-				if errors.Is(readErr, ErrNotExist) {
-					return nil
-				}
-				return &PathError{Op: "readdirnames", Path: base, Err: readErr}
-			}
-
-			respSize = len(names)
-			for _, name := range names {
-				err := removeAllFrom(fs, file, name)
-				if err != nil {
-					if pathErr, ok := err.(*PathError); ok {
-						pathErr.Path = base + string(os.PathSeparator) + pathErr.Path
-					}
-					numErr++
-					if recurseErr == nil {
-						recurseErr = err
-					}
-				}
-			}
-
-			// If we can delete any entry, break to start new iteration.
-			// Otherwise, we discard current names, get next entries and try deleting them.
-			if numErr != reqSize {
-				break
-			}
-		}
-
-		// Removing files from the directory may have caused
-		// the OS to reshuffle it. Simply calling Readdirnames
-		// again may skip some entries. The only reliable way
-		// to avoid this is to close and re-open the
-		// directory. See issue https://go.dev/issue/20841.
-		_ = file.Close()
-
-		// Finish when the end of the directory is reached
-		if respSize < reqSize {
-			break
-		}
-	}
-
-	// Remove the directory itself.
-	unlinkErr := fs.unlinkat(parentFd, base, AT_REMOVEDIR)
-	if unlinkErr == nil || errors.Is(unlinkErr, ErrNotExist) {
-		return nil
-	}
-
-	if recurseErr != nil {
-		return recurseErr
-	}
-	return &PathError{Op: "unlinkat", Path: base, Err: unlinkErr}
-}
-
-// openFdAt opens path relative to the directory in fd.
-// Other than that this should act like openFileNolog.
-// This acts like openFileNolog rather than OpenFile because
-// we are going to (try to) remove the file.
-// The contents of this file are not relevant for test caching.
-func openFdAt(dirfd int, name string) (File, error) {
-	var fd int
-	for {
-		var err error
-		fd, err = unix.Openat(dirfd, name, O_RDONLY|O_CLOEXEC|O_NOFOLLOW, 0)
-		if err == nil {
-			break
-		}
-
-		// See comment in openFileNolog.
-		if err == unix.EINTR {
-			continue
-		}
-
-		return nil, err
-	}
-	// This is stupid, os.NewFile immediately casts `fd` to an `int`, but wants
-	// it to be passed as a `uintptr`.
-	return os.NewFile(uintptr(fd), name), nil
-}

internal/ufs/stat_unix.go

@@ -1,67 +0,0 @@
-// SPDX-License-Identifier: BSD-3-Clause
-
-// Code in this file was copied from `go/src/os/stat_linux.go`
-// and `go/src/os/types_unix.go`.
-
-// Copyright 2009 The Go Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style
-// license that can be found in the `go.LICENSE` file.
-
-//go:build unix
-
-package ufs
-
-import (
-	"time"
-
-	"golang.org/x/sys/unix"
-)
-
-type fileStat struct {
-	name    string
-	size    int64
-	mode    FileMode
-	modTime time.Time
-	sys     unix.Stat_t
-}
-
-var _ FileInfo = (*fileStat)(nil)
-
-func (fs *fileStat) Size() int64        { return fs.size }
-func (fs *fileStat) Mode() FileMode     { return fs.mode }
-func (fs *fileStat) ModTime() time.Time { return fs.modTime }
-func (fs *fileStat) Sys() any           { return &fs.sys }
-func (fs *fileStat) Name() string       { return fs.name }
-func (fs *fileStat) IsDir() bool        { return fs.Mode().IsDir() }
-
-func fillFileStatFromSys(fs *fileStat, name string) {
-	fs.name = basename(name)
-	fs.size = fs.sys.Size
-	fs.modTime = time.Unix(fs.sys.Mtim.Unix())
-	fs.mode = FileMode(fs.sys.Mode & 0o777)
-	switch fs.sys.Mode & unix.S_IFMT {
-	case unix.S_IFBLK:
-		fs.mode |= ModeDevice
-	case unix.S_IFCHR:
-		fs.mode |= ModeDevice | ModeCharDevice
-	case unix.S_IFDIR:
-		fs.mode |= ModeDir
-	case unix.S_IFIFO:
-		fs.mode |= ModeNamedPipe
-	case unix.S_IFLNK:
-		fs.mode |= ModeSymlink
-	case unix.S_IFREG:
-		// nothing to do
-	case unix.S_IFSOCK:
-		fs.mode |= ModeSocket
-	}
-	if fs.sys.Mode&unix.S_ISGID != 0 {
-		fs.mode |= ModeSetgid
-	}
-	if fs.sys.Mode&unix.S_ISUID != 0 {
-		fs.mode |= ModeSetuid
-	}
-	if fs.sys.Mode&unix.S_ISVTX != 0 {
-		fs.mode |= ModeSticky
-	}
-}

internal/ufs/walk.go

@@ -1,123 +0,0 @@
-// SPDX-License-Identifier: BSD-3-Clause
-
-// Code in this file was derived from `go/src/io/fs/walk.go`.
-
-// Copyright 2020 The Go Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style
-// license that can be found in the `go.LICENSE` file.
-
-package ufs
-
-import (
-	iofs "io/fs"
-	"path"
-)
-
-// SkipDir is used as a return value from [WalkDirFunc] to indicate that
-// the directory named in the call is to be skipped. It is not returned
-// as an error by any function.
-var SkipDir = iofs.SkipDir
-
-// SkipAll is used as a return value from [WalkDirFunc] to indicate that
-// all remaining files and directories are to be skipped. It is not returned
-// as an error by any function.
-var SkipAll = iofs.SkipAll
-
-// WalkDirFunc is the type of the function called by [WalkDir] to visit
-// each file or directory.
-//
-// The path argument contains the argument to [WalkDir] as a prefix.
-// That is, if WalkDir is called with root argument "dir" and finds a file
-// named "a" in that directory, the walk function will be called with
-// argument "dir/a".
-//
-// The d argument is the [DirEntry] for the named path.
-//
-// The error result returned by the function controls how [WalkDir]
-// continues. If the function returns the special value [SkipDir], WalkDir
-// skips the current directory (path if d.IsDir() is true, otherwise
-// path's parent directory). If the function returns the special value
-// [SkipAll], WalkDir skips all remaining files and directories. Otherwise,
-// if the function returns a non-nil error, WalkDir stops entirely and
-// returns that error.
-//
-// The err argument reports an error related to path, signaling that
-// [WalkDir] will not walk into that directory. The function can decide how
-// to handle that error; as described earlier, returning the error will
-// cause WalkDir to stop walking the entire tree.
-//
-// [WalkDir] calls the function with a non-nil err argument in two cases.
-//
-// First, if the initial [Stat] on the root directory fails, WalkDir
-// calls the function with path set to root, d set to nil, and err set to
-// the error from [fs.Stat].
-//
-// Second, if a directory's ReadDir method (see [ReadDirFile]) fails, WalkDir calls the
-// function with path set to the directory's path, d set to an
-// [DirEntry] describing the directory, and err set to the error from
-// ReadDir. In this second case, the function is called twice with the
-// path of the directory: the first call is before the directory read is
-// attempted and has err set to nil, giving the function a chance to
-// return [SkipDir] or [SkipAll] and avoid the ReadDir entirely. The second call
-// is after a failed ReadDir and reports the error from ReadDir.
-// (If ReadDir succeeds, there is no second call.)
-type WalkDirFunc func(path string, d DirEntry, err error) error
-
-// WalkDir walks the file tree rooted at root, calling fn for each file or
-// directory in the tree, including root.
-//
-// All errors that arise visiting files and directories are filtered by fn:
-// see the [WalkDirFunc] documentation for details.
-//
-// The files are walked in lexical order, which makes the output deterministic
-// but requires WalkDir to read an entire directory into memory before proceeding
-// to walk that directory.
-//
-// WalkDir does not follow symbolic links found in directories,
-// but if root itself is a symbolic link, its target will be walked.
-func WalkDir(fs Filesystem, root string, fn WalkDirFunc) error {
-	info, err := fs.Stat(root)
-	if err != nil {
-		err = fn(root, nil, err)
-	} else {
-		err = walkDir(fs, root, iofs.FileInfoToDirEntry(info), fn)
-	}
-	if err == SkipDir || err == SkipAll {
-		return nil
-	}
-	return err
-}
-
-// walkDir recursively descends path, calling walkDirFn.
-func walkDir(fs Filesystem, name string, d DirEntry, walkDirFn WalkDirFunc) error {
-	if err := walkDirFn(name, d, nil); err != nil || !d.IsDir() {
-		if err == SkipDir && d.IsDir() {
-			// Successfully skipped directory.
-			err = nil
-		}
-		return err
-	}
-
-	dirs, err := fs.ReadDir(name)
-	if err != nil {
-		// Second call, to report ReadDir error.
-		err = walkDirFn(name, d, err)
-		if err != nil {
-			if err == SkipDir && d.IsDir() {
-				err = nil
-			}
-			return err
-		}
-	}
-
-	for _, d1 := range dirs {
-		name1 := path.Join(name, d1.Name())
-		if err := walkDir(fs, name1, d1, walkDirFn); err != nil {
-			if err == SkipDir {
-				break
-			}
-			return err
-		}
-	}
-	return nil
-}

internal/ufs/walk_unix.go

@@ -1,298 +0,0 @@
-// SPDX-License-Identifier: BSD-2-Clause
-
-// Some code in this file was derived from https://github.com/karrick/godirwalk.
-
-//go:build unix
-
-package ufs
-
-import (
-	"bytes"
-	iofs "io/fs"
-	"os"
-	"path"
-	"path/filepath"
-	"reflect"
-	"unsafe"
-
-	"golang.org/x/sys/unix"
-)
-
-type WalkDiratFunc func(dirfd int, name, relative string, d DirEntry, err error) error
-
-func (fs *UnixFS) WalkDirat(dirfd int, name string, fn WalkDiratFunc) error {
-	if dirfd == 0 {
-		// TODO: proper validation, ideally a dedicated function.
-		dirfd = int(fs.dirfd.Load())
-	}
-	info, err := fs.Lstatat(dirfd, name)
-	if err != nil {
-		err = fn(dirfd, name, name, nil, err)
-	} else {
-		b := newScratchBuffer()
-		err = fs.walkDir(b, dirfd, name, name, iofs.FileInfoToDirEntry(info), fn)
-	}
-	if err == SkipDir || err == SkipAll {
-		return nil
-	}
-	return err
-}
-
-func (fs *UnixFS) walkDir(b []byte, parentfd int, name, relative string, d DirEntry, walkDirFn WalkDiratFunc) error {
-	if err := walkDirFn(parentfd, name, relative, d, nil); err != nil || !d.IsDir() {
-		if err == SkipDir && d.IsDir() {
-			// Successfully skipped directory.
-			err = nil
-		}
-		return err
-	}
-
-	dirfd, err := fs.openat(parentfd, name, O_DIRECTORY|O_RDONLY, 0)
-	if err != nil {
-		return err
-	}
-	defer unix.Close(dirfd)
-
-	dirs, err := fs.readDir(dirfd, name, b)
-	if err != nil {
-		// Second call, to report ReadDir error.
-		err = walkDirFn(dirfd, name, relative, d, err)
-		if err != nil {
-			if err == SkipDir && d.IsDir() {
-				err = nil
-			}
-			return err
-		}
-	}
-
-	for _, d1 := range dirs {
-		// TODO: the path.Join on this line may actually be partially incorrect.
-		// If we are not walking starting at the root, relative will contain the
-		// name of the directory we are starting the walk from, which will be
-		// relative to the root of the filesystem instead of from where the walk
-		// was initiated from.
-		//
-		// ref; https://github.com/pterodactyl/panel/issues/5030
-		if err := fs.walkDir(b, dirfd, d1.Name(), path.Join(relative, d1.Name()), d1, walkDirFn); err != nil {
-			if err == SkipDir {
-				break
-			}
-			return err
-		}
-	}
-	return nil
-}
-
-// ReadDirMap .
-// TODO: document
-func ReadDirMap[T any](fs *UnixFS, path string, fn func(DirEntry) (T, error)) ([]T, error) {
-	dirfd, name, closeFd, err := fs.safePath(path)
-	defer closeFd()
-	if err != nil {
-		return nil, err
-	}
-	fd, err := fs.openat(dirfd, name, O_DIRECTORY|O_RDONLY, 0)
-	if err != nil {
-		return nil, err
-	}
-	defer unix.Close(fd)
-
-	entries, err := fs.readDir(fd, ".", nil)
-	if err != nil {
-		return nil, err
-	}
-
-	out := make([]T, len(entries))
-	for i, e := range entries {
-		idx := i
-		e := e
-		v, err := fn(e)
-		if err != nil {
-			return nil, err
-		}
-		out[idx] = v
-	}
-	return out, nil
-}
-
-// nameOffset is a compile time constant
-const nameOffset = int(unsafe.Offsetof(unix.Dirent{}.Name))
-
-func nameFromDirent(de *unix.Dirent) (name []byte) {
-	// Because this GOOS' syscall.Dirent does not provide a field that specifies
-	// the name length, this function must first calculate the max possible name
-	// length, and then search for the NULL byte.
-	ml := int(de.Reclen) - nameOffset
-
-	// Convert syscall.Dirent.Name, which is array of int8, to []byte, by
-	// overwriting Cap, Len, and Data slice header fields to the max possible
-	// name length computed above, and finding the terminating NULL byte.
-	//
-	// TODO: is there an alternative to the deprecated SliceHeader?
-	// SliceHeader was mainly deprecated due to it being misused for avoiding
-	// allocations when converting a byte slice to a string, ref;
-	// https://go.dev/issue/53003
-	sh := (*reflect.SliceHeader)(unsafe.Pointer(&name))
-	sh.Cap = ml
-	sh.Len = ml
-	sh.Data = uintptr(unsafe.Pointer(&de.Name[0]))
-
-	if index := bytes.IndexByte(name, 0); index >= 0 {
-		// Found NULL byte; set slice's cap and len accordingly.
-		sh.Cap = index
-		sh.Len = index
-		return
-	}
-
-	// NOTE: This branch is not expected, but included for defensive
-	// programming, and provides a hard stop on the name based on the structure
-	// field array size.
-	sh.Cap = len(de.Name)
-	sh.Len = sh.Cap
-	return
-}
-
-// modeTypeFromDirent converts a syscall defined constant, which is in purview
-// of OS, to a constant defined by Go, assumed by this project to be stable.
-//
-// When the syscall constant is not recognized, this function falls back to a
-// Stat on the file system.
-func (fs *UnixFS) modeTypeFromDirent(fd int, de *unix.Dirent, osDirname, osBasename string) (FileMode, error) {
-	switch de.Type {
-	case unix.DT_REG:
-		return 0, nil
-	case unix.DT_DIR:
-		return ModeDir, nil
-	case unix.DT_LNK:
-		return ModeSymlink, nil
-	case unix.DT_CHR:
-		return ModeDevice | ModeCharDevice, nil
-	case unix.DT_BLK:
-		return ModeDevice, nil
-	case unix.DT_FIFO:
-		return ModeNamedPipe, nil
-	case unix.DT_SOCK:
-		return ModeSocket, nil
-	default:
-		// If syscall returned unknown type (e.g., DT_UNKNOWN, DT_WHT), then
-		// resolve actual mode by reading file information.
-		return fs.modeType(fd, filepath.Join(osDirname, osBasename))
-	}
-}
-
-// modeType returns the mode type of the file system entry identified by
-// osPathname by calling os.LStat function, to intentionally not follow symbolic
-// links.
-//
-// Even though os.LStat provides all file mode bits, we want to ensure same
-// values returned to caller regardless of whether we obtained file mode bits
-// from syscall or stat call. Therefore, mask out the additional file mode bits
-// that are provided by stat but not by the syscall, so users can rely on their
-// values.
-func (fs *UnixFS) modeType(dirfd int, name string) (os.FileMode, error) {
-	fi, err := fs.Lstatat(dirfd, name)
-	if err == nil {
-		return fi.Mode() & ModeType, nil
-	}
-	return 0, err
-}
-
-var minimumScratchBufferSize = os.Getpagesize()
-
-func newScratchBuffer() []byte {
-	return make([]byte, minimumScratchBufferSize)
-}
-
-func (fs *UnixFS) readDir(fd int, name string, b []byte) ([]DirEntry, error) {
-	scratchBuffer := b
-	if scratchBuffer == nil || len(scratchBuffer) < minimumScratchBufferSize {
-		scratchBuffer = newScratchBuffer()
-	}
-
-	var entries []DirEntry
-	var workBuffer []byte
-
-	var sde unix.Dirent
-	for {
-		if len(workBuffer) == 0 {
-			n, err := unix.Getdents(fd, scratchBuffer)
-			if err != nil {
-				if err == unix.EINTR {
-					continue
-				}
-				return nil, convertErrorType(err)
-			}
-			if n <= 0 {
-				// end of directory: normal exit
-				return entries, nil
-			}
-			workBuffer = scratchBuffer[:n] // trim work buffer to number of bytes read
-		}
-
-		// "Go is like C, except that you just put `unsafe` all over the place".
-		copy((*[unsafe.Sizeof(unix.Dirent{})]byte)(unsafe.Pointer(&sde))[:], workBuffer)
-		workBuffer = workBuffer[sde.Reclen:] // advance buffer for next iteration through loop
-
-		if sde.Ino == 0 {
-			continue // inode set to 0 indicates an entry that was marked as deleted
-		}
-
-		nameSlice := nameFromDirent(&sde)
-		nameLength := len(nameSlice)
-
-		if nameLength == 0 || (nameSlice[0] == '.' && (nameLength == 1 || (nameLength == 2 && nameSlice[1] == '.'))) {
-			continue
-		}
-
-		childName := string(nameSlice)
-		mt, err := fs.modeTypeFromDirent(fd, &sde, name, childName)
-		if err != nil {
-			return nil, convertErrorType(err)
-		}
-		entries = append(entries, &dirent{name: childName, path: name, modeType: mt, dirfd: fd, fs: fs})
-	}
-}
-
-// dirent stores the name and file system mode type of discovered file system
-// entries.
-type dirent struct {
-	name     string
-	path     string
-	modeType FileMode
-
-	dirfd int
-	fs    *UnixFS
-}
-
-func (de dirent) Name() string {
-	return de.name
-}
-
-func (de dirent) IsDir() bool {
-	return de.modeType&ModeDir != 0
-}
-
-func (de dirent) Type() FileMode {
-	return de.modeType
-}
-
-func (de dirent) Info() (FileInfo, error) {
-	if de.fs == nil {
-		return nil, nil
-	}
-	return de.fs.Lstatat(de.dirfd, de.name)
-}
-
-func (de dirent) Open() (File, error) {
-	if de.fs == nil {
-		return nil, nil
-	}
-	return de.fs.OpenFileat(de.dirfd, de.name, O_RDONLY, 0)
-}
-
-// reset releases memory held by entry err and name, and resets mode type to 0.
-func (de *dirent) reset() {
-	de.name = ""
-	de.path = ""
-	de.modeType = 0
-}

parser/helpers.go

@@ -2,6 +2,8 @@ package parser
 
 import (
 	"bytes"
+	"io"
+	"os"
 	"regexp"
 	"strconv"
 	"strings"
@@ -27,14 +29,24 @@ var configMatchRegex = regexp.MustCompile(`{{\s?config\.([\w.-]+)\s?}}`)
 // matching:
 //
 // <Root>
-//
+//   <Property value="testing"/>
-//	<Property value="testing"/>
-//
 // </Root>
 //
 // noinspection RegExpRedundantEscape
 var xmlValueMatchRegex = regexp.MustCompile(`^\[([\w]+)='(.*)'\]$`)
 
+// Gets the []byte representation of a configuration file to be passed through to other
+// handler functions. If the file does not currently exist, it will be created.
+func readFileBytes(path string) ([]byte, error) {
+	file, err := os.OpenFile(path, os.O_CREATE|os.O_RDWR, 0o644)
+	if err != nil {
+		return nil, err
+	}
+	defer file.Close()
+
+	return io.ReadAll(file)
+}
+
 // Gets the value of a key based on the value type defined.
 func (cfr *ConfigurationFileReplacement) getKeyValue(value string) interface{} {
 	if cfr.ReplaceWith.Type() == jsonparser.Boolean {

parser/parser.go

@@ -2,8 +2,8 @@ package parser
 
 import (
 	"bufio"
-	"bytes"
+	"os"
-	"io"
+	"path/filepath"
 	"strconv"
 	"strings"
 
@@ -18,7 +18,6 @@ import (
 	"gopkg.in/yaml.v3"
 
 	"github.com/pterodactyl/wings/config"
-	"github.com/pterodactyl/wings/internal/ufs"
 )
 
 // The file parsing options that are available for a server configuration file.
@@ -75,26 +74,6 @@ func (cv *ReplaceValue) String() string {
 	}
 }
 
-func (cv *ReplaceValue) Bytes() []byte {
-	switch cv.Type() {
-	case jsonparser.String:
-		var stackbuf [64]byte
-		bU, err := jsonparser.Unescape(cv.value, stackbuf[:])
-		if err != nil {
-			panic(errors.Wrap(err, "parser: could not parse value"))
-		}
-		return bU
-	case jsonparser.Null:
-		return []byte("<nil>")
-	case jsonparser.Boolean:
-		return cv.value
-	case jsonparser.Number:
-		return cv.value
-	default:
-		return []byte("<invalid>")
-	}
-}
-
 type ConfigurationParser string
 
 func (cp ConfigurationParser) String() string {
@@ -188,12 +167,11 @@ func (cfr *ConfigurationFileReplacement) UnmarshalJSON(data []byte) error {
 	return nil
 }
 
-// Parse parses a given configuration file and updates all the values within
+// Parses a given configuration file and updates all of the values within as defined
-// as defined in the API response from the Panel.
+// in the API response from the Panel.
-func (f *ConfigurationFile) Parse(file ufs.File) error {
+func (f *ConfigurationFile) Parse(path string, internal bool) error {
-	//log.WithField("path", path).WithField("parser", f.Parser.String()).Debug("parsing server configuration file")
+	log.WithField("path", path).WithField("parser", f.Parser.String()).Debug("parsing server configuration file")
 
-	// What the fuck is going on here?
 	if mb, err := json.Marshal(config.Get()); err != nil {
 		return err
 	} else {
@@ -204,24 +182,56 @@ func (f *ConfigurationFile) Parse(file ufs.File) error {
 
 	switch f.Parser {
 	case Properties:
-		err = f.parsePropertiesFile(file)
+		err = f.parsePropertiesFile(path)
+		break
 	case File:
-		err = f.parseTextFile(file)
+		err = f.parseTextFile(path)
+		break
 	case Yaml, "yml":
-		err = f.parseYamlFile(file)
+		err = f.parseYamlFile(path)
+		break
 	case Json:
-		err = f.parseJsonFile(file)
+		err = f.parseJsonFile(path)
+		break
 	case Ini:
-		err = f.parseIniFile(file)
+		err = f.parseIniFile(path)
+		break
 	case Xml:
-		err = f.parseXmlFile(file)
+		err = f.parseXmlFile(path)
+		break
 	}
+
+	if errors.Is(err, os.ErrNotExist) {
+		// File doesn't exist, we tried creating it, and same error is returned? Pretty
+		// sure this pathway is impossible, but if not, abort here.
+		if internal {
+			return nil
+		}
+
+		b := strings.TrimSuffix(path, filepath.Base(path))
+		if err := os.MkdirAll(b, 0o755); err != nil {
+			return errors.WithMessage(err, "failed to create base directory for missing configuration file")
+		} else {
+			if _, err := os.Create(path); err != nil {
+				return errors.WithMessage(err, "failed to create missing configuration file")
+			}
+		}
+
+		return f.Parse(path, true)
+	}
+
 	return err
 }
 
 // Parses an xml file.
-func (f *ConfigurationFile) parseXmlFile(file ufs.File) error {
+func (f *ConfigurationFile) parseXmlFile(path string) error {
 	doc := etree.NewDocument()
+	file, err := os.OpenFile(path, os.O_CREATE|os.O_RDWR, 0o644)
+	if err != nil {
+		return err
+	}
+	defer file.Close()
+
 	if _, err := doc.ReadFrom(file); err != nil {
 		return err
 	}
@@ -281,27 +291,41 @@ func (f *ConfigurationFile) parseXmlFile(file ufs.File) error {
 		}
 	}
 
-	if _, err := file.Seek(0, io.SeekStart); err != nil {
+	// If you don't truncate the file you'll end up duplicating the data in there (or just appending
-		return err
+	// to the end of the file. We don't want to do that.
-	}
 	if err := file.Truncate(0); err != nil {
 		return err
 	}
 
+	// Move the cursor to the start of the file to avoid weird spacing issues.
+	file.Seek(0, 0)
+
 	// Ensure the XML is indented properly.
 	doc.Indent(2)
 
-	// Write the XML to the file.
+	// Truncate the file before attempting to write the changes.
-	if _, err := doc.WriteTo(file); err != nil {
+	if err := os.Truncate(path, 0); err != nil {
 		return err
 	}
-	return nil
+
+	// Write the XML to the file.
+	_, err = doc.WriteTo(file)
+
+	return err
 }
 
 // Parses an ini file.
-func (f *ConfigurationFile) parseIniFile(file ufs.File) error {
+func (f *ConfigurationFile) parseIniFile(path string) error {
-	// Wrap the file in a NopCloser so the ini package doesn't close the file.
+	// Ini package can't handle a non-existent file, so handle that automatically here
-	cfg, err := ini.Load(io.NopCloser(file))
+	// by creating it if not exists. Then, immediately close the file since we will use
+	// other methods to write the new contents.
+	file, err := os.OpenFile(path, os.O_CREATE|os.O_RDWR, 0o644)
+	if err != nil {
+		return err
+	}
+	file.Close()
+
+	cfg, err := ini.Load(path)
 	if err != nil {
 		return err
 	}
@@ -364,24 +388,14 @@ func (f *ConfigurationFile) parseIniFile(file ufs.File) error {
 		}
 	}
 
-	if _, err := file.Seek(0, io.SeekStart); err != nil {
+	return cfg.SaveTo(path)
-		return err
-	}
-	if err := file.Truncate(0); err != nil {
-		return err
-	}
-
-	if _, err := cfg.WriteTo(file); err != nil {
-		return err
-	}
-	return nil
 }
 
 // Parses a json file updating any matching key/value pairs. If a match is not found, the
 // value is set regardless in the file. See the commentary in parseYamlFile for more details
 // about what is happening during this process.
-func (f *ConfigurationFile) parseJsonFile(file ufs.File) error {
+func (f *ConfigurationFile) parseJsonFile(path string) error {
-	b, err := io.ReadAll(file)
+	b, err := readFileBytes(path)
 	if err != nil {
 		return err
 	}
@@ -391,24 +405,14 @@ func (f *ConfigurationFile) parseJsonFile(file ufs.File) error {
 		return err
 	}
 
-	if _, err := file.Seek(0, io.SeekStart); err != nil {
+	output := []byte(data.StringIndent("", "    "))
-		return err
+	return os.WriteFile(path, output, 0o644)
-	}
-	if err := file.Truncate(0); err != nil {
-		return err
-	}
-
-	// Write the data to the file.
-	if _, err := io.Copy(file, bytes.NewReader(data.BytesIndent("", "    "))); err != nil {
-		return errors.Wrap(err, "parser: failed to write properties file to disk")
-	}
-	return nil
 }
 
 // Parses a yaml file and updates any matching key/value pairs before persisting
 // it back to the disk.
-func (f *ConfigurationFile) parseYamlFile(file ufs.File) error {
+func (f *ConfigurationFile) parseYamlFile(path string) error {
-	b, err := io.ReadAll(file)
+	b, err := readFileBytes(path)
 	if err != nil {
 		return err
 	}
@@ -439,56 +443,35 @@ func (f *ConfigurationFile) parseYamlFile(file ufs.File) error {
 		return err
 	}
 
-	if _, err := file.Seek(0, io.SeekStart); err != nil {
+	return os.WriteFile(path, marshaled, 0o644)
-		return err
-	}
-	if err := file.Truncate(0); err != nil {
-		return err
-	}
-
-	// Write the data to the file.
-	if _, err := io.Copy(file, bytes.NewReader(marshaled)); err != nil {
-		return errors.Wrap(err, "parser: failed to write properties file to disk")
-	}
-	return nil
 }
 
 // Parses a text file using basic find and replace. This is a highly inefficient method of
 // scanning a file and performing a replacement. You should attempt to use anything other
 // than this function where possible.
-func (f *ConfigurationFile) parseTextFile(file ufs.File) error {
+func (f *ConfigurationFile) parseTextFile(path string) error {
-	b := bytes.NewBuffer(nil)
+	input, err := os.ReadFile(path)
-	s := bufio.NewScanner(file)
+	if err != nil {
-	var replaced bool
+		return err
-	for s.Scan() {
+	}
-		line := s.Bytes()
+
-		replaced = false
+	lines := strings.Split(string(input), "\n")
+	for i, line := range lines {
 		for _, replace := range f.Replace {
 			// If this line doesn't match what we expect for the replacement, move on to the next
 			// line. Otherwise, update the line to have the replacement value.
-			if !bytes.HasPrefix(line, []byte(replace.Match)) {
+			if !strings.HasPrefix(line, replace.Match) {
 				continue
 			}
-			b.Write(replace.ReplaceWith.Bytes())
+
-			replaced = true
+			lines[i] = replace.ReplaceWith.String()
 		}
-		if !replaced {
-			b.Write(line)
-		}
-		b.WriteByte('\n')
 	}
 
-	if _, err := file.Seek(0, io.SeekStart); err != nil {
+	if err := os.WriteFile(path, []byte(strings.Join(lines, "\n")), 0o644); err != nil {
-		return err
-	}
-	if err := file.Truncate(0); err != nil {
 		return err
 	}
 
-	// Write the data to the file.
-	if _, err := io.Copy(file, b); err != nil {
-		return errors.Wrap(err, "parser: failed to write properties file to disk")
-	}
 	return nil
 }
 
@@ -518,29 +501,31 @@ func (f *ConfigurationFile) parseTextFile(file ufs.File) error {
 //
 // @see https://github.com/pterodactyl/panel/issues/2308 (original)
 // @see https://github.com/pterodactyl/panel/issues/3009 ("bug" introduced as result)
-func (f *ConfigurationFile) parsePropertiesFile(file ufs.File) error {
+func (f *ConfigurationFile) parsePropertiesFile(path string) error {
-	b, err := io.ReadAll(file)
+	var s strings.Builder
-	if err != nil {
+	// Open the file and attempt to load any comments that currenty exist at the start
-		return err
+	// of the file. This is kind of a hack, but should work for a majority of users for
-	}
+	// the time being.
-
+	if fd, err := os.Open(path); err != nil {
-	s := bytes.NewBuffer(nil)
+		return errors.Wrap(err, "parser: could not open file for reading")
-	scanner := bufio.NewScanner(bytes.NewReader(b))
+	} else {
-	// Scan until we hit a line that is not a comment that actually has content
+		scanner := bufio.NewScanner(fd)
-	// on it. Keep appending the comments until that time.
+		// Scan until we hit a line that is not a comment that actually has content
-	for scanner.Scan() {
+		// on it. Keep appending the comments until that time.
-		text := scanner.Bytes()
+		for scanner.Scan() {
-		if len(text) > 0 && text[0] != '#' {
+			text := scanner.Text()
-			break
+			if len(text) > 0 && text[0] != '#' {
+				break
+			}
+			s.WriteString(text + "\n")
+		}
+		_ = fd.Close()
+		if err := scanner.Err(); err != nil {
+			return errors.WithStackIf(err)
 		}
-		s.Write(text)
-		s.WriteByte('\n')
-	}
-	if err := scanner.Err(); err != nil {
-		return errors.WithStackIf(err)
 	}
 
-	p, err := properties.Load(b, properties.UTF8)
+	p, err := properties.LoadFile(path, properties.UTF8)
 	if err != nil {
 		return errors.Wrap(err, "parser: could not load properties file for configuration update")
 	}
@@ -578,16 +563,17 @@ func (f *ConfigurationFile) parsePropertiesFile(file ufs.File) error {
 		s.WriteString(key + "=" + strings.Trim(strconv.QuoteToASCII(value), "\"") + "\n")
 	}
 
-	if _, err := file.Seek(0, io.SeekStart); err != nil {
+	// Open the file for writing.
-		return err
+	w, err := os.OpenFile(path, os.O_CREATE|os.O_WRONLY|os.O_TRUNC, 0o644)
-	}
+	if err != nil {
-	if err := file.Truncate(0); err != nil {
 		return err
 	}
+	defer w.Close()
 
 	// Write the data to the file.
-	if _, err := io.Copy(file, s); err != nil {
+	if _, err := w.Write([]byte(s.String())); err != nil {
 		return errors.Wrap(err, "parser: failed to write properties file to disk")
 	}
+
 	return nil
 }

remote/http.go

@@ -29,7 +29,7 @@ type Client interface {
 	SetArchiveStatus(ctx context.Context, uuid string, successful bool) error
 	SetBackupStatus(ctx context.Context, backup string, data BackupRequest) error
 	SendRestorationStatus(ctx context.Context, backup string, successful bool) error
-	SetInstallationStatus(ctx context.Context, uuid string, data InstallStatusRequest) error
+	SetInstallationStatus(ctx context.Context, uuid string, successful bool) error
 	SetTransferStatus(ctx context.Context, uuid string, successful bool) error
 	ValidateSftpCredentials(ctx context.Context, request SftpAuthRequest) (SftpAuthResponse, error)
 	SendActivityLogs(ctx context.Context, activity []models.Activity) error

remote/servers.go

@@ -19,7 +19,7 @@ const (
 	ProcessStopNativeStop = "stop"
 )
 
-// GetServers returns all the servers that are present on the Panel making
+// GetServers returns all of the servers that are present on the Panel making
 // parallel API calls to the endpoint if more than one page of servers is
 // returned.
 func (c *client) GetServers(ctx context.Context, limit int) ([]RawServerData, error) {
@@ -58,7 +58,7 @@ func (c *client) GetServers(ctx context.Context, limit int) ([]RawServerData, er
 //
 // This handles Wings exiting during either of these processes which will leave
 // things in a bad state within the Panel. This API call is executed once Wings
-// has fully booted all the servers.
+// has fully booted all of the servers.
 func (c *client) ResetServersState(ctx context.Context) error {
 	res, err := c.Post(ctx, "/servers/reset", nil)
 	if err != nil {
@@ -92,8 +92,8 @@ func (c *client) GetInstallationScript(ctx context.Context, uuid string) (Instal
 	return config, err
 }
 
-func (c *client) SetInstallationStatus(ctx context.Context, uuid string, data InstallStatusRequest) error {
+func (c *client) SetInstallationStatus(ctx context.Context, uuid string, successful bool) error {
-	resp, err := c.Post(ctx, fmt.Sprintf("/servers/%s/install", uuid), data)
+	resp, err := c.Post(ctx, fmt.Sprintf("/servers/%s/install", uuid), d{"successful": successful})
 	if err != nil {
 		return err
 	}
@@ -115,7 +115,7 @@ func (c *client) SetTransferStatus(ctx context.Context, uuid string, successful
 	if successful {
 		state = "success"
 	}
-	resp, err := c.Post(ctx, fmt.Sprintf("/servers/%s/transfer/%s", uuid, state), nil)
+	resp, err := c.Get(ctx, fmt.Sprintf("/servers/%s/transfer/%s", uuid, state), nil)
 	if err != nil {
 		return err
 	}
@@ -127,7 +127,7 @@ func (c *client) SetTransferStatus(ctx context.Context, uuid string, successful
 // password combination provided is associated with a valid server on the instance
 // using the Panel's authentication control mechanisms. This will get itself
 // throttled if too many requests are made, allowing us to completely offload
-// all the authorization security logic to the Panel.
+// all of the authorization security logic to the Panel.
 func (c *client) ValidateSftpCredentials(ctx context.Context, request SftpAuthRequest) (SftpAuthResponse, error) {
 	var auth SftpAuthResponse
 	res, err := c.Post(ctx, "/sftp/auth", request)

remote/types.go

@@ -92,8 +92,8 @@ type SftpAuthResponse struct {
 }
 
 type OutputLineMatcher struct {
-	// raw string to match against. This may or may not be prefixed with
+	// The raw string to match against. This may or may not be prefixed with
-	// `regex:` which indicates we want to match against the regex expression.
+	// regex: which indicates we want to match against the regex expression.
 	raw []byte
 	reg *regexp.Regexp
 }
@@ -139,9 +139,9 @@ type ProcessStopConfiguration struct {
 }
 
 // ProcessConfiguration defines the process configuration for a given server
-// instance. This sets what Wings is looking for to mark a server as done
+// instance. This sets what Wings is looking for to mark a server as done starting
-// starting what to do when stopping, and what changes to make to the
+// what to do when stopping, and what changes to make to the configuration file
-// configuration file for a server.
+// for a server.
 type ProcessConfiguration struct {
 	Startup struct {
 		Done            []*OutputLineMatcher `json:"done"`
@@ -169,8 +169,3 @@ type BackupRequest struct {
 	Successful   bool         `json:"successful"`
 	Parts        []BackupPart `json:"parts"`
 }
-
-type InstallStatusRequest struct {
-	Successful bool `json:"successful"`
-	Reinstall  bool `json:"reinstall"`
-}

router/downloader/downloader.go

@@ -20,58 +20,20 @@ import (
 	"github.com/pterodactyl/wings/server"
 )
 
-var client *http.Client
+var client = &http.Client{
-
+	Timeout: time.Hour * 12,
-func init() {
+	// Disallow any redirect on an HTTP call. This is a security requirement: do not modify
-	dialer := &net.Dialer{
+	// this logic without first ensuring that the new target location IS NOT within the current
-		LocalAddr: nil,
+	// instance's local network.
-	}
+	//
-
+	// This specific error response just causes the client to not follow the redirect and
-	trnspt := http.DefaultTransport.(*http.Transport).Clone()
+	// returns the actual redirect response to the caller. Not perfect, but simple and most
-	trnspt.DialContext = func(ctx context.Context, network, addr string) (net.Conn, error) {
+	// people won't be using URLs that redirect anyways hopefully?
-		c, err := dialer.DialContext(ctx, network, addr)
+	//
-		if err != nil {
+	// We'll re-evaluate this down the road if needed.
-			return nil, errors.WithStack(err)
+	CheckRedirect: func(req *http.Request, via []*http.Request) error {
-		}
+		return http.ErrUseLastResponse
-
+	},
-		ipStr, _, err := net.SplitHostPort(c.RemoteAddr().String())
-		if err != nil {
-			return c, errors.WithStack(err)
-		}
-		ip := net.ParseIP(ipStr)
-		if ip == nil {
-			return c, errors.WithStack(ErrInvalidIPAddress)
-		}
-		if ip.IsLoopback() || ip.IsLinkLocalUnicast() || ip.IsLinkLocalMulticast() || ip.IsInterfaceLocalMulticast() {
-			return c, errors.WithStack(ErrInternalResolution)
-		}
-		for _, block := range internalRanges {
-			if !block.Contains(ip) {
-				continue
-			}
-			return c, errors.WithStack(ErrInternalResolution)
-		}
-		return c, nil
-	}
-
-	client = &http.Client{
-		Timeout: time.Hour * 12,
-
-		Transport: trnspt,
-
-		// Disallow any redirect on an HTTP call. This is a security requirement: do not modify
-		// this logic without first ensuring that the new target location IS NOT within the current
-		// instance's local network.
-		//
-		// This specific error response just causes the client to not follow the redirect and
-		// returns the actual redirect response to the caller. Not perfect, but simple and most
-		// people won't be using URLs that redirect anyways hopefully?
-		//
-		// We'll re-evaluate this down the road if needed.
-		CheckRedirect: func(req *http.Request, via []*http.Request) error {
-			return http.ErrUseLastResponse
-		},
-	}
 }
 
 var instance = &Downloader{
@@ -181,6 +143,12 @@ func (dl *Download) Execute() error {
 	dl.cancelFunc = &cancel
 	defer dl.Cancel()
 
+	// Always ensure that we're checking the destination for the download to avoid a malicious
+	// user from accessing internal network resources.
+	if err := dl.isExternalNetwork(ctx); err != nil {
+		return err
+	}
+
 	// At this point we have verified the destination is not within the local network, so we can
 	// now make a request to that URL and pull down the file, saving it to the server's data
 	// directory.
@@ -199,8 +167,13 @@ func (dl *Download) Execute() error {
 		return errors.New("downloader: got bad response status from endpoint: " + res.Status)
 	}
 
-	if res.ContentLength < 1 {
+	// If there is a Content-Length header on this request go ahead and check that we can
-		return errors.New("downloader: request is missing ContentLength")
+	// even write the whole file before beginning this process. If there is no header present
+	// we'll just have to give it a spin and see how it goes.
+	if res.ContentLength > 0 {
+		if err := dl.server.Filesystem().HasSpaceFor(res.ContentLength); err != nil {
+			return errors.WrapIf(err, "downloader: failed to write file: not enough space")
+		}
 	}
 
 	if dl.req.UseHeader {
@@ -227,10 +200,8 @@ func (dl *Download) Execute() error {
 	p := dl.Path()
 	dl.server.Log().WithField("path", p).Debug("writing remote file to disk")
 
-	// Write the file while tracking the progress, Write will check that the
-	// size of the file won't exceed the disk limit.
 	r := io.TeeReader(res.Body, dl.counter(res.ContentLength))
-	if err := dl.server.Filesystem().Write(p, r, res.ContentLength, 0o644); err != nil {
+	if err := dl.server.Filesystem().Writefile(p, r); err != nil {
 		return errors.WrapIf(err, "downloader: failed to write file to server directory")
 	}
 	return nil
@@ -275,6 +246,59 @@ func (dl *Download) counter(contentLength int64) *Counter {
 	}
 }
 
+// Verifies that a given download resolves to a location not within the current local
+// network for the machine. If the final destination of a resource is within the local
+// network an ErrInternalResolution error is returned.
+func (dl *Download) isExternalNetwork(ctx context.Context) error {
+	dialer := &net.Dialer{
+		LocalAddr: nil,
+	}
+
+	host := dl.req.URL.Host
+
+	// This cluster-fuck of math and integer shit converts an integer IP into a proper IPv4.
+	// For example: 16843009 would become 1.1.1.1
+	//if i, err := strconv.ParseInt(host, 10, 64); err == nil {
+	//	host = strconv.FormatInt((i>>24)&0xFF, 10) + "." + strconv.FormatInt((i>>16)&0xFF, 10) + "." + strconv.FormatInt((i>>8)&0xFF, 10) + "." + strconv.FormatInt(i&0xFF, 10)
+	//}
+
+	if _, _, err := net.SplitHostPort(host); err != nil {
+		if !strings.Contains(err.Error(), "missing port in address") {
+			return errors.WithStack(err)
+		}
+		switch dl.req.URL.Scheme {
+		case "http":
+			host += ":80"
+		case "https":
+			host += ":443"
+		}
+	}
+
+	c, err := dialer.DialContext(ctx, "tcp", host)
+	if err != nil {
+		return errors.WithStack(err)
+	}
+	_ = c.Close()
+
+	ipStr, _, err := net.SplitHostPort(c.RemoteAddr().String())
+	if err != nil {
+		return errors.WithStack(err)
+	}
+	ip := net.ParseIP(ipStr)
+	if ip == nil {
+		return errors.WithStack(ErrInvalidIPAddress)
+	}
+	if ip.IsLoopback() || ip.IsLinkLocalUnicast() || ip.IsLinkLocalMulticast() || ip.IsInterfaceLocalMulticast() {
+		return errors.WithStack(ErrInternalResolution)
+	}
+	for _, block := range internalRanges {
+		if block.Contains(ip) {
+			return errors.WithStack(ErrInternalResolution)
+		}
+	}
+	return nil
+}
+
 // Downloader represents a global downloader that keeps track of all currently processing downloads
 // for the machine.
 type Downloader struct {

router/error.go

@@ -0,0 +1,157 @@
+package router
+
+import (
+	"fmt"
+	"net/http"
+	"os"
+	"strings"
+
+	"emperror.dev/errors"
+	"github.com/apex/log"
+	"github.com/gin-gonic/gin"
+	"github.com/google/uuid"
+
+	"github.com/pterodactyl/wings/server"
+	"github.com/pterodactyl/wings/server/filesystem"
+)
+
+type RequestError struct {
+	err     error
+	uuid    string
+	message string
+	server  *server.Server
+}
+
+// Attaches an error to the gin.Context object for the request and ensures that it
+// has a proper stacktrace associated with it when doing so.
+//
+// If you just call c.Error(err) without using this function you'll likely end up
+// with an error that has no annotated stack on it.
+func WithError(c *gin.Context, err error) error {
+	return c.Error(errors.WithStackDepthIf(err, 1))
+}
+
+// Generates a new tracked error, which simply tracks the specific error that
+// is being passed in, and also assigned a UUID to the error so that it can be
+// cross referenced in the logs.
+func NewTrackedError(err error) *RequestError {
+	return &RequestError{
+		err:  err,
+		uuid: uuid.Must(uuid.NewRandom()).String(),
+	}
+}
+
+// Same as NewTrackedError, except this will also attach the server instance that
+// generated this server for the purposes of logging.
+func NewServerError(err error, s *server.Server) *RequestError {
+	return &RequestError{
+		err:    err,
+		uuid:   uuid.Must(uuid.NewRandom()).String(),
+		server: s,
+	}
+}
+
+func (e *RequestError) logger() *log.Entry {
+	if e.server != nil {
+		return e.server.Log().WithField("error_id", e.uuid).WithField("error", e.err)
+	}
+	return log.WithField("error_id", e.uuid).WithField("error", e.err)
+}
+
+// Sets the output message to display to the user in the error.
+func (e *RequestError) SetMessage(msg string) *RequestError {
+	e.message = msg
+	return e
+}
+
+// Aborts the request with the given status code, and responds with the error. This
+// will also include the error UUID in the output so that the user can report that
+// and link the response to a specific error in the logs.
+func (e *RequestError) AbortWithStatus(status int, c *gin.Context) {
+	// In instances where the status has already been set just use that existing status
+	// since we cannot change it at this point, and trying to do so will emit a gin warning
+	// into the program output.
+	if c.Writer.Status() != 200 {
+		status = c.Writer.Status()
+	}
+
+	// If this error is because the resource does not exist, we likely do not need to log
+	// the error anywhere, just return a 404 and move on with our lives.
+	if errors.Is(e.err, os.ErrNotExist) {
+		c.AbortWithStatusJSON(http.StatusNotFound, gin.H{
+			"error": "The requested resource was not found on the system.",
+		})
+		return
+	}
+
+	if strings.HasPrefix(e.err.Error(), "invalid URL escape") {
+		c.AbortWithStatusJSON(http.StatusBadRequest, gin.H{
+			"error": "Some of the data provided in the request appears to be escaped improperly.",
+		})
+		return
+	}
+
+	// If this is a Filesystem error just return it without all of the tracking code nonsense
+	// since we don't need to be logging it into the logs or anything, its just a normal error
+	// that the user can solve on their end.
+	if st, msg := e.getAsFilesystemError(); st != 0 {
+		c.AbortWithStatusJSON(st, gin.H{"error": msg})
+		return
+	}
+
+	// Otherwise, log the error to zap, and then report the error back to the user.
+	if status >= 500 {
+		e.logger().Error("unexpected error while handling HTTP request")
+	} else {
+		e.logger().Debug("non-server error encountered while handling HTTP request")
+	}
+
+	if e.message == "" {
+		e.message = "An unexpected error was encountered while processing this request."
+	}
+
+	c.AbortWithStatusJSON(status, gin.H{"error": e.message, "error_id": e.uuid})
+}
+
+// Helper function to just abort with an internal server error. This is generally the response
+// from most errors encountered by the API.
+func (e *RequestError) Abort(c *gin.Context) {
+	e.AbortWithStatus(http.StatusInternalServerError, c)
+}
+
+// Looks at the given RequestError and determines if it is a specific filesystem error that
+// we can process and return differently for the user.
+func (e *RequestError) getAsFilesystemError() (int, string) {
+	// Some external things end up calling fmt.Errorf() on our filesystem errors
+	// which ends up just unleashing chaos on the system. For the sake of this
+	// fallback to using text checks...
+	if filesystem.IsErrorCode(e.err, filesystem.ErrCodeDenylistFile) || strings.Contains(e.err.Error(), "filesystem: file access prohibited") {
+		return http.StatusForbidden, "This file cannot be modified: present in egg denylist."
+	}
+	if filesystem.IsErrorCode(e.err, filesystem.ErrCodePathResolution) || strings.Contains(e.err.Error(), "resolves to a location outside the server root") {
+		return http.StatusNotFound, "The requested resource was not found on the system."
+	}
+	if filesystem.IsErrorCode(e.err, filesystem.ErrCodeIsDirectory) || strings.Contains(e.err.Error(), "filesystem: is a directory") {
+		return http.StatusBadRequest, "Cannot perform that action: file is a directory."
+	}
+	if filesystem.IsErrorCode(e.err, filesystem.ErrCodeDiskSpace) || strings.Contains(e.err.Error(), "filesystem: not enough disk space") {
+		return http.StatusBadRequest, "Cannot perform that action: not enough disk space available."
+	}
+	if strings.HasSuffix(e.err.Error(), "file name too long") {
+		return http.StatusBadRequest, "Cannot perform that action: file name is too long."
+	}
+	if e, ok := e.err.(*os.SyscallError); ok && e.Syscall == "readdirent" {
+		return http.StatusNotFound, "The requested directory does not exist."
+	}
+	return 0, ""
+}
+
+// Handle specific filesystem errors for a server.
+func (e *RequestError) AbortFilesystemError(c *gin.Context) {
+	e.Abort(c)
+}
+
+// Format the error to a string and include the UUID.
+func (e *RequestError) Error() string {
+	return fmt.Sprintf("%v (uuid: %s)", e.err, e.uuid)
+}

router/middleware/middleware.go

@@ -1,9 +1,11 @@
 package middleware
 
 import (
+	"context"
 	"crypto/subtle"
 	"io"
 	"net/http"
+	"os"
 	"strings"
 
 	"emperror.dev/errors"
@@ -14,8 +16,133 @@ import (
 	"github.com/pterodactyl/wings/config"
 	"github.com/pterodactyl/wings/remote"
 	"github.com/pterodactyl/wings/server"
+	"github.com/pterodactyl/wings/server/filesystem"
 )
 
+// RequestError is a custom error type returned when something goes wrong with
+// any of the HTTP endpoints.
+type RequestError struct {
+	err    error
+	status int
+	msg    string
+}
+
+// NewError returns a new RequestError for the provided error.
+func NewError(err error) *RequestError {
+	return &RequestError{
+		// Attach a stacktrace to the error if it is missing at this point and mark it
+		// as originating from the location where NewError was called, rather than this
+		// specific point in the code.
+		err: errors.WithStackDepthIf(err, 1),
+	}
+}
+
+// SetMessage allows for a custom error message to be set on an existing
+// RequestError instance.
+func (re *RequestError) SetMessage(m string) {
+	re.msg = m
+}
+
+// SetStatus sets the HTTP status code for the error response. By default this
+// is a HTTP-500 error.
+func (re *RequestError) SetStatus(s int) {
+	re.status = s
+}
+
+// Abort aborts the given HTTP request with the specified status code and then
+// logs the event into the logs. The error that is output will include the unique
+// request ID if it is present.
+func (re *RequestError) Abort(c *gin.Context, status int) {
+	reqId := c.Writer.Header().Get("X-Request-Id")
+
+	// Generate the base logger instance, attaching the unique request ID and
+	// the URL that was requested.
+	event := log.WithField("request_id", reqId).WithField("url", c.Request.URL.String())
+	// If there is a server present in the gin.Context stack go ahead and pull it
+	// and attach that server UUID to the logs as well so that we can see what specific
+	// server triggered this error.
+	if s, ok := c.Get("server"); ok {
+		if s, ok := s.(*server.Server); ok {
+			event = event.WithField("server_id", s.ID())
+		}
+	}
+
+	if c.Writer.Status() == 200 {
+		// Handle context deadlines being exceeded a little differently since we want
+		// to report a more user-friendly error and a proper error code. The "context
+		// canceled" error is generally when a request is terminated before all of the
+		// logic is finished running.
+		if errors.Is(re.err, context.DeadlineExceeded) {
+			re.SetStatus(http.StatusGatewayTimeout)
+			re.SetMessage("The server could not process this request in time, please try again.")
+		} else if strings.Contains(re.Cause().Error(), "context canceled") {
+			re.SetStatus(http.StatusBadRequest)
+			re.SetMessage("Request aborted by client.")
+		}
+	}
+
+	// c.Writer.Status() will be a non-200 value if the headers have already been sent
+	// to the requester but an error is encountered. This can happen if there is an issue
+	// marshaling a struct placed into a c.JSON() call (or c.AbortWithJSON() call).
+	if status >= 500 || c.Writer.Status() != 200 {
+		event.WithField("status", status).WithField("error", re.err).Error("error while handling HTTP request")
+	} else {
+		event.WithField("status", status).WithField("error", re.err).Debug("error handling HTTP request (not a server error)")
+	}
+	if re.msg == "" {
+		re.msg = "An unexpected error was encountered while processing this request"
+	}
+	// Now abort the request with the error message and include the unique request
+	// ID that was present to make things super easy on people who don't know how
+	// or cannot view the response headers (where X-Request-Id would be present).
+	c.AbortWithStatusJSON(status, gin.H{"error": re.msg, "request_id": reqId})
+}
+
+// Cause returns the underlying error.
+func (re *RequestError) Cause() error {
+	return re.err
+}
+
+// Error returns the underlying error message for this request.
+func (re *RequestError) Error() string {
+	return re.err.Error()
+}
+
+// Looks at the given RequestError and determines if it is a specific filesystem
+// error that we can process and return differently for the user.
+//
+// Some external things end up calling fmt.Errorf() on our filesystem errors
+// which ends up just unleashing chaos on the system. For the sake of this,
+// fallback to using text checks.
+//
+// If the error passed into this call is nil or does not match empty values will
+// be returned to the caller.
+func (re *RequestError) asFilesystemError() (int, string) {
+	err := re.Cause()
+	if err == nil {
+		return 0, ""
+	}
+	if filesystem.IsErrorCode(err, filesystem.ErrCodeDenylistFile) || strings.Contains(err.Error(), "filesystem: file access prohibited") {
+		return http.StatusForbidden, "This file cannot be modified: present in egg denylist."
+	}
+	if filesystem.IsErrorCode(err, filesystem.ErrCodePathResolution) || strings.Contains(err.Error(), "resolves to a location outside the server root") {
+		return http.StatusNotFound, "The requested resource was not found on the system."
+	}
+	if filesystem.IsErrorCode(err, filesystem.ErrCodeIsDirectory) || strings.Contains(err.Error(), "filesystem: is a directory") {
+		return http.StatusBadRequest, "Cannot perform that action: file is a directory."
+	}
+	if filesystem.IsErrorCode(err, filesystem.ErrCodeDiskSpace) || strings.Contains(err.Error(), "filesystem: not enough disk space") {
+		return http.StatusBadRequest, "There is not enough disk space available to perform that action."
+	}
+	if strings.HasSuffix(err.Error(), "file name too long") {
+		return http.StatusBadRequest, "Cannot perform that action: file name is too long."
+	}
+	if e, ok := err.(*os.SyscallError); ok && e.Syscall == "readdirent" {
+		return http.StatusNotFound, "The requested directory does not exist."
+	}
+	return 0, ""
+}
+
 // AttachRequestID attaches a unique ID to the incoming HTTP request so that any
 // errors that are generated or returned to the client will include this reference
 // allowing for an easier time identifying the specific request that failed for
@@ -53,7 +180,7 @@ func AttachApiClient(client remote.Client) gin.HandlerFunc {
 }
 
 // CaptureAndAbort aborts the request and attaches the provided error to the gin
-// context, so it can be reported properly. If the error is missing a stacktrace
+// context so it can be reported properly. If the error is missing a stacktrace
 // at the time it is called the stack will be attached.
 func CaptureAndAbort(c *gin.Context, err error) {
 	c.Abort()

router/middleware/request_error.go

@@ -1,141 +0,0 @@
-package middleware
-
-import (
-	"context"
-	"net/http"
-	"os"
-	"strings"
-
-	"emperror.dev/errors"
-	"github.com/apex/log"
-	"github.com/gin-gonic/gin"
-
-	"github.com/pterodactyl/wings/server"
-	"github.com/pterodactyl/wings/server/filesystem"
-)
-
-// RequestError is a custom error type returned when something goes wrong with
-// any of the HTTP endpoints.
-type RequestError struct {
-	err    error
-	status int
-	msg    string
-}
-
-// NewError returns a new RequestError for the provided error.
-func NewError(err error) *RequestError {
-	return &RequestError{
-		// Attach a stacktrace to the error if it is missing at this point and mark it
-		// as originating from the location where NewError was called, rather than this
-		// specific point in the code.
-		err: errors.WithStackDepthIf(err, 1),
-	}
-}
-
-// SetMessage allows for a custom error message to be set on an existing
-// RequestError instance.
-func (re *RequestError) SetMessage(m string) {
-	re.msg = m
-}
-
-// SetStatus sets the HTTP status code for the error response. By default this
-// is a HTTP-500 error.
-func (re *RequestError) SetStatus(s int) {
-	re.status = s
-}
-
-// Abort aborts the given HTTP request with the specified status code and then
-// logs the event into the logs. The error that is output will include the unique
-// request ID if it is present.
-func (re *RequestError) Abort(c *gin.Context, status int) {
-	reqId := c.Writer.Header().Get("X-Request-Id")
-
-	// Generate the base logger instance, attaching the unique request ID and
-	// the URL that was requested.
-	event := log.WithField("request_id", reqId).WithField("url", c.Request.URL.String())
-	// If there is a server present in the gin.Context stack go ahead and pull it
-	// and attach that server UUID to the logs as well so that we can see what specific
-	// server triggered this error.
-	if s, ok := c.Get("server"); ok {
-		if s, ok := s.(*server.Server); ok {
-			event = event.WithField("server_id", s.ID())
-		}
-	}
-
-	if c.Writer.Status() == 200 {
-		// Handle context deadlines being exceeded a little differently since we want
-		// to report a more user-friendly error and a proper error code. The "context
-		// canceled" error is generally when a request is terminated before all of the
-		// logic is finished running.
-		if errors.Is(re.err, context.DeadlineExceeded) {
-			re.SetStatus(http.StatusGatewayTimeout)
-			re.SetMessage("The server could not process this request in time, please try again.")
-		} else if strings.Contains(re.Cause().Error(), "context canceled") {
-			re.SetStatus(http.StatusBadRequest)
-			re.SetMessage("Request aborted by client.")
-		}
-	}
-
-	// c.Writer.Status() will be a non-200 value if the headers have already been sent
-	// to the requester but an error is encountered. This can happen if there is an issue
-	// marshaling a struct placed into a c.JSON() call (or c.AbortWithJSON() call).
-	if status >= 500 || c.Writer.Status() != 200 {
-		event.WithField("status", status).WithField("error", re.err).Error("error while handling HTTP request")
-	} else {
-		event.WithField("status", status).WithField("error", re.err).Debug("error handling HTTP request (not a server error)")
-	}
-	if re.msg == "" {
-		re.msg = "An unexpected error was encountered while processing this request"
-	}
-	// Now abort the request with the error message and include the unique request
-	// ID that was present to make things super easy on people who don't know how
-	// or cannot view the response headers (where X-Request-Id would be present).
-	c.AbortWithStatusJSON(status, gin.H{"error": re.msg, "request_id": reqId})
-}
-
-// Cause returns the underlying error.
-func (re *RequestError) Cause() error {
-	return re.err
-}
-
-// Error returns the underlying error message for this request.
-func (re *RequestError) Error() string {
-	return re.err.Error()
-}
-
-// Looks at the given RequestError and determines if it is a specific filesystem
-// error that we can process and return differently for the user.
-//
-// Some external things end up calling fmt.Errorf() on our filesystem errors
-// which ends up just unleashing chaos on the system. For the sake of this,
-// fallback to using text checks.
-//
-// If the error passed into this call is nil or does not match empty values will
-// be returned to the caller.
-func (re *RequestError) asFilesystemError() (int, string) {
-	err := re.Cause()
-	if err == nil {
-		return 0, ""
-	}
-	if filesystem.IsErrorCode(err, filesystem.ErrNotExist) ||
-		filesystem.IsErrorCode(err, filesystem.ErrCodePathResolution) ||
-		strings.Contains(err.Error(), "resolves to a location outside the server root") {
-		return http.StatusNotFound, "The requested resources was not found on the system."
-	}
-	if filesystem.IsErrorCode(err, filesystem.ErrCodeDenylistFile) || strings.Contains(err.Error(), "filesystem: file access prohibited") {
-		return http.StatusForbidden, "This file cannot be modified: present in egg denylist."
-	}
-	if filesystem.IsErrorCode(err, filesystem.ErrCodeIsDirectory) || strings.Contains(err.Error(), "filesystem: is a directory") {
-		return http.StatusBadRequest, "Cannot perform that action: file is a directory."
-	}
-	if filesystem.IsErrorCode(err, filesystem.ErrCodeDiskSpace) || strings.Contains(err.Error(), "filesystem: not enough disk space") {
-		return http.StatusBadRequest, "There is not enough disk space available to perform that action."
-	}
-	if strings.HasSuffix(err.Error(), "file name too long") {
-		return http.StatusBadRequest, "Cannot perform that action: file name is too long."
-	}
-	if e, ok := err.(*os.SyscallError); ok && e.Syscall == "readdirent" {
-		return http.StatusNotFound, "The requested directory does not exist."
-	}
-	return 0, ""
-}

router/router.go

@@ -1,7 +1,6 @@
 package router
 
 import (
-	"emperror.dev/errors"
 	"github.com/apex/log"
 	"github.com/gin-gonic/gin"
 
@@ -17,10 +16,7 @@ func Configure(m *wserver.Manager, client remote.Client) *gin.Engine {
 
 	router := gin.New()
 	router.Use(gin.Recovery())
-	if err := router.SetTrustedProxies(config.Get().Api.TrustedProxies); err != nil {
+	_ = router.SetTrustedProxies(config.Get().Api.TrustedProxies)
-		panic(errors.WithStack(err))
-		return nil
-	}
 	router.Use(middleware.AttachRequestID(), middleware.CaptureErrors(), middleware.SetAccessControlHeaders())
 	router.Use(middleware.AttachServerManager(m), middleware.AttachApiClient(client))
 	// @todo log this into a different file so you can setup IP blocking for abusive requests and such.

router/router_download.go

@@ -8,7 +8,6 @@ import (
 	"strconv"
 
 	"github.com/gin-gonic/gin"
-	"github.com/google/uuid"
 
 	"github.com/pterodactyl/wings/router/middleware"
 	"github.com/pterodactyl/wings/router/tokens"
@@ -20,64 +19,9 @@ func getDownloadBackup(c *gin.Context) {
 	client := middleware.ExtractApiClient(c)
 	manager := middleware.ExtractManager(c)
 
-	// Get the payload from the token.
 	token := tokens.BackupPayload{}
 	if err := tokens.ParseToken([]byte(c.Query("token")), &token); err != nil {
-		middleware.CaptureAndAbort(c, err)
+		NewTrackedError(err).Abort(c)
-		return
-	}
-
-	// Get the server using the UUID from the token.
-	if _, ok := manager.Get(token.ServerUuid); !ok || !token.IsUniqueRequest() {
-		c.AbortWithStatusJSON(http.StatusNotFound, gin.H{
-			"error": "The requested resource was not found on this server.",
-		})
-		return
-	}
-
-	// Validate that the BackupUuid field is actually a UUID and not some random characters or a
-	// file path.
-	if _, err := uuid.Parse(token.BackupUuid); err != nil {
-		middleware.CaptureAndAbort(c, err)
-		return
-	}
-
-	// Locate the backup on the local disk.
-	b, st, err := backup.LocateLocal(client, token.BackupUuid)
-	if err != nil {
-		if errors.Is(err, os.ErrNotExist) {
-			c.AbortWithStatusJSON(http.StatusNotFound, gin.H{
-				"error": "The requested backup was not found on this server.",
-			})
-			return
-		}
-
-		middleware.CaptureAndAbort(c, err)
-		return
-	}
-
-	// The use of `os` here is safe as backups are not stored within server
-	// accessible directories.
-	f, err := os.Open(b.Path())
-	if err != nil {
-		middleware.CaptureAndAbort(c, err)
-		return
-	}
-	defer f.Close()
-
-	c.Header("Content-Length", strconv.Itoa(int(st.Size())))
-	c.Header("Content-Disposition", "attachment; filename="+strconv.Quote(st.Name()))
-	c.Header("Content-Type", "application/octet-stream")
-
-	_, _ = bufio.NewReader(f).WriteTo(c.Writer)
-}
-
-// Handles downloading a specific file for a server.
-func getDownloadFile(c *gin.Context) {
-	manager := middleware.ExtractManager(c)
-	token := tokens.FilePayload{}
-	if err := tokens.ParseToken([]byte(c.Query("token")), &token); err != nil {
-		middleware.CaptureAndAbort(c, err)
 		return
 	}
 
@@ -89,22 +33,73 @@ func getDownloadFile(c *gin.Context) {
 		return
 	}
 
-	f, st, err := s.Filesystem().File(token.FilePath)
+	b, st, err := backup.LocateLocal(client, token.BackupUuid)
 	if err != nil {
-		middleware.CaptureAndAbort(c, err)
+		if errors.Is(err, os.ErrNotExist) {
+			c.AbortWithStatusJSON(http.StatusNotFound, gin.H{
+				"error": "The requested backup was not found on this server.",
+			})
+			return
+		}
+
+		NewServerError(err, s).Abort(c)
+		return
+	}
+
+	f, err := os.Open(b.Path())
+	if err != nil {
+		NewServerError(err, s).Abort(c)
 		return
 	}
 	defer f.Close()
-	if st.IsDir() {
+
+	c.Header("Content-Length", strconv.Itoa(int(st.Size())))
+	c.Header("Content-Disposition", "attachment; filename="+strconv.Quote(st.Name()))
+	c.Header("Content-Type", "application/octet-stream")
+
+	bufio.NewReader(f).WriteTo(c.Writer)
+}
+
+// Handles downloading a specific file for a server.
+func getDownloadFile(c *gin.Context) {
+	manager := middleware.ExtractManager(c)
+	token := tokens.FilePayload{}
+	if err := tokens.ParseToken([]byte(c.Query("token")), &token); err != nil {
+		NewTrackedError(err).Abort(c)
+		return
+	}
+
+	s, ok := manager.Get(token.ServerUuid)
+	if !ok || !token.IsUniqueRequest() {
 		c.AbortWithStatusJSON(http.StatusNotFound, gin.H{
 			"error": "The requested resource was not found on this server.",
 		})
 		return
 	}
 
+	p, _ := s.Filesystem().SafePath(token.FilePath)
+	st, err := os.Stat(p)
+	// If there is an error or we're somehow trying to download a directory, just
+	// respond with the appropriate error.
+	if err != nil {
+		NewServerError(err, s).Abort(c)
+		return
+	} else if st.IsDir() {
+		c.AbortWithStatusJSON(http.StatusNotFound, gin.H{
+			"error": "The requested resource was not found on this server.",
+		})
+		return
+	}
+
+	f, err := os.Open(p)
+	if err != nil {
+		NewServerError(err, s).Abort(c)
+		return
+	}
+
 	c.Header("Content-Length", strconv.Itoa(int(st.Size())))
 	c.Header("Content-Disposition", "attachment; filename="+strconv.Quote(st.Name()))
 	c.Header("Content-Type", "application/octet-stream")
 
-	_, _ = bufio.NewReader(f).WriteTo(c.Writer)
+	bufio.NewReader(f).WriteTo(c.Writer)
 }

router/router_server.go

@@ -35,7 +35,7 @@ func getServerLogs(c *gin.Context) {
 
 	out, err := s.ReadLogfile(l)
 	if err != nil {
-		middleware.CaptureAndAbort(c, err)
+		NewServerError(err, s).Abort(c)
 		return
 	}
 
@@ -109,7 +109,7 @@ func postServerCommands(c *gin.Context) {
 	s := ExtractServer(c)
 
 	if running, err := s.Environment.IsRunning(c.Request.Context()); err != nil {
-		middleware.CaptureAndAbort(c, err)
+		NewServerError(err, s).Abort(c)
 		return
 	} else if !running {
 		c.AbortWithStatusJSON(http.StatusBadGateway, gin.H{
@@ -143,7 +143,7 @@ func postServerSync(c *gin.Context) {
 	s := ExtractServer(c)
 
 	if err := s.Sync(); err != nil {
-		middleware.CaptureAndAbort(c, err)
+		WithError(c, err)
 	} else {
 		c.Status(http.StatusNoContent)
 	}
@@ -153,15 +153,9 @@ func postServerSync(c *gin.Context) {
 func postServerInstall(c *gin.Context) {
 	s := ExtractServer(c)
 
-	go func(s *server.Server) {
+	go func(serv *server.Server) {
-		s.Log().Info("syncing server state with remote source before executing installation process")
+		if err := serv.Install(true); err != nil {
-		if err := s.Sync(); err != nil {
+			serv.Log().WithField("error", err).Error("failed to execute server installation process")
-			s.Log().WithField("error", err).Error("failed to sync server state with Panel")
-			return
-		}
-
-		if err := s.Install(); err != nil {
-			s.Log().WithField("error", err).Error("failed to execute server installation process")
 		}
 	}(s)
 
@@ -217,7 +211,7 @@ func deleteServer(c *gin.Context) {
 	// forcibly terminate it before removing the container, so we do not need to handle
 	// that here.
 	if err := s.Environment.Destroy(); err != nil {
-		middleware.CaptureAndAbort(c, err)
+		_ = WithError(c, err)
 		return
 	}
 
@@ -227,19 +221,19 @@ func deleteServer(c *gin.Context) {
 	//
 	// In addition, servers with large amounts of files can take some time to finish deleting,
 	// so we don't want to block the HTTP call while waiting on this.
-	go func(s *server.Server) {
+	go func(p string) {
-		fs := s.Filesystem()
-		p := fs.Path()
-		_ = fs.UnixFS().Close()
 		if err := os.RemoveAll(p); err != nil {
 			log.WithFields(log.Fields{"path": p, "error": err}).Warn("failed to remove server files during deletion process")
 		}
-	}(s)
+	}(s.Filesystem().Path())
 
 	middleware.ExtractManager(c).Remove(func(server *server.Server) bool {
 		return server.ID() == s.ID()
 	})
 
+	// Deallocate the reference to this server.
+	s = nil
+
 	c.Status(http.StatusNoContent)
 }
 

router/router_server_files.go

@@ -30,7 +30,7 @@ import (
 // getServerFileContents returns the contents of a file on the server.
 func getServerFileContents(c *gin.Context) {
 	s := middleware.ExtractServer(c)
-	p := strings.TrimLeft(c.Query("file"), "/")
+	p := "/" + strings.TrimLeft(c.Query("file"), "/")
 	f, st, err := s.Filesystem().File(p)
 	if err != nil {
 		middleware.CaptureAndAbort(c, err)
@@ -79,7 +79,7 @@ func getServerListDirectory(c *gin.Context) {
 	s := ExtractServer(c)
 	dir := c.Query("directory")
 	if stats, err := s.Filesystem().ListDirectory(dir); err != nil {
-		middleware.CaptureAndAbort(c, err)
+		WithError(c, err)
 	} else {
 		c.JSON(http.StatusOK, stats)
 	}
@@ -129,6 +129,7 @@ func putServerRenameFiles(c *gin.Context) {
 				}
 				if err := fs.Rename(pf, pt); err != nil {
 					// Return nil if the error is an is not exists.
+					// NOTE: os.IsNotExist() does not work if the error is wrapped.
 					if errors.Is(err, os.ErrNotExist) {
 						s.Log().WithField("error", err).
 							WithField("from_path", pf).
@@ -151,7 +152,7 @@ func putServerRenameFiles(c *gin.Context) {
 			return
 		}
 
-		middleware.CaptureAndAbort(c, err)
+		NewServerError(err, s).AbortFilesystemError(c)
 		return
 	}
 
@@ -171,11 +172,11 @@ func postServerCopyFile(c *gin.Context) {
 	}
 
 	if err := s.Filesystem().IsIgnored(data.Location); err != nil {
-		middleware.CaptureAndAbort(c, err)
+		NewServerError(err, s).Abort(c)
 		return
 	}
 	if err := s.Filesystem().Copy(data.Location); err != nil {
-		middleware.CaptureAndAbort(c, err)
+		NewServerError(err, s).AbortFilesystemError(c)
 		return
 	}
 
@@ -220,7 +221,7 @@ func postServerDeleteFiles(c *gin.Context) {
 	}
 
 	if err := g.Wait(); err != nil {
-		middleware.CaptureAndAbort(c, err)
+		NewServerError(err, s).Abort(c)
 		return
 	}
 
@@ -235,19 +236,10 @@ func postServerWriteFile(c *gin.Context) {
 	f = "/" + strings.TrimLeft(f, "/")
 
 	if err := s.Filesystem().IsIgnored(f); err != nil {
-		middleware.CaptureAndAbort(c, err)
+		NewServerError(err, s).Abort(c)
 		return
 	}
-
+	if err := s.Filesystem().Writefile(f, c.Request.Body); err != nil {
-	// A content length of -1 means the actual length is unknown.
-	if c.Request.ContentLength == -1 {
-		c.AbortWithStatusJSON(http.StatusBadRequest, gin.H{
-			"error": "Missing Content-Length",
-		})
-		return
-	}
-
-	if err := s.Filesystem().Write(f, c.Request.Body, c.Request.ContentLength, 0o644); err != nil {
 		if filesystem.IsErrorCode(err, filesystem.ErrCodeIsDirectory) {
 			c.AbortWithStatusJSON(http.StatusBadRequest, gin.H{
 				"error": "Cannot write file, name conflicts with an existing directory by the same name.",
@@ -255,7 +247,7 @@ func postServerWriteFile(c *gin.Context) {
 			return
 		}
 
-		middleware.CaptureAndAbort(c, err)
+		NewServerError(err, s).AbortFilesystemError(c)
 		return
 	}
 
@@ -302,12 +294,12 @@ func postServerPullRemoteFile(c *gin.Context) {
 			})
 			return
 		}
-		middleware.CaptureAndAbort(c, err)
+		WithError(c, err)
 		return
 	}
 
 	if err := s.Filesystem().HasSpaceErr(true); err != nil {
-		middleware.CaptureAndAbort(c, err)
+		WithError(c, err)
 		return
 	}
 	// Do not allow more than three simultaneous remote file downloads at one time.
@@ -346,13 +338,13 @@ func postServerPullRemoteFile(c *gin.Context) {
 	}
 
 	if err := download(); err != nil {
-		middleware.CaptureAndAbort(c, err)
+		NewServerError(err, s).Abort(c)
 		return
 	}
 
 	st, err := s.Filesystem().Stat(dl.Path())
 	if err != nil {
-		middleware.CaptureAndAbort(c, err)
+		NewServerError(err, s).AbortFilesystemError(c)
 		return
 	}
 	c.JSON(http.StatusOK, &st)
@@ -388,7 +380,7 @@ func postServerCreateDirectory(c *gin.Context) {
 			return
 		}
 
-		middleware.CaptureAndAbort(c, err)
+		NewServerError(err, s).Abort(c)
 		return
 	}
 
@@ -423,7 +415,7 @@ func postServerCompressFiles(c *gin.Context) {
 
 	f, err := s.Filesystem().CompressFiles(data.RootPath, data.Files)
 	if err != nil {
-		middleware.CaptureAndAbort(c, err)
+		NewServerError(err, s).AbortFilesystemError(c)
 		return
 	}
 
@@ -541,7 +533,7 @@ func postServerChmodFile(c *gin.Context) {
 			return
 		}
 
-		middleware.CaptureAndAbort(c, err)
+		NewServerError(err, s).AbortFilesystemError(c)
 		return
 	}
 
@@ -553,7 +545,7 @@ func postServerUploadFiles(c *gin.Context) {
 
 	token := tokens.UploadPayload{}
 	if err := tokens.ParseToken([]byte(c.Query("token")), &token); err != nil {
-		middleware.CaptureAndAbort(c, err)
+		NewTrackedError(err).Abort(c)
 		return
 	}
 
@@ -597,10 +589,16 @@ func postServerUploadFiles(c *gin.Context) {
 	}
 
 	for _, header := range headers {
+		p, err := s.Filesystem().SafePath(filepath.Join(directory, header.Filename))
+		if err != nil {
+			NewServerError(err, s).Abort(c)
+			return
+		}
+
 		// We run this in a different method so I can use defer without any of
 		// the consequences caused by calling it in a loop.
-		if err := handleFileUpload(filepath.Join(directory, header.Filename), s, header); err != nil {
+		if err := handleFileUpload(p, s, header); err != nil {
-			middleware.CaptureAndAbort(c, err)
+			NewServerError(err, s).Abort(c)
 			return
 		} else {
 			s.SaveActivity(s.NewRequestActivity(token.UserUuid, c.ClientIP()), server.ActivityFileUploaded, models.ActivityMeta{
@@ -621,8 +619,7 @@ func handleFileUpload(p string, s *server.Server, header *multipart.FileHeader)
 	if err := s.Filesystem().IsIgnored(p); err != nil {
 		return err
 	}
-
+	if err := s.Filesystem().Writefile(p, file); err != nil {
-	if err := s.Filesystem().Write(p, file, header.Size, 0o644); err != nil {
 		return err
 	}
 	return nil

router/router_server_transfer.go

@@ -6,7 +6,6 @@ import (
 	"strings"
 	"time"
 
-	"emperror.dev/errors"
 	"github.com/gin-gonic/gin"
 
 	"github.com/pterodactyl/wings/environment"
@@ -64,11 +63,11 @@ func postServerTransfer(c *gin.Context) {
 	if s.Environment.State() != environment.ProcessOfflineState {
 		if err := s.Environment.WaitForStop(
 			s.Context(),
-			time.Second*15,
+			time.Minute,
 			false,
 		); err != nil && !strings.Contains(strings.ToLower(err.Error()), "no such container") {
-			s.SetTransferring(false)
+			notifyPanelOfFailure()
-			middleware.CaptureAndAbort(c, errors.Wrap(err, "failed to stop server for transfer"))
+			s.Log().WithError(err).Error("failed to stop server for transfer")
 			return
 		}
 	}

router/router_server_ws.go

@@ -34,7 +34,7 @@ func getServerWebsocket(c *gin.Context) {
 
 	handler, err := websocket.GetHandler(s, c.Writer, c.Request, c)
 	if err != nil {
-		middleware.CaptureAndAbort(c, err)
+		NewServerError(err, s).Abort(c)
 		return
 	}
 	defer handler.Connection.Close()
@@ -58,7 +58,7 @@ func getServerWebsocket(c *gin.Context) {
 		case <-ctx.Done():
 			break
 		case <-s.Context().Done():
-			_ = handler.Connection.WriteControl(ws.CloseMessage, ws.FormatCloseMessage(ws.CloseGoingAway, "server deleted"), time.Now().Add(time.Second*5))
+			handler.Connection.WriteControl(ws.CloseMessage, ws.FormatCloseMessage(ws.CloseGoingAway, "server deleted"), time.Now().Add(time.Second*5))
 			break
 		}
 	}()
@@ -83,7 +83,7 @@ func getServerWebsocket(c *gin.Context) {
 
 		go func(msg websocket.Message) {
 			if err := handler.HandleInbound(ctx, msg); err != nil {
-				_ = handler.SendErrorJson(msg, err)
+				handler.SendErrorJson(msg, err)
 			}
 		}(j)
 	}

router/router_system.go

@@ -20,28 +20,12 @@ import (
 func getSystemInformation(c *gin.Context) {
 	i, err := system.GetSystemInformation()
 	if err != nil {
-		middleware.CaptureAndAbort(c, err)
+		NewTrackedError(err).Abort(c)
+
 		return
 	}
 
-	if c.Query("v") == "2" {
+	c.JSON(http.StatusOK, i)
-		c.JSON(http.StatusOK, i)
-		return
-	}
-
-	c.JSON(http.StatusOK, struct {
-		Architecture  string `json:"architecture"`
-		CPUCount      int    `json:"cpu_count"`
-		KernelVersion string `json:"kernel_version"`
-		OS            string `json:"os"`
-		Version       string `json:"version"`
-	}{
-		Architecture:  i.System.Architecture,
-		CPUCount:      i.System.CPUThreads,
-		KernelVersion: i.System.KernelVersion,
-		OS:            i.System.OSType,
-		Version:       i.Version,
-	})
 }
 
 // Returns all the servers that are registered and configured correctly on
@@ -91,7 +75,7 @@ func postCreateServer(c *gin.Context) {
 			return
 		}
 
-		if err := i.Server().Install(); err != nil {
+		if err := i.Server().Install(false); err != nil {
 			log.WithFields(log.Fields{"server": i.Server().ID(), "error": err}).Error("failed to run install process for server")
 			return
 		}
@@ -113,21 +97,9 @@ func postCreateServer(c *gin.Context) {
 	c.Status(http.StatusAccepted)
 }
 
-type postUpdateConfigurationResponse struct {
-	Applied bool `json:"applied"`
-}
-
 // Updates the running configuration for this Wings instance.
 func postUpdateConfiguration(c *gin.Context) {
 	cfg := config.Get()
-
-	if cfg.IgnorePanelConfigUpdates {
-		c.JSON(http.StatusOK, postUpdateConfigurationResponse{
-			Applied: false,
-		})
-		return
-	}
-
 	if err := c.BindJSON(&cfg); err != nil {
 		return
 	}
@@ -145,13 +117,11 @@ func postUpdateConfiguration(c *gin.Context) {
 	// Try to write this new configuration to the disk before updating our global
 	// state with it.
 	if err := config.WriteToDisk(cfg); err != nil {
-		middleware.CaptureAndAbort(c, err)
+		_ = WithError(c, err)
 		return
 	}
 	// Since we wrote it to the disk successfully now update the global configuration
 	// state to use this new configuration struct.
 	config.Set(cfg)
-	c.JSON(http.StatusOK, postUpdateConfigurationResponse{
+	c.Status(http.StatusNoContent)
-		Applied: true,
-	})
 }

router/router_transfer.go

@@ -38,14 +38,14 @@ func postTransfers(c *gin.Context) {
 
 	token := tokens.TransferPayload{}
 	if err := tokens.ParseToken([]byte(auth[1]), &token); err != nil {
-		middleware.CaptureAndAbort(c, err)
+		NewTrackedError(err).Abort(c)
 		return
 	}
 
 	manager := middleware.ExtractManager(c)
 	u, err := uuid.Parse(token.Subject)
 	if err != nil {
-		middleware.CaptureAndAbort(c, err)
+		NewTrackedError(err).Abort(c)
 		return
 	}
 
@@ -70,7 +70,7 @@ func postTransfers(c *gin.Context) {
 			if err := manager.Client().SetTransferStatus(context.Background(), trnsfr.Server.ID(), false); err != nil {
 				trnsfr.Log().WithField("status", false).WithError(err).Error("failed to set transfer status")
 			}
-			middleware.CaptureAndAbort(c, err)
+			NewTrackedError(err).Abort(c)
 			return
 		}
 
@@ -106,7 +106,6 @@ func postTransfers(c *gin.Context) {
 			if !successful && err != nil {
 				// Delete all extracted files.
 				go func(trnsfr *transfer.Transfer) {
-					_ = trnsfr.Server.Filesystem().UnixFS().Close()
 					if err := os.RemoveAll(trnsfr.Server.Filesystem().Path()); err != nil && !os.IsNotExist(err) {
 						trnsfr.Log().WithError(err).Warn("failed to delete local server files")
 					}
@@ -124,13 +123,13 @@ func postTransfers(c *gin.Context) {
 	mediaType, params, err := mime.ParseMediaType(c.GetHeader("Content-Type"))
 	if err != nil {
 		trnsfr.Log().Debug("failed to parse content type header")
-		middleware.CaptureAndAbort(c, err)
+		NewTrackedError(err).Abort(c)
 		return
 	}
 
 	if !strings.HasPrefix(mediaType, "multipart/") {
 		trnsfr.Log().Debug("invalid content type")
-		middleware.CaptureAndAbort(c, fmt.Errorf("invalid content type \"%s\", expected \"multipart/form-data\"", mediaType))
+		NewTrackedError(fmt.Errorf("invalid content type \"%s\", expected \"multipart/form-data\"", mediaType)).Abort(c)
 		return
 	}
 
@@ -157,7 +156,7 @@ out:
 				break out
 			}
 			if err != nil {
-				middleware.CaptureAndAbort(c, err)
+				NewTrackedError(err).Abort(c)
 				return
 			}
 
@@ -167,13 +166,13 @@ out:
 				trnsfr.Log().Debug("received archive")
 
 				if err := trnsfr.Server.EnsureDataDirectoryExists(); err != nil {
-					middleware.CaptureAndAbort(c, err)
+					NewTrackedError(err).Abort(c)
 					return
 				}
 
 				tee := io.TeeReader(p, h)
 				if err := trnsfr.Server.Filesystem().ExtractStreamUnsafe(ctx, "/", tee); err != nil {
-					middleware.CaptureAndAbort(c, err)
+					NewTrackedError(err).Abort(c)
 					return
 				}
 
@@ -182,7 +181,7 @@ out:
 				trnsfr.Log().Debug("received checksum")
 
 				if !hasArchive {
-					middleware.CaptureAndAbort(c, errors.New("archive must be sent before the checksum"))
+					NewTrackedError(errors.New("archive must be sent before the checksum")).Abort(c)
 					return
 				}
 
@@ -190,14 +189,14 @@ out:
 
 				v, err := io.ReadAll(p)
 				if err != nil {
-					middleware.CaptureAndAbort(c, err)
+					NewTrackedError(err).Abort(c)
 					return
 				}
 
 				expected := make([]byte, hex.DecodedLen(len(v)))
 				n, err := hex.Decode(expected, v)
 				if err != nil {
-					middleware.CaptureAndAbort(c, err)
+					NewTrackedError(err).Abort(c)
 					return
 				}
 				actual := h.Sum(nil)
@@ -208,7 +207,7 @@ out:
 				}).Debug("checksums")
 
 				if !bytes.Equal(expected[:n], actual) {
-					middleware.CaptureAndAbort(c, errors.New("checksums don't match"))
+					NewTrackedError(errors.New("checksums don't match")).Abort(c)
 					return
 				}
 
@@ -221,12 +220,12 @@ out:
 	}
 
 	if !hasArchive || !hasChecksum {
-		middleware.CaptureAndAbort(c, errors.New("missing archive or checksum"))
+		NewTrackedError(errors.New("missing archive or checksum")).Abort(c)
 		return
 	}
 
 	if !checksumVerified {
-		middleware.CaptureAndAbort(c, errors.New("checksums don't match"))
+		NewTrackedError(errors.New("checksums don't match")).Abort(c)
 		return
 	}
 
@@ -236,7 +235,7 @@ out:
 
 	// Ensure the server environment gets configured.
 	if err := trnsfr.Server.CreateEnvironment(); err != nil {
-		middleware.CaptureAndAbort(c, err)
+		NewTrackedError(err).Abort(c)
 		return
 	}
 

server/backup.go

@@ -67,7 +67,7 @@ func (s *Server) Backup(b backup.BackupInterface) error {
 		}
 	}
 
-	ad, err := b.Generate(s.Context(), s.Filesystem(), ignored)
+	ad, err := b.Generate(s.Context(), s.Filesystem().Path(), ignored)
 	if err != nil {
 		if err := s.notifyPanelOfBackup(b.Identifier(), &backup.ArchiveDetails{}, false); err != nil {
 			s.Log().WithFields(log.Fields{
@@ -154,14 +154,17 @@ func (s *Server) RestoreBackup(b backup.BackupInterface, reader io.ReadCloser) (
 	err = b.Restore(s.Context(), reader, func(file string, info fs.FileInfo, r io.ReadCloser) error {
 		defer r.Close()
 		s.Events().Publish(DaemonMessageEvent, "(restoring): "+file)
-		// TODO: since this will be called a lot, it may be worth adding an optimized
+
-		// Write with Chtimes method to the UnixFS that is able to re-use the
+		if err := s.Filesystem().Writefile(file, r); err != nil {
-		// same dirfd and file name.
-		if err := s.Filesystem().Write(file, r, info.Size(), info.Mode()); err != nil {
 			return err
 		}
+		if err := s.Filesystem().Chmod(file, info.Mode()); err != nil {
+			return err
+		}
+
 		atime := info.ModTime()
-		return s.Filesystem().Chtimes(file, atime, atime)
+		mtime := atime
+		return s.Filesystem().Chtimes(file, atime, mtime)
 	})
 
 	return errors.WithStackIf(err)

server/backup/backup.go

@@ -16,7 +16,6 @@ import (
 
 	"github.com/pterodactyl/wings/config"
 	"github.com/pterodactyl/wings/remote"
-	"github.com/pterodactyl/wings/server/filesystem"
 )
 
 var format = archiver.CompressedArchive{
@@ -47,7 +46,7 @@ type BackupInterface interface {
 	WithLogContext(map[string]interface{})
 	// Generate creates a backup in whatever the configured source for the
 	// specific implementation is.
-	Generate(context.Context, *filesystem.Filesystem, string) (*ArchiveDetails, error)
+	Generate(context.Context, string, string) (*ArchiveDetails, error)
 	// Ignored returns the ignored files for this backup instance.
 	Ignored() string
 	// Checksum returns a SHA1 checksum for the generated backup.

server/backup/backup_local.go

@@ -59,10 +59,10 @@ func (b *LocalBackup) WithLogContext(c map[string]interface{}) {
 
 // Generate generates a backup of the selected files and pushes it to the
 // defined location for this instance.
-func (b *LocalBackup) Generate(ctx context.Context, fsys *filesystem.Filesystem, ignore string) (*ArchiveDetails, error) {
+func (b *LocalBackup) Generate(ctx context.Context, basePath, ignore string) (*ArchiveDetails, error) {
 	a := &filesystem.Archive{
-		Filesystem: fsys,
+		BasePath: basePath,
-		Ignore:     ignore,
+		Ignore:   ignore,
 	}
 
 	b.log().WithField("path", b.Path()).Info("creating backup for server")
@@ -85,7 +85,6 @@ func (b *LocalBackup) Restore(ctx context.Context, _ io.Reader, callback Restore
 	if err != nil {
 		return err
 	}
-	defer f.Close()
 
 	var reader io.Reader = f
 	// Steal the logic we use for making backups which will be applied when restoring
@@ -100,7 +99,7 @@ func (b *LocalBackup) Restore(ctx context.Context, _ io.Reader, callback Restore
 		}
 		defer r.Close()
 
-		return callback(f.NameInArchive, f.FileInfo, r)
+		return callback(filesystem.ExtractNameFromArchive(f), f.FileInfo, r)
 	}); err != nil {
 		return err
 	}

server/backup/backup_s3.go

@@ -48,12 +48,12 @@ func (s *S3Backup) WithLogContext(c map[string]interface{}) {
 
 // Generate creates a new backup on the disk, moves it into the S3 bucket via
 // the provided presigned URL, and then deletes the backup from the disk.
-func (s *S3Backup) Generate(ctx context.Context, fsys *filesystem.Filesystem, ignore string) (*ArchiveDetails, error) {
+func (s *S3Backup) Generate(ctx context.Context, basePath, ignore string) (*ArchiveDetails, error) {
 	defer s.Remove()
 
 	a := &filesystem.Archive{
-		Filesystem: fsys,
+		BasePath: basePath,
-		Ignore:     ignore,
+		Ignore:   ignore,
 	}
 
 	s.log().WithField("path", s.Path()).Info("creating backup for server")
@@ -100,7 +100,7 @@ func (s *S3Backup) Restore(ctx context.Context, r io.Reader, callback RestoreCal
 		}
 		defer r.Close()
 
-		return callback(f.NameInArchive, f.FileInfo, r)
+		return callback(filesystem.ExtractNameFromArchive(f), f.FileInfo, r)
 	}); err != nil {
 		return err
 	}

server/config_parser.go

@@ -4,11 +4,9 @@ import (
 	"runtime"
 
 	"github.com/gammazero/workerpool"
-
-	"github.com/pterodactyl/wings/internal/ufs"
 )
 
-// UpdateConfigurationFiles updates all the defined configuration files for
+// UpdateConfigurationFiles updates all of the defined configuration files for
 // a server automatically to ensure that they always use the specified values.
 func (s *Server) UpdateConfigurationFiles() {
 	pool := workerpool.New(runtime.NumCPU())
@@ -20,18 +18,18 @@ func (s *Server) UpdateConfigurationFiles() {
 		f := cf
 
 		pool.Submit(func() {
-			file, err := s.Filesystem().UnixFS().Touch(f.FileName, ufs.O_RDWR|ufs.O_CREATE, 0o644)
+			p, err := s.Filesystem().SafePath(f.FileName)
 			if err != nil {
-				s.Log().WithField("file_name", f.FileName).WithField("error", err).Error("failed to open file for configuration")
+				s.Log().WithField("error", err).Error("failed to generate safe path for configuration file")
+
 				return
 			}
-			defer file.Close()
 
-			if err := f.Parse(file); err != nil {
+			if err := f.Parse(p, false); err != nil {
 				s.Log().WithField("error", err).Error("failed to parse and update server configuration file")
 			}
 
-			s.Log().WithField("file_name", f.FileName).Debug("finished processing server configuration file")
+			s.Log().WithField("path", f.FileName).Debug("finished processing server configuration file")
 		})
 	}
 

server/console.go

@@ -37,7 +37,7 @@ func (s *Server) Throttler() *ConsoleThrottle {
 
 		s.throttler = newConsoleThrottle(throttles.Lines, period)
 		s.throttler.strike = func() {
-			s.PublishConsoleOutputFromDaemon("Server is outputting console data too quickly -- throttling...")
+			s.PublishConsoleOutputFromDaemon(fmt.Sprintf("Server is outputting console data too quickly -- throttling..."))
 		}
 	})
 	return s.throttler

server/crash.go

@@ -6,8 +6,6 @@ import (
 	"sync"
 	"time"
 
-	"emperror.dev/errors"
-
 	"github.com/pterodactyl/wings/config"
 	"github.com/pterodactyl/wings/environment"
 )
@@ -59,7 +57,7 @@ func (s *Server) handleServerCrash() error {
 
 	exitCode, oomKilled, err := s.Environment.ExitState()
 	if err != nil {
-		return errors.Wrap(err, "failed to get exit state for server process")
+		return err
 	}
 
 	// If the system is not configured to detect a clean exit code as a crash, and the
@@ -87,5 +85,5 @@ func (s *Server) handleServerCrash() error {
 
 	s.crasher.SetLastCrash(time.Now())
 
-	return errors.Wrap(s.HandlePowerAction(PowerActionStart), "failed to start server after crash detection")
+	return s.HandlePowerAction(PowerActionStart)
 }

server/filesystem/archive.go

@@ -13,12 +13,12 @@ import (
 	"emperror.dev/errors"
 	"github.com/apex/log"
 	"github.com/juju/ratelimit"
+	"github.com/karrick/godirwalk"
 	"github.com/klauspost/pgzip"
 	ignore "github.com/sabhiram/go-gitignore"
 
 	"github.com/pterodactyl/wings/config"
 	"github.com/pterodactyl/wings/internal/progress"
-	"github.com/pterodactyl/wings/internal/ufs"
 )
 
 const memory = 4 * 1024
@@ -56,35 +56,25 @@ func (p *TarProgress) Write(v []byte) (int, error) {
 }
 
 type Archive struct {
-	// Filesystem to create the archive with.
+	// BasePath is the absolute path to create the archive from where Files and Ignore are
-	Filesystem *Filesystem
+	// relative to.
+	BasePath string
 
 	// Ignore is a gitignore string (most likely read from a file) of files to ignore
 	// from the archive.
 	Ignore string
 
-	// BaseDirectory .
+	// Files specifies the files to archive, this takes priority over the Ignore option, if
-	BaseDirectory string
+	// unspecified, all files in the BasePath will be archived unless Ignore is set.
-
-	// Files specifies the files to archive, this takes priority over the Ignore
-	// option, if unspecified, all files in the BaseDirectory will be archived
-	// unless Ignore is set.
 	Files []string
 
 	// Progress wraps the writer of the archive to pass through the progress tracker.
 	Progress *progress.Progress
-
-	w *TarProgress
 }
 
 // Create creates an archive at dst with all the files defined in the
 // included Files array.
-//
-// THIS IS UNSAFE TO USE IF `dst` IS PROVIDED BY A USER! ONLY USE THIS WITH
-// CONTROLLED PATHS!
 func (a *Archive) Create(ctx context.Context, dst string) error {
-	// Using os.OpenFile here is expected, as long as `dst` is not a user
-	// provided path.
 	f, err := os.OpenFile(dst, os.O_WRONLY|os.O_CREATE|os.O_TRUNC, 0o600)
 	if err != nil {
 		return err
@@ -105,30 +95,8 @@ func (a *Archive) Create(ctx context.Context, dst string) error {
 	return a.Stream(ctx, writer)
 }
 
-type walkFunc func(dirfd int, name, relative string, d ufs.DirEntry) error
+// Stream .
-
-// Stream streams the creation of the archive to the given writer.
 func (a *Archive) Stream(ctx context.Context, w io.Writer) error {
-	if a.Filesystem == nil {
-		return errors.New("filesystem: archive.Filesystem is unset")
-	}
-
-	// The base directory may come with a prefixed `/`, strip it to prevent
-	// problems.
-	a.BaseDirectory = strings.TrimPrefix(a.BaseDirectory, "/")
-
-	if filesLen := len(a.Files); filesLen > 0 {
-		files := make([]string, filesLen)
-		for i, f := range a.Files {
-			if !strings.HasPrefix(f, a.Filesystem.Path()) {
-				files[i] = f
-				continue
-			}
-			files[i] = strings.TrimPrefix(strings.TrimPrefix(f, a.Filesystem.Path()), "/")
-		}
-		a.Files = files
-	}
-
 	// Choose which compression level to use based on the compression_level configuration option
 	var compressionLevel int
 	switch config.Get().System.Backups.CompressionLevel {
@@ -136,6 +104,8 @@ func (a *Archive) Stream(ctx context.Context, w io.Writer) error {
 		compressionLevel = pgzip.NoCompression
 	case "best_compression":
 		compressionLevel = pgzip.BestCompression
+	case "best_speed":
+		fallthrough
 	default:
 		compressionLevel = pgzip.BestSpeed
 	}
@@ -149,124 +119,105 @@ func (a *Archive) Stream(ctx context.Context, w io.Writer) error {
 	tw := tar.NewWriter(gw)
 	defer tw.Close()
 
-	a.w = NewTarProgress(tw, a.Progress)
+	pw := NewTarProgress(tw, a.Progress)
 
-	fs := a.Filesystem.unixFS
+	// Configure godirwalk.
+	options := &godirwalk.Options{
+		FollowSymbolicLinks: false,
+		Unsorted:            true,
+	}
 
 	// If we're specifically looking for only certain files, or have requested
 	// that certain files be ignored we'll update the callback function to reflect
 	// that request.
-	var callback walkFunc
+	var callback godirwalk.WalkFunc
 	if len(a.Files) == 0 && len(a.Ignore) > 0 {
 		i := ignore.CompileIgnoreLines(strings.Split(a.Ignore, "\n")...)
-		callback = a.callback(func(_ int, _, relative string, _ ufs.DirEntry) error {
+
-			if i.MatchesPath(relative) {
+		callback = a.callback(pw, func(_ string, rp string) error {
-				return SkipThis
+			if i.MatchesPath(rp) {
+				return godirwalk.SkipThis
 			}
+
 			return nil
 		})
 	} else if len(a.Files) > 0 {
-		callback = a.withFilesCallback()
+		callback = a.withFilesCallback(pw)
 	} else {
-		callback = a.callback()
+		callback = a.callback(pw)
 	}
 
-	// Open the base directory we were provided.
+	// Set the callback function, wrapped with support for context cancellation.
-	dirfd, name, closeFd, err := fs.SafePath(a.BaseDirectory)
+	options.Callback = func(path string, de *godirwalk.Dirent) error {
-	defer closeFd()
-	if err != nil {
-		return err
-	}
-
-	// Recursively walk the base directory.
-	return fs.WalkDirat(dirfd, name, func(dirfd int, name, relative string, d ufs.DirEntry, err error) error {
-		if err != nil {
-			return err
-		}
 		select {
 		case <-ctx.Done():
 			return ctx.Err()
 		default:
-			return callback(dirfd, name, relative, d)
+			return callback(path, de)
 		}
-	})
+	}
+
+	// Recursively walk the path we are archiving.
+	return godirwalk.Walk(a.BasePath, options)
 }
 
 // Callback function used to determine if a given file should be included in the archive
 // being generated.
-func (a *Archive) callback(opts ...walkFunc) walkFunc {
+func (a *Archive) callback(tw *TarProgress, opts ...func(path string, relative string) error) func(path string, de *godirwalk.Dirent) error {
-	// Get the base directory we need to strip when walking.
+	return func(path string, de *godirwalk.Dirent) error {
-	//
-	// This is important as when we are walking, the last part of the base directory
-	// is present on all the paths we walk.
-	var base string
-	if a.BaseDirectory != "" {
-		base = filepath.Base(a.BaseDirectory) + "/"
-	}
-	return func(dirfd int, name, relative string, d ufs.DirEntry) error {
 		// Skip directories because we are walking them recursively.
-		if d.IsDir() {
+		if de.IsDir() {
 			return nil
 		}
 
-		// If base isn't empty, strip it from the relative path. This fixes an
+		relative := filepath.ToSlash(strings.TrimPrefix(path, a.BasePath+string(filepath.Separator)))
-		// issue when creating an archive starting from a nested directory.
-		//
-		// See https://github.com/pterodactyl/panel/issues/5030 for more details.
-		if base != "" {
-			relative = strings.TrimPrefix(relative, base)
-		}
 
 		// Call the additional options passed to this callback function. If any of them return
 		// a non-nil error we will exit immediately.
 		for _, opt := range opts {
-			if err := opt(dirfd, name, relative, d); err != nil {
+			if err := opt(path, relative); err != nil {
-				if err == SkipThis {
-					return nil
-				}
 				return err
 			}
 		}
 
 		// Add the file to the archive, if it is nested in a directory,
 		// the directory will be automatically "created" in the archive.
-		return a.addToArchive(dirfd, name, relative, d)
+		return a.addToArchive(path, relative, tw)
 	}
 }
 
-var SkipThis = errors.New("skip this")
-
 // Pushes only files defined in the Files key to the final archive.
-func (a *Archive) withFilesCallback() walkFunc {
+func (a *Archive) withFilesCallback(tw *TarProgress) func(path string, de *godirwalk.Dirent) error {
-	return a.callback(func(_ int, _, relative string, _ ufs.DirEntry) error {
+	return a.callback(tw, func(p string, rp string) error {
 		for _, f := range a.Files {
-			// Allow exact file matches, otherwise check if file is within a parent directory.
+			// If the given doesn't match, or doesn't have the same prefix continue
-			//
+			// to the next item in the loop.
-			// The slashes are added in the prefix checks to prevent partial name matches from being
+			if p != f && !strings.HasPrefix(strings.TrimSuffix(p, "/")+"/", f) {
-			// included in the archive.
-			if f != relative && !strings.HasPrefix(strings.TrimSuffix(relative, "/")+"/", strings.TrimSuffix(f, "/")+"/") {
 				continue
 			}
 
 			// Once we have a match return a nil value here so that the loop stops and the
 			// call to this function will correctly include the file in the archive. If there
 			// are no matches we'll never make it to this line, and the final error returned
-			// will be the ufs.SkipDir error.
+			// will be the godirwalk.SkipThis error.
 			return nil
 		}
 
-		return SkipThis
+		return godirwalk.SkipThis
 	})
 }
 
 // Adds a given file path to the final archive being created.
-func (a *Archive) addToArchive(dirfd int, name, relative string, entry ufs.DirEntry) error {
+func (a *Archive) addToArchive(p string, rp string, w *TarProgress) error {
-	s, err := entry.Info()
+	// Lstat the file, this will give us the same information as Stat except that it will not
+	// follow a symlink to its target automatically. This is important to avoid including
+	// files that exist outside the server root unintentionally in the backup.
+	s, err := os.Lstat(p)
 	if err != nil {
-		if errors.Is(err, ufs.ErrNotExist) {
+		if os.IsNotExist(err) {
 			return nil
 		}
-		return errors.WrapIff(err, "failed executing os.Lstat on '%s'", name)
+		return errors.WrapIff(err, "failed executing os.Lstat on '%s'", rp)
 	}
 
 	// Skip socket files as they are unsupported by archive/tar.
@@ -286,7 +237,7 @@ func (a *Archive) addToArchive(dirfd int, name, relative string, entry ufs.DirEn
 		if err != nil {
 			// Ignore the not exist errors specifically, since there is nothing important about that.
 			if !os.IsNotExist(err) {
-				log.WithField("name", name).WithField("readlink_err", err.Error()).Warn("failed reading symlink for target path; skipping...")
+				log.WithField("path", rp).WithField("readlink_err", err.Error()).Warn("failed reading symlink for target path; skipping...")
 			}
 			return nil
 		}
@@ -295,17 +246,17 @@ func (a *Archive) addToArchive(dirfd int, name, relative string, entry ufs.DirEn
 	// Get the tar FileInfoHeader in order to add the file to the archive.
 	header, err := tar.FileInfoHeader(s, filepath.ToSlash(target))
 	if err != nil {
-		return errors.WrapIff(err, "failed to get tar#FileInfoHeader for '%s'", name)
+		return errors.WrapIff(err, "failed to get tar#FileInfoHeader for '%s'", rp)
 	}
 
 	// Fix the header name if the file is not a symlink.
 	if s.Mode()&fs.ModeSymlink == 0 {
-		header.Name = relative
+		header.Name = rp
 	}
 
 	// Write the tar FileInfoHeader to the archive.
-	if err := a.w.WriteHeader(header); err != nil {
+	if err := w.WriteHeader(header); err != nil {
-		return errors.WrapIff(err, "failed to write tar#FileInfoHeader for '%s'", name)
+		return errors.WrapIff(err, "failed to write tar#FileInfoHeader for '%s'", rp)
 	}
 
 	// If the size of the file is less than 1 (most likely for symlinks), skip writing the file.
@@ -327,7 +278,7 @@ func (a *Archive) addToArchive(dirfd int, name, relative string, entry ufs.DirEn
 	}
 
 	// Open the file.
-	f, err := a.Filesystem.unixFS.OpenFileat(dirfd, name, ufs.O_RDONLY, 0)
+	f, err := os.Open(p)
 	if err != nil {
 		if os.IsNotExist(err) {
 			return nil
@@ -337,8 +288,9 @@ func (a *Archive) addToArchive(dirfd int, name, relative string, entry ufs.DirEn
 	defer f.Close()
 
 	// Copy the file's contents to the archive using our buffer.
-	if _, err := io.CopyBuffer(a.w, io.LimitReader(f, header.Size), buf); err != nil {
+	if _, err := io.CopyBuffer(w, io.LimitReader(f, header.Size), buf); err != nil {
 		return errors.WrapIff(err, "failed to copy '%s' to archive", header.Name)
 	}
+
 	return nil
 }

server/filesystem/archive_test.go

@@ -1,122 +0,0 @@
-package filesystem
-
-import (
-	"context"
-	iofs "io/fs"
-	"os"
-	"path/filepath"
-	"sort"
-	"strings"
-	"testing"
-
-	. "github.com/franela/goblin"
-	"github.com/mholt/archiver/v4"
-)
-
-func TestArchive_Stream(t *testing.T) {
-	g := Goblin(t)
-	fs, rfs := NewFs()
-
-	g.Describe("Archive", func() {
-		g.AfterEach(func() {
-			// Reset the filesystem after each run.
-			_ = fs.TruncateRootDirectory()
-		})
-
-		g.It("creates archive with intended files", func() {
-			g.Assert(fs.CreateDirectory("test", "/")).IsNil()
-			g.Assert(fs.CreateDirectory("test2", "/")).IsNil()
-
-			r := strings.NewReader("hello, world!\n")
-			err := fs.Write("test/file.txt", r, r.Size(), 0o644)
-			g.Assert(err).IsNil()
-
-			r = strings.NewReader("hello, world!\n")
-			err = fs.Write("test2/file.txt", r, r.Size(), 0o644)
-			g.Assert(err).IsNil()
-
-			r = strings.NewReader("hello, world!\n")
-			err = fs.Write("test_file.txt", r, r.Size(), 0o644)
-			g.Assert(err).IsNil()
-
-			r = strings.NewReader("hello, world!\n")
-			err = fs.Write("test_file.txt.old", r, r.Size(), 0o644)
-			g.Assert(err).IsNil()
-
-			a := &Archive{
-				Filesystem: fs,
-				Files: []string{
-					"test",
-					"test_file.txt",
-				},
-			}
-
-			// Create the archive.
-			archivePath := filepath.Join(rfs.root, "archive.tar.gz")
-			g.Assert(a.Create(context.Background(), archivePath)).IsNil()
-
-			// Ensure the archive exists.
-			_, err = os.Stat(archivePath)
-			g.Assert(err).IsNil()
-
-			// Open the archive.
-			genericFs, err := archiver.FileSystem(context.Background(), archivePath)
-			g.Assert(err).IsNil()
-
-			// Assert that we are opening an archive.
-			afs, ok := genericFs.(archiver.ArchiveFS)
-			g.Assert(ok).IsTrue()
-
-			// Get the names of the files recursively from the archive.
-			files, err := getFiles(afs, ".")
-			g.Assert(err).IsNil()
-
-			// Ensure the files in the archive match what we are expecting.
-			expected := []string{
-				"test_file.txt",
-				"test/file.txt",
-			}
-
-			// Sort the slices to ensure the comparison never fails if the
-			// contents are sorted differently.
-			sort.Strings(expected)
-			sort.Strings(files)
-
-			g.Assert(files).Equal(expected)
-		})
-	})
-}
-
-func getFiles(f iofs.ReadDirFS, name string) ([]string, error) {
-	var v []string
-
-	entries, err := f.ReadDir(name)
-	if err != nil {
-		return nil, err
-	}
-
-	for _, e := range entries {
-		entryName := e.Name()
-		if name != "." {
-			entryName = filepath.Join(name, entryName)
-		}
-
-		if e.IsDir() {
-			files, err := getFiles(f, entryName)
-			if err != nil {
-				return nil, err
-			}
-
-			if files == nil {
-				return nil, nil
-			}
-
-			v = append(v, files...)
-			continue
-		}
-
-		v = append(v, entryName)
-	}
-
-	return v, nil
-}

server/filesystem/archiverext/compressed.go

@@ -1,100 +0,0 @@
-// SPDX-License-Identifier: MIT
-// SPDX-FileCopyrightText: Copyright (c) 2016 Matthew Holt
-
-// Code in this file was derived from
-// https://github.com/mholt/archiver/blob/v4.0.0-alpha.8/fs.go
-//
-// These modifications were necessary to allow us to use an already open file
-// with archiver.FileFS.
-
-package archiverext
-
-import (
-	"io"
-	"io/fs"
-
-	"github.com/mholt/archiver/v4"
-)
-
-// FileFS allows accessing a file on disk using a consistent file system interface.
-// The value should be the path to a regular file, not a directory. This file will
-// be the only entry in the file system and will be at its root. It can be accessed
-// within the file system by the name of "." or the filename.
-//
-// If the file is compressed, set the Compression field so that reads from the
-// file will be transparently decompressed.
-type FileFS struct {
-	// File is the compressed file backing the FileFS.
-	File fs.File
-
-	// If file is compressed, setting this field will
-	// transparently decompress reads.
-	Compression archiver.Decompressor
-}
-
-// Open opens the named file, which must be the file used to create the file system.
-func (f FileFS) Open(name string) (fs.File, error) {
-	if err := f.checkName(name, "open"); err != nil {
-		return nil, err
-	}
-	if f.Compression == nil {
-		return f.File, nil
-	}
-	r, err := f.Compression.OpenReader(f.File)
-	if err != nil {
-		return nil, err
-	}
-	return compressedFile{f.File, r}, nil
-}
-
-// ReadDir returns a directory listing with the file as the singular entry.
-func (f FileFS) ReadDir(name string) ([]fs.DirEntry, error) {
-	if err := f.checkName(name, "stat"); err != nil {
-		return nil, err
-	}
-	info, err := f.Stat(name)
-	if err != nil {
-		return nil, err
-	}
-	return []fs.DirEntry{fs.FileInfoToDirEntry(info)}, nil
-}
-
-// Stat stats the named file, which must be the file used to create the file system.
-func (f FileFS) Stat(name string) (fs.FileInfo, error) {
-	if err := f.checkName(name, "stat"); err != nil {
-		return nil, err
-	}
-	return f.File.Stat()
-}
-
-func (f FileFS) checkName(name, op string) error {
-	if !fs.ValidPath(name) {
-		return &fs.PathError{Op: "open", Path: name, Err: fs.ErrInvalid}
-	}
-	// TODO: we may need better name validation.
-	if name != "." {
-		return &fs.PathError{Op: op, Path: name, Err: fs.ErrNotExist}
-	}
-	return nil
-}
-
-// compressedFile is an fs.File that specially reads
-// from a decompression reader, and which closes both
-// that reader and the underlying file.
-type compressedFile struct {
-	fs.File
-	decomp io.ReadCloser
-}
-
-func (cf compressedFile) Read(p []byte) (int, error) {
-	return cf.decomp.Read(p)
-}
-
-func (cf compressedFile) Close() error {
-	err := cf.File.Close()
-	err2 := cf.decomp.Close()
-	if err2 != nil && err == nil {
-		err = err2
-	}
-	return err
-}

server/filesystem/compress.go

@@ -1,22 +1,25 @@
 package filesystem
 
 import (
+	"archive/tar"
+	"archive/zip"
+	"compress/gzip"
 	"context"
 	"fmt"
 	"io"
 	iofs "io/fs"
+	"os"
 	"path"
 	"path/filepath"
+	"reflect"
 	"strings"
 	"sync/atomic"
 	"time"
 
 	"emperror.dev/errors"
-	"github.com/klauspost/compress/zip"
+	gzip2 "github.com/klauspost/compress/gzip"
+	zip2 "github.com/klauspost/compress/zip"
 	"github.com/mholt/archiver/v4"
-
-	"github.com/pterodactyl/wings/internal/ufs"
-	"github.com/pterodactyl/wings/server/filesystem/archiverext"
 )
 
 // CompressFiles compresses all the files matching the given paths in the
@@ -28,70 +31,46 @@ import (
 // All paths are relative to the dir that is passed in as the first argument,
 // and the compressed file will be placed at that location named
 // `archive-{date}.tar.gz`.
-func (fs *Filesystem) CompressFiles(dir string, paths []string) (ufs.FileInfo, error) {
+func (fs *Filesystem) CompressFiles(dir string, paths []string) (os.FileInfo, error) {
-	a := &Archive{Filesystem: fs, BaseDirectory: dir, Files: paths}
+	cleanedRootDir, err := fs.SafePath(dir)
+	if err != nil {
+		return nil, err
+	}
+
+	// Take all the paths passed in and merge them together with the root directory we've gotten.
+	for i, p := range paths {
+		paths[i] = filepath.Join(cleanedRootDir, p)
+	}
+
+	cleaned, err := fs.ParallelSafePath(paths)
+	if err != nil {
+		return nil, err
+	}
+
+	a := &Archive{BasePath: cleanedRootDir, Files: cleaned}
 	d := path.Join(
-		dir,
+		cleanedRootDir,
 		fmt.Sprintf("archive-%s.tar.gz", strings.ReplaceAll(time.Now().Format(time.RFC3339), ":", "")),
 	)
-	f, err := fs.unixFS.OpenFile(d, ufs.O_WRONLY|ufs.O_CREATE, 0o644)
+
+	if err := a.Create(context.Background(), d); err != nil {
+		return nil, err
+	}
+
+	f, err := os.Stat(d)
 	if err != nil {
-		return nil, err
+		_ = os.Remove(d)
-	}
-	defer f.Close()
-	cw := ufs.NewCountedWriter(f)
-	if err := a.Stream(context.Background(), cw); err != nil {
-		return nil, err
-	}
-	if !fs.unixFS.CanFit(cw.BytesWritten()) {
-		_ = fs.unixFS.Remove(d)
-		return nil, newFilesystemError(ErrCodeDiskSpace, nil)
-	}
-	fs.unixFS.Add(cw.BytesWritten())
-	return f.Stat()
-}
-
-func (fs *Filesystem) archiverFileSystem(ctx context.Context, p string) (iofs.FS, error) {
-	f, err := fs.unixFS.Open(p)
-	if err != nil {
-		return nil, err
-	}
-	// Do not use defer to close `f`, it will likely be used later.
-
-	format, _, err := archiver.Identify(filepath.Base(p), f)
-	if err != nil && !errors.Is(err, archiver.ErrNoMatch) {
-		_ = f.Close()
 		return nil, err
 	}
 
-	// Reset the file reader.
+	if err := fs.HasSpaceFor(f.Size()); err != nil {
-	if _, err := f.Seek(0, io.SeekStart); err != nil {
+		_ = os.Remove(d)
-		_ = f.Close()
 		return nil, err
 	}
 
-	info, err := f.Stat()
+	fs.addDisk(f.Size())
-	if err != nil {
-		_ = f.Close()
-		return nil, err
-	}
 
-	if format != nil {
+	return f, nil
-		switch ff := format.(type) {
-		case archiver.Zip:
-			// zip.Reader is more performant than ArchiveFS, because zip.Reader caches content information
-			// and zip.Reader can open several content files concurrently because of io.ReaderAt requirement
-			// while ArchiveFS can't.
-			// zip.Reader doesn't suffer from issue #330 and #310 according to local test (but they should be fixed anyway)
-			return zip.NewReader(f, info.Size())
-		case archiver.Archival:
-			return archiver.ArchiveFS{Stream: io.NewSectionReader(f, 0, info.Size()), Format: ff, Context: ctx}, nil
-		case archiver.Compression:
-			return archiverext.FileFS{File: f, Compression: ff}, nil
-		}
-	}
-	_ = f.Close()
-	return nil, archiver.ErrNoMatch
 }
 
 // SpaceAvailableForDecompression looks through a given archive and determines
@@ -103,7 +82,16 @@ func (fs *Filesystem) SpaceAvailableForDecompression(ctx context.Context, dir st
 		return nil
 	}
 
-	fsys, err := fs.archiverFileSystem(ctx, filepath.Join(dir, file))
+	source, err := fs.SafePath(filepath.Join(dir, file))
+	if err != nil {
+		return err
+	}
+
+	// Get the cached size in a parallel process so that if it is not cached we are not
+	// waiting an unnecessary amount of time on this call.
+	dirSize, err := fs.DiskUsage(false)
+
+	fsys, err := archiver.FileSystem(source)
 	if err != nil {
 		if errors.Is(err, archiver.ErrNoMatch) {
 			return newFilesystemError(ErrCodeUnknownArchive, err)
@@ -111,7 +99,7 @@ func (fs *Filesystem) SpaceAvailableForDecompression(ctx context.Context, dir st
 		return err
 	}
 
-	var size atomic.Int64
+	var size int64
 	return iofs.WalkDir(fsys, ".", func(path string, d iofs.DirEntry, err error) error {
 		if err != nil {
 			return err
@@ -126,7 +114,7 @@ func (fs *Filesystem) SpaceAvailableForDecompression(ctx context.Context, dir st
 			if err != nil {
 				return err
 			}
-			if !fs.unixFS.CanFit(size.Add(info.Size())) {
+			if atomic.AddInt64(&size, info.Size())+dirSize > fs.MaxDisk() {
 				return newFilesystemError(ErrCodeDiskSpace, nil)
 			}
 			return nil
@@ -140,11 +128,27 @@ func (fs *Filesystem) SpaceAvailableForDecompression(ctx context.Context, dir st
 // zip-slip attack being attempted by validating that the final path is within
 // the server data directory.
 func (fs *Filesystem) DecompressFile(ctx context.Context, dir string, file string) error {
-	f, err := fs.unixFS.Open(filepath.Join(dir, file))
+	source, err := fs.SafePath(filepath.Join(dir, file))
 	if err != nil {
 		return err
 	}
-	defer f.Close()
+	return fs.DecompressFileUnsafe(ctx, dir, source)
+}
+
+// DecompressFileUnsafe will decompress any file on the local disk without checking
+// if it is owned by the server.  The file will be SAFELY decompressed and extracted
+// into the server's directory.
+func (fs *Filesystem) DecompressFileUnsafe(ctx context.Context, dir string, file string) error {
+	// Ensure that the archive actually exists on the system.
+	if _, err := os.Stat(file); err != nil {
+		return errors.WithStack(err)
+	}
+
+	f, err := os.Open(file)
+	if err != nil {
+		return err
+	}
+	// TODO: defer file close?
 
 	// Identify the type of archive we are dealing with.
 	format, input, err := archiver.Identify(filepath.Base(file), f)
@@ -156,7 +160,6 @@ func (fs *Filesystem) DecompressFile(ctx context.Context, dir string, file strin
 	}
 
 	return fs.extractStream(ctx, extractStreamOptions{
-		FileName:  file,
 		Directory: dir,
 		Format:    format,
 		Reader:    input,
@@ -172,6 +175,7 @@ func (fs *Filesystem) ExtractStreamUnsafe(ctx context.Context, dir string, r io.
 		}
 		return err
 	}
+
 	return fs.extractStream(ctx, extractStreamOptions{
 		Directory: dir,
 		Format:    format,
@@ -191,95 +195,80 @@ type extractStreamOptions struct {
 }
 
 func (fs *Filesystem) extractStream(ctx context.Context, opts extractStreamOptions) error {
-
+	// Decompress and extract archive
-	// See if it's a compressed archive, such as TAR or a ZIP
+	if ex, ok := opts.Format.(archiver.Extractor); ok {
-	ex, ok := opts.Format.(archiver.Extractor)
+		return ex.Extract(ctx, opts.Reader, nil, func(ctx context.Context, f archiver.File) error {
-	if !ok {
+			if f.IsDir() {
-
+				return nil
-		// If not, check if it's a single-file compression, such as
-		// .log.gz, .sql.gz, and so on
-		de, ok := opts.Format.(archiver.Decompressor)
-		if !ok {
-			return nil
-		}
-
-		// Strip the compression suffix
-		p := filepath.Join(opts.Directory, strings.TrimSuffix(opts.FileName, opts.Format.Name()))
-
-		// Make sure it's not ignored
-		if err := fs.IsIgnored(p); err != nil {
-			return nil
-		}
-
-		reader, err := de.OpenReader(opts.Reader)
-		if err != nil {
-			return err
-		}
-		defer reader.Close()
-
-		// Open the file for creation/writing
-		f, err := fs.unixFS.OpenFile(p, ufs.O_WRONLY|ufs.O_CREATE, 0o644)
-		if err != nil {
-			return err
-		}
-		defer f.Close()
-
-		// Read in 4 KB chunks
-		buf := make([]byte, 4096)
-		for {
-			n, err := reader.Read(buf)
-			if n > 0 {
-
-				// Check quota before writing the chunk
-				if quotaErr := fs.HasSpaceFor(int64(n)); quotaErr != nil {
-					return quotaErr
-				}
-
-				// Write the chunk
-				if _, writeErr := f.Write(buf[:n]); writeErr != nil {
-					return writeErr
-				}
-
-				// Add to quota
-				fs.addDisk(int64(n))
 			}
-
+			p := filepath.Join(opts.Directory, ExtractNameFromArchive(f))
+			// If it is ignored, just don't do anything with the file and skip over it.
+			if err := fs.IsIgnored(p); err != nil {
+				return nil
+			}
+			r, err := f.Open()
 			if err != nil {
-				// EOF are expected
-				if err == io.EOF {
-					break
-				}
-
-				// Return any other
 				return err
 			}
-		}
+			defer r.Close()
-
+			if err := fs.Writefile(p, r); err != nil {
-		return nil
+				return wrapError(err, opts.FileName)
+			}
+			// Update the file permissions to the one set in the archive.
+			if err := fs.Chmod(p, f.Mode()); err != nil {
+				return wrapError(err, opts.FileName)
+			}
+			// Update the file modification time to the one set in the archive.
+			if err := fs.Chtimes(p, f.ModTime(), f.ModTime()); err != nil {
+				return wrapError(err, opts.FileName)
+			}
+			return nil
+		})
+	}
+	return nil
+}
+
+// ExtractNameFromArchive looks at an archive file to try and determine the name
+// for a given element in an archive. Because of... who knows why, each file type
+// uses different methods to determine the file name.
+//
+// If there is a archiver.File#Sys() value present we will try to use the name
+// present in there, otherwise falling back to archiver.File#Name() if all else
+// fails. Without this logic present, some archive types such as zip/tars/etc.
+// will write all of the files to the base directory, rather than the nested
+// directory that is expected.
+//
+// For files like ".rar" types, there is no f.Sys() value present, and the value
+// of archiver.File#Name() will be what you need.
+func ExtractNameFromArchive(f archiver.File) string {
+	sys := f.Sys()
+	// Some archive types won't have a value returned when you call f.Sys() on them,
+	// such as ".rar" archives for example. In those cases the only thing you can do
+	// is hope that "f.Name()" is actually correct for them.
+	if sys == nil {
+		return f.Name()
+	}
+	switch s := sys.(type) {
+	case *zip.FileHeader:
+		return s.Name
+	case *zip2.FileHeader:
+		return s.Name
+	case *tar.Header:
+		return s.Name
+	case *gzip.Header:
+		return s.Name
+	case *gzip2.Header:
+		return s.Name
+	default:
+		// At this point we cannot figure out what type of archive this might be so
+		// just try to find the name field in the struct. If it is found return it.
+		field := reflect.Indirect(reflect.ValueOf(sys)).FieldByName("Name")
+		if field.IsValid() {
+			return field.String()
+		}
+		// Fallback to the basename of the file at this point. There is nothing we can really
+		// do to try and figure out what the underlying directory of the file is supposed to
+		// be since it didn't implement a name field.
+		return f.Name()
 	}
-
-	// Decompress and extract archive
-	return ex.Extract(ctx, opts.Reader, nil, func(ctx context.Context, f archiver.File) error {
-		if f.IsDir() {
-			return nil
-		}
-		p := filepath.Join(opts.Directory, f.NameInArchive)
-		// If it is ignored, just don't do anything with the file and skip over it.
-		if err := fs.IsIgnored(p); err != nil {
-			return nil
-		}
-		r, err := f.Open()
-		if err != nil {
-			return err
-		}
-		defer r.Close()
-		if err := fs.Write(p, r, f.Size(), f.Mode()); err != nil {
-			return wrapError(err, opts.FileName)
-		}
-		// Update the file modification time to the one set in the archive.
-		if err := fs.Chtimes(p, f.ModTime(), f.ModTime()); err != nil {
-			return wrapError(err, opts.FileName)
-		}
-		return nil
-	})
 }

server/filesystem/compress_test.go

@@ -3,18 +3,17 @@ package filesystem
 import (
 	"context"
 	"os"
+	"sync/atomic"
 	"testing"
 
 	. "github.com/franela/goblin"
 )
 
 // Given an archive named test.{ext}, with the following file structure:
-//
 //	test/
 //	|──inside/
 //	|────finside.txt
 //	|──outside.txt
-//
 // this test will ensure that it's being decompressed as expected
 func TestFilesystem_DecompressFile(t *testing.T) {
 	g := Goblin(t)
@@ -48,7 +47,9 @@ func TestFilesystem_DecompressFile(t *testing.T) {
 		}
 
 		g.AfterEach(func() {
-			_ = fs.TruncateRootDirectory()
+			rfs.reset()
+			atomic.StoreInt64(&fs.diskUsed, 0)
+			atomic.StoreInt64(&fs.diskLimit, 0)
 		})
 	})
 }

server/filesystem/disk_space.go

@@ -1,29 +1,26 @@
 package filesystem
 
 import (
-	"golang.org/x/sys/unix"
-	"slices"
 	"sync"
 	"sync/atomic"
+	"syscall"
 	"time"
 
 	"emperror.dev/errors"
 	"github.com/apex/log"
-
+	"github.com/karrick/godirwalk"
-	"github.com/pterodactyl/wings/internal/ufs"
 )
 
 type SpaceCheckingOpts struct {
 	AllowStaleResponse bool
 }
 
-// TODO: can this be replaced with some sort of atomic? Like atomic.Pointer?
 type usageLookupTime struct {
 	sync.RWMutex
 	value time.Time
 }
 
-// Set sets the last time that a disk space lookup was performed.
+// Update the last time that a disk space lookup was performed.
 func (ult *usageLookupTime) Set(t time.Time) {
 	ult.Lock()
 	ult.value = t
@@ -38,15 +35,14 @@ func (ult *usageLookupTime) Get() time.Time {
 	return ult.value
 }
 
-// MaxDisk returns the maximum amount of disk space that this Filesystem
+// Returns the maximum amount of disk space that this Filesystem instance is allowed to use.
-// instance is allowed to use.
 func (fs *Filesystem) MaxDisk() int64 {
-	return fs.unixFS.Limit()
+	return atomic.LoadInt64(&fs.diskLimit)
 }
 
-// SetDiskLimit sets the disk space limit for this Filesystem instance.
+// Sets the disk space limit for this Filesystem instance.
 func (fs *Filesystem) SetDiskLimit(i int64) {
-	fs.unixFS.SetLimit(i)
+	atomic.SwapInt64(&fs.diskLimit, i)
 }
 
 // The same concept as HasSpaceAvailable however this will return an error if there is
@@ -69,7 +65,7 @@ func (fs *Filesystem) HasSpaceErr(allowStaleValue bool) error {
 func (fs *Filesystem) HasSpaceAvailable(allowStaleValue bool) bool {
 	size, err := fs.DiskUsage(allowStaleValue)
 	if err != nil {
-		log.WithField("root", fs.Path()).WithField("error", err).Warn("failed to determine root fs directory size")
+		log.WithField("root", fs.root).WithField("error", err).Warn("failed to determine root fs directory size")
 	}
 
 	// If space is -1 or 0 just return true, means they're allowed unlimited.
@@ -88,7 +84,7 @@ func (fs *Filesystem) HasSpaceAvailable(allowStaleValue bool) bool {
 // function for critical logical checks. It should only be used in areas where the actual disk usage
 // does not need to be perfect, e.g. API responses for server resource usage.
 func (fs *Filesystem) CachedUsage() int64 {
-	return fs.unixFS.Usage()
+	return atomic.LoadInt64(&fs.diskUsed)
 }
 
 // Internal helper function to allow other parts of the codebase to check the total used disk space
@@ -118,14 +114,14 @@ func (fs *Filesystem) DiskUsage(allowStaleValue bool) (int64, error) {
 			// currently performing a lookup, just do the disk usage calculation in the background.
 			go func(fs *Filesystem) {
 				if _, err := fs.updateCachedDiskUsage(); err != nil {
-					log.WithField("root", fs.Path()).WithField("error", err).Warn("failed to update fs disk usage from within routine")
+					log.WithField("root", fs.root).WithField("error", err).Warn("failed to update fs disk usage from within routine")
 				}
 			}(fs)
 		}
 	}
 
 	// Return the currently cached value back to the calling function.
-	return fs.unixFS.Usage(), nil
+	return atomic.LoadInt64(&fs.diskUsed), nil
 }
 
 // Updates the currently used disk space for a server.
@@ -153,56 +149,63 @@ func (fs *Filesystem) updateCachedDiskUsage() (int64, error) {
 	// error encountered.
 	fs.lastLookupTime.Set(time.Now())
 
-	fs.unixFS.SetUsage(size)
+	atomic.StoreInt64(&fs.diskUsed, size)
 
 	return size, err
 }
 
-// DirectorySize calculates the size of a directory and its descendants.
+// Determines the directory size of a given location by running parallel tasks to iterate
-func (fs *Filesystem) DirectorySize(root string) (int64, error) {
+// through all of the folders. Returns the size in bytes. This can be a fairly taxing operation
-	dirfd, name, closeFd, err := fs.unixFS.SafePath(root)
+// on locations with tons of files, so it is recommended that you cache the output.
-	defer closeFd()
+func (fs *Filesystem) DirectorySize(dir string) (int64, error) {
+	d, err := fs.SafePath(dir)
 	if err != nil {
 		return 0, err
 	}
 
-	var hardLinks []uint64
+	var size int64
+	var st syscall.Stat_t
 
-	var size atomic.Int64
+	err = godirwalk.Walk(d, &godirwalk.Options{
-	err = fs.unixFS.WalkDirat(dirfd, name, func(dirfd int, name, _ string, d ufs.DirEntry, err error) error {
+		Unsorted: true,
-		if err != nil {
+		Callback: func(p string, e *godirwalk.Dirent) error {
-			return errors.Wrap(err, "walkdirat err")
+			// If this is a symlink then resolve the final destination of it before trying to continue walking
-		}
+			// over its contents. If it resolves outside the server data directory just skip everything else for
+			// it. Otherwise, allow it to continue.
+			if e.IsSymlink() {
+				if _, err := fs.SafePath(p); err != nil {
+					if IsErrorCode(err, ErrCodePathResolution) {
+						return godirwalk.SkipThis
+					}
 
-		// Only calculate the size of regular files.
+					return err
-		if !d.Type().IsRegular() {
+				}
-			return nil
-		}
-
-		info, err := fs.unixFS.Lstatat(dirfd, name)
-		if err != nil {
-			return errors.Wrap(err, "lstatat err")
-		}
-
-		var sysFileInfo = info.Sys().(*unix.Stat_t)
-		if sysFileInfo.Nlink > 1 {
-			// Hard links have the same inode number
-			if slices.Contains(hardLinks, sysFileInfo.Ino) {
-				// Don't add hard links size twice
-				return nil
-			} else {
-				hardLinks = append(hardLinks, sysFileInfo.Ino)
 			}
-		}
 
-		size.Add(info.Size())
+			if !e.IsDir() {
-		return nil
+				syscall.Lstat(p, &st)
+				atomic.AddInt64(&size, st.Size)
+			}
+
+			return nil
+		},
 	})
-	return size.Load(), errors.WrapIf(err, "server/filesystem: directorysize: failed to walk directory")
+
+	return size, errors.WrapIf(err, "server/filesystem: directorysize: failed to walk directory")
 }
 
+// Helper function to determine if a server has space available for a file of a given size.
+// If space is available, no error will be returned, otherwise an ErrNotEnoughSpace error
+// will be raised.
 func (fs *Filesystem) HasSpaceFor(size int64) error {
-	if !fs.unixFS.CanFit(size) {
+	if fs.MaxDisk() == 0 {
+		return nil
+	}
+	s, err := fs.DiskUsage(true)
+	if err != nil {
+		return err
+	}
+	if (s + size) > fs.MaxDisk() {
 		return newFilesystemError(ErrCodeDiskSpace, nil)
 	}
 	return nil
@@ -210,5 +213,24 @@ func (fs *Filesystem) HasSpaceFor(size int64) error {
 
 // Updates the disk usage for the Filesystem instance.
 func (fs *Filesystem) addDisk(i int64) int64 {
-	return fs.unixFS.Add(i)
+	size := atomic.LoadInt64(&fs.diskUsed)
+
+	// Sorry go gods. This is ugly but the best approach I can come up with for right
+	// now without completely re-evaluating the logic we use for determining disk space.
+	//
+	// Normally I would just be using the atomic load right below, but I'm not sure about
+	// the scenarios where it is 0 because nothing has run that would trigger a disk size
+	// calculation?
+	//
+	// Perhaps that isn't even a concern for the sake of this?
+	if !fs.isTest {
+		size, _ = fs.DiskUsage(true)
+	}
+
+	// If we're dropping below 0 somehow just cap it to 0.
+	if (size + i) < 0 {
+		return atomic.SwapInt64(&fs.diskUsed, 0)
+	}
+
+	return atomic.AddInt64(&fs.diskUsed, i)
 }

server/filesystem/errors.go

@@ -2,12 +2,11 @@ package filesystem
 
 import (
 	"fmt"
+	"os"
 	"path/filepath"
 
 	"emperror.dev/errors"
 	"github.com/apex/log"
-
-	"github.com/pterodactyl/wings/internal/ufs"
 )
 
 type ErrorCode string
@@ -19,7 +18,6 @@ const (
 	ErrCodePathResolution ErrorCode = "E_BADPATH"
 	ErrCodeDenylistFile   ErrorCode = "E_DENYLIST"
 	ErrCodeUnknownError   ErrorCode = "E_UNKNOWN"
-	ErrNotExist           ErrorCode = "E_NOTEXIST"
 )
 
 type Error struct {
@@ -70,8 +68,6 @@ func (e *Error) Error() string {
 			r = "<empty>"
 		}
 		return fmt.Sprintf("filesystem: server path [%s] resolves to a location outside the server root: %s", e.path, r)
-	case ErrNotExist:
-		return "filesystem: does not exist"
 	case ErrCodeUnknownError:
 		fallthrough
 	default:
@@ -87,15 +83,15 @@ func (e *Error) Unwrap() error {
 
 // Generates an error logger instance with some basic information.
 func (fs *Filesystem) error(err error) *log.Entry {
-	return log.WithField("subsystem", "filesystem").WithField("root", fs.Path()).WithField("error", err)
+	return log.WithField("subsystem", "filesystem").WithField("root", fs.root).WithField("error", err)
 }
 
 // Handle errors encountered when walking through directories.
 //
 // If there is a path resolution error just skip the item entirely. Only return this for a
 // directory, otherwise return nil. Returning this error for a file will stop the walking
-// for the remainder of the directory. This is assuming an FileInfo struct was even returned.
+// for the remainder of the directory. This is assuming an os.FileInfo struct was even returned.
-func (fs *Filesystem) handleWalkerError(err error, f ufs.FileInfo) error {
+func (fs *Filesystem) handleWalkerError(err error, f os.FileInfo) error {
 	if !IsErrorCode(err, ErrCodePathResolution) {
 		return err
 	}

server/filesystem/filesystem.go

@@ -1,11 +1,13 @@
 package filesystem
 
 import (
-	"fmt"
+	"bufio"
 	"io"
+	"io/ioutil"
 	"os"
+	"path"
 	"path/filepath"
-	"slices"
+	"sort"
 	"strconv"
 	"strings"
 	"sync"
@@ -13,253 +15,265 @@ import (
 	"time"
 
 	"emperror.dev/errors"
-	"github.com/apex/log"
 	"github.com/gabriel-vasile/mimetype"
+	"github.com/karrick/godirwalk"
 	ignore "github.com/sabhiram/go-gitignore"
 
 	"github.com/pterodactyl/wings/config"
-	"github.com/pterodactyl/wings/internal/ufs"
+	"github.com/pterodactyl/wings/system"
 )
 
 type Filesystem struct {
-	unixFS *ufs.Quota
-
 	mu                sync.RWMutex
 	lastLookupTime    *usageLookupTime
-	lookupInProgress  atomic.Bool
+	lookupInProgress  *system.AtomicBool
+	diskUsed          int64
 	diskCheckInterval time.Duration
 	denylist          *ignore.GitIgnore
 
+	// The maximum amount of disk space (in bytes) that this Filesystem instance can use.
+	diskLimit int64
+
+	// The root data directory path for this Filesystem instance.
+	root string
+
 	isTest bool
 }
 
 // New creates a new Filesystem instance for a given server.
-func New(root string, size int64, denylist []string) (*Filesystem, error) {
+func New(root string, size int64, denylist []string) *Filesystem {
-	if err := os.MkdirAll(root, 0o755); err != nil {
-		return nil, err
-	}
-	unixFS, err := ufs.NewUnixFS(root, config.UseOpenat2())
-	if err != nil {
-		return nil, err
-	}
-	quota := ufs.NewQuota(unixFS, size)
-
 	return &Filesystem{
-		unixFS: quota,
+		root:              root,
-
+		diskLimit:         size,
 		diskCheckInterval: time.Duration(config.Get().System.DiskCheckInterval),
 		lastLookupTime:    &usageLookupTime{},
+		lookupInProgress:  system.NewAtomicBool(false),
 		denylist:          ignore.CompileIgnoreLines(denylist...),
-	}, nil
+	}
 }
 
 // Path returns the root path for the Filesystem instance.
 func (fs *Filesystem) Path() string {
-	return fs.unixFS.BasePath()
+	return fs.root
-}
-
-// ReadDir reads directory entries.
-func (fs *Filesystem) ReadDir(path string) ([]ufs.DirEntry, error) {
-	return fs.unixFS.ReadDir(path)
-}
-
-// ReadDirStat is like ReadDir except that it returns FileInfo for each entry
-// instead of just a DirEntry.
-func (fs *Filesystem) ReadDirStat(path string) ([]ufs.FileInfo, error) {
-	return ufs.ReadDirMap(fs.unixFS.UnixFS, path, func(e ufs.DirEntry) (ufs.FileInfo, error) {
-		return e.Info()
-	})
 }
 
 // File returns a reader for a file instance as well as the stat information.
-func (fs *Filesystem) File(p string) (ufs.File, Stat, error) {
+func (fs *Filesystem) File(p string) (*os.File, Stat, error) {
-	f, err := fs.unixFS.Open(p)
+	cleaned, err := fs.SafePath(p)
 	if err != nil {
 		return nil, Stat{}, err
 	}
-	st, err := statFromFile(f)
+	st, err := fs.Stat(cleaned)
+	if err != nil {
+		return nil, Stat{}, err
+	}
+	if st.IsDir() {
+		return nil, Stat{}, newFilesystemError(ErrCodeIsDirectory, nil)
+	}
+	f, err := os.Open(cleaned)
 	if err != nil {
-		_ = f.Close()
 		return nil, Stat{}, err
 	}
 	return f, st, nil
 }
 
-func (fs *Filesystem) UnixFS() *ufs.UnixFS {
+// Acts by creating the given file and path on the disk if it is not present already. If
-	return fs.unixFS.UnixFS
+// it is present, the file is opened using the defaults which will truncate the contents.
-}
+// The opened file is then returned to the caller.
-
+func (fs *Filesystem) Touch(p string, flag int) (*os.File, error) {
-// Touch acts by creating the given file and path on the disk if it is not present
+	cleaned, err := fs.SafePath(p)
-// already. If  it is present, the file is opened using the defaults which will truncate
+	if err != nil {
-// the contents. The opened file is then returned to the caller.
+		return nil, err
-func (fs *Filesystem) Touch(p string, flag int) (ufs.File, error) {
+	}
-	return fs.unixFS.Touch(p, flag, 0o644)
+	f, err := os.OpenFile(cleaned, flag, 0o644)
+	if err == nil {
+		return f, nil
+	}
+	// If the error is not because it doesn't exist then we just need to bail at this point.
+	if !errors.Is(err, os.ErrNotExist) {
+		return nil, errors.Wrap(err, "server/filesystem: touch: failed to open file handle")
+	}
+	// Only create and chown the directory if it doesn't exist.
+	if _, err := os.Stat(filepath.Dir(cleaned)); errors.Is(err, os.ErrNotExist) {
+		// Create the path leading up to the file we're trying to create, setting the final perms
+		// on it as we go.
+		if err := os.MkdirAll(filepath.Dir(cleaned), 0o755); err != nil {
+			return nil, errors.Wrap(err, "server/filesystem: touch: failed to create directory tree")
+		}
+		if err := fs.Chown(filepath.Dir(cleaned)); err != nil {
+			return nil, err
+		}
+	}
+	o := &fileOpener{}
+	// Try to open the file now that we have created the pathing necessary for it, and then
+	// Chown that file so that the permissions don't mess with things.
+	f, err = o.open(cleaned, flag, 0o644)
+	if err != nil {
+		return nil, errors.Wrap(err, "server/filesystem: touch: failed to open file with wait")
+	}
+	_ = fs.Chown(cleaned)
+	return f, nil
 }
 
 // Writefile writes a file to the system. If the file does not already exist one
 // will be created. This will also properly recalculate the disk space used by
 // the server when writing new files or modifying existing ones.
-//
-// DEPRECATED: use `Write` instead.
 func (fs *Filesystem) Writefile(p string, r io.Reader) error {
-	var currentSize int64
+	cleaned, err := fs.SafePath(p)
-	st, err := fs.unixFS.Stat(p)
-	if err != nil && !errors.Is(err, ufs.ErrNotExist) {
-		return errors.Wrap(err, "server/filesystem: writefile: failed to stat file")
-	} else if err == nil {
-		if st.IsDir() {
-			// TODO: resolved
-			return errors.WithStack(&Error{code: ErrCodeIsDirectory, resolved: ""})
-		}
-		currentSize = st.Size()
-	}
-
-	// Touch the file and return the handle to it at this point. This will
-	// create or truncate the file, and create any necessary parent directories
-	// if they are missing.
-	file, err := fs.unixFS.Touch(p, ufs.O_RDWR|ufs.O_TRUNC, 0o644)
 	if err != nil {
-		return fmt.Errorf("error touching file: %w", err)
+		return err
 	}
-	defer file.Close()
 
-	// Do not use CopyBuffer here, it is wasteful as the file implements
-	// io.ReaderFrom, which causes it to not use the buffer anyways.
-	n, err := io.Copy(file, r)
-
-	// Adjust the disk usage to account for the old size and the new size of the file.
-	fs.unixFS.Add(n - currentSize)
-
-	if err := fs.chownFile(p); err != nil {
-		return fmt.Errorf("error chowning file: %w", err)
-	}
-	// Return the error from io.Copy.
-	return err
-}
-
-func (fs *Filesystem) Write(p string, r io.Reader, newSize int64, mode ufs.FileMode) error {
 	var currentSize int64
-	st, err := fs.unixFS.Stat(p)
+	// If the file does not exist on the system already go ahead and create the pathway
-	if err != nil && !errors.Is(err, ufs.ErrNotExist) {
+	// to it and an empty file. We'll then write to it later on after this completes.
+	stat, err := os.Stat(cleaned)
+	if err != nil && !os.IsNotExist(err) {
 		return errors.Wrap(err, "server/filesystem: writefile: failed to stat file")
 	} else if err == nil {
-		if st.IsDir() {
+		if stat.IsDir() {
-			// TODO: resolved
+			return errors.WithStack(&Error{code: ErrCodeIsDirectory, resolved: cleaned})
-			return errors.WithStack(&Error{code: ErrCodeIsDirectory, resolved: ""})
 		}
-		currentSize = st.Size()
+		currentSize = stat.Size()
 	}
 
+	br := bufio.NewReader(r)
 	// Check that the new size we're writing to the disk can fit. If there is currently
 	// a file we'll subtract that current file size from the size of the buffer to determine
 	// the amount of new data we're writing (or amount we're removing if smaller).
-	if err := fs.HasSpaceFor(newSize - currentSize); err != nil {
+	if err := fs.HasSpaceFor(int64(br.Size()) - currentSize); err != nil {
 		return err
 	}
 
-	// Touch the file and return the handle to it at this point. This will
+	// Touch the file and return the handle to it at this point. This will create the file,
-	// create or truncate the file, and create any necessary parent directories
+	// any necessary directories, and set the proper owner of the file.
-	// if they are missing.
+	file, err := fs.Touch(cleaned, os.O_RDWR|os.O_CREATE|os.O_TRUNC)
-	file, err := fs.unixFS.Touch(p, ufs.O_RDWR|ufs.O_TRUNC, mode)
 	if err != nil {
 		return err
 	}
 	defer file.Close()
 
-	if newSize == 0 {
+	buf := make([]byte, 1024*4)
-		// Subtract the previous size of the file if the new size is 0.
+	sz, err := io.CopyBuffer(file, r, buf)
-		fs.unixFS.Add(-currentSize)
-	} else {
-		// Do not use CopyBuffer here, it is wasteful as the file implements
-		// io.ReaderFrom, which causes it to not use the buffer anyways.
-		var n int64
-		n, err = io.Copy(file, io.LimitReader(r, newSize))
 
-		// Adjust the disk usage to account for the old size and the new size of the file.
+	// Adjust the disk usage to account for the old size and the new size of the file.
-		fs.unixFS.Add(n - currentSize)
+	fs.addDisk(sz - currentSize)
-	}
 
-	if err := fs.chownFile(p); err != nil {
+	return fs.Chown(cleaned)
+}
+
+// Creates a new directory (name) at a specified path (p) for the server.
+func (fs *Filesystem) CreateDirectory(name string, p string) error {
+	cleaned, err := fs.SafePath(path.Join(p, name))
+	if err != nil {
 		return err
 	}
-	// Return any remaining error.
+	return os.MkdirAll(cleaned, 0o755)
-	return err
 }
 
-// CreateDirectory creates a new directory (name) at a specified path (p) for
+// Rename moves (or renames) a file or directory.
-// the server.
+func (fs *Filesystem) Rename(from string, to string) error {
-func (fs *Filesystem) CreateDirectory(name string, p string) error {
+	cleanedFrom, err := fs.SafePath(from)
-	return fs.unixFS.MkdirAll(filepath.Join(p, name), 0o755)
+	if err != nil {
-}
+		return errors.WithStack(err)
-
-func (fs *Filesystem) Rename(oldpath, newpath string) error {
-	return fs.unixFS.Rename(oldpath, newpath)
-}
-
-func (fs *Filesystem) Symlink(oldpath, newpath string) error {
-	return fs.unixFS.Symlink(oldpath, newpath)
-}
-
-func (fs *Filesystem) chownFile(name string) error {
-	if fs.isTest {
-		return nil
 	}
 
-	uid := config.Get().System.User.Uid
+	cleanedTo, err := fs.SafePath(to)
-	gid := config.Get().System.User.Gid
+	if err != nil {
-	return fs.unixFS.Lchown(name, uid, gid)
+		return errors.WithStack(err)
+	}
+
+	// If the target file or directory already exists the rename function will fail, so just
+	// bail out now.
+	if _, err := os.Stat(cleanedTo); err == nil {
+		return os.ErrExist
+	}
+
+	if cleanedTo == fs.Path() {
+		return errors.New("attempting to rename into an invalid directory space")
+	}
+
+	d := strings.TrimSuffix(cleanedTo, path.Base(cleanedTo))
+	// Ensure that the directory we're moving into exists correctly on the system. Only do this if
+	// we're not at the root directory level.
+	if d != fs.Path() {
+		if mkerr := os.MkdirAll(d, 0o755); mkerr != nil {
+			return errors.WithMessage(mkerr, "failed to create directory structure for file rename")
+		}
+	}
+
+	if err := os.Rename(cleanedFrom, cleanedTo); err != nil {
+		return errors.WithStack(err)
+	}
+	return nil
 }
 
-// Chown recursively iterates over a file or directory and sets the permissions on all of the
+// Recursively iterates over a file or directory and sets the permissions on all of the
 // underlying files. Iterate over all of the files and directories. If it is a file just
 // go ahead and perform the chown operation. Otherwise dig deeper into the directory until
 // we've run out of directories to dig into.
-func (fs *Filesystem) Chown(p string) error {
+func (fs *Filesystem) Chown(path string) error {
-	if fs.isTest {
+	cleaned, err := fs.SafePath(path)
-		return nil
-	}
-
-	uid := config.Get().System.User.Uid
-	gid := config.Get().System.User.Gid
-
-	dirfd, name, closeFd, err := fs.unixFS.SafePath(p)
-	defer closeFd()
 	if err != nil {
 		return err
 	}
 
+	if fs.isTest {
+		return nil
+	}
+
+	uid := config.Get().System.User.Uid
+	gid := config.Get().System.User.Gid
+
 	// Start by just chowning the initial path that we received.
-	if err := fs.unixFS.Lchownat(dirfd, name, uid, gid); err != nil {
+	if err := os.Chown(cleaned, uid, gid); err != nil {
 		return errors.Wrap(err, "server/filesystem: chown: failed to chown path")
 	}
 
 	// If this is not a directory we can now return from the function, there is nothing
 	// left that we need to do.
-	if st, err := fs.unixFS.Lstatat(dirfd, name); err != nil || !st.IsDir() {
+	if st, err := os.Stat(cleaned); err != nil || !st.IsDir() {
 		return nil
 	}
 
-	// This walker is probably some of the most efficient code in Wings. It has
+	// If this was a directory, begin walking over its contents recursively and ensure that all
-	// an internally re-used buffer for listing directory entries and doesn't
+	// of the subfiles and directories get their permissions updated as well.
-	// need to check if every individual path it touches is safe as the code
+	err = godirwalk.Walk(cleaned, &godirwalk.Options{
-	// doesn't traverse symlinks, is immune to symlink timing attacks, and
+		Unsorted: true,
-	// gives us a dirfd and file name to make a direct syscall with.
+		Callback: func(p string, e *godirwalk.Dirent) error {
-	if err := fs.unixFS.WalkDirat(dirfd, name, func(dirfd int, name, _ string, info ufs.DirEntry, err error) error {
+			// Do not attempt to chown a symlink. Go's os.Chown function will affect the symlink
-		if err != nil {
+			// so if it points to a location outside the data directory the user would be able to
-			return err
+			// (un)intentionally modify that files permissions.
-		}
+			if e.IsSymlink() {
-		if err := fs.unixFS.Lchownat(dirfd, name, uid, gid); err != nil {
+				if e.IsDir() {
-			return err
+					return godirwalk.SkipThis
-		}
+				}
-		return nil
+
-	}); err != nil {
+				return nil
-		return fmt.Errorf("server/filesystem: chown: failed to chown during walk function: %w", err)
+			}
-	}
+
-	return nil
+			return os.Chown(p, uid, gid)
+		},
+	})
+
+	return errors.Wrap(err, "server/filesystem: chown: failed to chown during walk function")
 }
 
-func (fs *Filesystem) Chmod(path string, mode ufs.FileMode) error {
+func (fs *Filesystem) Chmod(path string, mode os.FileMode) error {
-	return fs.unixFS.Chmod(path, mode)
+	cleaned, err := fs.SafePath(path)
+	if err != nil {
+		return err
+	}
+
+	if fs.isTest {
+		return nil
+	}
+
+	if err := os.Chmod(cleaned, mode); err != nil {
+		return err
+	}
+
+	return nil
 }
 
 // Begin looping up to 50 times to try and create a unique copy file name. This will take
@@ -270,7 +284,7 @@ func (fs *Filesystem) Chmod(path string, mode ufs.FileMode) error {
 // Could probably make this more efficient by checking if there are any files matching the copy
 // pattern, and trying to find the highest number and then incrementing it by one rather than
 // looping endlessly.
-func (fs *Filesystem) findCopySuffix(dirfd int, name, extension string) (string, error) {
+func (fs *Filesystem) findCopySuffix(dir string, name string, extension string) (string, error) {
 	var i int
 	suffix := " copy"
 
@@ -282,10 +296,11 @@ func (fs *Filesystem) findCopySuffix(dirfd int, name, extension string) (string,
 		n := name + suffix + extension
 		// If we stat the file and it does not exist that means we're good to create the copy. If it
 		// does exist, we'll just continue to the next loop and try again.
-		if _, err := fs.unixFS.Lstatat(dirfd, n); err != nil {
+		if _, err := fs.Stat(path.Join(dir, n)); err != nil {
-			if !errors.Is(err, ufs.ErrNotExist) {
+			if !errors.Is(err, os.ErrNotExist) {
 				return "", err
 			}
+
 			break
 		}
 
@@ -297,68 +312,53 @@ func (fs *Filesystem) findCopySuffix(dirfd int, name, extension string) (string,
 	return name + suffix + extension, nil
 }
 
-// Copy copies a given file to the same location and appends a suffix to the
+// Copies a given file to the same location and appends a suffix to the file to indicate that
-// file to indicate that it has been copied.
+// it has been copied.
 func (fs *Filesystem) Copy(p string) error {
-	dirfd, name, closeFd, err := fs.unixFS.SafePath(p)
+	cleaned, err := fs.SafePath(p)
-	defer closeFd()
 	if err != nil {
 		return err
 	}
-	source, err := fs.unixFS.OpenFileat(dirfd, name, ufs.O_RDONLY, 0)
+
+	s, err := os.Stat(cleaned)
 	if err != nil {
 		return err
-	}
+	} else if s.IsDir() || !s.Mode().IsRegular() {
-	defer source.Close()
-	info, err := source.Stat()
-	if err != nil {
-		return err
-	}
-	if info.IsDir() || !info.Mode().IsRegular() {
 		// If this is a directory or not a regular file, just throw a not-exist error
 		// since anything calling this function should understand what that means.
-		return ufs.ErrNotExist
+		return os.ErrNotExist
 	}
-	currentSize := info.Size()
 
 	// Check that copying this file wouldn't put the server over its limit.
-	if err := fs.HasSpaceFor(currentSize); err != nil {
+	if err := fs.HasSpaceFor(s.Size()); err != nil {
 		return err
 	}
 
-	base := info.Name()
+	base := filepath.Base(cleaned)
+	relative := strings.TrimSuffix(strings.TrimPrefix(cleaned, fs.Path()), base)
 	extension := filepath.Ext(base)
-	baseName := strings.TrimSuffix(base, extension)
+	name := strings.TrimSuffix(base, extension)
 
 	// Ensure that ".tar" is also counted as apart of the file extension.
 	// There might be a better way to handle this for other double file extensions,
 	// but this is a good workaround for now.
-	if strings.HasSuffix(baseName, ".tar") {
+	if strings.HasSuffix(name, ".tar") {
 		extension = ".tar" + extension
-		baseName = strings.TrimSuffix(baseName, ".tar")
+		name = strings.TrimSuffix(name, ".tar")
 	}
 
-	newName, err := fs.findCopySuffix(dirfd, baseName, extension)
+	source, err := os.Open(cleaned)
 	if err != nil {
 		return err
 	}
-	dst, err := fs.unixFS.OpenFileat(dirfd, newName, ufs.O_WRONLY|ufs.O_CREATE, info.Mode())
+	defer source.Close()
+
+	n, err := fs.findCopySuffix(relative, name, extension)
 	if err != nil {
 		return err
 	}
 
-	// Do not use CopyBuffer here, it is wasteful as the file implements
+	return fs.Writefile(path.Join(relative, n), source)
-	// io.ReaderFrom, which causes it to not use the buffer anyways.
-	n, err := io.Copy(dst, io.LimitReader(source, currentSize))
-	fs.unixFS.Add(n)
-
-	if !fs.isTest {
-		if err := fs.unixFS.Lchownat(dirfd, newName, config.Get().System.User.Uid, config.Get().System.User.Gid); err != nil {
-			return err
-		}
-	}
-	// Return the error from io.Copy.
-	return err
 }
 
 // TruncateRootDirectory removes _all_ files and directories from a server's
@@ -370,128 +370,172 @@ func (fs *Filesystem) TruncateRootDirectory() error {
 	if err := os.Mkdir(fs.Path(), 0o755); err != nil {
 		return err
 	}
-	_ = fs.unixFS.Close()
+	atomic.StoreInt64(&fs.diskUsed, 0)
-	unixFS, err := ufs.NewUnixFS(fs.Path(), config.UseOpenat2())
-	if err != nil {
-		return err
-	}
-	var limit int64
-	if fs.isTest {
-		limit = 0
-	} else {
-		limit = fs.unixFS.Limit()
-	}
-	fs.unixFS = ufs.NewQuota(unixFS, limit)
 	return nil
 }
 
 // Delete removes a file or folder from the system. Prevents the user from
 // accidentally (or maliciously) removing their root server data directory.
 func (fs *Filesystem) Delete(p string) error {
-	return fs.unixFS.RemoveAll(p)
+	wg := sync.WaitGroup{}
+	// This is one of the few (only?) places in the codebase where we're explicitly not using
+	// the SafePath functionality when working with user provided input. If we did, you would
+	// not be able to delete a file that is a symlink pointing to a location outside of the data
+	// directory.
+	//
+	// We also want to avoid resolving a symlink that points _within_ the data directory and thus
+	// deleting the actual source file for the symlink rather than the symlink itself. For these
+	// purposes just resolve the actual file path using filepath.Join() and confirm that the path
+	// exists within the data directory.
+	resolved := fs.unsafeFilePath(p)
+	if !fs.unsafeIsInDataDirectory(resolved) {
+		return NewBadPathResolution(p, resolved)
+	}
+
+	// Block any whoopsies.
+	if resolved == fs.Path() {
+		return errors.New("cannot delete root server directory")
+	}
+
+	if st, err := os.Lstat(resolved); err != nil {
+		if !os.IsNotExist(err) {
+			fs.error(err).Warn("error while attempting to stat file before deletion")
+		}
+	} else {
+		if !st.IsDir() {
+			fs.addDisk(-st.Size())
+		} else {
+			wg.Add(1)
+			go func(wg *sync.WaitGroup, st os.FileInfo, resolved string) {
+				defer wg.Done()
+				if s, err := fs.DirectorySize(resolved); err == nil {
+					fs.addDisk(-s)
+				}
+			}(&wg, st, resolved)
+		}
+	}
+
+	wg.Wait()
+
+	return os.RemoveAll(resolved)
 }
 
-//type fileOpener struct {
+type fileOpener struct {
-//	fs   *Filesystem
+	busy uint
-//	busy uint
+}
-//}
+
-//
+// Attempts to open a given file up to "attempts" number of times, using a backoff. If the file
-//// Attempts to open a given file up to "attempts" number of times, using a backoff. If the file
+// cannot be opened because of a "text file busy" error, we will attempt until the number of attempts
-//// cannot be opened because of a "text file busy" error, we will attempt until the number of attempts
+// has been exhaused, at which point we will abort with an error.
-//// has been exhaused, at which point we will abort with an error.
+func (fo *fileOpener) open(path string, flags int, perm os.FileMode) (*os.File, error) {
-//func (fo *fileOpener) open(path string, flags int, perm ufs.FileMode) (ufs.File, error) {
+	for {
-//	for {
+		f, err := os.OpenFile(path, flags, perm)
-//		f, err := fo.fs.unixFS.OpenFile(path, flags, perm)
+
-//
+		// If there is an error because the text file is busy, go ahead and sleep for a few
-//		// If there is an error because the text file is busy, go ahead and sleep for a few
+		// hundred milliseconds and then try again up to three times before just returning the
-//		// hundred milliseconds and then try again up to three times before just returning the
+		// error back to the caller.
-//		// error back to the caller.
+		//
-//		//
+		// Based on code from: https://github.com/golang/go/issues/22220#issuecomment-336458122
-//		// Based on code from: https://github.com/golang/go/issues/22220#issuecomment-336458122
+		if err != nil && fo.busy < 3 && strings.Contains(err.Error(), "text file busy") {
-//		if err != nil && fo.busy < 3 && strings.Contains(err.Error(), "text file busy") {
+			time.Sleep(100 * time.Millisecond << fo.busy)
-//			time.Sleep(100 * time.Millisecond << fo.busy)
+			fo.busy++
-//			fo.busy++
+			continue
-//			continue
+		}
-//		}
+
-//
+		return f, err
-//		return f, err
+	}
-//	}
+}
-//}
 
 // ListDirectory lists the contents of a given directory and returns stat
 // information about each file and folder within it.
 func (fs *Filesystem) ListDirectory(p string) ([]Stat, error) {
-	// Read entries from the path on the filesystem, using the mapped reader, so
+	cleaned, err := fs.SafePath(p)
-	// we can map the DirEntry slice into a Stat slice with mimetype information.
-	out, err := ufs.ReadDirMap(fs.unixFS.UnixFS, p, func(e ufs.DirEntry) (Stat, error) {
-		info, err := e.Info()
-		if err != nil {
-			return Stat{}, err
-		}
-
-		var d string
-		if e.Type().IsDir() {
-			d = "inode/directory"
-		} else {
-			d = "application/octet-stream"
-		}
-		var m *mimetype.MIME
-		if e.Type().IsRegular() {
-			// TODO: I should probably find a better way to do this.
-			eO := e.(interface {
-				Open() (ufs.File, error)
-			})
-			f, err := eO.Open()
-			if err != nil {
-				return Stat{}, err
-			}
-			m, err = mimetype.DetectReader(f)
-			if err != nil {
-				log.Error(err.Error())
-			}
-			_ = f.Close()
-		}
-
-		st := Stat{FileInfo: info, Mimetype: d}
-		if m != nil {
-			st.Mimetype = m.String()
-		}
-		return st, nil
-	})
 	if err != nil {
 		return nil, err
 	}
 
-	// Sort entries alphabetically.
+	files, err := ioutil.ReadDir(cleaned)
-	slices.SortStableFunc(out, func(a, b Stat) int {
+	if err != nil {
-		switch {
+		return nil, err
-		case a.Name() == b.Name():
+	}
-			return 0
+
-		case a.Name() > b.Name():
+	var wg sync.WaitGroup
-			return 1
+
-		default:
+	// You must initialize the output of this directory as a non-nil value otherwise
-			return -1
+	// when it is marshaled into a JSON object you'll just get 'null' back, which will
+	// break the panel badly.
+	out := make([]Stat, len(files))
+
+	// Iterate over all of the files and directories returned and perform an async process
+	// to get the mime-type for them all.
+	for i, file := range files {
+		wg.Add(1)
+
+		go func(idx int, f os.FileInfo) {
+			defer wg.Done()
+
+			var m *mimetype.MIME
+			d := "inode/directory"
+			if !f.IsDir() {
+				cleanedp := filepath.Join(cleaned, f.Name())
+				if f.Mode()&os.ModeSymlink != 0 {
+					cleanedp, _ = fs.SafePath(filepath.Join(cleaned, f.Name()))
+				}
+
+				// Don't try to detect the type on a pipe — this will just hang the application and
+				// you'll never get a response back.
+				//
+				// @see https://github.com/pterodactyl/panel/issues/4059
+				if cleanedp != "" && f.Mode()&os.ModeNamedPipe == 0 {
+					m, _ = mimetype.DetectFile(filepath.Join(cleaned, f.Name()))
+				} else {
+					// Just pass this for an unknown type because the file could not safely be resolved within
+					// the server data path.
+					d = "application/octet-stream"
+				}
+			}
+
+			st := Stat{FileInfo: f, Mimetype: d}
+			if m != nil {
+				st.Mimetype = m.String()
+			}
+			out[idx] = st
+		}(i, file)
+	}
+
+	wg.Wait()
+
+	// Sort the output alphabetically to begin with since we've run the output
+	// through an asynchronous process and the order is gonna be very random.
+	sort.SliceStable(out, func(i, j int) bool {
+		if out[i].Name() == out[j].Name() || out[i].Name() > out[j].Name() {
+			return true
 		}
+		return false
 	})
 
-	// Sort folders before other file types.
+	// Then, sort it so that directories are listed first in the output. Everything
-	slices.SortStableFunc(out, func(a, b Stat) int {
+	// will continue to be alphabetized at this point.
-		switch {
+	sort.SliceStable(out, func(i, j int) bool {
-		case a.IsDir() && b.IsDir():
+		return out[i].IsDir()
-			return 0
-		case a.IsDir():
-			return -1
-		default:
-			return 1
-		}
 	})
 
 	return out, nil
 }
 
 func (fs *Filesystem) Chtimes(path string, atime, mtime time.Time) error {
+	cleaned, err := fs.SafePath(path)
+	if err != nil {
+		return err
+	}
+
 	if fs.isTest {
 		return nil
 	}
-	return fs.unixFS.Chtimes(path, atime, mtime)
+
+	if err := os.Chtimes(cleaned, atime, mtime); err != nil {
+		return err
+	}
+
+	return nil
 }

server/filesystem/filesystem_test.go

@@ -7,13 +7,12 @@ import (
 	"math/rand"
 	"os"
 	"path/filepath"
+	"sync/atomic"
 	"testing"
 	"unicode/utf8"
 
 	. "github.com/franela/goblin"
 
-	"github.com/pterodactyl/wings/internal/ufs"
-
 	"github.com/pterodactyl/wings/config"
 )
 
@@ -29,23 +28,15 @@ func NewFs() (*Filesystem, *rootFs) {
 	tmpDir, err := os.MkdirTemp(os.TempDir(), "pterodactyl")
 	if err != nil {
 		panic(err)
-		return nil, nil
 	}
+	// defer os.RemoveAll(tmpDir)
 
 	rfs := rootFs{root: tmpDir}
 
-	p := filepath.Join(tmpDir, "server")
+	rfs.reset()
-	if err := os.Mkdir(p, 0o755); err != nil {
-		panic(err)
-		return nil, nil
-	}
 
-	fs, _ := New(p, 0, []string{})
+	fs := New(filepath.Join(tmpDir, "/server"), 0, []string{})
 	fs.isTest = true
-	if err := fs.TruncateRootDirectory(); err != nil {
-		panic(err)
-		return nil, nil
-	}
 
 	return fs, &rfs
 }
@@ -54,7 +45,7 @@ type rootFs struct {
 	root string
 }
 
-func getFileContent(file ufs.File) string {
+func getFileContent(file *os.File) string {
 	var w bytes.Buffer
 	if _, err := bufio.NewReader(file).WriteTo(&w); err != nil {
 		panic(err)
@@ -63,11 +54,11 @@ func getFileContent(file ufs.File) string {
 }
 
 func (rfs *rootFs) CreateServerFile(p string, c []byte) error {
-	f, err := os.Create(filepath.Join(rfs.root, "server", p))
+	f, err := os.Create(filepath.Join(rfs.root, "/server", p))
 
 	if err == nil {
-		_, _ = f.Write(c)
+		f.Write(c)
-		_ = f.Close()
+		f.Close()
 	}
 
 	return err
@@ -78,42 +69,24 @@ func (rfs *rootFs) CreateServerFileFromString(p string, c string) error {
 }
 
 func (rfs *rootFs) StatServerFile(p string) (os.FileInfo, error) {
-	return os.Stat(filepath.Join(rfs.root, "server", p))
+	return os.Stat(filepath.Join(rfs.root, "/server", p))
 }
 
-func TestFilesystem_Openfile(t *testing.T) {
+func (rfs *rootFs) reset() {
-	g := Goblin(t)
+	if err := os.RemoveAll(filepath.Join(rfs.root, "/server")); err != nil {
-	fs, rfs := NewFs()
+		if !os.IsNotExist(err) {
+			panic(err)
+		}
+	}
 
-	g.Describe("File", func() {
+	if err := os.Mkdir(filepath.Join(rfs.root, "/server"), 0o755); err != nil {
-		g.It("returns custom error when file does not exist", func() {
+		panic(err)
-			_, _, err := fs.File("foo/bar.txt")
+	}
-
-			g.Assert(err).IsNotNil()
-			// TODO
-			//g.Assert(IsErrorCode(err, ErrNotExist)).IsTrue()
-		})
-
-		g.It("returns file stat information", func() {
-			_ = rfs.CreateServerFile("foo.txt", []byte("hello world"))
-
-			f, st, err := fs.File("foo.txt")
-			g.Assert(err).IsNil()
-
-			g.Assert(st.Name()).Equal("foo.txt")
-			g.Assert(f).IsNotNil()
-			_ = f.Close()
-		})
-
-		g.AfterEach(func() {
-			_ = fs.TruncateRootDirectory()
-		})
-	})
 }
 
 func TestFilesystem_Writefile(t *testing.T) {
 	g := Goblin(t)
-	fs, _ := NewFs()
+	fs, rfs := NewFs()
 
 	g.Describe("Open and WriteFile", func() {
 		buf := &bytes.Buffer{}
@@ -123,22 +96,22 @@ func TestFilesystem_Writefile(t *testing.T) {
 		g.It("can create a new file", func() {
 			r := bytes.NewReader([]byte("test file content"))
 
-			g.Assert(fs.CachedUsage()).Equal(int64(0))
+			g.Assert(atomic.LoadInt64(&fs.diskUsed)).Equal(int64(0))
 
-			err := fs.Write("test.txt", r, r.Size(), 0o644)
+			err := fs.Writefile("test.txt", r)
 			g.Assert(err).IsNil()
 
 			f, _, err := fs.File("test.txt")
 			g.Assert(err).IsNil()
 			defer f.Close()
 			g.Assert(getFileContent(f)).Equal("test file content")
-			g.Assert(fs.CachedUsage()).Equal(r.Size())
+			g.Assert(atomic.LoadInt64(&fs.diskUsed)).Equal(r.Size())
 		})
 
 		g.It("can create a new file inside a nested directory with leading slash", func() {
 			r := bytes.NewReader([]byte("test file content"))
 
-			err := fs.Write("/some/nested/test.txt", r, r.Size(), 0o644)
+			err := fs.Writefile("/some/nested/test.txt", r)
 			g.Assert(err).IsNil()
 
 			f, _, err := fs.File("/some/nested/test.txt")
@@ -150,7 +123,7 @@ func TestFilesystem_Writefile(t *testing.T) {
 		g.It("can create a new file inside a nested directory without a trailing slash", func() {
 			r := bytes.NewReader([]byte("test file content"))
 
-			err := fs.Write("some/../foo/bar/test.txt", r, r.Size(), 0o644)
+			err := fs.Writefile("some/../foo/bar/test.txt", r)
 			g.Assert(err).IsNil()
 
 			f, _, err := fs.File("foo/bar/test.txt")
@@ -162,13 +135,13 @@ func TestFilesystem_Writefile(t *testing.T) {
 		g.It("cannot create a file outside the root directory", func() {
 			r := bytes.NewReader([]byte("test file content"))
 
-			err := fs.Write("/some/../foo/../../test.txt", r, r.Size(), 0o644)
+			err := fs.Writefile("/some/../foo/../../test.txt", r)
 			g.Assert(err).IsNotNil()
-			g.Assert(errors.Is(err, ufs.ErrBadPathResolution)).IsTrue("err is not ErrBadPathResolution")
+			g.Assert(IsErrorCode(err, ErrCodePathResolution)).IsTrue()
 		})
 
 		g.It("cannot write a file that exceeds the disk limits", func() {
-			fs.SetDiskLimit(1024)
+			atomic.StoreInt64(&fs.diskLimit, 1024)
 
 			b := make([]byte, 1025)
 			_, err := rand.Read(b)
@@ -176,18 +149,18 @@ func TestFilesystem_Writefile(t *testing.T) {
 			g.Assert(len(b)).Equal(1025)
 
 			r := bytes.NewReader(b)
-			err = fs.Write("test.txt", r, int64(len(b)), 0o644)
+			err = fs.Writefile("test.txt", r)
 			g.Assert(err).IsNotNil()
 			g.Assert(IsErrorCode(err, ErrCodeDiskSpace)).IsTrue()
 		})
 
 		g.It("truncates the file when writing new contents", func() {
 			r := bytes.NewReader([]byte("original data"))
-			err := fs.Write("test.txt", r, r.Size(), 0o644)
+			err := fs.Writefile("test.txt", r)
 			g.Assert(err).IsNil()
 
 			r = bytes.NewReader([]byte("new data"))
-			err = fs.Write("test.txt", r, r.Size(), 0o644)
+			err = fs.Writefile("test.txt", r)
 			g.Assert(err).IsNil()
 
 			f, _, err := fs.File("test.txt")
@@ -198,7 +171,10 @@ func TestFilesystem_Writefile(t *testing.T) {
 
 		g.AfterEach(func() {
 			buf.Truncate(0)
-			_ = fs.TruncateRootDirectory()
+			rfs.reset()
+
+			atomic.StoreInt64(&fs.diskUsed, 0)
+			atomic.StoreInt64(&fs.diskLimit, 0)
 		})
 	})
 }
@@ -231,17 +207,17 @@ func TestFilesystem_CreateDirectory(t *testing.T) {
 		g.It("should not allow the creation of directories outside the root", func() {
 			err := fs.CreateDirectory("test", "e/../../something")
 			g.Assert(err).IsNotNil()
-			g.Assert(errors.Is(err, ufs.ErrBadPathResolution)).IsTrue("err is not ErrBadPathResolution")
+			g.Assert(IsErrorCode(err, ErrCodePathResolution)).IsTrue()
 		})
 
 		g.It("should not increment the disk usage", func() {
 			err := fs.CreateDirectory("test", "/")
 			g.Assert(err).IsNil()
-			g.Assert(fs.CachedUsage()).Equal(int64(0))
+			g.Assert(atomic.LoadInt64(&fs.diskUsed)).Equal(int64(0))
 		})
 
 		g.AfterEach(func() {
-			_ = fs.TruncateRootDirectory()
+			rfs.reset()
 		})
 	})
 }
@@ -263,25 +239,25 @@ func TestFilesystem_Rename(t *testing.T) {
 
 			err = fs.Rename("source.txt", "target.txt")
 			g.Assert(err).IsNotNil()
-			g.Assert(errors.Is(err, ufs.ErrExist)).IsTrue("err is not ErrExist")
+			g.Assert(errors.Is(err, os.ErrExist)).IsTrue()
 		})
 
 		g.It("returns an error if the final destination is the root directory", func() {
 			err := fs.Rename("source.txt", "/")
 			g.Assert(err).IsNotNil()
-			g.Assert(errors.Is(err, ufs.ErrBadPathResolution)).IsTrue("err is not ErrBadPathResolution")
+			g.Assert(errors.Is(err, os.ErrExist)).IsTrue()
 		})
 
 		g.It("returns an error if the source destination is the root directory", func() {
-			err := fs.Rename("/", "target.txt")
+			err := fs.Rename("source.txt", "/")
 			g.Assert(err).IsNotNil()
-			g.Assert(errors.Is(err, ufs.ErrBadPathResolution)).IsTrue("err is not ErrBadPathResolution")
+			g.Assert(errors.Is(err, os.ErrExist)).IsTrue()
 		})
 
 		g.It("does not allow renaming to a location outside the root", func() {
 			err := fs.Rename("source.txt", "../target.txt")
 			g.Assert(err).IsNotNil()
-			g.Assert(errors.Is(err, ufs.ErrBadPathResolution)).IsTrue("err is not ErrBadPathResolution")
+			g.Assert(IsErrorCode(err, ErrCodePathResolution)).IsTrue()
 		})
 
 		g.It("does not allow renaming from a location outside the root", func() {
@@ -289,7 +265,7 @@ func TestFilesystem_Rename(t *testing.T) {
 
 			err = fs.Rename("/../ext-source.txt", "target.txt")
 			g.Assert(err).IsNotNil()
-			g.Assert(errors.Is(err, ufs.ErrBadPathResolution)).IsTrue("err is not ErrBadPathResolution")
+			g.Assert(IsErrorCode(err, ErrCodePathResolution)).IsTrue()
 		})
 
 		g.It("allows a file to be renamed", func() {
@@ -298,7 +274,7 @@ func TestFilesystem_Rename(t *testing.T) {
 
 			_, err = rfs.StatServerFile("source.txt")
 			g.Assert(err).IsNotNil()
-			g.Assert(errors.Is(err, ufs.ErrNotExist)).IsTrue("err is not ErrNotExist")
+			g.Assert(errors.Is(err, os.ErrNotExist)).IsTrue()
 
 			st, err := rfs.StatServerFile("target.txt")
 			g.Assert(err).IsNil()
@@ -315,7 +291,7 @@ func TestFilesystem_Rename(t *testing.T) {
 
 			_, err = rfs.StatServerFile("source_dir")
 			g.Assert(err).IsNotNil()
-			g.Assert(errors.Is(err, ufs.ErrNotExist)).IsTrue("err is not ErrNotExist")
+			g.Assert(errors.Is(err, os.ErrNotExist)).IsTrue()
 
 			st, err := rfs.StatServerFile("target_dir")
 			g.Assert(err).IsNil()
@@ -325,7 +301,7 @@ func TestFilesystem_Rename(t *testing.T) {
 		g.It("returns an error if the source does not exist", func() {
 			err := fs.Rename("missing.txt", "target.txt")
 			g.Assert(err).IsNotNil()
-			g.Assert(errors.Is(err, ufs.ErrNotExist)).IsTrue("err is not ErrNotExist")
+			g.Assert(errors.Is(err, os.ErrNotExist)).IsTrue()
 		})
 
 		g.It("creates directories if they are missing", func() {
@@ -338,7 +314,7 @@ func TestFilesystem_Rename(t *testing.T) {
 		})
 
 		g.AfterEach(func() {
-			_ = fs.TruncateRootDirectory()
+			rfs.reset()
 		})
 	})
 }
@@ -353,13 +329,13 @@ func TestFilesystem_Copy(t *testing.T) {
 				panic(err)
 			}
 
-			fs.unixFS.SetUsage(int64(utf8.RuneCountInString("test content")))
+			atomic.StoreInt64(&fs.diskUsed, int64(utf8.RuneCountInString("test content")))
 		})
 
 		g.It("should return an error if the source does not exist", func() {
 			err := fs.Copy("foo.txt")
 			g.Assert(err).IsNotNil()
-			g.Assert(errors.Is(err, ufs.ErrNotExist)).IsTrue("err is not ErrNotExist")
+			g.Assert(errors.Is(err, os.ErrNotExist)).IsTrue()
 		})
 
 		g.It("should return an error if the source is outside the root", func() {
@@ -367,11 +343,11 @@ func TestFilesystem_Copy(t *testing.T) {
 
 			err = fs.Copy("../ext-source.txt")
 			g.Assert(err).IsNotNil()
-			g.Assert(errors.Is(err, ufs.ErrBadPathResolution)).IsTrue("err is not ErrBadPathResolution")
+			g.Assert(IsErrorCode(err, ErrCodePathResolution)).IsTrue()
 		})
 
 		g.It("should return an error if the source directory is outside the root", func() {
-			err := os.MkdirAll(filepath.Join(rfs.root, "nested/in/dir"), 0o755)
+			err := os.MkdirAll(filepath.Join(rfs.root, "/nested/in/dir"), 0o755)
 			g.Assert(err).IsNil()
 
 			err = rfs.CreateServerFileFromString("/../nested/in/dir/ext-source.txt", "external content")
@@ -379,28 +355,28 @@ func TestFilesystem_Copy(t *testing.T) {
 
 			err = fs.Copy("../nested/in/dir/ext-source.txt")
 			g.Assert(err).IsNotNil()
-			g.Assert(errors.Is(err, ufs.ErrBadPathResolution)).IsTrue("err is not ErrBadPathResolution")
+			g.Assert(IsErrorCode(err, ErrCodePathResolution)).IsTrue()
 
 			err = fs.Copy("nested/in/../../../nested/in/dir/ext-source.txt")
 			g.Assert(err).IsNotNil()
-			g.Assert(errors.Is(err, ufs.ErrBadPathResolution)).IsTrue("err is not ErrBadPathResolution")
+			g.Assert(IsErrorCode(err, ErrCodePathResolution)).IsTrue()
 		})
 
 		g.It("should return an error if the source is a directory", func() {
-			err := os.Mkdir(filepath.Join(rfs.root, "server/dir"), 0o755)
+			err := os.Mkdir(filepath.Join(rfs.root, "/server/dir"), 0o755)
 			g.Assert(err).IsNil()
 
 			err = fs.Copy("dir")
 			g.Assert(err).IsNotNil()
-			g.Assert(errors.Is(err, ufs.ErrNotExist)).IsTrue("err is not ErrNotExist")
+			g.Assert(errors.Is(err, os.ErrNotExist)).IsTrue()
 		})
 
 		g.It("should return an error if there is not space to copy the file", func() {
-			fs.SetDiskLimit(2)
+			atomic.StoreInt64(&fs.diskLimit, 2)
 
 			err := fs.Copy("source.txt")
 			g.Assert(err).IsNotNil()
-			g.Assert(IsErrorCode(err, ErrCodeDiskSpace)).IsTrue("err is not ErrCodeDiskSpace")
+			g.Assert(IsErrorCode(err, ErrCodeDiskSpace)).IsTrue()
 		})
 
 		g.It("should create a copy of the file and increment the disk used", func() {
@@ -428,7 +404,7 @@ func TestFilesystem_Copy(t *testing.T) {
 				g.Assert(err).IsNil()
 			}
 
-			g.Assert(fs.CachedUsage()).Equal(int64(utf8.RuneCountInString("test content")) * 3)
+			g.Assert(atomic.LoadInt64(&fs.diskUsed)).Equal(int64(utf8.RuneCountInString("test content")) * 3)
 		})
 
 		g.It("should create a copy inside of a directory", func() {
@@ -449,7 +425,10 @@ func TestFilesystem_Copy(t *testing.T) {
 		})
 
 		g.AfterEach(func() {
-			_ = fs.TruncateRootDirectory()
+			rfs.reset()
+
+			atomic.StoreInt64(&fs.diskUsed, 0)
+			atomic.StoreInt64(&fs.diskLimit, 0)
 		})
 	})
 }
@@ -464,7 +443,7 @@ func TestFilesystem_Delete(t *testing.T) {
 				panic(err)
 			}
 
-			fs.unixFS.SetUsage(int64(utf8.RuneCountInString("test content")))
+			atomic.StoreInt64(&fs.diskUsed, int64(utf8.RuneCountInString("test content")))
 		})
 
 		g.It("does not delete files outside the root directory", func() {
@@ -472,13 +451,13 @@ func TestFilesystem_Delete(t *testing.T) {
 
 			err = fs.Delete("../ext-source.txt")
 			g.Assert(err).IsNotNil()
-			g.Assert(errors.Is(err, ufs.ErrBadPathResolution)).IsTrue("err is not ErrBadPathResolution")
+			g.Assert(IsErrorCode(err, ErrCodePathResolution)).IsTrue()
 		})
 
 		g.It("does not allow the deletion of the root directory", func() {
 			err := fs.Delete("/")
 			g.Assert(err).IsNotNil()
-			g.Assert(errors.Is(err, ufs.ErrBadPathResolution)).IsTrue("err is not ErrBadPathResolution")
+			g.Assert(err.Error()).Equal("cannot delete root server directory")
 		})
 
 		g.It("does not return an error if the target does not exist", func() {
@@ -496,9 +475,9 @@ func TestFilesystem_Delete(t *testing.T) {
 
 			_, err = rfs.StatServerFile("source.txt")
 			g.Assert(err).IsNotNil()
-			g.Assert(errors.Is(err, ufs.ErrNotExist)).IsTrue("err is not ErrNotExist")
+			g.Assert(errors.Is(err, os.ErrNotExist)).IsTrue()
 
-			g.Assert(fs.CachedUsage()).Equal(int64(0))
+			g.Assert(atomic.LoadInt64(&fs.diskUsed)).Equal(int64(0))
 		})
 
 		g.It("deletes all items inside a directory if the directory is deleted", func() {
@@ -516,95 +495,24 @@ func TestFilesystem_Delete(t *testing.T) {
 				g.Assert(err).IsNil()
 			}
 
-			fs.unixFS.SetUsage(int64(utf8.RuneCountInString("test content") * 3))
+			atomic.StoreInt64(&fs.diskUsed, int64(utf8.RuneCountInString("test content")*3))
 
 			err = fs.Delete("foo")
 			g.Assert(err).IsNil()
-			g.Assert(fs.unixFS.Usage()).Equal(int64(0))
+			g.Assert(atomic.LoadInt64(&fs.diskUsed)).Equal(int64(0))
 
 			for _, s := range sources {
 				_, err = rfs.StatServerFile(s)
 				g.Assert(err).IsNotNil()
-				g.Assert(errors.Is(err, ufs.ErrNotExist)).IsTrue("err is not ErrNotExist")
+				g.Assert(errors.Is(err, os.ErrNotExist)).IsTrue()
 			}
 		})
 
-		g.It("deletes a symlink but not it's target within the root directory", func() {
-			// Symlink to a file inside the root directory.
-			err := os.Symlink(filepath.Join(rfs.root, "server/source.txt"), filepath.Join(rfs.root, "server/symlink.txt"))
-			g.Assert(err).IsNil()
-
-			// Delete the symlink itself.
-			err = fs.Delete("symlink.txt")
-			g.Assert(err).IsNil()
-
-			// Ensure the symlink was deleted.
-			_, err = os.Lstat(filepath.Join(rfs.root, "server/symlink.txt"))
-			g.Assert(err).IsNotNil()
-
-			// Ensure the symlink target still exists.
-			_, err = os.Lstat(filepath.Join(rfs.root, "server/source.txt"))
-			g.Assert(err).IsNil()
-		})
-
-		g.It("does not delete files symlinked outside of the root directory", func() {
-			// Create a file outside the root directory.
-			err := rfs.CreateServerFileFromString("/../source.txt", "test content")
-			g.Assert(err).IsNil()
-
-			// Create a symlink to the file outside the root directory.
-			err = os.Symlink(filepath.Join(rfs.root, "source.txt"), filepath.Join(rfs.root, "/server/symlink.txt"))
-			g.Assert(err).IsNil()
-
-			// Delete the symlink. (This should pass as we will delete the symlink itself, not it's target)
-			err = fs.Delete("symlink.txt")
-			g.Assert(err).IsNil()
-
-			// Ensure the file outside the root directory still exists.
-			_, err = os.Lstat(filepath.Join(rfs.root, "source.txt"))
-			g.Assert(err).IsNil()
-		})
-
-		g.It("does not delete files symlinked through a directory outside of the root directory", func() {
-			// Create a directory outside the root directory.
-			err := os.Mkdir(filepath.Join(rfs.root, "foo"), 0o755)
-			g.Assert(err).IsNil()
-
-			// Create a file inside the directory that is outside the root.
-			err = rfs.CreateServerFileFromString("/../foo/source.txt", "test content")
-			g.Assert(err).IsNil()
-
-			// Symlink the directory that is outside the root to a file inside the root.
-			err = os.Symlink(filepath.Join(rfs.root, "foo"), filepath.Join(rfs.root, "server/symlink"))
-			g.Assert(err).IsNil()
-
-			// Delete a file inside the symlinked directory.
-			err = fs.Delete("symlink/source.txt")
-			g.Assert(err).IsNotNil()
-			g.Assert(errors.Is(err, ufs.ErrBadPathResolution)).IsTrue("err is not ErrBadPathResolution")
-
-			// Ensure the file outside the root directory still exists.
-			_, err = os.Lstat(filepath.Join(rfs.root, "foo/source.txt"))
-			g.Assert(err).IsNil()
-		})
-
-		g.It("returns an error when trying to delete a non-existent file symlinked through a directory outside of the root directory", func() {
-			// Create a directory outside the root directory.
-			err := os.Mkdir(filepath.Join(rfs.root, "foo2"), 0o755)
-			g.Assert(err).IsNil()
-
-			// Symlink the directory that is outside the root to a file inside the root.
-			err = os.Symlink(filepath.Join(rfs.root, "foo2"), filepath.Join(rfs.root, "server/symlink"))
-			g.Assert(err).IsNil()
-
-			// Delete a file inside the symlinked directory.
-			err = fs.Delete("symlink/source.txt")
-			g.Assert(err).IsNotNil()
-			g.Assert(errors.Is(err, ufs.ErrBadPathResolution)).IsTrue("err is not ErrBadPathResolution")
-		})
-
 		g.AfterEach(func() {
-			_ = fs.TruncateRootDirectory()
+			rfs.reset()
+
+			atomic.StoreInt64(&fs.diskUsed, 0)
+			atomic.StoreInt64(&fs.diskLimit, 0)
 		})
 	})
 }

server/filesystem/path.go

@@ -1,28 +1,95 @@
 package filesystem
 
 import (
+	"context"
+	"os"
 	"path/filepath"
 	"strings"
+	"sync"
 
 	"emperror.dev/errors"
+	"golang.org/x/sync/errgroup"
 )
 
 // Checks if the given file or path is in the server's file denylist. If so, an Error
 // is returned, otherwise nil is returned.
 func (fs *Filesystem) IsIgnored(paths ...string) error {
 	for _, p := range paths {
-		//sp, err := fs.SafePath(p)
+		sp, err := fs.SafePath(p)
-		//if err != nil {
+		if err != nil {
-		//	return err
+			return err
-		//}
+		}
-		// TODO: update logic to use unixFS
+		if fs.denylist.MatchesPath(sp) {
-		if fs.denylist.MatchesPath(p) {
+			return errors.WithStack(&Error{code: ErrCodeDenylistFile, path: p, resolved: sp})
-			return errors.WithStack(&Error{code: ErrCodeDenylistFile, path: p, resolved: p})
 		}
 	}
 	return nil
 }
 
+// Normalizes a directory being passed in to ensure the user is not able to escape
+// from their data directory. After normalization if the directory is still within their home
+// path it is returned. If they managed to "escape" an error will be returned.
+//
+// This logic is actually copied over from the SFTP server code. Ideally that eventually
+// either gets ported into this application, or is able to make use of this package.
+func (fs *Filesystem) SafePath(p string) (string, error) {
+	var nonExistentPathResolution string
+
+	// Start with a cleaned up path before checking the more complex bits.
+	r := fs.unsafeFilePath(p)
+
+	// At the same time, evaluate the symlink status and determine where this file or folder
+	// is truly pointing to.
+	ep, err := filepath.EvalSymlinks(r)
+	if err != nil && !os.IsNotExist(err) {
+		return "", errors.Wrap(err, "server/filesystem: failed to evaluate symlink")
+	} else if os.IsNotExist(err) {
+		// The requested directory doesn't exist, so at this point we need to iterate up the
+		// path chain until we hit a directory that _does_ exist and can be validated.
+		parts := strings.Split(filepath.Dir(r), "/")
+
+		var try string
+		// Range over all of the path parts and form directory pathings from the end
+		// moving up until we have a valid resolution or we run out of paths to try.
+		for k := range parts {
+			try = strings.Join(parts[:(len(parts)-k)], "/")
+
+			if !fs.unsafeIsInDataDirectory(try) {
+				break
+			}
+
+			t, err := filepath.EvalSymlinks(try)
+			if err == nil {
+				nonExistentPathResolution = t
+				break
+			}
+		}
+	}
+
+	// If the new path doesn't start with their root directory there is clearly an escape
+	// attempt going on, and we should NOT resolve this path for them.
+	if nonExistentPathResolution != "" {
+		if !fs.unsafeIsInDataDirectory(nonExistentPathResolution) {
+			return "", NewBadPathResolution(p, nonExistentPathResolution)
+		}
+
+		// If the nonExistentPathResolution variable is not empty then the initial path requested
+		// did not exist and we looped through the pathway until we found a match. At this point
+		// we've confirmed the first matched pathway exists in the root server directory, so we
+		// can go ahead and just return the path that was requested initially.
+		return r, nil
+	}
+
+	// If the requested directory from EvalSymlinks begins with the server root directory go
+	// ahead and return it. If not we'll return an error which will block any further action
+	// on the file.
+	if fs.unsafeIsInDataDirectory(ep) {
+		return ep, nil
+	}
+
+	return "", NewBadPathResolution(p, r)
+}
+
 // Generate a path to the file by cleaning it up and appending the root server path to it. This
 // DOES NOT guarantee that the file resolves within the server data directory. You'll want to use
 // the fs.unsafeIsInDataDirectory(p) function to confirm.
@@ -41,3 +108,51 @@ func (fs *Filesystem) unsafeFilePath(p string) string {
 func (fs *Filesystem) unsafeIsInDataDirectory(p string) bool {
 	return strings.HasPrefix(strings.TrimSuffix(p, "/")+"/", strings.TrimSuffix(fs.Path(), "/")+"/")
 }
+
+// Executes the fs.SafePath function in parallel against an array of paths. If any of the calls
+// fails an error will be returned.
+func (fs *Filesystem) ParallelSafePath(paths []string) ([]string, error) {
+	var cleaned []string
+
+	// Simple locker function to avoid racy appends to the array of cleaned paths.
+	m := new(sync.Mutex)
+	push := func(c string) {
+		m.Lock()
+		cleaned = append(cleaned, c)
+		m.Unlock()
+	}
+
+	// Create an error group that we can use to run processes in parallel while retaining
+	// the ability to cancel the entire process immediately should any of it fail.
+	g, ctx := errgroup.WithContext(context.Background())
+
+	// Iterate over all of the paths and generate a cleaned path, if there is an error for any
+	// of the files, abort the process.
+	for _, p := range paths {
+		// Create copy so we can use it within the goroutine correctly.
+		pi := p
+
+		// Recursively call this function to continue digging through the directory tree within
+		// a separate goroutine. If the context is canceled abort this process.
+		g.Go(func() error {
+			select {
+			case <-ctx.Done():
+				return ctx.Err()
+			default:
+				// If the callback returns true, go ahead and keep walking deeper. This allows
+				// us to programmatically continue deeper into directories, or stop digging
+				// if that pathway knows it needs nothing else.
+				if c, err := fs.SafePath(pi); err != nil {
+					return err
+				} else {
+					push(c)
+				}
+
+				return nil
+			}
+		})
+	}
+
+	// Block until all of the routines finish and have returned a value.
+	return cleaned, g.Wait()
+}

server/filesystem/path_test.go

@@ -8,8 +8,6 @@ import (
 
 	"emperror.dev/errors"
 	. "github.com/franela/goblin"
-
-	"github.com/pterodactyl/wings/internal/ufs"
 )
 
 func TestFilesystem_Path(t *testing.T) {
@@ -23,6 +21,80 @@ func TestFilesystem_Path(t *testing.T) {
 	})
 }
 
+func TestFilesystem_SafePath(t *testing.T) {
+	g := Goblin(t)
+	fs, rfs := NewFs()
+	prefix := filepath.Join(rfs.root, "/server")
+
+	g.Describe("SafePath", func() {
+		g.It("returns a cleaned path to a given file", func() {
+			p, err := fs.SafePath("test.txt")
+			g.Assert(err).IsNil()
+			g.Assert(p).Equal(prefix + "/test.txt")
+
+			p, err = fs.SafePath("/test.txt")
+			g.Assert(err).IsNil()
+			g.Assert(p).Equal(prefix + "/test.txt")
+
+			p, err = fs.SafePath("./test.txt")
+			g.Assert(err).IsNil()
+			g.Assert(p).Equal(prefix + "/test.txt")
+
+			p, err = fs.SafePath("/foo/../test.txt")
+			g.Assert(err).IsNil()
+			g.Assert(p).Equal(prefix + "/test.txt")
+
+			p, err = fs.SafePath("/foo/bar")
+			g.Assert(err).IsNil()
+			g.Assert(p).Equal(prefix + "/foo/bar")
+		})
+
+		g.It("handles root directory access", func() {
+			p, err := fs.SafePath("/")
+			g.Assert(err).IsNil()
+			g.Assert(p).Equal(prefix)
+
+			p, err = fs.SafePath("")
+			g.Assert(err).IsNil()
+			g.Assert(p).Equal(prefix)
+		})
+
+		g.It("removes trailing slashes from paths", func() {
+			p, err := fs.SafePath("/foo/bar/")
+			g.Assert(err).IsNil()
+			g.Assert(p).Equal(prefix + "/foo/bar")
+		})
+
+		g.It("handles deeply nested directories that do not exist", func() {
+			p, err := fs.SafePath("/foo/bar/baz/quaz/../../ducks/testing.txt")
+			g.Assert(err).IsNil()
+			g.Assert(p).Equal(prefix + "/foo/bar/ducks/testing.txt")
+		})
+
+		g.It("blocks access to files outside the root directory", func() {
+			p, err := fs.SafePath("../test.txt")
+			g.Assert(err).IsNotNil()
+			g.Assert(IsErrorCode(err, ErrCodePathResolution)).IsTrue()
+			g.Assert(p).Equal("")
+
+			p, err = fs.SafePath("/../test.txt")
+			g.Assert(err).IsNotNil()
+			g.Assert(IsErrorCode(err, ErrCodePathResolution)).IsTrue()
+			g.Assert(p).Equal("")
+
+			p, err = fs.SafePath("./foo/../../test.txt")
+			g.Assert(err).IsNotNil()
+			g.Assert(IsErrorCode(err, ErrCodePathResolution)).IsTrue()
+			g.Assert(p).Equal("")
+
+			p, err = fs.SafePath("..")
+			g.Assert(err).IsNotNil()
+			g.Assert(IsErrorCode(err, ErrCodePathResolution)).IsTrue()
+			g.Assert(p).Equal("")
+		})
+	})
+}
+
 // We test against accessing files outside the root directory in the tests, however it
 // is still possible for someone to mess up and not properly use this safe path call. In
 // order to truly confirm this, we'll try to pass in a symlinked malicious file to all of
@@ -43,14 +115,6 @@ func TestFilesystem_Blocks_Symlinks(t *testing.T) {
 		panic(err)
 	}
 
-	if err := os.Symlink(filepath.Join(rfs.root, "malicious_does_not_exist.txt"), filepath.Join(rfs.root, "/server/symlinked_does_not_exist.txt")); err != nil {
-		panic(err)
-	}
-
-	if err := os.Symlink(filepath.Join(rfs.root, "/server/symlinked_does_not_exist.txt"), filepath.Join(rfs.root, "/server/symlinked_does_not_exist2.txt")); err != nil {
-		panic(err)
-	}
-
 	if err := os.Symlink(filepath.Join(rfs.root, "/malicious_dir"), filepath.Join(rfs.root, "/server/external_dir")); err != nil {
 		panic(err)
 	}
@@ -61,23 +125,7 @@ func TestFilesystem_Blocks_Symlinks(t *testing.T) {
 
 			err := fs.Writefile("symlinked.txt", r)
 			g.Assert(err).IsNotNil()
-			g.Assert(errors.Is(err, ufs.ErrBadPathResolution)).IsTrue("err is not ErrBadPathResolution")
+			g.Assert(IsErrorCode(err, ErrCodePathResolution)).IsTrue()
-		})
-
-		g.It("cannot write to a non-existent file symlinked outside the root", func() {
-			r := bytes.NewReader([]byte("testing what the fuck"))
-
-			err := fs.Writefile("symlinked_does_not_exist.txt", r)
-			g.Assert(err).IsNotNil()
-			g.Assert(errors.Is(err, ufs.ErrBadPathResolution)).IsTrue("err is not ErrBadPathResolution")
-		})
-
-		g.It("cannot write to chained symlinks with target that does not exist outside the root", func() {
-			r := bytes.NewReader([]byte("testing what the fuck"))
-
-			err := fs.Writefile("symlinked_does_not_exist2.txt", r)
-			g.Assert(err).IsNotNil()
-			g.Assert(errors.Is(err, ufs.ErrBadPathResolution)).IsTrue("err is not ErrBadPathResolution")
 		})
 
 		g.It("cannot write a file to a directory symlinked outside the root", func() {
@@ -85,7 +133,7 @@ func TestFilesystem_Blocks_Symlinks(t *testing.T) {
 
 			err := fs.Writefile("external_dir/foo.txt", r)
 			g.Assert(err).IsNotNil()
-			g.Assert(errors.Is(err, ufs.ErrNotDirectory)).IsTrue("err is not ErrNotDirectory")
+			g.Assert(IsErrorCode(err, ErrCodePathResolution)).IsTrue()
 		})
 	})
 
@@ -93,54 +141,55 @@ func TestFilesystem_Blocks_Symlinks(t *testing.T) {
 		g.It("cannot create a directory outside the root", func() {
 			err := fs.CreateDirectory("my_dir", "external_dir")
 			g.Assert(err).IsNotNil()
-			g.Assert(errors.Is(err, ufs.ErrNotDirectory)).IsTrue("err is not ErrNotDirectory")
+			g.Assert(IsErrorCode(err, ErrCodePathResolution)).IsTrue()
 		})
 
 		g.It("cannot create a nested directory outside the root", func() {
 			err := fs.CreateDirectory("my/nested/dir", "external_dir/foo/bar")
 			g.Assert(err).IsNotNil()
-			g.Assert(errors.Is(err, ufs.ErrNotDirectory)).IsTrue("err is not ErrNotDirectory")
+			g.Assert(IsErrorCode(err, ErrCodePathResolution)).IsTrue()
 		})
 
 		g.It("cannot create a nested directory outside the root", func() {
 			err := fs.CreateDirectory("my/nested/dir", "external_dir/server")
 			g.Assert(err).IsNotNil()
-			g.Assert(errors.Is(err, ufs.ErrNotDirectory)).IsTrue("err is not ErrNotDirectory")
+			g.Assert(IsErrorCode(err, ErrCodePathResolution)).IsTrue()
 		})
 	})
 
 	g.Describe("Rename", func() {
-		g.It("can rename a file symlinked outside the directory root", func() {
+		g.It("cannot rename a file symlinked outside the directory root", func() {
-			_, err := os.Lstat(filepath.Join(rfs.root, "server", "symlinked.txt"))
+			err := fs.Rename("symlinked.txt", "foo.txt")
-			g.Assert(err).IsNil()
+			g.Assert(err).IsNotNil()
-			err = fs.Rename("symlinked.txt", "foo.txt")
+			g.Assert(IsErrorCode(err, ErrCodePathResolution)).IsTrue()
-			g.Assert(err).IsNil()
-			_, err = os.Lstat(filepath.Join(rfs.root, "server", "foo.txt"))
-			g.Assert(err).IsNil()
 		})
 
-		g.It("can rename a symlinked directory outside the root", func() {
+		g.It("cannot rename a symlinked directory outside the root", func() {
-			_, err := os.Lstat(filepath.Join(rfs.root, "server", "external_dir"))
+			err := fs.Rename("external_dir", "foo")
-			g.Assert(err).IsNil()
+			g.Assert(err).IsNotNil()
-			err = fs.Rename("external_dir", "foo")
+			g.Assert(IsErrorCode(err, ErrCodePathResolution)).IsTrue()
-			g.Assert(err).IsNil()
-			_, err = os.Lstat(filepath.Join(rfs.root, "server", "foo"))
-			g.Assert(err).IsNil()
 		})
 
 		g.It("cannot rename a file to a location outside the directory root", func() {
-			_ = rfs.CreateServerFileFromString("my_file.txt", "internal content")
+			rfs.CreateServerFileFromString("my_file.txt", "internal content")
-			t.Log(rfs.root)
 
-			st, err := os.Lstat(filepath.Join(rfs.root, "server", "foo"))
+			err := fs.Rename("my_file.txt", "external_dir/my_file.txt")
-			g.Assert(err).IsNil()
+			g.Assert(err).IsNotNil()
-			g.Assert(st.Mode()&ufs.ModeSymlink != 0).IsTrue()
+			g.Assert(IsErrorCode(err, ErrCodePathResolution)).IsTrue()
+		})
+	})
 
-			err = fs.Rename("my_file.txt", "foo/my_file.txt")
+	g.Describe("Chown", func() {
-			g.Assert(errors.Is(err, ufs.ErrNotDirectory)).IsTrue()
+		g.It("cannot chown a file symlinked outside the directory root", func() {
+			err := fs.Chown("symlinked.txt")
+			g.Assert(err).IsNotNil()
+			g.Assert(IsErrorCode(err, ErrCodePathResolution)).IsTrue()
+		})
 
-			st, err = os.Lstat(filepath.Join(rfs.root, "malicious_dir", "my_file.txt"))
+		g.It("cannot chown a directory symlinked outside the directory root", func() {
-			g.Assert(errors.Is(err, ufs.ErrNotExist)).IsTrue()
+			err := fs.Chown("external_dir")
+			g.Assert(err).IsNotNil()
+			g.Assert(IsErrorCode(err, ErrCodePathResolution)).IsTrue()
 		})
 	})
 
@@ -148,7 +197,7 @@ func TestFilesystem_Blocks_Symlinks(t *testing.T) {
 		g.It("cannot copy a file symlinked outside the directory root", func() {
 			err := fs.Copy("symlinked.txt")
 			g.Assert(err).IsNotNil()
-			g.Assert(errors.Is(err, ufs.ErrNotExist)).IsTrue("err is not ErrNotExist")
+			g.Assert(IsErrorCode(err, ErrCodePathResolution)).IsTrue()
 		})
 	})
 
@@ -162,9 +211,9 @@ func TestFilesystem_Blocks_Symlinks(t *testing.T) {
 
 			_, err = rfs.StatServerFile("symlinked.txt")
 			g.Assert(err).IsNotNil()
-			g.Assert(errors.Is(err, ufs.ErrNotExist)).IsTrue("err is not ErrNotExist")
+			g.Assert(errors.Is(err, os.ErrNotExist)).IsTrue()
 		})
 	})
 
-	_ = fs.TruncateRootDirectory()
+	rfs.reset()
 }

server/filesystem/stat.go

@@ -1,18 +1,16 @@
 package filesystem
 
 import (
-	"encoding/json"
+	"os"
-	"io"
 	"strconv"
 	"time"
 
 	"github.com/gabriel-vasile/mimetype"
-
+	"github.com/goccy/go-json"
-	"github.com/pterodactyl/wings/internal/ufs"
 )
 
 type Stat struct {
-	ufs.FileInfo
+	os.FileInfo
 	Mimetype string
 }
 
@@ -33,31 +31,40 @@ func (s *Stat) MarshalJSON() ([]byte, error) {
 		Created:  s.CTime().Format(time.RFC3339),
 		Modified: s.ModTime().Format(time.RFC3339),
 		Mode:     s.Mode().String(),
-		// Using `&ModePerm` on the file's mode will cause the mode to only have the permission values, and nothing else.
+		// Using `&os.ModePerm` on the file's mode will cause the mode to only have the permission values, and nothing else.
-		ModeBits:  strconv.FormatUint(uint64(s.Mode()&ufs.ModePerm), 8),
+		ModeBits:  strconv.FormatUint(uint64(s.Mode()&os.ModePerm), 8),
 		Size:      s.Size(),
 		Directory: s.IsDir(),
 		File:      !s.IsDir(),
-		Symlink:   s.Mode().Perm()&ufs.ModeSymlink != 0,
+		Symlink:   s.Mode().Perm()&os.ModeSymlink != 0,
 		Mime:      s.Mimetype,
 	})
 }
 
-func statFromFile(f ufs.File) (Stat, error) {
+// Stat stats a file or folder and returns the base stat object from go along
-	s, err := f.Stat()
+// with the MIME data that can be used for editing files.
+func (fs *Filesystem) Stat(p string) (Stat, error) {
+	cleaned, err := fs.SafePath(p)
 	if err != nil {
 		return Stat{}, err
 	}
+	return fs.unsafeStat(cleaned)
+}
+
+func (fs *Filesystem) unsafeStat(p string) (Stat, error) {
+	s, err := os.Stat(p)
+	if err != nil {
+		return Stat{}, err
+	}
+
 	var m *mimetype.MIME
 	if !s.IsDir() {
-		m, err = mimetype.DetectReader(f)
+		m, err = mimetype.DetectFile(p)
 		if err != nil {
 			return Stat{}, err
 		}
-		if _, err := f.Seek(0, io.SeekStart); err != nil {
-			return Stat{}, err
-		}
 	}
+
 	st := Stat{
 		FileInfo: s,
 		Mimetype: "inode/directory",
@@ -65,20 +72,6 @@ func statFromFile(f ufs.File) (Stat, error) {
 	if m != nil {
 		st.Mimetype = m.String()
 	}
-	return st, nil
-}
 
-// Stat stats a file or folder and returns the base stat object from go along
-// with the MIME data that can be used for editing files.
-func (fs *Filesystem) Stat(p string) (Stat, error) {
-	f, err := fs.unixFS.Open(p)
-	if err != nil {
-		return Stat{}, err
-	}
-	defer f.Close()
-	st, err := statFromFile(f)
-	if err != nil {
-		return Stat{}, err
-	}
 	return st, nil
 }

server/filesystem/stat_darwin.go

@@ -0,0 +1,13 @@
+package filesystem
+
+import (
+	"syscall"
+	"time"
+)
+
+// CTime returns the time that the file/folder was created.
+func (s *Stat) CTime() time.Time {
+	st := s.Sys().(*syscall.Stat_t)
+
+	return time.Unix(st.Ctimespec.Sec, st.Ctimespec.Nsec)
+}

server/filesystem/stat_linux.go

@@ -3,22 +3,12 @@ package filesystem
 import (
 	"syscall"
 	"time"
-
-	"golang.org/x/sys/unix"
 )
 
-// CTime returns the time that the file/folder was created.
+// Returns the time that the file/folder was created.
-//
-// TODO: remove. Ctim is not actually ever been correct and doesn't actually
-// return the creation time.
 func (s *Stat) CTime() time.Time {
-	if st, ok := s.Sys().(*unix.Stat_t); ok {
+	st := s.Sys().(*syscall.Stat_t)
-		// Do not remove these "redundant" type-casts, they are required for 32-bit builds to work.
+
-		return time.Unix(int64(st.Ctim.Sec), int64(st.Ctim.Nsec))
+	// Do not remove these "redundant" type-casts, they are required for 32-bit builds to work.
-	}
+	return time.Unix(int64(st.Ctim.Sec), int64(st.Ctim.Nsec))
-	if st, ok := s.Sys().(*syscall.Stat_t); ok {
-		// Do not remove these "redundant" type-casts, they are required for 32-bit builds to work.
-		return time.Unix(int64(st.Ctim.Sec), int64(st.Ctim.Nsec))
-	}
-	return time.Time{}
 }

server/filesystem/stat_windows.go

@@ -0,0 +1,12 @@
+package filesystem
+
+import (
+	"time"
+)
+
+// On linux systems this will return the time that the file was created.
+// However, I have no idea how to do this on windows, so we're skipping it
+// for right now.
+func (s *Stat) CTime() time.Time {
+	return s.ModTime()
+}

server/install.go

@@ -2,7 +2,9 @@ package server
 
 import (
 	"bufio"
+	"bytes"
 	"context"
+	"fmt"
 	"html/template"
 	"io"
 	"os"
@@ -30,17 +32,19 @@ import (
 //
 // Pass true as the first argument in order to execute a server sync before the
 // process to ensure the latest information is used.
-func (s *Server) Install() error {
+func (s *Server) Install(sync bool) error {
-	return s.install(false)
+	if sync {
-}
+		s.Log().Info("syncing server state with remote source before executing installation process")
+		if err := s.Sync(); err != nil {
+			return errors.WrapIf(err, "install: failed to sync server state with Panel")
+		}
+	}
 
-func (s *Server) install(reinstall bool) error {
 	var err error
 	if !s.Config().SkipEggScripts {
-		// Send the start event so the Panel can automatically update. We don't
+		// Send the start event so the Panel can automatically update. We don't send this unless the process
-		// send this unless the process is actually going to run, otherwise all
+		// is actually going to run, otherwise all sorts of weird rapid UI behavior happens since there isn't
-		// sorts of weird rapid UI behavior happens since there isn't an actual
+		// an actual install process being executed.
-		// install process being executed.
 		s.Events().Publish(InstallStartedEvent, "")
 
 		err = s.internalInstall()
@@ -49,13 +53,12 @@ func (s *Server) install(reinstall bool) error {
 	}
 
 	s.Log().WithField("was_successful", err == nil).Debug("notifying panel of server install state")
-	if serr := s.SyncInstallState(err == nil, reinstall); serr != nil {
+	if serr := s.SyncInstallState(err == nil); serr != nil {
 		l := s.Log().WithField("was_successful", err == nil)
 
-		// If the request was successful but there was an error with this request,
+		// If the request was successful but there was an error with this request, attach the
-		// attach the error to this log entry. Otherwise, ignore it in this log
+		// error to this log entry. Otherwise ignore it in this log since whatever is calling
-		// since whatever is calling this function should handle the error and
+		// this function should handle the error and will end up logging the same one.
-		// will end up logging the same one.
 		if err == nil {
 			l.WithField("error", err)
 		}
@@ -63,20 +66,19 @@ func (s *Server) install(reinstall bool) error {
 		l.Warn("failed to notify panel of server install state")
 	}
 
-	// Ensure that the server is marked as offline at this point, otherwise you
+	// Ensure that the server is marked as offline at this point, otherwise you end up
-	// end up with a blank value which is a bit confusing.
+	// with a blank value which is a bit confusing.
 	s.Environment.SetState(environment.ProcessOfflineState)
 
-	// Push an event to the websocket, so we can auto-refresh the information in
+	// Push an event to the websocket so we can auto-refresh the information in the panel once
-	// the panel once the installation is completed.
+	// the install is completed.
 	s.Events().Publish(InstallCompletedEvent, "")
 
 	return errors.WithStackIf(err)
 }
 
-// Reinstall reinstalls a server's software by utilizing the installation script
+// Reinstalls a server's software by utilizing the install script for the server egg. This
-// for the server egg. This does not touch any existing files for the server,
+// does not touch any existing files for the server, other than what the script modifies.
-// other than what the script modifies.
 func (s *Server) Reinstall() error {
 	if s.Environment.State() != environment.ProcessOfflineState {
 		s.Log().Debug("waiting for server instance to enter a stopped state")
@@ -85,12 +87,7 @@ func (s *Server) Reinstall() error {
 		}
 	}
 
-	s.Log().Info("syncing server state with remote source before executing re-installation process")
+	return s.Install(true)
-	if err := s.Sync(); err != nil {
-		return errors.WrapIf(err, "install: failed to sync server state with Panel")
-	}
-
-	return s.install(true)
 }
 
 // Internal installation function used to simplify reporting back to the Panel.
@@ -119,9 +116,8 @@ type InstallationProcess struct {
 	client *client.Client
 }
 
-// NewInstallationProcess returns a new installation process struct that will be
+// Generates a new installation process struct that will be used to create containers,
-// used to create containers and otherwise perform installation commands for a
+// and otherwise perform installation commands for a server.
-// server.
 func NewInstallationProcess(s *Server, script *remote.InstallationScript) (*InstallationProcess, error) {
 	proc := &InstallationProcess{
 		Script: script,
@@ -137,8 +133,8 @@ func NewInstallationProcess(s *Server, script *remote.InstallationScript) (*Inst
 	return proc, nil
 }
 
-// IsInstalling returns if the server is actively running the installation
+// Determines if the server is actively running the installation process by checking the status
-// process by checking the status of the installer lock.
+// of the installer lock.
 func (s *Server) IsInstalling() bool {
 	return s.installing.Load()
 }
@@ -159,7 +155,7 @@ func (s *Server) SetRestoring(state bool) {
 	s.restoring.Store(state)
 }
 
-// RemoveContainer removes the installation container for the server.
+// Removes the installer container for the server.
 func (ip *InstallationProcess) RemoveContainer() error {
 	err := ip.client.ContainerRemove(ip.Server.Context(), ip.Server.ID()+"_installer", types.ContainerRemoveOptions{
 		RemoveVolumes: true,
@@ -217,18 +213,30 @@ func (ip *InstallationProcess) tempDir() string {
 // can be properly mounted into the installation container and then executed.
 func (ip *InstallationProcess) writeScriptToDisk() error {
 	// Make sure the temp directory root exists before trying to make a directory within it. The
-	// os.TempDir call expects this base to exist, it won't create it for you.
+	// ioutil.TempDir call expects this base to exist, it won't create it for you.
 	if err := os.MkdirAll(ip.tempDir(), 0o700); err != nil {
 		return errors.WithMessage(err, "could not create temporary directory for install process")
 	}
+
 	f, err := os.OpenFile(filepath.Join(ip.tempDir(), "install.sh"), os.O_RDWR|os.O_CREATE|os.O_TRUNC, 0o644)
 	if err != nil {
 		return errors.WithMessage(err, "failed to write server installation script to disk before mount")
 	}
 	defer f.Close()
-	if _, err := io.Copy(f, strings.NewReader(strings.ReplaceAll(ip.Script.Script, "\r\n", "\n"))); err != nil {
+
+	w := bufio.NewWriter(f)
+
+	scanner := bufio.NewScanner(bytes.NewReader([]byte(ip.Script.Script)))
+	for scanner.Scan() {
+		w.WriteString(scanner.Text() + "\n")
+	}
+
+	if err := scanner.Err(); err != nil {
 		return err
 	}
+
+	w.Flush()
+
 	return nil
 }
 
@@ -320,14 +328,14 @@ func (ip *InstallationProcess) BeforeExecute() error {
 	return nil
 }
 
-// GetLogPath returns the log path for the installation process.
+// Returns the log path for the installation process.
 func (ip *InstallationProcess) GetLogPath() string {
 	return filepath.Join(config.Get().System.LogDirectory, "/install", ip.Server.ID()+".log")
 }
 
-// AfterExecute cleans up after the execution of the installation process.
+// Cleans up after the execution of the installation process. This grabs the logs from the
-// This grabs the logs from the process to store in the server configuration
+// process to store in the server configuration directory, and then destroys the associated
-// directory, and then destroys the associated installation container.
+// installation container.
 func (ip *InstallationProcess) AfterExecute(containerId string) error {
 	defer ip.RemoveContainer()
 
@@ -413,6 +421,10 @@ func (ip *InstallationProcess) Execute() (string, error) {
 	}
 
 	cfg := config.Get()
+	if cfg.System.User.Rootless.Enabled {
+		conf.User = fmt.Sprintf("%d:%d", cfg.System.User.Rootless.ContainerUID, cfg.System.User.Rootless.ContainerGID)
+	}
+
 	tmpfsSize := strconv.Itoa(int(cfg.Docker.TmpfsSize))
 	hostConf := &container.HostConfig{
 		Mounts: []mount.Mount{
@@ -435,6 +447,7 @@ func (ip *InstallationProcess) Execute() (string, error) {
 		},
 		DNS:         cfg.Docker.Network.Dns,
 		LogConfig:   cfg.Docker.ContainerLogConfig(),
+		Privileged:  true,
 		NetworkMode: container.NetworkMode(cfg.Docker.Network.Mode),
 		UsernsMode:  container.UsernsMode(cfg.Docker.UsernsMode),
 	}
@@ -512,7 +525,7 @@ func (ip *InstallationProcess) StreamOutput(ctx context.Context, id string) erro
 	return nil
 }
 
-// resourceLimits returns resource limits for the installation container. This
+// resourceLimits returns the install container specific resource limits. This
 // looks at the globally defined install container limits and attempts to use
 // the higher of the two (defined limits & server limits). This allows for servers
 // with super low limits (e.g. Discord bots with 128Mb of memory) to perform more
@@ -524,8 +537,8 @@ func (ip *InstallationProcess) StreamOutput(ctx context.Context, id string) erro
 func (ip *InstallationProcess) resourceLimits() container.Resources {
 	limits := config.Get().Docker.InstallerLimits
 
-	// Create a copy of the configuration, so we're not accidentally making
+	// Create a copy of the configuration so we're not accidentally making changes
-	// changes to the underlying server build data.
+	// to the underlying server build data.
 	c := *ip.Server.Config()
 	cfg := c.Build
 	if cfg.MemoryLimit < limits.Memory {
@@ -549,12 +562,10 @@ func (ip *InstallationProcess) resourceLimits() container.Resources {
 	return resources
 }
 
-// SyncInstallState makes an HTTP request to the Panel instance notifying it that
+// SyncInstallState makes a HTTP request to the Panel instance notifying it that
 // the server has completed the installation process, and what the state of the
-// server is.
+// server is. A boolean value of "true" means everything was successful, "false"
-func (s *Server) SyncInstallState(successful, reinstall bool) error {
+// means something went wrong and the server must be deleted and re-created.
-	return s.client.SetInstallationStatus(s.Context(), s.ID(), remote.InstallStatusRequest{
+func (s *Server) SyncInstallState(successful bool) error {
-		Successful: successful,
+	return s.client.SetInstallationStatus(s.Context(), s.ID(), successful)
-		Reinstall:  reinstall,
-	})
 }

server/manager.go

@@ -196,10 +196,7 @@ func (m *Manager) InitServer(data remote.ServerConfigurationResponse) (*Server,
 		return nil, errors.WithStackIf(err)
 	}
 
-	s.fs, err = filesystem.New(filepath.Join(config.Get().System.Data, s.ID()), s.DiskSpace(), s.Config().Egg.FileDenylist)
+	s.fs = filesystem.New(filepath.Join(config.Get().System.Data, s.ID()), s.DiskSpace(), s.Config().Egg.FileDenylist)
-	if err != nil {
-		return nil, errors.WithStackIf(err)
-	}
 
 	// Right now we only support a Docker based environment, so I'm going to hard code
 	// this logic in. When we're ready to support other environment we'll need to make

server/mounts.go

@@ -29,21 +29,6 @@ func (s *Server) Mounts() []environment.Mount {
 		},
 	}
 
-	// Handle mounting a generated `/etc/passwd` if the feature is enabled.
-	if passwd := config.Get().System.Passwd; passwd.Enable {
-		s.Log().WithFields(log.Fields{"source_path": passwd.Directory}).Info("mouting generated /etc/{group,passwd} to workaround UID/GID issues")
-		m = append(m, environment.Mount{
-			Source:   filepath.Join(passwd.Directory, "group"),
-			Target:   "/etc/group",
-			ReadOnly: true,
-		})
-		m = append(m, environment.Mount{
-			Source:   filepath.Join(passwd.Directory, "passwd"),
-			Target:   "/etc/passwd",
-			ReadOnly: true,
-		})
-	}
-
 	// Also include any of this server's custom mounts when returning them.
 	return append(m, s.customMounts()...)
 }
@@ -71,12 +56,14 @@ func (s *Server) customMounts() []environment.Mount {
 			if !strings.HasPrefix(source, filepath.Clean(allowed)) {
 				continue
 			}
+
 			mounted = true
 			mounts = append(mounts, environment.Mount{
 				Source:   source,
 				Target:   target,
 				ReadOnly: m.ReadOnly,
 			})
+
 			break
 		}
 

server/power.go

@@ -3,6 +3,7 @@ package server
 import (
 	"context"
 	"fmt"
+	"os"
 	"time"
 
 	"emperror.dev/errors"
@@ -160,7 +161,7 @@ func (s *Server) HandlePowerAction(action PowerAction, waitSeconds ...int) error
 
 		return s.Environment.Start(s.Context())
 	case PowerActionTerminate:
-		return s.Environment.Terminate(s.Context(), "SIGKILL")
+		return s.Environment.Terminate(s.Context(), os.Kill)
 	}
 
 	return errors.New("attempting to handle unknown power action")

server/server.go

@@ -147,7 +147,6 @@ func (s *Server) Context() context.Context {
 // server instance.
 func (s *Server) GetEnvironmentVariables() []string {
 	out := []string{
-		// TODO: allow this to be overridden by the user.
 		fmt.Sprintf("TZ=%s", config.Get().System.Timezone),
 		fmt.Sprintf("STARTUP=%s", s.Config().Invocation),
 		fmt.Sprintf("SERVER_MEMORY=%d", s.MemoryLimit()),

server/transfer/archive.go

@@ -35,8 +35,8 @@ type Archive struct {
 func NewArchive(t *Transfer, size uint64) *Archive {
 	return &Archive{
 		archive: &filesystem.Archive{
-			Filesystem: t.Server.Filesystem(),
+			BasePath: t.Server.Filesystem().Path(),
-			Progress:   progress.NewProgress(size),
+			Progress: progress.NewProgress(size),
 		},
 	}
 }

server/transfer/source.go

@@ -128,13 +128,6 @@ func (t *Transfer) PushArchiveToTarget(url, token string) ([]byte, error) {
 	t.Log().Debug("sending archive to destination")
 	client := http.Client{Timeout: 0}
 	res, err := client.Do(req)
-	if err != nil {
-		t.Log().Debug("error while sending archive to destination")
-		return nil, err
-	}
-	if res.StatusCode != http.StatusOK {
-		return nil, fmt.Errorf("unexpected status code from destination: %d", res.StatusCode)
-	}
 	t.Log().Debug("waiting for stream to complete")
 	select {
 	case <-ctx.Done():

server/update.go

@@ -28,7 +28,6 @@ func (s *Server) SyncWithEnvironment() {
 		Mounts:      s.Mounts(),
 		Allocations: cfg.Allocations,
 		Limits:      cfg.Build,
-		Labels:      cfg.Labels,
 	})
 
 	// For Docker specific environments we also want to update the configured image

sftp/handler.go

@@ -2,6 +2,7 @@ package sftp
 
 import (
 	"io"
+	"io/ioutil"
 	"os"
 	"path/filepath"
 	"strings"
@@ -121,7 +122,7 @@ func (h *Handler) Filewrite(request *sftp.Request) (io.WriterAt, error) {
 	if !h.can(permission) {
 		return nil, sftp.ErrSSHFxPermissionDenied
 	}
-	f, err := h.fs.Touch(request.Filepath, os.O_RDWR|os.O_TRUNC)
+	f, err := h.fs.Touch(request.Filepath, os.O_RDWR|os.O_CREATE|os.O_TRUNC)
 	if err != nil {
 		l.WithField("flags", request.Flags).WithField("error", err).Error("failed to open existing file on system")
 		return nil, sftp.ErrSSHFxFailure
@@ -219,8 +220,16 @@ func (h *Handler) Filecmd(request *sftp.Request) error {
 		if !h.can(PermissionFileCreate) {
 			return sftp.ErrSSHFxPermissionDenied
 		}
-		if err := h.fs.Symlink(request.Filepath, request.Target); err != nil {
+		source, err := h.fs.SafePath(request.Filepath)
-			l.WithField("target", request.Target).WithField("error", err).Error("failed to create symlink")
+		if err != nil {
+			return sftp.ErrSSHFxNoSuchFile
+		}
+		target, err := h.fs.SafePath(request.Target)
+		if err != nil {
+			return sftp.ErrSSHFxNoSuchFile
+		}
+		if err := os.Symlink(source, target); err != nil {
+			l.WithField("target", target).WithField("error", err).Error("failed to create symlink")
 			return sftp.ErrSSHFxFailure
 		}
 		break
@@ -265,12 +274,16 @@ func (h *Handler) Filelist(request *sftp.Request) (sftp.ListerAt, error) {
 
 	switch request.Method {
 	case "List":
-		entries, err := h.fs.ReadDirStat(request.Filepath)
+		p, err := h.fs.SafePath(request.Filepath)
+		if err != nil {
+			return nil, sftp.ErrSSHFxNoSuchFile
+		}
+		files, err := ioutil.ReadDir(p)
 		if err != nil {
 			h.logger.WithField("source", request.Filepath).WithField("error", err).Error("error while listing directory")
 			return nil, sftp.ErrSSHFxFailure
 		}
-		return ListerAt(entries), nil
+		return ListerAt(files), nil
 	case "Stat":
 		st, err := h.fs.Stat(request.Filepath)
 		if err != nil {

sftp/server.go

@@ -68,21 +68,6 @@ func (c *SFTPServer) Run() error {
 	}
 
 	conf := &ssh.ServerConfig{
-		Config: ssh.Config{
-			KeyExchanges: []string{
-				"curve25519-sha256", "curve25519-sha256@libssh.org",
-				"ecdh-sha2-nistp256", "ecdh-sha2-nistp384", "ecdh-sha2-nistp521",
-				"diffie-hellman-group14-sha256",
-			},
-			Ciphers: []string{
-				"aes128-gcm@openssh.com",
-				"chacha20-poly1305@openssh.com",
-				"aes128-ctr", "aes192-ctr", "aes256-ctr",
-			},
-			MACs: []string{
-				"hmac-sha2-256-etm@openssh.com", "hmac-sha2-256",
-			},
-		},
 		NoClientAuth: false,
 		MaxAuthTries: 6,
 		PasswordCallback: func(conn ssh.ConnMetadata, password []byte) (*ssh.Permissions, error) {
@@ -107,7 +92,7 @@ func (c *SFTPServer) Run() error {
 			go func(conn net.Conn) {
 				defer conn.Close()
 				if err := c.AcceptInbound(conn, conf); err != nil {
-					log.WithField("error", err).WithField("ip", conn.RemoteAddr().String()).Error("sftp: failed to accept inbound connection")
+					log.WithField("error", err).Error("sftp: failed to accept inbound connection")
 				}
 			}(conn)
 		}

system/const.go

@@ -1,3 +1,3 @@
 package system
 
-var Version = "develop"
+var Version = "1.11.0-rc.1"

system/sink_pool_test.go

@@ -15,16 +15,7 @@ func MutexLocked(m *sync.RWMutex) bool {
 
 	state := v.FieldByName("w").FieldByName("state")
 
-	readerCountField := v.FieldByName("readerCount")
+	return state.Int()&1 == 1 || v.FieldByName("readerCount").Int() > 0
-	// go1.20 changed readerCount to an atomic
-	// ref; https://github.com/golang/go/commit/e509452727b469d89a3fc4a7d1cbf9d3f110efee
-	var readerCount int64
-	if readerCountField.Kind() == reflect.Struct {
-		readerCount = readerCountField.FieldByName("v").Int()
-	} else {
-		readerCount = readerCountField.Int()
-	}
-	return state.Int()&1 == 1 || readerCount > 0
 }
 
 func TestSink(t *testing.T) {

system/strings.go

@@ -0,0 +1,29 @@
+package system
+
+import (
+	"math/rand"
+	"regexp"
+	"strings"
+)
+
+var ipTrimRegex = regexp.MustCompile(`(:\d*)?$`)
+
+const characters = "abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ1234567890"
+
+// RandomString generates a random string of alpha-numeric characters using a
+// pseudo-random number generator. The output of this function IS NOT cryptographically
+// secure, it is used solely for generating random strings outside a security context.
+func RandomString(n int) string {
+	var b strings.Builder
+	b.Grow(n)
+	for i := 0; i < n; i++ {
+		b.WriteByte(characters[rand.Intn(len(characters))])
+	}
+	return b.String()
+}
+
+// TrimIPSuffix removes the internal port value from an IP address to ensure we're only
+// ever working directly with the IP address.
+func TrimIPSuffix(s string) string {
+	return ipTrimRegex.ReplaceAllString(s, "")
+}

system/system.go

@@ -1,58 +1,17 @@
 package system
 
 import (
-	"context"
 	"runtime"
 
-	"github.com/acobaugh/osrelease"
-	"github.com/docker/docker/api/types"
-	"github.com/docker/docker/api/types/system"
-	"github.com/docker/docker/client"
 	"github.com/docker/docker/pkg/parsers/kernel"
 )
 
 type Information struct {
-	Version string            `json:"version"`
+	Version       string `json:"version"`
-	Docker  DockerInformation `json:"docker"`
-	System  System            `json:"system"`
-}
-
-type DockerInformation struct {
-	Version    string           `json:"version"`
-	Cgroups    DockerCgroups    `json:"cgroups"`
-	Containers DockerContainers `json:"containers"`
-	Storage    DockerStorage    `json:"storage"`
-	Runc       DockerRunc       `json:"runc"`
-}
-
-type DockerCgroups struct {
-	Driver  string `json:"driver"`
-	Version string `json:"version"`
-}
-
-type DockerContainers struct {
-	Total   int `json:"total"`
-	Running int `json:"running"`
-	Paused  int `json:"paused"`
-	Stopped int `json:"stopped"`
-}
-
-type DockerStorage struct {
-	Driver     string `json:"driver"`
-	Filesystem string `json:"filesystem"`
-}
-
-type DockerRunc struct {
-	Version string `json:"version"`
-}
-
-type System struct {
-	Architecture  string `json:"architecture"`
-	CPUThreads    int    `json:"cpu_threads"`
-	MemoryBytes   int64  `json:"memory_bytes"`
 	KernelVersion string `json:"kernel_version"`
+	Architecture  string `json:"architecture"`
 	OS            string `json:"os"`
-	OSType        string `json:"os_type"`
+	CpuCount      int    `json:"cpu_count"`
 }
 
 func GetSystemInformation() (*Information, error) {
@@ -61,84 +20,13 @@ func GetSystemInformation() (*Information, error) {
 		return nil, err
 	}
 
-	version, info, err := GetDockerInfo(context.Background())
+	s := &Information{
-	if err != nil {
+		Version:       Version,
-		return nil, err
+		KernelVersion: k.String(),
+		Architecture:  runtime.GOARCH,
+		OS:            runtime.GOOS,
+		CpuCount:      runtime.NumCPU(),
 	}
 
-	release, err := osrelease.Read()
+	return s, nil
-	if err != nil {
-		return nil, err
-	}
-
-	var os string
-	if release["PRETTY_NAME"] != "" {
-		os = release["PRETTY_NAME"]
-	} else if release["NAME"] != "" {
-		os = release["NAME"]
-	} else {
-		os = info.OperatingSystem
-	}
-
-	var filesystem string
-	for _, v := range info.DriverStatus {
-		if v[0] != "Backing Filesystem" {
-			continue
-		}
-		filesystem = v[1]
-		break
-	}
-
-	return &Information{
-		Version: Version,
-		Docker: DockerInformation{
-			Version: version.Version,
-			Cgroups: DockerCgroups{
-				Driver:  info.CgroupDriver,
-				Version: info.CgroupVersion,
-			},
-			Containers: DockerContainers{
-				Total:   info.Containers,
-				Running: info.ContainersRunning,
-				Paused:  info.ContainersPaused,
-				Stopped: info.ContainersStopped,
-			},
-			Storage: DockerStorage{
-				Driver:     info.Driver,
-				Filesystem: filesystem,
-			},
-			Runc: DockerRunc{
-				Version: info.RuncCommit.ID,
-			},
-		},
-		System: System{
-			Architecture:  runtime.GOARCH,
-			CPUThreads:    runtime.NumCPU(),
-			MemoryBytes:   info.MemTotal,
-			KernelVersion: k.String(),
-			OS:            os,
-			OSType:        runtime.GOOS,
-		},
-	}, nil
-}
-
-func GetDockerInfo(ctx context.Context) (types.Version, system.Info, error) {
-	// TODO: find a way to re-use the client from the docker environment.
-	c, err := client.NewClientWithOpts(client.FromEnv, client.WithAPIVersionNegotiation())
-	if err != nil {
-		return types.Version{}, system.Info{}, err
-	}
-	defer c.Close()
-
-	dockerVersion, err := c.ServerVersion(ctx)
-	if err != nil {
-		return types.Version{}, system.Info{}, err
-	}
-
-	dockerInfo, err := c.Info(ctx)
-	if err != nil {
-		return types.Version{}, system.Info{}, err
-	}
-
-	return dockerVersion, dockerInfo, nil
 }