Fix #2380

router/router_server_files.go

@@ -327,6 +327,16 @@ func postServerDecompressFiles(c *gin.Context) {
 
 	hasSpace, err := s.Filesystem.SpaceAvailableForDecompression(data.RootPath, data.File)
 	if err != nil {
+		// Handle an unknown format error.
+		if errors.Is(err, server.ErrUnknownArchiveFormat) {
+			s.Log().WithField("error", err).Warn("failed to decompress file due to unknown format")
+
+			c.AbortWithStatusJSON(http.StatusBadRequest, gin.H{
+				"error": "unknown archive format",
+			})
+			return
+		}
+
 		TrackedServerError(err, s).AbortWithServerError(c)
 		return
 	}

server/filesystem.go

@@ -599,7 +599,15 @@ func (fs *Filesystem) Copy(p string) error {
 	base := filepath.Base(cleaned)
 	relative := strings.TrimSuffix(strings.TrimPrefix(cleaned, fs.Path()), base)
 	extension := filepath.Ext(base)
-	name := strings.TrimSuffix(base, filepath.Ext(base))
+	name := strings.TrimSuffix(base, extension)
+
+	// Ensure that ".tar" is also counted as apart of the file extension.
+	// There might be a better way to handle this for other double file extensions,
+	// but this is a good workaround for now.
+	if strings.HasSuffix(name, ".tar") {
+		extension = ".tar" + extension
+		name = strings.TrimSuffix(name, ".tar")
+	}
 
 	// Begin looping up to 50 times to try and create a unique copy file name. This will take
 	// an input of "file.txt" and generate "file copy.txt". If that name is already taken, it will

server/filesystem_unarchive.go

@@ -10,9 +10,12 @@ import (
 	"os"
 	"path/filepath"
 	"reflect"
+	"strings"
 	"sync/atomic"
 )
 
+var ErrUnknownArchiveFormat = errors.New("filesystem: unknown archive format")
+
 // Look through a given archive and determine if decompressing it would put the server over
 // its allocated disk space limit.
 func (fs *Filesystem) SpaceAvailableForDecompression(dir string, file string) (bool, error) {
@@ -41,8 +44,15 @@ func (fs *Filesystem) SpaceAvailableForDecompression(dir string, file string) (b
 
 		return nil
 	})
+	if err != nil {
+		if strings.HasPrefix(err.Error(), "format ") {
+			return false, errors.WithStack(ErrUnknownArchiveFormat)
+		}
 
-	return err == nil, errors.WithStack(err)
+		return false, errors.WithStack(err)
+	}
+
+	return true, errors.WithStack(err)
 }
 
 // Decompress a file in a given directory by using the archiver tool to infer the file
@@ -63,7 +73,7 @@ func (fs *Filesystem) DecompressFile(dir string, file string) error {
 	// Walk over all of the files spinning up an additional go-routine for each file we've encountered
 	// and then extract that file from the archive and write it to the disk. If any part of this process
 	// encounters an error the entire process will be stopped.
-	return archiver.Walk(source, func(f archiver.File) error {
+	err = archiver.Walk(source, func(f archiver.File) error {
 		// Don't waste time with directories, we don't need to create them if they have no contents, and
 		// we will ensure the directory exists when opening the file for writing anyways.
 		if f.IsDir() {
@@ -90,4 +100,13 @@ func (fs *Filesystem) DecompressFile(dir string, file string) error {
 
 		return errors.Wrap(fs.Writefile(p, f), "could not extract file from archive")
 	})
+	if err != nil {
+		if strings.HasPrefix(err.Error(), "format ") {
+			return errors.WithStack(ErrUnknownArchiveFormat)
+		}
+
+		return errors.WithStack(err)
+	}
+
+	return nil
 }