MCorange/wings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix memory leak with websocket not removing unused listeners

Browse Source
This commit is contained in:
Dane Everitt 2020-07-29 21:39:17 -07:00
parent 0b761320cc
commit f0d6f67c6b
No known key found for this signature in database
GPG Key ID: EEA66103B3D71F53
1 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
router/websocket/listeners.go
View File

@ -52,16 +52,15 @@ func (h *Handler) ListenForServerEvents(ctx context.Context) {
h.server.Events().Subscribe(event, eventChannel) h.server.Events().Subscribe(event, eventChannel)
} }
select { for d := range eventChannel {
case <-ctx.Done(): select {
for _, event := range events { case <-ctx.Done():
h.server.Events().Unsubscribe(event, eventChannel) for _, event := range events {
} h.server.Events().Unsubscribe(event, eventChannel)
}
close(eventChannel) close(eventChannel)
default: default:
// Listen for different events emitted by the server and respond to them appropriately.
for d := range eventChannel {
h.SendJson(&Message{ h.SendJson(&Message{
Event: d.Topic, Event: d.Topic,
Args: []string{d.Data}, Args: []string{d.Data},