Error handling improvements (#71)

* Remove `emperror.dev/errors`, remove all `errors#Wrap` and `errors#WithStack` calls
* Improve logging in `server/backup.go`

environment/docker/container.go

@@ -4,7 +4,6 @@ import (
 	"bufio"
 	"bytes"
 	"context"
-	"emperror.dev/errors"
 	"encoding/json"
 	"fmt"
 	"github.com/apex/log"
@@ -13,6 +12,7 @@ import (
 	"github.com/docker/docker/api/types/mount"
 	"github.com/docker/docker/client"
 	"github.com/docker/docker/daemon/logger/jsonfilelog"
+	"github.com/pkg/errors"
 	"github.com/pterodactyl/wings/config"
 	"github.com/pterodactyl/wings/environment"
 	"io"
@@ -36,7 +36,7 @@ func (e *Environment) Attach() error {
 	}
 
 	if err := e.followOutput(); err != nil {
-		return errors.WithStackIf(err)
+		return err
 	}
 
 	opts := types.ContainerAttachOptions{
@@ -48,7 +48,7 @@ func (e *Environment) Attach() error {
 
 	// Set the stream again with the container.
 	if st, err := e.client.ContainerAttach(context.Background(), e.Id, opts); err != nil {
-		return errors.WithStackIf(err)
+		return err
 	} else {
 		e.SetStream(&st)
 	}
@@ -72,7 +72,7 @@ func (e *Environment) Attach() error {
 			if err := e.pollResources(ctx); err != nil {
 				l := log.WithField("environment_id", e.Id)
 				if !errors.Is(err, context.Canceled) {
-					l.WithField("error", errors.WithStackIf(err)).Error("error during environment resource polling")
+					l.WithField("error", err).Error("error during environment resource polling")
 				} else {
 					l.Warn("stopping server resource polling: context canceled")
 				}
@@ -82,7 +82,7 @@ func (e *Environment) Attach() error {
 		// Stream the reader output to the console which will then fire off events and handle console
 		// throttling and sending the output to the user.
 		if _, err := io.Copy(console, e.stream.Reader); err != nil {
-			log.WithField("environment_id", e.Id).WithField("error", errors.WithStackIf(err)).Error("error while copying environment output to console")
+			log.WithField("environment_id", e.Id).WithField("error", err).Error("error while copying environment output to console")
 		}
 	}(c)
 
@@ -120,7 +120,7 @@ func (e *Environment) InSituUpdate() error {
 			return nil
 		}
 
-		return errors.WithStackIf(err)
+		return err
 	}
 
 	u := container.UpdateConfig{
@@ -130,7 +130,7 @@ func (e *Environment) InSituUpdate() error {
 	ctx, cancel := context.WithTimeout(context.Background(), time.Second*10)
 	defer cancel()
 	if _, err := e.client.ContainerUpdate(ctx, e.Id, u); err != nil {
-		return errors.WithStackIf(err)
+		return err
 	}
 
 	return nil
@@ -145,12 +145,12 @@ func (e *Environment) Create() error {
 	if _, err := e.client.ContainerInspect(context.Background(), e.Id); err == nil {
 		return nil
 	} else if !client.IsErrNotFound(err) {
-		return errors.WithStackIf(err)
+		return err
 	}
 
 	// Try to pull the requested image before creating the container.
 	if err := e.ensureImageExists(e.meta.Image); err != nil {
-		return errors.WithStackIf(err)
+		return err
 	}
 
 	a := e.Configuration.Allocations()
@@ -225,7 +225,7 @@ func (e *Environment) Create() error {
 	}
 
 	if _, err := e.client.ContainerCreate(context.Background(), conf, hostConf, nil, e.Id); err != nil {
-		return errors.WithStackIf(err)
+		return err
 	}
 
 	return nil
@@ -277,7 +277,7 @@ func (e *Environment) Destroy() error {
 func (e *Environment) followOutput() error {
 	if exists, err := e.Exists(); !exists {
 		if err != nil {
-			return errors.WithStackIf(err)
+			return err
 		}
 
 		return errors.New(fmt.Sprintf("no such container: %s", e.Id))
@@ -302,7 +302,6 @@ func (e *Environment) followOutput() error {
 		cr := []byte(" \r")
 		crr := []byte("\r\n")
 
-
 		// Avoid constantly re-allocating memory when we're flooding lines through this
 		// function by using the same buffer for the duration of the call and just truncating
 		// the value back to 0 every loop.
@@ -354,7 +353,7 @@ func (e *Environment) followOutput() error {
 		}
 	}(reader)
 
-	return errors.WithStackIf(err)
+	return err
 }
 
 // Pulls the image from Docker. If there is an error while pulling the image from the source