Don't ignore disk space limits when copying/archiving; closes pterodactyl/panel#2400

router/error.go

@@ -9,6 +9,7 @@ import (
 	"github.com/pterodactyl/wings/server"
 	"net/http"
 	"os"
+	"strings"
 )
 
 type RequestError struct {
@@ -95,6 +96,39 @@ func (e *RequestError) AbortWithServerError(c *gin.Context) {
 	e.AbortWithStatus(http.StatusInternalServerError, c)
 }
 
+// Handle specific filesystem errors for a server.
+func (e *RequestError) AbortFilesystemError(c *gin.Context) {
+	if errors.Is(e.Err, os.ErrNotExist) {
+		c.AbortWithStatusJSON(http.StatusNotFound, gin.H{
+			"error": "The requested resource was not found.",
+		})
+		return
+	}
+
+	if errors.Is(e.Err, server.ErrNotEnoughDiskSpace) {
+		c.AbortWithStatusJSON(http.StatusBadRequest, gin.H{
+			"error": server.ErrNotEnoughDiskSpace.Error(),
+		})
+		return
+	}
+
+	if strings.HasSuffix(e.Err.Error(), "file name too long") {
+		c.AbortWithStatusJSON(http.StatusBadRequest, gin.H{
+			"error": "File name is too long.",
+		})
+		return
+	}
+
+	if e, ok := e.Err.(*os.SyscallError); ok && e.Syscall == "readdirent" {
+		c.AbortWithStatusJSON(http.StatusNotFound, gin.H{
+			"error": "The requested directory does not exist.",
+		})
+		return
+	}
+
+	e.AbortWithServerError(c)
+}
+
 // Format the error to a string and include the UUID.
 func (e *RequestError) Error() string {
 	return fmt.Sprintf("%v (uuid: %s)", e.Err, e.Uuid)

router/router_server_files.go

@@ -82,14 +82,7 @@ func getServerListDirectory(c *gin.Context) {
 
 	stats, err := s.Filesystem.ListDirectory(d)
 	if err != nil {
-		if e, ok := err.(*os.SyscallError); ok && e.Syscall == "readdirent" {
-			c.AbortWithStatusJSON(http.StatusNotFound, gin.H{
-				"error": "The requested directory does not exist.",
-			})
-			return
-		}
-
-		TrackedServerError(err, s).AbortWithServerError(c)
+		TrackedServerError(err, s).AbortFilesystemError(c)
 		return
 	}
 
@@ -156,14 +149,7 @@ func putServerRenameFiles(c *gin.Context) {
 			return
 		}
 
-		if strings.HasSuffix(err.Error(), "file name too long") {
-			c.AbortWithStatusJSON(http.StatusBadRequest, gin.H{
-				"error": "Cannot move or rename file, name is too long.",
-			})
-			return
-		}
-
-		TrackedServerError(err, s).AbortWithServerError(c)
+		TrackedServerError(err, s).AbortFilesystemError(c)
 		return
 	}
 
@@ -183,15 +169,7 @@ func postServerCopyFile(c *gin.Context) {
 	}
 
 	if err := s.Filesystem.Copy(data.Location); err != nil {
-		// Check if the file does not exist.
-		// NOTE: os.IsNotExist() does not work if the error is wrapped.
-		if errors.Is(err, os.ErrNotExist) {
-			c.Status(http.StatusNotFound)
-			return
-		}
-
-		TrackedServerError(err, s).AbortWithServerError(c)
-		return
+		TrackedServerError(err, s).AbortFilesystemError(c)
 	}
 
 	c.Status(http.StatusNoContent)