Make logged stacktraces more useful
This commit is contained in:
parent
83f0d2c953
commit
81fd1a3758
|
@ -71,51 +71,25 @@ func (h *Handler) HandleLog(e *log.Entry) error {
|
||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
|
|
||||||
var br = color2.New(color2.Bold, color2.FgRed)
|
|
||||||
if err, ok := e.Fields.Get("error").(error); ok {
|
if err, ok := e.Fields.Get("error").(error); ok {
|
||||||
fmt.Fprintf(h.Writer, "\n%s%+v\n\n", br.Sprintf("Stacktrace:"), getErrorStack(err, false))
|
br := color2.New(color2.Bold, color2.FgRed)
|
||||||
} else {
|
|
||||||
fmt.Fprintf(h.Writer, "\n%s%+v\n\n", br.Sprintf("Invalid Error:"), err)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
return nil
|
|
||||||
}
|
|
||||||
|
|
||||||
func getErrorStack(err error, i bool) errors.StackTrace {
|
|
||||||
e, ok := err.(tracer)
|
|
||||||
if !ok {
|
|
||||||
if i {
|
|
||||||
// Just abort out of this and return a stacktrace leading up to this point. It isn't perfect
|
|
||||||
// but it'll at least include what function lead to this being called which we can then handle.
|
|
||||||
if e, ok = errors.WithMessage(err, "failed to generate stacktrace for caught error").(tracer); ok {
|
|
||||||
return e.StackTrace()
|
|
||||||
}
|
|
||||||
|
|
||||||
// The errors.WrapIf did not return a interface compatible with `tracer`, so
|
|
||||||
// we don't have an easy way to get the stacktrace, this should probably be changed
|
|
||||||
// at some point, but without this the application may panic when handling some errors.
|
|
||||||
return nil
|
|
||||||
}
|
|
||||||
|
|
||||||
return getErrorStack(errors.WithMessage(err, err.Error()), true)
|
|
||||||
}
|
|
||||||
|
|
||||||
|
if e, ok := errors.Cause(err).(tracer); ok {
|
||||||
st := e.StackTrace()
|
st := e.StackTrace()
|
||||||
|
|
||||||
l := len(st)
|
l := len(st)
|
||||||
// If this was an internal stack generation we're going to skip over the top four items in the stack
|
if l > 10 {
|
||||||
// trace since they'll point to the error that was generated by this function.
|
l = 10
|
||||||
f := 0
|
|
||||||
if i {
|
|
||||||
f = 5
|
|
||||||
}
|
}
|
||||||
|
|
||||||
if i && l > 9 {
|
fmt.Fprintf(h.Writer, "\n%s%+v\n\n", br.Sprintf("Stacktrace:"), st[0:l])
|
||||||
l = 9
|
} else {
|
||||||
} else if !i && l > 5 {
|
fmt.Fprintf(h.Writer, "\n%s\n%+v\n\n", br.Sprintf("Stacktrace:"), err)
|
||||||
l = 5
|
}
|
||||||
|
} else {
|
||||||
|
fmt.Printf("\n\nINVALID ERROR\n\n")
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
return st[f:l]
|
return nil
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue
Block a user