MCorange/wings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Force upload file overwrite and remove un-needed TODO comments

Browse Source
This commit is contained in:
Matthew Penner 2020-07-31 21:15:36 -06:00
parent b1940426c3
commit 776062107b
1 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
router/router_server_files.go
View File

@ -360,11 +360,9 @@ func postServerUploadFiles(c *gin.Context) {
return return
} }
// TODO: Make sure directory is safe.
directory := c.Query("directory") directory := c.Query("directory")
for _, header := range headers { for _, header := range headers {
// TODO: Make sure header#Filename is clean.
p, err := s.Filesystem.SafePath(filepath.Join(directory, header.Filename)) p, err := s.Filesystem.SafePath(filepath.Join(directory, header.Filename))
if err != nil { if err != nil {
c.AbortWithError(http.StatusInternalServerError, err) c.AbortWithError(http.StatusInternalServerError, err)
@ -381,16 +379,6 @@ func postServerUploadFiles(c *gin.Context) {
} }
func handleFileUpload(p string, s *server.Server, header *multipart.FileHeader) error { func handleFileUpload(p string, s *server.Server, header *multipart.FileHeader) error {
_, err := s.Filesystem.Stat(header.Filename)
if err == nil {
// TODO: Figure out how to better handle this
// This means the file exists, not 100% sure what to do in this situation, but for now we will skip the file.
return nil
} else if !os.IsNotExist(err) {
return errors.WithStack(err)
}
file, err := header.Open() file, err := header.Open()
if err != nil { if err != nil {
return errors.WithStack(err) return errors.WithStack(err)