MCorange/wings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Quick note about the importance of the copy

Browse Source
This commit is contained in:
Dane Everitt 2022-01-22 14:33:49 -05:00
parent b5536dfc77
commit 1591d86e23
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
system/utils.go
View File

@ -99,6 +99,8 @@ func ScanReader(r io.Reader, callback func(line []byte)) error {
// the websocket. The front-end can handle the linebreaks in the middle of // the websocket. The front-end can handle the linebreaks in the middle of
// the output, it simply expects that the end of the event emit is a newline. // the output, it simply expects that the end of the event emit is a newline.
if buf.Len() > 0 { if buf.Len() > 0 {
// You need to make a copy of the buffer here because the callback will encounter
// a race condition since "buf.Bytes()" is going to be by-reference if passed directly.
c := make([]byte, buf.Len()) c := make([]byte, buf.Len())
copy(c, buf.Bytes()) copy(c, buf.Bytes())
callback(c) callback(c)