Autisticats/mautrix-discord
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

backfill: document why we aren't backfilling reactions (for now)

Browse Source
This commit is contained in:
Skip R
2025-12-11 19:50:16 -08:00
parent 506f42f93b
commit ab82f8b131
1 changed files with 16 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
pkg/connector/backfill.go
View File

@@ -68,7 +68,22 @@ func (dc *DiscordClient) FetchMessages(ctx context.Context, fetchParams bridgev2
streamOrder, _ := strconv.ParseInt(msg.ID, 10, 64) streamOrder, _ := strconv.ParseInt(msg.ID, 10, 64)
ts, _ := discordgo.SnowflakeTimestamp(msg.ID) ts, _ := discordgo.SnowflakeTimestamp(msg.ID)
// FIXME(skip): Backfill reactions. // NOTE: For now, we aren't backfilling reactions. This is because:
//
// - Discord does not provide enough historical reaction data in the
// response from the message history endpoint to construct valid
// BackfillReactions.
// - Fetching the reaction data would be prohibitively expensive for
// messages with many reactions. Messages in large guilds can have
// tens of thousands of reactions.
// - Indicating aggregated child events[1] from BackfillMessage doesn't
// seem possible due to how portal backfilling batching currently
// works.
//
// [1]: https://spec.matrix.org/v1.16/client-server-api/#reference-relations
//
// It might be worth fetching the reaction data anyways if we observe
// a small overall number of reactions.
sender := dc.makeEventSender(msg.Author) sender := dc.makeEventSender(msg.Author)
// Use the ghost's intent, falling back to the bridge's. // Use the ghost's intent, falling back to the bridge's.