Autisticats/mautrix-discord
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

client: don't nil out discordgo.Session when disconnecting

Browse Source 
I don't have the logs anymore unfortunately, but I witnessed a
(seemingly?) rare nil dereference _within discordgo's event handling
code_ after Disconnect on the client was called (caused by SIGINT). My
thinking is that this caused the Session to get garbage collected, so
the method receiver became nil out from under it.

To let discordgo clean up after itself, keep a reference to it in the
client.
This commit is contained in:
Skip R
2025-12-18 18:28:07 -08:00
parent 776ddd7c96
commit 2075a4b853
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
pkg/connector/client.go
View File

@@ -149,7 +149,6 @@ func (cl *DiscordClient) connect(ctx context.Context) error {
func (d *DiscordClient) Disconnect() { func (d *DiscordClient) Disconnect() {
d.UserLogin.Log.Info().Msg("Disconnecting session") d.UserLogin.Log.Info().Msg("Disconnecting session")
d.Session.Close() d.Session.Close()
d.Session = nil
} }
func (d *DiscordClient) IsLoggedIn() bool { func (d *DiscordClient) IsLoggedIn() bool {